adamjakab / SuiteCRM

tests/bootstrap.php

Indentation +23 added lines, -23 removed lines

@@ -1,27 +1,27 @@
 <?php
- /**
- * 
- * 
- * @package 
- * @copyright SalesAgility Ltd http://www.salesagility.com
- * 
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU AFFERO GENERAL PUBLIC LICENSE
- * along with this program; if not, see http://www.gnu.org/licenses
- * or write to the Free Software Foundation,Inc., 51 Franklin Street,
- * Fifth Floor, Boston, MA 02110-1301  USA
- *
- * @author Salesagility Ltd <support@salesagility.com>
- */
+    /**
+     * 
+     * 
+     * @package 
+     * @copyright SalesAgility Ltd http://www.salesagility.com
+     * 
+     * This program is free software; you can redistribute it and/or modify
+     * it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE as published by
+     * the Free Software Foundation; either version 3 of the License, or
+     * (at your option) any later version.
+     *
+     * This program is distributed in the hope that it will be useful,
+     * but WITHOUT ANY WARRANTY; without even the implied warranty of
+     * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+     * GNU General Public License for more details.
+     *
+     * You should have received a copy of the GNU AFFERO GENERAL PUBLIC LICENSE
+     * along with this program; if not, see http://www.gnu.org/licenses
+     * or write to the Free Software Foundation,Inc., 51 Franklin Street,
+     * Fifth Floor, Boston, MA 02110-1301  USA
+     *
+     * @author Salesagility Ltd <support@salesagility.com>
+     */
 require_once 'modules/InboundEmail/InboundEmail.php';
 require_once 'include/clean.php';
 class AOPInboundEmail extends InboundEmail {

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
 
 chdir('..');
 
-define('sugarEntry',TRUE);
+define('sugarEntry', TRUE);
 
 global $sugar_config, $db;
 require_once 'include/utils.php';

tests/tests/configTest.php

Indentation +4 added lines, -4 removed lines

@@ -3,11 +3,11 @@
 class configTest extends PHPUnit_Framework_TestCase
 {
 
-	public function test_config() {
-	    global $sugar_config;
-		$this->assertNotEmpty($sugar_config,"SuiteCRM config is empty");
+    public function test_config() {
+        global $sugar_config;
+        $this->assertNotEmpty($sugar_config,"SuiteCRM config is empty");
 	
-	}
+    }
 
 
 }

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
 
 	public function test_config() {
 	    global $sugar_config;
-		$this->assertNotEmpty($sugar_config,"SuiteCRM config is empty");
+		$this->assertNotEmpty($sugar_config, "SuiteCRM config is empty");
 	
 	}
 

tests/tests/include/MVC/SugarApplicationTest.php

Indentation +235 added lines, -235 removed lines

@@ -5,25 +5,25 @@ 
 {
 
 
-	public function testexecute(){
+    public function testexecute(){
 		
-		$SugarApplication = new SugarApplication();
+        $SugarApplication = new SugarApplication();
 
-		//execute the method and test if it works and does not throws an exception other than headers output exception.
-		try {
-			$SugarApplication->execute();
+        //execute the method and test if it works and does not throws an exception other than headers output exception.
+        try {
+            $SugarApplication->execute();
 			
-		} catch (Exception $e) {
-			$this->assertStringStartsWith('Cannot modify header information',$e->getMessage());
-		}
+        } catch (Exception $e) {
+            $this->assertStringStartsWith('Cannot modify header information',$e->getMessage());
+        }
 			
-	}
+    }
 
 
-	public function testloadUser(){
+    public function testloadUser(){
 		
-		//cannot test this method as it uses die which stops execution of php unit as well
-		/*  
+        //cannot test this method as it uses die which stops execution of php unit as well
+        /*  
 		error_reporting(E_ERROR | E_PARSE);
 		
 		$SugarApplication = new SugarApplication();
@@ -38,269 +38,269 @@ 
 		
 		$this->assertTrue(TRUE);
 		*/
-		$this->markTestIncomplete('Can Not be implemented');
+        $this->markTestIncomplete('Can Not be implemented');
 		
-	}
+    }
 
-	public function testACLFilter(){
+    public function testACLFilter(){
 
-		$SugarApplication = new SugarApplication();
+        $SugarApplication = new SugarApplication();
 				
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$SugarApplication->ACLFilter();
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->ACLFilter();
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
 		
-	}
+    }
 
 
-	public function testsetupResourceManagement() {
+    public function testsetupResourceManagement() {
 
 
-		$SugarApplication = new SugarApplication();
+        $SugarApplication = new SugarApplication();
 		
-		//execute the method with invalid input and test if it works and does not throws an exception.
-		try {
-			$SugarApplication->setupResourceManagement('');	
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method with invalid input and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->setupResourceManagement('');	
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 
-		//execute the method with valid input and test if it works and does not throws an exception.
-		try {
-			$SugarApplication->setupResourceManagement('Users');
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method with valid input and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->setupResourceManagement('Users');
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
 		
-	}
+    }
 
-	public function testsetupPrint() {
+    public function testsetupPrint() {
 
-		$SugarApplication = new SugarApplication();
+        $SugarApplication = new SugarApplication();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$SugarApplication->setupPrint();
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->setupPrint();
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
 		
-	}
+    }
 
-	public function testpreProcess(){
+    public function testpreProcess(){
 
-		$SugarApplication = new SugarApplication();
-		$SugarApplication->controller = new SugarController();
+        $SugarApplication = new SugarApplication();
+        $SugarApplication->controller = new SugarController();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$SugarApplication->preProcess();
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->preProcess();
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->assertTrue(TRUE);		
+        $this->assertTrue(TRUE);		
 		
-	}
+    }
 
 	
-	public function testhandleOfflineClient(){
-		$SugarApplication = new SugarApplication();
+    public function testhandleOfflineClient(){
+        $SugarApplication = new SugarApplication();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$SugarApplication->handleOfflineClient();
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->handleOfflineClient();
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->assertTrue(TRUE);
-	}
+        $this->assertTrue(TRUE);
+    }
 
 
-	public function testhandleAccessControl(){
+    public function testhandleAccessControl(){
 		
-		$SugarApplication = new SugarApplication();
-		$SugarApplication->controller = new SugarController();
+        $SugarApplication = new SugarApplication();
+        $SugarApplication->controller = new SugarController();
 		
-		$result = $SugarApplication->handleAccessControl();
+        $result = $SugarApplication->handleAccessControl();
 		
-		//check that it returns Null
-		$this->assertEquals(NULL,$result);
+        //check that it returns Null
+        $this->assertEquals(NULL,$result);
 		
-		//check that controller->hasAccess is true i-e default setting.
-		$this->assertEquals(True,$SugarApplication->controller->hasAccess);
+        //check that controller->hasAccess is true i-e default setting.
+        $this->assertEquals(True,$SugarApplication->controller->hasAccess);
 
-	}
+    }
 
 
-	public function testpreLoadLanguages()
-	{
-		try {
-			SugarApplication::preLoadLanguages();
+    public function testpreLoadLanguages()
+    {
+        try {
+            SugarApplication::preLoadLanguages();
 			
-			//check that method call got the current_language global variable set.
-			$this->assertTrue(isset($GLOBALS['current_language'] ));
+            //check that method call got the current_language global variable set.
+            $this->assertTrue(isset($GLOBALS['current_language'] ));
 			
-			//check that method call got the app_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0 );
+            //check that method call got the app_strings global variable set.
+            $this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0 );
 			
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 	
-	}
+    }
 
-	public function testloadLanguages(){
+    public function testloadLanguages(){
 	
-		$SugarApplication = new SugarApplication();
-		$SugarApplication->controller = new SugarController();
+        $SugarApplication = new SugarApplication();
+        $SugarApplication->controller = new SugarController();
 		
-		try {
-			$SugarApplication->loadLanguages();
+        try {
+            $SugarApplication->loadLanguages();
 				
-			//check that method call got the current_language global variable set.
-			$this->assertTrue(isset($GLOBALS['current_language'] ));
+            //check that method call got the current_language global variable set.
+            $this->assertTrue(isset($GLOBALS['current_language'] ));
 				
-			//check that method call got the app_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0 );
+            //check that method call got the app_strings global variable set.
+            $this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0 );
 			
-			//check that method call got the app_list_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['app_list_strings']) && count($GLOBALS['app_list_strings']) > 0 );
+            //check that method call got the app_list_strings global variable set.
+            $this->assertTrue(is_array($GLOBALS['app_list_strings']) && count($GLOBALS['app_list_strings']) > 0 );
 
-			//check that method call got the mod_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['mod_strings']) && count($GLOBALS['mod_strings']) > 0 );
+            //check that method call got the mod_strings global variable set.
+            $this->assertTrue(is_array($GLOBALS['mod_strings']) && count($GLOBALS['mod_strings']) > 0 );
 				
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-	}
+    }
 
- 	public function testcheckDatabaseVersion()
- 	{
- 		error_reporting(E_ERROR | E_PARSE);
+        public function testcheckDatabaseVersion()
+        {
+            error_reporting(E_ERROR | E_PARSE);
  		
- 		$SugarApplication = new SugarApplication();
+            $SugarApplication = new SugarApplication();
  		
- 		//execute the method with false parameter and check for false returned as it cannot connect to DB.
- 		//testing with true will allow it to use die() which stops phpunit execution as well.
- 		$result = $SugarApplication->checkDatabaseVersion(false);
- 		$this->assertFalse($result);
+            //execute the method with false parameter and check for false returned as it cannot connect to DB.
+            //testing with true will allow it to use die() which stops phpunit execution as well.
+            $result = $SugarApplication->checkDatabaseVersion(false);
+            $this->assertFalse($result);
 
-	}
+    }
 
 
-	public function testloadDisplaySettings(){
+    public function testloadDisplaySettings(){
 
-    	$SugarApplication = new SugarApplication();
+        $SugarApplication = new SugarApplication();
     	
-    	//execute the method and test if it works and does not throws an exception.
-    	try {
-    		$SugarApplication->loadDisplaySettings();
-    	}
-    	catch (Exception $e) {
-    		$this->fail();
-    	}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->loadDisplaySettings();
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
     	
-    	$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
     	
-	}
+    }
 
-	public function testloadLicense(){
+    public function testloadLicense(){
 
-		$SugarApplication = new SugarApplication();
+        $SugarApplication = new SugarApplication();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$SugarApplication->loadLicense();
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->loadLicense();
 		
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}		
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }		
 		
-		$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
 		
-	}
+    }
 
-	public function testloadGlobals(){
+    public function testloadGlobals(){
 
-		$SugarApplication = new SugarApplication();
-		$SugarApplication->controller = new SugarController();
+        $SugarApplication = new SugarApplication();
+        $SugarApplication->controller = new SugarController();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$SugarApplication->loadGlobals();
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->loadGlobals();
 				
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
 		
-	}
+    }
 
 
-	public function teststartSession(){
+    public function teststartSession(){
 	
-		$SugarApplication = new SugarApplication();
-		$SugarApplication->controller = new SugarController();
+        $SugarApplication = new SugarApplication();
+        $SugarApplication->controller = new SugarController();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$SugarApplication->startSession();
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->startSession();
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->assertTrue(TRUE);		
+        $this->assertTrue(TRUE);		
 		
 	
-	}
+    }
 	
 	
-	public function testendSession(){
+    public function testendSession(){
 
 		
-		$SugarApplication = new SugarApplication();
-		$SugarApplication->controller = new SugarController();
+        $SugarApplication = new SugarApplication();
+        $SugarApplication->controller = new SugarController();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$SugarApplication->endSession();
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $SugarApplication->endSession();
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
 		
-	}
+    }
 
- 	public function testredirect()
-	{
-		//this method uses exit() which stops execution of phpunit as well so it cannot be tested without additional --process-isolation commandline parameter.
-		/*
+        public function testredirect()
+    {
+        //this method uses exit() which stops execution of phpunit as well so it cannot be tested without additional --process-isolation commandline parameter.
+        /*
 		$SugarApplication = new SugarApplication();
 
 		//execute the method and check if it works and doesn't throws an exception
@@ -317,75 +317,75 @@ 
 			$this->fail();
 		}
 		*/
-		$this->markTestIncomplete('Can Not be implemented');
+        $this->markTestIncomplete('Can Not be implemented');
 		
-	}
+    }
 
 
- 	public function testappendErrorMessage()
-	{
-		//execute the method and check that the method adds the message to user_error_message array.
-		//there should be one more array element after method execution.
-		$user_error_message_count = count($_SESSION['user_error_message']);
-		SugarApplication::appendErrorMessage('some error');
-		$this->assertGreaterThan($user_error_message_count , count($_SESSION['user_error_message']));
-	}
+        public function testappendErrorMessage()
+    {
+        //execute the method and check that the method adds the message to user_error_message array.
+        //there should be one more array element after method execution.
+        $user_error_message_count = count($_SESSION['user_error_message']);
+        SugarApplication::appendErrorMessage('some error');
+        $this->assertGreaterThan($user_error_message_count , count($_SESSION['user_error_message']));
+    }
 
     public function testgetErrorMessages()
-	{
-		//execute the method and check if it returns a array. 
-		$errorMessages = SugarApplication::getErrorMessages();
-		$this->assertTrue(is_array($errorMessages));
+    {
+        //execute the method and check if it returns a array. 
+        $errorMessages = SugarApplication::getErrorMessages();
+        $this->assertTrue(is_array($errorMessages));
 		
-	}
+    }
 
 
-	public function testsetCookie( )
-	{
-		//execute the method and check that the method adds the key value pair to cookies array.
-		SugarApplication::setCookie('key','value');
-		$this->assertEquals('value' , $_COOKIE['key'] );
+    public function testsetCookie( )
+    {
+        //execute the method and check that the method adds the key value pair to cookies array.
+        SugarApplication::setCookie('key','value');
+        $this->assertEquals('value' , $_COOKIE['key'] );
 			
-	}
+    }
 
 
-	public function testcreateLoginVars()
-	{
+    public function testcreateLoginVars()
+    {
 
-		$SugarApplication = new SugarApplication();
+        $SugarApplication = new SugarApplication();
 
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$vars = $SugarApplication->createLoginVars();
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $vars = $SugarApplication->createLoginVars();
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
 		
-	}
+    }
 
 
-	public function testgetLoginVars()
-	{
-		$SugarApplication = new SugarApplication();
+    public function testgetLoginVars()
+    {
+        $SugarApplication = new SugarApplication();
 		
-		//execute the method and test that it returns a array.
-		$vars = $SugarApplication->getLoginVars();
-		$this->assertTrue(is_array($vars));
+        //execute the method and test that it returns a array.
+        $vars = $SugarApplication->getLoginVars();
+        $this->assertTrue(is_array($vars));
 		
-	}
+    }
 
 
-	public function testgetLoginRedirect()
-	{
+    public function testgetLoginRedirect()
+    {
 		
-		$SugarApplication = new SugarApplication();
+        $SugarApplication = new SugarApplication();
 		
-		//execute the method and test that it returns a plus length string
-		$redirect = $SugarApplication->getLoginRedirect();
-		$this->assertGreaterThan(0, strlen($redirect));
+        //execute the method and test that it returns a plus length string
+        $redirect = $SugarApplication->getLoginRedirect();
+        $this->assertGreaterThan(0, strlen($redirect));
 		
-	}
+    }
 }

Spacing +25 added lines, -25 removed lines

@@ -5,7 +5,7 @@ 
 {
 
 
-	public function testexecute(){
+	public function testexecute() {
 		
 		$SugarApplication = new SugarApplication();
 
@@ -13,14 +13,14 @@ 
 		try {
 			$SugarApplication->execute();
 			
-		} catch (Exception $e) {
-			$this->assertStringStartsWith('Cannot modify header information',$e->getMessage());
+		}catch (Exception $e) {
+			$this->assertStringStartsWith('Cannot modify header information', $e->getMessage());
 		}
 			
 	}
 
 
-	public function testloadUser(){
+	public function testloadUser() {
 		
 		//cannot test this method as it uses die which stops execution of php unit as well
 		/*  
@@ -42,7 +42,7 @@ 
 		
 	}
 
-	public function testACLFilter(){
+	public function testACLFilter() {
 
 		$SugarApplication = new SugarApplication();
 				
@@ -100,7 +100,7 @@ 
 		
 	}
 
-	public function testpreProcess(){
+	public function testpreProcess() {
 
 		$SugarApplication = new SugarApplication();
 		$SugarApplication->controller = new SugarController();
@@ -118,7 +118,7 @@ 
 	}
 
 	
-	public function testhandleOfflineClient(){
+	public function testhandleOfflineClient() {
 		$SugarApplication = new SugarApplication();
 		
 		//execute the method and test if it works and does not throws an exception.
@@ -133,7 +133,7 @@ 
 	}
 
 
-	public function testhandleAccessControl(){
+	public function testhandleAccessControl() {
 		
 		$SugarApplication = new SugarApplication();
 		$SugarApplication->controller = new SugarController();
@@ -141,10 +141,10 @@ 
 		$result = $SugarApplication->handleAccessControl();
 		
 		//check that it returns Null
-		$this->assertEquals(NULL,$result);
+		$this->assertEquals(NULL, $result);
 		
 		//check that controller->hasAccess is true i-e default setting.
-		$this->assertEquals(True,$SugarApplication->controller->hasAccess);
+		$this->assertEquals(True, $SugarApplication->controller->hasAccess);
 
 	}
 
@@ -155,10 +155,10 @@ 
 			SugarApplication::preLoadLanguages();
 			
 			//check that method call got the current_language global variable set.
-			$this->assertTrue(isset($GLOBALS['current_language'] ));
+			$this->assertTrue(isset($GLOBALS['current_language']));
 			
 			//check that method call got the app_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0 );
+			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0);
 			
 		}
 		catch (Exception $e) {
@@ -167,7 +167,7 @@ 
 	
 	}
 
-	public function testloadLanguages(){
+	public function testloadLanguages() {
 	
 		$SugarApplication = new SugarApplication();
 		$SugarApplication->controller = new SugarController();
@@ -176,16 +176,16 @@ 
 			$SugarApplication->loadLanguages();
 				
 			//check that method call got the current_language global variable set.
-			$this->assertTrue(isset($GLOBALS['current_language'] ));
+			$this->assertTrue(isset($GLOBALS['current_language']));
 				
 			//check that method call got the app_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0 );
+			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0);
 			
 			//check that method call got the app_list_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['app_list_strings']) && count($GLOBALS['app_list_strings']) > 0 );
+			$this->assertTrue(is_array($GLOBALS['app_list_strings']) && count($GLOBALS['app_list_strings']) > 0);
 
 			//check that method call got the mod_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['mod_strings']) && count($GLOBALS['mod_strings']) > 0 );
+			$this->assertTrue(is_array($GLOBALS['mod_strings']) && count($GLOBALS['mod_strings']) > 0);
 				
 		}
 		catch (Exception $e) {
@@ -208,7 +208,7 @@ 
 	}
 
 
-	public function testloadDisplaySettings(){
+	public function testloadDisplaySettings() {
 
     	$SugarApplication = new SugarApplication();
     	
@@ -224,7 +224,7 @@ 
     	
 	}
 
-	public function testloadLicense(){
+	public function testloadLicense() {
 
 		$SugarApplication = new SugarApplication();
 		
@@ -241,7 +241,7 @@ 
 		
 	}
 
-	public function testloadGlobals(){
+	public function testloadGlobals() {
 
 		$SugarApplication = new SugarApplication();
 		$SugarApplication->controller = new SugarController();
@@ -260,7 +260,7 @@ 
 	}
 
 
-	public function teststartSession(){
+	public function teststartSession() {
 	
 		$SugarApplication = new SugarApplication();
 		$SugarApplication->controller = new SugarController();
@@ -279,7 +279,7 @@ 
 	}
 	
 	
-	public function testendSession(){
+	public function testendSession() {
 
 		
 		$SugarApplication = new SugarApplication();
@@ -328,7 +328,7 @@ 
 		//there should be one more array element after method execution.
 		$user_error_message_count = count($_SESSION['user_error_message']);
 		SugarApplication::appendErrorMessage('some error');
-		$this->assertGreaterThan($user_error_message_count , count($_SESSION['user_error_message']));
+		$this->assertGreaterThan($user_error_message_count, count($_SESSION['user_error_message']));
 	}
 
     public function testgetErrorMessages()
@@ -343,8 +343,8 @@ 
 	public function testsetCookie( )
 	{
 		//execute the method and check that the method adds the key value pair to cookies array.
-		SugarApplication::setCookie('key','value');
-		$this->assertEquals('value' , $_COOKIE['key'] );
+		SugarApplication::setCookie('key', 'value');
+		$this->assertEquals('value', $_COOKIE['key']);
 			
 	}
 

Braces +14 added lines, -28 removed lines

@@ -49,8 +49,7 @@ 
 		//execute the method and test if it works and does not throws an exception.
 		try {
 			$SugarApplication->ACLFilter();
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -67,16 +66,14 @@ 
 		//execute the method with invalid input and test if it works and does not throws an exception.
 		try {
 			$SugarApplication->setupResourceManagement('');	
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 
 		//execute the method with valid input and test if it works and does not throws an exception.
 		try {
 			$SugarApplication->setupResourceManagement('Users');
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -91,8 +88,7 @@ 
 		//execute the method and test if it works and does not throws an exception.
 		try {
 			$SugarApplication->setupPrint();
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -108,8 +104,7 @@ 
 		//execute the method and test if it works and does not throws an exception.
 		try {
 			$SugarApplication->preProcess();
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -124,8 +119,7 @@ 
 		//execute the method and test if it works and does not throws an exception.
 		try {
 			$SugarApplication->handleOfflineClient();
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -160,8 +154,7 @@ 
 			//check that method call got the app_strings global variable set.
 			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0 );
 			
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 	
@@ -187,8 +180,7 @@ 
 			//check that method call got the mod_strings global variable set.
 			$this->assertTrue(is_array($GLOBALS['mod_strings']) && count($GLOBALS['mod_strings']) > 0 );
 				
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -215,8 +207,7 @@ 
     	//execute the method and test if it works and does not throws an exception.
     	try {
     		$SugarApplication->loadDisplaySettings();
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -232,8 +223,7 @@ 
 		try {
 			$SugarApplication->loadLicense();
 		
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}		
 		
@@ -250,8 +240,7 @@ 
 		try {
 			$SugarApplication->loadGlobals();
 				
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -268,8 +257,7 @@ 
 		//execute the method and test if it works and does not throws an exception.
 		try {
 			$SugarApplication->startSession();
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -288,8 +276,7 @@ 
 		//execute the method and test if it works and does not throws an exception.
 		try {
 			$SugarApplication->endSession();
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -357,8 +344,7 @@ 
 		//execute the method and test if it works and does not throws an exception.
 		try {
 			$vars = $SugarApplication->createLoginVars();
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

tests/tests/include/MVC/View/SugarViewTest.php

Indentation +145 added lines, -145 removed lines

@@ -6,18 +6,18 @@ 
 
     public function testinit()
     {
-    	error_reporting(E_ERROR | E_WARNING | E_PARSE);
+        error_reporting(E_ERROR | E_WARNING | E_PARSE);
     	
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	 
-    	//execute the method and check if it works and doesn't throws an exception
-    	try {
-    		$SugarView->init();
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        //execute the method and check if it works and doesn't throws an exception
+        try {
+            $SugarView->init();
+        } catch (Exception $e) {
+            $this->fail();
+        }
     	 
-    	$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
     	
     	
     }
@@ -26,43 +26,43 @@ 
     public function testprocess()
     {
 
-    	$SugarView = new SugarView();
-    	$SugarView->module = "Users";
-    	$GLOBALS['app'] = new SugarApplication();
+        $SugarView = new SugarView();
+        $SugarView->module = "Users";
+        $GLOBALS['app'] = new SugarApplication();
     	
-    	//execute the method and check if it works and doesn't throws an exception
-    	//secondly check if it outputs any content to browser
-    	try {
+        //execute the method and check if it works and doesn't throws an exception
+        //secondly check if it outputs any content to browser
+        try {
     		
-    		ob_start(); 
+            ob_start(); 
     		   		
-    		$SugarView->process();
+            $SugarView->process();
     		
-    		$renderedContent = ob_get_contents();
-    		ob_end_clean();
+            $renderedContent = ob_get_contents();
+            ob_end_clean();
 
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+            $this->assertGreaterThan(0,strlen($renderedContent));
     		  		
-    	} catch (Exception $e) {
-     		$this->fail();
-    	}
+        } catch (Exception $e) {
+                $this->fail();
+        }
     	    	
     }
 
     
     public function testdisplayErrors()
     {
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	
-    	//execute the method and check if it works and doesn't throws an exception
-    	try {
-    		$errors = $SugarView->displayErrors();
-    		$this->assertSame(NULL,$errors);
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        //execute the method and check if it works and doesn't throws an exception
+        try {
+            $errors = $SugarView->displayErrors();
+            $this->assertSame(NULL,$errors);
+        } catch (Exception $e) {
+            $this->fail();
+        }
     	
-    	$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
     	 
     	
     	
@@ -71,17 +71,17 @@ 
     public function testpreDisplay()
     {
 
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	 
-    	//execute the method and check if it works and doesn't throws an exception
-    	try {
-    		$SugarView->preDisplay();
+        //execute the method and check if it works and doesn't throws an exception
+        try {
+            $SugarView->preDisplay();
     	
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        } catch (Exception $e) {
+            $this->fail();
+        }
     	 
-    	$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
     	 
     
     }
@@ -90,76 +90,76 @@ 
     public function testdisplay()
     {
 
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	
-    	//execute the method and check if it works and doesn't throws an exception
-    	try {
-    		$SugarView->display();
+        //execute the method and check if it works and doesn't throws an exception
+        try {
+            $SugarView->display();
     		 
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        } catch (Exception $e) {
+            $this->fail();
+        }
     	
-    	$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
     
     }
 
     public function testdisplayHeader()
     {
 
-    	$SugarView = new SugarView();
-    	$SugarView->module = "Users";
-    	$GLOBALS['app'] = new SugarApplication();
+        $SugarView = new SugarView();
+        $SugarView->module = "Users";
+        $GLOBALS['app'] = new SugarApplication();
     	 
-    	//execute the method and check if it works and doesn't throws an exception
-    	//secondly check if it outputs any content to browser
-    	try {
-    		ob_start();
+        //execute the method and check if it works and doesn't throws an exception
+        //secondly check if it outputs any content to browser
+        try {
+            ob_start();
     		
-    		$SugarView->displayHeader();
+            $SugarView->displayHeader();
     		
-    		$renderedContent = ob_get_contents();
-    		ob_end_clean();
+            $renderedContent = ob_get_contents();
+            ob_end_clean();
     		
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+            $this->assertGreaterThan(0,strlen($renderedContent));
     	
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        } catch (Exception $e) {
+            $this->fail();
+        }
       
     }
 
     function testgetModuleMenuHTML()
     {
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	
-    	//execute the method and check if it works and doesn't throws an exception
-    	try {
-    		$SugarView->getModuleMenuHTML();
+        //execute the method and check if it works and doesn't throws an exception
+        try {
+            $SugarView->getModuleMenuHTML();
     		 
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        } catch (Exception $e) {
+            $this->fail();
+        }
     	
-    	$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
 
     }
 
  
     public function testincludeClassicFile()
     {
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	
-    	//execute the method and check if it works and doesn't throws an exception
-    	//use any valid file path, we just need to avoid failing require_once
-    	try {
-    		$SugarView->includeClassicFile('config.php');
+        //execute the method and check if it works and doesn't throws an exception
+        //use any valid file path, we just need to avoid failing require_once
+        try {
+            $SugarView->includeClassicFile('config.php');
     		 
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        } catch (Exception $e) {
+            $this->fail();
+        }
     	
-    	$this->assertTrue(TRUE);
+        $this->assertTrue(TRUE);
     	
     }
 
@@ -167,32 +167,32 @@ 
 
     public function testgetJavascriptValidation()
     {
-		//check if it returns any text i-e JS code    	
-    	$js = SugarView::getJavascriptValidation();  	
-    	$this->assertGreaterThan(0,strlen($js));
+        //check if it returns any text i-e JS code    	
+        $js = SugarView::getJavascriptValidation();  	
+        $this->assertGreaterThan(0,strlen($js));
     }
 
   
     public function testdisplayFooter()
     {
     	
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	
-    	//execute the method and check if it works and doesn't throws an exception
-    	//secondly check if it outputs any content to browser
-    	try {
-    		ob_start();
+        //execute the method and check if it works and doesn't throws an exception
+        //secondly check if it outputs any content to browser
+        try {
+            ob_start();
     	
-    		$SugarView->displayFooter();
+            $SugarView->displayFooter();
     	
-    		$renderedContent = ob_get_contents();
-    		ob_end_clean();
+            $renderedContent = ob_get_contents();
+            ob_end_clean();
     	
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+            $this->assertGreaterThan(0,strlen($renderedContent));
     		 
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        } catch (Exception $e) {
+            $this->fail();
+        }
     	  		
     }
 
@@ -200,23 +200,23 @@ 
     public function testrenderJavascript()
     {
 
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	 
-    	//execute the method and check if it works and doesn't throws an exception
-    	//secondly check if it outputs any content to browser
-    	try {
-    		ob_start();
+        //execute the method and check if it works and doesn't throws an exception
+        //secondly check if it outputs any content to browser
+        try {
+            ob_start();
     		 
-    		$SugarView->renderJavascript();
+            $SugarView->renderJavascript();
     		 
-    		$renderedContent = ob_get_contents();
-    		ob_end_clean();
+            $renderedContent = ob_get_contents();
+            ob_end_clean();
     		 
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+            $this->assertGreaterThan(0,strlen($renderedContent));
     		 
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        } catch (Exception $e) {
+            $this->fail();
+        }
     	
     }
 
@@ -225,14 +225,14 @@ 
     public function testgetMenu()
     {
     	  
-    	//error_reporting(E_ALL);
+        //error_reporting(E_ALL);
     	
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	
     	
-    	//execute the method and check if it works and throws an exception if no module is provided
-    	//it creates memory Fatal errors which causes PHPunit to crash so we will skip this scenario
-    	/*
+        //execute the method and check if it works and throws an exception if no module is provided
+        //it creates memory Fatal errors which causes PHPunit to crash so we will skip this scenario
+        /*
     	try {
     		//check first with invalid value and test if it throws an exception
     		$menu = $SugarView->getMenu();
@@ -244,28 +244,28 @@ 
     	} */ 	
     	
     	
-    	//check with valid value and check if it returns an array.
-    	$menu = $SugarView->getMenu('Users');
-    	$this->assertTrue(is_array($menu));
+        //check with valid value and check if it returns an array.
+        $menu = $SugarView->getMenu('Users');
+        $this->assertTrue(is_array($menu));
     	 
     }
 
     public function testgetModuleTitle()
     {
         
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	
-    	//first execute the method with default value
-    	$moduleTitle = $SugarView->getModuleTitle();		 
-    	$this->assertGreaterThan(0,strlen($moduleTitle));
+        //first execute the method with default value
+        $moduleTitle = $SugarView->getModuleTitle();		 
+        $this->assertGreaterThan(0,strlen($moduleTitle));
   	
-    	//second execute the method with true value
-    	$moduleTitle = $SugarView->getModuleTitle(true);
-    	$this->assertGreaterThan(0,strlen($moduleTitle));    
+        //second execute the method with true value
+        $moduleTitle = $SugarView->getModuleTitle(true);
+        $this->assertGreaterThan(0,strlen($moduleTitle));    
 
-    	//third execute the method with false value
-    	$moduleTitle = $SugarView->getModuleTitle(false);
-    	$this->assertGreaterThan(0,strlen($moduleTitle));    	
+        //third execute the method with false value
+        $moduleTitle = $SugarView->getModuleTitle(false);
+        $this->assertGreaterThan(0,strlen($moduleTitle));    	
     	
     }
 
@@ -273,19 +273,19 @@ 
     public function testgetMetaDataFile()
     {
    
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
 
-    	//first execute the method with missing attributes. it should return Null.
-    	$metaDataFile = $SugarView->getMetaDataFile();
-    	$this->assertEquals(NULL,$metaDataFile);
+        //first execute the method with missing attributes. it should return Null.
+        $metaDataFile = $SugarView->getMetaDataFile();
+        $this->assertEquals(NULL,$metaDataFile);
 
 
-    	//second execute the method with valid attributes set. it should return a file path string.
-    	$SugarView->type ='detail' ;
-    	$SugarView->module = 'Users';
+        //second execute the method with valid attributes set. it should return a file path string.
+        $SugarView->type ='detail' ;
+        $SugarView->module = 'Users';
     	
-    	$metaDataFile = $SugarView->getMetaDataFile();
-    	$this->assertGreaterThan(0,strlen($metaDataFile));
+        $metaDataFile = $SugarView->getMetaDataFile();
+        $this->assertGreaterThan(0,strlen($metaDataFile));
     	
     }
 
@@ -294,11 +294,11 @@ 
     public function testgetBrowserTitle()
     {
 
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	
-    	//execute the method. it should return a title string.
-    	$browserTitle = $SugarView->getBrowserTitle();
-    	$this->assertGreaterThan(0,strlen($browserTitle));    	
+        //execute the method. it should return a title string.
+        $browserTitle = $SugarView->getBrowserTitle();
+        $this->assertGreaterThan(0,strlen($browserTitle));    	
     	
     }
 
@@ -306,22 +306,22 @@ 
     public function testgetBreadCrumbSymbol()
     {
 
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	 
-    	//execute the method. it should return a string.
-    	$breadCrumbSymbol = $SugarView->getBreadCrumbSymbol();
-    	$this->assertGreaterThan(0,strlen($breadCrumbSymbol));    	
+        //execute the method. it should return a string.
+        $breadCrumbSymbol = $SugarView->getBreadCrumbSymbol();
+        $this->assertGreaterThan(0,strlen($breadCrumbSymbol));    	
     		
     }
 
 
     public function testcheckPostMaxSizeError(){
 
-    	$SugarView = new SugarView();
+        $SugarView = new SugarView();
     	
-    	//execute the method. it should return False because Request parameters are not available.
-    	$postMaxSizeError = $SugarView->checkPostMaxSizeError();
-    	$this->assertFalse($postMaxSizeError);
+        //execute the method. it should return False because Request parameters are not available.
+        $postMaxSizeError = $SugarView->checkPostMaxSizeError();
+        $this->assertFalse($postMaxSizeError);
     	
     }
 

Spacing +25 added lines, -25 removed lines

@@ -13,7 +13,7 @@ 
     	//execute the method and check if it works and doesn't throws an exception
     	try {
     		$SugarView->init();
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	 
@@ -41,9 +41,9 @@ 
     		$renderedContent = ob_get_contents();
     		ob_end_clean();
 
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+    		$this->assertGreaterThan(0, strlen($renderedContent));
     		  		
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
      		$this->fail();
     	}
     	    	
@@ -57,8 +57,8 @@ 
     	//execute the method and check if it works and doesn't throws an exception
     	try {
     		$errors = $SugarView->displayErrors();
-    		$this->assertSame(NULL,$errors);
-    	} catch (Exception $e) {
+    		$this->assertSame(NULL, $errors);
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -77,7 +77,7 @@ 
     	try {
     		$SugarView->preDisplay();
     	
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	 
@@ -96,7 +96,7 @@ 
     	try {
     		$SugarView->display();
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -121,9 +121,9 @@ 
     		$renderedContent = ob_get_contents();
     		ob_end_clean();
     		
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+    		$this->assertGreaterThan(0, strlen($renderedContent));
     	
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
       
@@ -137,7 +137,7 @@ 
     	try {
     		$SugarView->getModuleMenuHTML();
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -155,7 +155,7 @@ 
     	try {
     		$SugarView->includeClassicFile('config.php');
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -169,7 +169,7 @@ 
     {
 		//check if it returns any text i-e JS code    	
     	$js = SugarView::getJavascriptValidation();  	
-    	$this->assertGreaterThan(0,strlen($js));
+    	$this->assertGreaterThan(0, strlen($js));
     }
 
   
@@ -188,9 +188,9 @@ 
     		$renderedContent = ob_get_contents();
     		ob_end_clean();
     	
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+    		$this->assertGreaterThan(0, strlen($renderedContent));
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	  		
@@ -212,9 +212,9 @@ 
     		$renderedContent = ob_get_contents();
     		ob_end_clean();
     		 
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+    		$this->assertGreaterThan(0, strlen($renderedContent));
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -257,15 +257,15 @@ 
     	
     	//first execute the method with default value
     	$moduleTitle = $SugarView->getModuleTitle();		 
-    	$this->assertGreaterThan(0,strlen($moduleTitle));
+    	$this->assertGreaterThan(0, strlen($moduleTitle));
   	
     	//second execute the method with true value
     	$moduleTitle = $SugarView->getModuleTitle(true);
-    	$this->assertGreaterThan(0,strlen($moduleTitle));    
+    	$this->assertGreaterThan(0, strlen($moduleTitle));    
 
     	//third execute the method with false value
     	$moduleTitle = $SugarView->getModuleTitle(false);
-    	$this->assertGreaterThan(0,strlen($moduleTitle));    	
+    	$this->assertGreaterThan(0, strlen($moduleTitle));    	
     	
     }
 
@@ -277,15 +277,15 @@ 
 
     	//first execute the method with missing attributes. it should return Null.
     	$metaDataFile = $SugarView->getMetaDataFile();
-    	$this->assertEquals(NULL,$metaDataFile);
+    	$this->assertEquals(NULL, $metaDataFile);
 
 
     	//second execute the method with valid attributes set. it should return a file path string.
-    	$SugarView->type ='detail' ;
+    	$SugarView->type = 'detail';
     	$SugarView->module = 'Users';
     	
     	$metaDataFile = $SugarView->getMetaDataFile();
-    	$this->assertGreaterThan(0,strlen($metaDataFile));
+    	$this->assertGreaterThan(0, strlen($metaDataFile));
     	
     }
 
@@ -298,7 +298,7 @@ 
     	
     	//execute the method. it should return a title string.
     	$browserTitle = $SugarView->getBrowserTitle();
-    	$this->assertGreaterThan(0,strlen($browserTitle));    	
+    	$this->assertGreaterThan(0, strlen($browserTitle));    	
     	
     }
 
@@ -310,12 +310,12 @@ 
     	 
     	//execute the method. it should return a string.
     	$breadCrumbSymbol = $SugarView->getBreadCrumbSymbol();
-    	$this->assertGreaterThan(0,strlen($breadCrumbSymbol));    	
+    	$this->assertGreaterThan(0, strlen($breadCrumbSymbol));    	
     		
     }
 
 
-    public function testcheckPostMaxSizeError(){
+    public function testcheckPostMaxSizeError() {
 
     	$SugarView = new SugarView();
     	

tests/tests/include/MVC/View/ViewFactoryTest.php

Indentation +52 added lines, -52 removed lines

@@ -4,76 +4,76 @@
 
 class ViewFactoryTest extends PHPUnit_Framework_TestCase{
 
-	public function testloadView(){
-		error_reporting(E_ERROR | E_WARNING | E_PARSE);
+    public function testloadView(){
+        error_reporting(E_ERROR | E_WARNING | E_PARSE);
 		
-		//check with invalid input. must return sugaview instance
-		$view = ViewFactory::loadView('default','');
-		$this->assertInstanceOf('SugarView',$view);
+        //check with invalid input. must return sugaview instance
+        $view = ViewFactory::loadView('default','');
+        $this->assertInstanceOf('SugarView',$view);
 		
-		//check with a valid module without a specific view, must return sugarview instance
-		$view = ViewFactory::loadView('default','Users');
-		$this->assertInstanceOf('SugarView',$view);
+        //check with a valid module without a specific view, must return sugarview instance
+        $view = ViewFactory::loadView('default','Users');
+        $this->assertInstanceOf('SugarView',$view);
 		
-		//check with a valid module and specific view, must reutern speciifc view instance
-		$view = ViewFactory::loadView('list','Users');
-		$this->assertInstanceOf('UsersViewList',$view);		
+        //check with a valid module and specific view, must reutern speciifc view instance
+        $view = ViewFactory::loadView('list','Users');
+        $this->assertInstanceOf('UsersViewList',$view);		
 		
-	}
+    }
 
-	public function test_loadConfig(){
-		//check with a invalid module, method must not change the view options.
-		$view = ViewFactory::loadView('default','');
-		$options = $view->options;
-		ViewFactory::_loadConfig($view, 'default');
-		$this->assertSame($options,$view->options);
+    public function test_loadConfig(){
+        //check with a invalid module, method must not change the view options.
+        $view = ViewFactory::loadView('default','');
+        $options = $view->options;
+        ViewFactory::_loadConfig($view, 'default');
+        $this->assertSame($options,$view->options);
 		
 		
-		//check with a valid module which does not implement it's own view config. method must not change the view options.
-		 $view = ViewFactory::loadView('detail','Users');
-		 $options = $view->options;
-		 ViewFactory::_loadConfig($view, 'detail');
-		 $this->assertSame($options,$view->options);
+        //check with a valid module which does not implement it's own view config. method must not change the view options.
+            $view = ViewFactory::loadView('detail','Users');
+            $options = $view->options;
+            ViewFactory::_loadConfig($view, 'detail');
+            $this->assertSame($options,$view->options);
 		 
 		
-		//check with a valid module which implement it's own view config. method still must not change the view options because it needs.
-		$view = ViewFactory::loadView('area_detail_map','jjwg_Areas');
-		$view->module = 'jjwg_Areas';
-		$options = $view->options;
-		ViewFactory::_loadConfig($view, 'area_detail_map');
-		$this->assertSame($options,$view->options);		
+        //check with a valid module which implement it's own view config. method still must not change the view options because it needs.
+        $view = ViewFactory::loadView('area_detail_map','jjwg_Areas');
+        $view->module = 'jjwg_Areas';
+        $options = $view->options;
+        ViewFactory::_loadConfig($view, 'area_detail_map');
+        $this->assertSame($options,$view->options);		
 		
 		
-	}
+    }
 
-	public function test_buildFromFile(){
+    public function test_buildFromFile(){
 
-		//checck with valid values and test if it returns correct view instance
-		$type = 'list';
-		$target_module = 'Users';
-		$bean = Null;
-		$view = ViewFactory::_buildFromFile('modules/' . $target_module . '/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
-		$this->assertInstanceOf('UsersViewList',$view);
+        //checck with valid values and test if it returns correct view instance
+        $type = 'list';
+        $target_module = 'Users';
+        $bean = Null;
+        $view = ViewFactory::_buildFromFile('modules/' . $target_module . '/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
+        $this->assertInstanceOf('UsersViewList',$view);
 		
-		//checck with valid values and test if it returns correct view instance
-		$type = 'detail';
-		$target_module = 'Users';
-		$bean = Null;
-		$view = ViewFactory::_buildFromFile('modules/' . $target_module . '/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
-		$this->assertInstanceOf('UsersViewDetail',$view);
+        //checck with valid values and test if it returns correct view instance
+        $type = 'detail';
+        $target_module = 'Users';
+        $bean = Null;
+        $view = ViewFactory::_buildFromFile('modules/' . $target_module . '/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
+        $this->assertInstanceOf('UsersViewDetail',$view);
 		
-	}
+    }
 
-	public function test_buildClass(){
+    public function test_buildClass(){
 
-		//checck with valid values and test if it returns correct view instance
-		$view = ViewFactory::_buildClass('UsersViewList', Null, array());
-		$this->assertInstanceOf('UsersViewList',$view);		
+        //checck with valid values and test if it returns correct view instance
+        $view = ViewFactory::_buildClass('UsersViewList', Null, array());
+        $this->assertInstanceOf('UsersViewList',$view);		
 		
-		//checck with valid values and test if it returns correct view instance
-		$view = ViewFactory::_buildClass('UsersViewDetail', Null, array());
-		$this->assertInstanceOf('UsersViewDetail',$view);
+        //checck with valid values and test if it returns correct view instance
+        $view = ViewFactory::_buildClass('UsersViewDetail', Null, array());
+        $this->assertInstanceOf('UsersViewDetail',$view);
 				
-	}
+    }
 }
 ?>

Spacing +23 added lines, -23 removed lines

@@ -2,77 +2,77 @@
 
 
 
-class ViewFactoryTest extends PHPUnit_Framework_TestCase{
+class ViewFactoryTest extends PHPUnit_Framework_TestCase {
 
-	public function testloadView(){
+	public function testloadView() {
 		error_reporting(E_ERROR | E_WARNING | E_PARSE);
 		
 		//check with invalid input. must return sugaview instance
-		$view = ViewFactory::loadView('default','');
-		$this->assertInstanceOf('SugarView',$view);
+		$view = ViewFactory::loadView('default', '');
+		$this->assertInstanceOf('SugarView', $view);
 		
 		//check with a valid module without a specific view, must return sugarview instance
-		$view = ViewFactory::loadView('default','Users');
-		$this->assertInstanceOf('SugarView',$view);
+		$view = ViewFactory::loadView('default', 'Users');
+		$this->assertInstanceOf('SugarView', $view);
 		
 		//check with a valid module and specific view, must reutern speciifc view instance
-		$view = ViewFactory::loadView('list','Users');
-		$this->assertInstanceOf('UsersViewList',$view);		
+		$view = ViewFactory::loadView('list', 'Users');
+		$this->assertInstanceOf('UsersViewList', $view);		
 		
 	}
 
-	public function test_loadConfig(){
+	public function test_loadConfig() {
 		//check with a invalid module, method must not change the view options.
-		$view = ViewFactory::loadView('default','');
+		$view = ViewFactory::loadView('default', '');
 		$options = $view->options;
 		ViewFactory::_loadConfig($view, 'default');
-		$this->assertSame($options,$view->options);
+		$this->assertSame($options, $view->options);
 		
 		
 		//check with a valid module which does not implement it's own view config. method must not change the view options.
-		 $view = ViewFactory::loadView('detail','Users');
+		 $view = ViewFactory::loadView('detail', 'Users');
 		 $options = $view->options;
 		 ViewFactory::_loadConfig($view, 'detail');
-		 $this->assertSame($options,$view->options);
+		 $this->assertSame($options, $view->options);
 		 
 		
 		//check with a valid module which implement it's own view config. method still must not change the view options because it needs.
-		$view = ViewFactory::loadView('area_detail_map','jjwg_Areas');
+		$view = ViewFactory::loadView('area_detail_map', 'jjwg_Areas');
 		$view->module = 'jjwg_Areas';
 		$options = $view->options;
 		ViewFactory::_loadConfig($view, 'area_detail_map');
-		$this->assertSame($options,$view->options);		
+		$this->assertSame($options, $view->options);		
 		
 		
 	}
 
-	public function test_buildFromFile(){
+	public function test_buildFromFile() {
 
 		//checck with valid values and test if it returns correct view instance
 		$type = 'list';
 		$target_module = 'Users';
 		$bean = Null;
-		$view = ViewFactory::_buildFromFile('modules/' . $target_module . '/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
-		$this->assertInstanceOf('UsersViewList',$view);
+		$view = ViewFactory::_buildFromFile('modules/'.$target_module.'/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
+		$this->assertInstanceOf('UsersViewList', $view);
 		
 		//checck with valid values and test if it returns correct view instance
 		$type = 'detail';
 		$target_module = 'Users';
 		$bean = Null;
-		$view = ViewFactory::_buildFromFile('modules/' . $target_module . '/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
-		$this->assertInstanceOf('UsersViewDetail',$view);
+		$view = ViewFactory::_buildFromFile('modules/'.$target_module.'/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
+		$this->assertInstanceOf('UsersViewDetail', $view);
 		
 	}
 
-	public function test_buildClass(){
+	public function test_buildClass() {
 
 		//checck with valid values and test if it returns correct view instance
 		$view = ViewFactory::_buildClass('UsersViewList', Null, array());
-		$this->assertInstanceOf('UsersViewList',$view);		
+		$this->assertInstanceOf('UsersViewList', $view);		
 		
 		//checck with valid values and test if it returns correct view instance
 		$view = ViewFactory::_buildClass('UsersViewDetail', Null, array());
-		$this->assertInstanceOf('UsersViewDetail',$view);
+		$this->assertInstanceOf('UsersViewDetail', $view);
 				
 	}
 }

tests/tests/include/MVC/View/views/view.metadataTest.php

Indentation +131 added lines, -131 removed lines

@@ -3,194 +3,194 @@
 class ViewMetadataTest extends PHPUnit_Framework_TestCase
 {
 
- 	public function testdisplayCheckBoxes(){
+        public function testdisplayCheckBoxes(){
 
- 		$view = new ViewMetadata();
+            $view = new ViewMetadata();
  		
- 		//check with empty values array. it should return html sting
- 		ob_start();
- 		$values = Array();
- 		$view->displayCheckBoxes('test',$values);		
- 		$renderedContent1 = ob_get_contents();
- 		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent1));
+            //check with empty values array. it should return html sting
+            ob_start();
+            $values = Array();
+            $view->displayCheckBoxes('test',$values);		
+            $renderedContent1 = ob_get_contents();
+            ob_end_clean();
+            $this->assertGreaterThan(0,strlen($renderedContent1));
  		
  		
- 		//check with prefilled values array. it should return html sting longer than earlier
- 		ob_start();
- 		$values = Array('option1','option2');
- 		$view->displayCheckBoxes('test',$values);
- 		$renderedContent2 = ob_get_contents();
- 		ob_end_clean();
- 		$this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
+            //check with prefilled values array. it should return html sting longer than earlier
+            ob_start();
+            $values = Array('option1','option2');
+            $view->displayCheckBoxes('test',$values);
+            $renderedContent2 = ob_get_contents();
+            ob_end_clean();
+            $this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
  			
- 	}
+        }
  	
- 	public function testdisplaySelect(){
+        public function testdisplaySelect(){
 
- 		$view = new ViewMetadata();
+            $view = new ViewMetadata();
  			
- 		//check with empty values array. it should return html sting
- 		ob_start();
- 		$values = Array();
- 		$view->displaySelect('test',$values);
- 		$renderedContent1 = ob_get_contents();
- 		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent1));
+            //check with empty values array. it should return html sting
+            ob_start();
+            $values = Array();
+            $view->displaySelect('test',$values);
+            $renderedContent1 = ob_get_contents();
+            ob_end_clean();
+            $this->assertGreaterThan(0,strlen($renderedContent1));
  			
  			
- 		//check with prefilled values array. it should return html sting longer than earlier
- 		ob_start();
- 		$values = Array('option1','option2');
- 		$view->displaySelect('test',$values);
- 		$renderedContent2 = ob_get_contents();
- 		ob_end_clean();
- 		$this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
+            //check with prefilled values array. it should return html sting longer than earlier
+            ob_start();
+            $values = Array('option1','option2');
+            $view->displaySelect('test',$values);
+            $renderedContent2 = ob_get_contents();
+            ob_end_clean();
+            $this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
  			
  		
- 	}
+        }
  	
  	
  	
- 	public function testdisplayTextBoxes(){
+        public function testdisplayTextBoxes(){
 
- 		$view = new ViewMetadata();
+            $view = new ViewMetadata();
  		
- 		//check with empty values array. it should return html sting
- 		ob_start();
- 		$values = Array();
- 		$view->displayTextBoxes($values);
- 		$renderedContent1 = ob_get_contents();
- 		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent1));
+            //check with empty values array. it should return html sting
+            ob_start();
+            $values = Array();
+            $view->displayTextBoxes($values);
+            $renderedContent1 = ob_get_contents();
+            ob_end_clean();
+            $this->assertGreaterThan(0,strlen($renderedContent1));
  		
  		
- 		//check with prefilled values array. it should return html sting longer than earlier
- 		ob_start();
- 		$values = Array('option1','option2');
- 		$view->displayTextBoxes($values);
- 		$renderedContent2 = ob_get_contents();
- 		ob_end_clean();
- 		$this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
+            //check with prefilled values array. it should return html sting longer than earlier
+            ob_start();
+            $values = Array('option1','option2');
+            $view->displayTextBoxes($values);
+            $renderedContent2 = ob_get_contents();
+            ob_end_clean();
+            $this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
  			
  		
- 	}
+        }
  	
  	 	
- 	public function testprintValue(){
+        public function testprintValue(){
 
- 		$view = new ViewMetadata();
+            $view = new ViewMetadata();
  		
- 		ob_start();
- 		$values = Array('option1','option2');
- 		$view->printValue($values);
- 		$renderedContent = ob_get_contents();
- 		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent));
+            ob_start();
+            $values = Array('option1','option2');
+            $view->printValue($values);
+            $renderedContent = ob_get_contents();
+            ob_end_clean();
+            $this->assertGreaterThan(0,strlen($renderedContent));
  		
- 	}
+        }
  	
- 	public function testdisplay(){
- 		error_reporting(E_ERROR | E_PARSE);
+        public function testdisplay(){
+            error_reporting(E_ERROR | E_PARSE);
  		
- 		$view = new ViewMetadata();
+            $view = new ViewMetadata();
  
- 		//test without setting REQUEST parameters
- 		ob_start();
- 		$view->display();
- 		$renderedContent = ob_get_contents();
- 		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent));
+            //test without setting REQUEST parameters
+            ob_start();
+            $view->display();
+            $renderedContent = ob_get_contents();
+            ob_end_clean();
+            $this->assertGreaterThan(0,strlen($renderedContent));
  			
  		
- 		//test with REQUEST parameters set
- 		$_REQUEST['modules'] = Array('Calls','Meetings');
- 		ob_start();
- 		$view->display();
- 		$renderedContent = ob_get_contents();
- 		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent));
+            //test with REQUEST parameters set
+            $_REQUEST['modules'] = Array('Calls','Meetings');
+            ob_start();
+            $view->display();
+            $renderedContent = ob_get_contents();
+            ob_end_clean();
+            $this->assertGreaterThan(0,strlen($renderedContent));
  			
-	}
+    }
 
 	
-	public function testgetModules(){
+    public function testgetModules(){
 		
-		//execute the method and test if it returns a array.
-		$modules = VardefBrowser::getModules();
-		$this->assertTrue(is_array($modules));
+        //execute the method and test if it returns a array.
+        $modules = VardefBrowser::getModules();
+        $this->assertTrue(is_array($modules));
 	
-	}
+    }
 	
-	public function testfindFieldsWithAttributes(){
+    public function testfindFieldsWithAttributes(){
 		
-		//check with emptty attributes array
-		$attributes = Array();
-		$fields1 = VardefBrowser::findFieldsWithAttributes($attributes);
-		$this->assertTrue(is_array($fields1));
+        //check with emptty attributes array
+        $attributes = Array();
+        $fields1 = VardefBrowser::findFieldsWithAttributes($attributes);
+        $this->assertTrue(is_array($fields1));
 		
-		//check with a very common attribute
-		$attributes = Array('id');
-		$fields2 = VardefBrowser::findFieldsWithAttributes($attributes);
-		$this->assertTrue(is_array($fields2));		
+        //check with a very common attribute
+        $attributes = Array('id');
+        $fields2 = VardefBrowser::findFieldsWithAttributes($attributes);
+        $this->assertTrue(is_array($fields2));		
 
-		//check with a very specific attribute
-		$attributes = Array('category');
-		$fields3 = VardefBrowser::findFieldsWithAttributes($attributes);
-		$this->assertTrue(is_array($fields3));
+        //check with a very specific attribute
+        $attributes = Array('category');
+        $fields3 = VardefBrowser::findFieldsWithAttributes($attributes);
+        $this->assertTrue(is_array($fields3));
 				
-		//check that all three arrays returned, are not same.
-		$this->assertNotSame($fields1,$fields2);
-		$this->assertNotSame($fields1,$fields3);
-		$this->assertNotSame($fields2,$fields3);
+        //check that all three arrays returned, are not same.
+        $this->assertNotSame($fields1,$fields2);
+        $this->assertNotSame($fields1,$fields3);
+        $this->assertNotSame($fields2,$fields3);
 		
-	}
+    }
 	
-	public function testfindVardefs(){
+    public function testfindVardefs(){
 	
-		//check with empty modules array
-		$modules = Array();
-		$defs1 = VardefBrowser::findVardefs($modules);
-		$this->assertTrue(is_array($defs1));
+        //check with empty modules array
+        $modules = Array();
+        $defs1 = VardefBrowser::findVardefs($modules);
+        $this->assertTrue(is_array($defs1));
 		
 		
-		//check with modules array set.
-		$modules = Array('Calls');
-		$defs2 = VardefBrowser::findVardefs($modules);
-		$this->assertTrue(is_array($defs2));
+        //check with modules array set.
+        $modules = Array('Calls');
+        $defs2 = VardefBrowser::findVardefs($modules);
+        $this->assertTrue(is_array($defs2));
 		
-		//check that two arrays returned, are not same.
-		$this->assertNotSame($defs1,$defs2);
+        //check that two arrays returned, are not same.
+        $this->assertNotSame($defs1,$defs2);
 		
-	}
+    }
 	
 	
-	public function testfindFieldAttributes(){
+    public function testfindFieldAttributes(){
 	
-		//check with emptty attributes array
-		$attributes = Array();
-		$fields1 = VardefBrowser::findFieldAttributes();
-		$this->assertTrue(is_array($fields1));
+        //check with emptty attributes array
+        $attributes = Array();
+        $fields1 = VardefBrowser::findFieldAttributes();
+        $this->assertTrue(is_array($fields1));
 
 		
-		//check with emptty attributes array and prefilled modules array.
-		$attributes = Array();
-		$modules = Array('Users');
-		$fields2 = VardefBrowser::findFieldAttributes($attributes,$modules,true,true);
-		$this->assertTrue(is_array($fields2));
+        //check with emptty attributes array and prefilled modules array.
+        $attributes = Array();
+        $modules = Array('Users');
+        $fields2 = VardefBrowser::findFieldAttributes($attributes,$modules,true,true);
+        $this->assertTrue(is_array($fields2));
 	
 		
-		//check with a very specific attribute and empty modules array.
-		$attributes = Array('category');
-		$fields3 = VardefBrowser::findFieldAttributes($attributes);
-		$this->assertTrue(is_array($fields3));
+        //check with a very specific attribute and empty modules array.
+        $attributes = Array('category');
+        $fields3 = VardefBrowser::findFieldAttributes($attributes);
+        $this->assertTrue(is_array($fields3));
 		
 		
-		//check that all three arrays returned, are not same.
-		$this->assertNotSame($fields1,$fields2);
-		$this->assertNotSame($fields1,$fields3);
-		$this->assertNotSame($fields2,$fields3);
+        //check that all three arrays returned, are not same.
+        $this->assertNotSame($fields1,$fields2);
+        $this->assertNotSame($fields1,$fields3);
+        $this->assertNotSame($fields2,$fields3);
 		
-	}	
+    }	
 	
 }

Spacing +35 added lines, -35 removed lines

@@ -3,56 +3,56 @@ 
 class ViewMetadataTest extends PHPUnit_Framework_TestCase
 {
 
- 	public function testdisplayCheckBoxes(){
+ 	public function testdisplayCheckBoxes() {
 
  		$view = new ViewMetadata();
  		
  		//check with empty values array. it should return html sting
  		ob_start();
  		$values = Array();
- 		$view->displayCheckBoxes('test',$values);		
+ 		$view->displayCheckBoxes('test', $values);		
  		$renderedContent1 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent1));
+ 		$this->assertGreaterThan(0, strlen($renderedContent1));
  		
  		
  		//check with prefilled values array. it should return html sting longer than earlier
  		ob_start();
- 		$values = Array('option1','option2');
- 		$view->displayCheckBoxes('test',$values);
+ 		$values = Array('option1', 'option2');
+ 		$view->displayCheckBoxes('test', $values);
  		$renderedContent2 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
+ 		$this->assertGreaterThan(strlen($renderedContent1), strlen($renderedContent2));
  			
  	}
  	
- 	public function testdisplaySelect(){
+ 	public function testdisplaySelect() {
 
  		$view = new ViewMetadata();
  			
  		//check with empty values array. it should return html sting
  		ob_start();
  		$values = Array();
- 		$view->displaySelect('test',$values);
+ 		$view->displaySelect('test', $values);
  		$renderedContent1 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent1));
+ 		$this->assertGreaterThan(0, strlen($renderedContent1));
  			
  			
  		//check with prefilled values array. it should return html sting longer than earlier
  		ob_start();
- 		$values = Array('option1','option2');
- 		$view->displaySelect('test',$values);
+ 		$values = Array('option1', 'option2');
+ 		$view->displaySelect('test', $values);
  		$renderedContent2 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
+ 		$this->assertGreaterThan(strlen($renderedContent1), strlen($renderedContent2));
  			
  		
  	}
  	
  	
  	
- 	public function testdisplayTextBoxes(){
+ 	public function testdisplayTextBoxes() {
 
  		$view = new ViewMetadata();
  		
@@ -62,35 +62,35 @@ 
  		$view->displayTextBoxes($values);
  		$renderedContent1 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent1));
+ 		$this->assertGreaterThan(0, strlen($renderedContent1));
  		
  		
  		//check with prefilled values array. it should return html sting longer than earlier
  		ob_start();
- 		$values = Array('option1','option2');
+ 		$values = Array('option1', 'option2');
  		$view->displayTextBoxes($values);
  		$renderedContent2 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
+ 		$this->assertGreaterThan(strlen($renderedContent1), strlen($renderedContent2));
  			
  		
  	}
  	
  	 	
- 	public function testprintValue(){
+ 	public function testprintValue() {
 
  		$view = new ViewMetadata();
  		
  		ob_start();
- 		$values = Array('option1','option2');
+ 		$values = Array('option1', 'option2');
  		$view->printValue($values);
  		$renderedContent = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent));
+ 		$this->assertGreaterThan(0, strlen($renderedContent));
  		
  	}
  	
- 	public function testdisplay(){
+ 	public function testdisplay() {
  		error_reporting(E_ERROR | E_PARSE);
  		
  		$view = new ViewMetadata();
@@ -100,21 +100,21 @@ 
  		$view->display();
  		$renderedContent = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent));
+ 		$this->assertGreaterThan(0, strlen($renderedContent));
  			
  		
  		//test with REQUEST parameters set
- 		$_REQUEST['modules'] = Array('Calls','Meetings');
+ 		$_REQUEST['modules'] = Array('Calls', 'Meetings');
  		ob_start();
  		$view->display();
  		$renderedContent = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent));
+ 		$this->assertGreaterThan(0, strlen($renderedContent));
  			
 	}
 
 	
-	public function testgetModules(){
+	public function testgetModules() {
 		
 		//execute the method and test if it returns a array.
 		$modules = VardefBrowser::getModules();
@@ -122,7 +122,7 @@ 
 	
 	}
 	
-	public function testfindFieldsWithAttributes(){
+	public function testfindFieldsWithAttributes() {
 		
 		//check with emptty attributes array
 		$attributes = Array();
@@ -140,13 +140,13 @@ 
 		$this->assertTrue(is_array($fields3));
 				
 		//check that all three arrays returned, are not same.
-		$this->assertNotSame($fields1,$fields2);
-		$this->assertNotSame($fields1,$fields3);
-		$this->assertNotSame($fields2,$fields3);
+		$this->assertNotSame($fields1, $fields2);
+		$this->assertNotSame($fields1, $fields3);
+		$this->assertNotSame($fields2, $fields3);
 		
 	}
 	
-	public function testfindVardefs(){
+	public function testfindVardefs() {
 	
 		//check with empty modules array
 		$modules = Array();
@@ -160,12 +160,12 @@ 
 		$this->assertTrue(is_array($defs2));
 		
 		//check that two arrays returned, are not same.
-		$this->assertNotSame($defs1,$defs2);
+		$this->assertNotSame($defs1, $defs2);
 		
 	}
 	
 	
-	public function testfindFieldAttributes(){
+	public function testfindFieldAttributes() {
 	
 		//check with emptty attributes array
 		$attributes = Array();
@@ -176,7 +176,7 @@ 
 		//check with emptty attributes array and prefilled modules array.
 		$attributes = Array();
 		$modules = Array('Users');
-		$fields2 = VardefBrowser::findFieldAttributes($attributes,$modules,true,true);
+		$fields2 = VardefBrowser::findFieldAttributes($attributes, $modules, true, true);
 		$this->assertTrue(is_array($fields2));
 	
 		
@@ -187,9 +187,9 @@ 
 		
 		
 		//check that all three arrays returned, are not same.
-		$this->assertNotSame($fields1,$fields2);
-		$this->assertNotSame($fields1,$fields3);
-		$this->assertNotSame($fields2,$fields3);
+		$this->assertNotSame($fields1, $fields2);
+		$this->assertNotSame($fields1, $fields3);
+		$this->assertNotSame($fields2, $fields3);
 		
 	}	
 	

tests/tests/include/MVC/View/views/view.ajaxuiTest.php

Indentation +17 added lines, -17 removed lines

@@ -3,28 +3,28 @@
 class ViewAjaxUITest extends PHPUnit_Framework_TestCase
 {
 	
- 	public function test__construct()
- 	{
- 		//execute the contructor and check for the Object type and type attribute
- 		$view = new ViewAjaxUI();
- 		$this->assertInstanceOf('ViewAjaxUI',$view);
- 		$this->assertInstanceOf('SugarView',$view);
- 		$this->assertTrue( is_array($view->options));
+        public function test__construct()
+        {
+            //execute the contructor and check for the Object type and type attribute
+            $view = new ViewAjaxUI();
+            $this->assertInstanceOf('ViewAjaxUI',$view);
+            $this->assertInstanceOf('SugarView',$view);
+            $this->assertTrue( is_array($view->options));
  		
- 	}
+        }
 
     public function testdisplay()
- 	{
+        {
  		 		
- 		$view = new ViewAjaxUI();
+            $view = new ViewAjaxUI();
  	
- 		//execute the method and test if it works and does not throws an exception other than headers output exception.
- 		try {
- 			$view->display();
+            //execute the method and test if it works and does not throws an exception other than headers output exception.
+            try {
+                $view->display();
  				
- 		} catch (Exception $e) {
- 			$this->assertStringStartsWith('Cannot modify header information',$e->getMessage());
- 		}
+            } catch (Exception $e) {
+                $this->assertStringStartsWith('Cannot modify header information',$e->getMessage());
+            }
  		
- 	}
+        }
 }

Spacing +5 added lines, -5 removed lines

@@ -7,9 +7,9 @@ 
  	{
  		//execute the contructor and check for the Object type and type attribute
  		$view = new ViewAjaxUI();
- 		$this->assertInstanceOf('ViewAjaxUI',$view);
- 		$this->assertInstanceOf('SugarView',$view);
- 		$this->assertTrue( is_array($view->options));
+ 		$this->assertInstanceOf('ViewAjaxUI', $view);
+ 		$this->assertInstanceOf('SugarView', $view);
+ 		$this->assertTrue(is_array($view->options));
  		
  	}
 
@@ -22,8 +22,8 @@ 
  		try {
  			$view->display();
  				
- 		} catch (Exception $e) {
- 			$this->assertStringStartsWith('Cannot modify header information',$e->getMessage());
+ 		}catch (Exception $e) {
+ 			$this->assertStringStartsWith('Cannot modify header information', $e->getMessage());
  		}
  		
  	}

tests/tests/include/MVC/View/views/view.favoritesTest.php

Indentation +8 added lines, -8 removed lines

@@ -6,15 +6,15 @@
 class ViewFavoritesTest extends PHPUnit_Framework_TestCase
 {
 	
- 	public function test__construct()
- 	{
- 		$this->markTestIncomplete('Can Not be implemented');
- 	}	
+        public function test__construct()
+        {
+            $this->markTestIncomplete('Can Not be implemented');
+        }	
  	
- 	public function testdisplay()
- 	{
- 		$this->markTestIncomplete('Can Not be implemented');
- 	}
+        public function testdisplay()
+        {
+            $this->markTestIncomplete('Can Not be implemented');
+        }
  	
  	
 }

tests/tests/include/MVC/View/views/view.listTest.php

Indentation +112 added lines, -112 removed lines

@@ -5,171 +5,171 @@
 
     public function testViewList()
     {
-    	//execute the contructor and check for the Object type and type attribute
-    	$view = new ViewList();
-    	$this->assertInstanceOf('ViewList',$view);
-    	$this->assertInstanceOf('SugarView',$view);
-    	$this->assertAttributeEquals('list','type', $view);
+        //execute the contructor and check for the Object type and type attribute
+        $view = new ViewList();
+        $this->assertInstanceOf('ViewList',$view);
+        $this->assertInstanceOf('SugarView',$view);
+        $this->assertAttributeEquals('list','type', $view);
     }
 
 
     public function testoldSearch()
     {
-    	$view = new ViewList();
+        $view = new ViewList();
     	
-    	//execute the method and test if it works and does not throws an exception.
-    	try {
-    		$view->oldSearch();
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $view->oldSearch();
  
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        } catch (Exception $e) {
+            $this->fail();
+        }
     	 
     }
     
     public function testnewSearch()
     {
-    	$view = new ViewList();
+        $view = new ViewList();
     	 
-    	//execute the method and test if it works and does not throws an exception.
-    	try {
-    		$view->newSearch();
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $view->newSearch();
     		 
-    	} catch (Exception $e) {
-    		$this->fail();
-    	}
+        } catch (Exception $e) {
+            $this->fail();
+        }
     	
     }
 
     public function testlistViewPrepare()
     {
-    	error_reporting(E_ERROR | E_PARSE);
-    	
-    	//test without setting parameters. it should return some html
-    	$view = new ViewList();
-    	$view->module = "Users";
-    	
-    	ob_start();
-    	$view->listViewPrepare();
-    	$renderedContent = ob_get_contents();
-    	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
-    	
-    	
-    	//test with some REQUEST parameters preset. it should return some html and set the REQUEST key we provided in current_query_by_page REQUEST Param.
-    	$view = new ViewList();
-    	$view->module = "Users";
-    	$GLOBALS['module']= "Users";
-    	$_REQUEST["Users2_USER_offset"]= 1;
-    	$_REQUEST['current_query_by_page'] = base64_encode(serialize(Array("key"=>"value")));
-    	$view->bean = New User();
-    	
-    	ob_start();
-    	$view->listViewPrepare();
-    	$renderedContent = ob_get_contents();
-    	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
-    	$this->assertEquals('value',$_REQUEST['key']);
+        error_reporting(E_ERROR | E_PARSE);
+    	
+        //test without setting parameters. it should return some html
+        $view = new ViewList();
+        $view->module = "Users";
+    	
+        ob_start();
+        $view->listViewPrepare();
+        $renderedContent = ob_get_contents();
+        ob_end_clean();
+        $this->assertGreaterThan(0,strlen($renderedContent));
+    	
+    	
+        //test with some REQUEST parameters preset. it should return some html and set the REQUEST key we provided in current_query_by_page REQUEST Param.
+        $view = new ViewList();
+        $view->module = "Users";
+        $GLOBALS['module']= "Users";
+        $_REQUEST["Users2_USER_offset"]= 1;
+        $_REQUEST['current_query_by_page'] = base64_encode(serialize(Array("key"=>"value")));
+        $view->bean = New User();
+    	
+        ob_start();
+        $view->listViewPrepare();
+        $renderedContent = ob_get_contents();
+        ob_end_clean();
+        $this->assertGreaterThan(0,strlen($renderedContent));
+        $this->assertEquals('value',$_REQUEST['key']);
     	
     }
 
     public function testlistViewProcess()
     {
-    	//execute the method and call methods to get the required child objects set. it should return some html.
-    	$view = new ViewList();
-    	$view->seed = new User();
-    	$view->prepareSearchForm();
-    	$view->preDisplay();
-    	
-    	ob_start();
-    	$view->listViewProcess();
-    	$renderedContent = ob_get_contents();
-    	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
+        //execute the method and call methods to get the required child objects set. it should return some html.
+        $view = new ViewList();
+        $view->seed = new User();
+        $view->prepareSearchForm();
+        $view->preDisplay();
+    	
+        ob_start();
+        $view->listViewProcess();
+        $renderedContent = ob_get_contents();
+        ob_end_clean();
+        $this->assertGreaterThan(0,strlen($renderedContent));
     	    	
     }
     
     public function testprepareSearchForm()
     {
-  		//test without any REQUEST parameters set. it will set searchform attribute to a searchform object. 
-    	$view1 = new ViewList();
-    	$view1->module = "Users";
-    	$view1->prepareSearchForm();    	
-    	$this->assertInstanceOf('SearchForm',$view1->searchForm);
-    	
-    	
-    	//test with REQUEST parameters set. it will set searchform attribute to a searchform object.
-    	$view2 = new ViewList();
-    	$view2->module = "Users";
-    	$_REQUEST['search_form'] = true;
-    	$_REQUEST['searchFormTab'] = 'advanced_search';
-    	$view2->prepareSearchForm();
+            //test without any REQUEST parameters set. it will set searchform attribute to a searchform object. 
+        $view1 = new ViewList();
+        $view1->module = "Users";
+        $view1->prepareSearchForm();    	
+        $this->assertInstanceOf('SearchForm',$view1->searchForm);
+    	
+    	
+        //test with REQUEST parameters set. it will set searchform attribute to a searchform object.
+        $view2 = new ViewList();
+        $view2->module = "Users";
+        $_REQUEST['search_form'] = true;
+        $_REQUEST['searchFormTab'] = 'advanced_search';
+        $view2->prepareSearchForm();
     	 
-    	$this->assertInstanceOf('SearchForm',$view2->searchForm);
+        $this->assertInstanceOf('SearchForm',$view2->searchForm);
  
     }
 
     public function testprocessSearchForm()
     {
-    	//test without use_old_search. it should return html.
-    	$view = new ViewList();
-    	$view->prepareSearchForm();
+        //test without use_old_search. it should return html.
+        $view = new ViewList();
+        $view->prepareSearchForm();
   
-    	ob_start();
-    	$view->processSearchForm();
-    	$renderedContent = ob_get_contents();
-    	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
+        ob_start();
+        $view->processSearchForm();
+        $renderedContent = ob_get_contents();
+        ob_end_clean();
+        $this->assertGreaterThan(0,strlen($renderedContent));
   
     	
-    	//test with use_old_search = true. there is a $view variable which is never set so it doesn't returns anything.
-    	$view = new ViewList();
-    	$view->prepareSearchForm();
-    	$view->use_old_search = true;
+        //test with use_old_search = true. there is a $view variable which is never set so it doesn't returns anything.
+        $view = new ViewList();
+        $view->prepareSearchForm();
+        $view->use_old_search = true;
     	
-    	ob_start();
-    	$view->processSearchForm();
-    	$renderedContent = ob_get_contents();
-    	ob_end_clean();
-    	$this->assertEquals(0,strlen($renderedContent));
+        ob_start();
+        $view->processSearchForm();
+        $renderedContent = ob_get_contents();
+        ob_end_clean();
+        $this->assertEquals(0,strlen($renderedContent));
 
     }
     
     
     public function testpreDisplay()
     {
-		//execute the method and test if it sets the lv attribute to ListViewSmarty object.
-    	$view = new ViewList();
-    	$view->preDisplay();
-    	$this->assertInstanceOf('ListViewSmarty',$view->lv);
+        //execute the method and test if it sets the lv attribute to ListViewSmarty object.
+        $view = new ViewList();
+        $view->preDisplay();
+        $this->assertInstanceOf('ListViewSmarty',$view->lv);
     	
     }
     
     public function testdisplay()
     {
-    	$view = new ViewList();
+        $view = new ViewList();
     	
-    	//test without setting bean attibute. it shuold return no access html.
-    	ob_start();
-    	$view->display();
-    	$renderedContent1 = ob_get_contents();
-    	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent1));
+        //test without setting bean attibute. it shuold return no access html.
+        ob_start();
+        $view->display();
+        $renderedContent1 = ob_get_contents();
+        ob_end_clean();
+        $this->assertGreaterThan(0,strlen($renderedContent1));
     	
 
-    	//test with bean, seed and other arrtibutes set. it shuold return html. 
-    	$view->bean = new User();
-    	$view->seed = new User();
-    	$view->module = "Users";
-    	$view->prepareSearchForm();
-    	$view->preDisplay();
-    	
-    	ob_start();
-    	
-    	$view->display();
-    	$renderedContent2 = ob_get_contents();
-    	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent2));
+        //test with bean, seed and other arrtibutes set. it shuold return html. 
+        $view->bean = new User();
+        $view->seed = new User();
+        $view->module = "Users";
+        $view->prepareSearchForm();
+        $view->preDisplay();
+    	
+        ob_start();
+    	
+        $view->display();
+        $renderedContent2 = ob_get_contents();
+        ob_end_clean();
+        $this->assertGreaterThan(0,strlen($renderedContent2));
     	
     	
     

Spacing +18 added lines, -18 removed lines

@@ -7,9 +7,9 @@ 
     {
     	//execute the contructor and check for the Object type and type attribute
     	$view = new ViewList();
-    	$this->assertInstanceOf('ViewList',$view);
-    	$this->assertInstanceOf('SugarView',$view);
-    	$this->assertAttributeEquals('list','type', $view);
+    	$this->assertInstanceOf('ViewList', $view);
+    	$this->assertInstanceOf('SugarView', $view);
+    	$this->assertAttributeEquals('list', 'type', $view);
     }
 
 
@@ -21,7 +21,7 @@ 
     	try {
     		$view->oldSearch();
  
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	 
@@ -35,7 +35,7 @@ 
     	try {
     		$view->newSearch();
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -53,14 +53,14 @@ 
     	$view->listViewPrepare();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
+    	$this->assertGreaterThan(0, strlen($renderedContent));
     	
     	
     	//test with some REQUEST parameters preset. it should return some html and set the REQUEST key we provided in current_query_by_page REQUEST Param.
     	$view = new ViewList();
     	$view->module = "Users";
-    	$GLOBALS['module']= "Users";
-    	$_REQUEST["Users2_USER_offset"]= 1;
+    	$GLOBALS['module'] = "Users";
+    	$_REQUEST["Users2_USER_offset"] = 1;
     	$_REQUEST['current_query_by_page'] = base64_encode(serialize(Array("key"=>"value")));
     	$view->bean = New User();
     	
@@ -68,8 +68,8 @@ 
     	$view->listViewPrepare();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
-    	$this->assertEquals('value',$_REQUEST['key']);
+    	$this->assertGreaterThan(0, strlen($renderedContent));
+    	$this->assertEquals('value', $_REQUEST['key']);
     	
     }
 
@@ -85,7 +85,7 @@ 
     	$view->listViewProcess();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
+    	$this->assertGreaterThan(0, strlen($renderedContent));
     	    	
     }
     
@@ -95,7 +95,7 @@ 
     	$view1 = new ViewList();
     	$view1->module = "Users";
     	$view1->prepareSearchForm();    	
-    	$this->assertInstanceOf('SearchForm',$view1->searchForm);
+    	$this->assertInstanceOf('SearchForm', $view1->searchForm);
     	
     	
     	//test with REQUEST parameters set. it will set searchform attribute to a searchform object.
@@ -105,7 +105,7 @@ 
     	$_REQUEST['searchFormTab'] = 'advanced_search';
     	$view2->prepareSearchForm();
     	 
-    	$this->assertInstanceOf('SearchForm',$view2->searchForm);
+    	$this->assertInstanceOf('SearchForm', $view2->searchForm);
  
     }
 
@@ -119,7 +119,7 @@ 
     	$view->processSearchForm();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
+    	$this->assertGreaterThan(0, strlen($renderedContent));
   
     	
     	//test with use_old_search = true. there is a $view variable which is never set so it doesn't returns anything.
@@ -131,7 +131,7 @@ 
     	$view->processSearchForm();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertEquals(0,strlen($renderedContent));
+    	$this->assertEquals(0, strlen($renderedContent));
 
     }
     
@@ -141,7 +141,7 @@ 
 		//execute the method and test if it sets the lv attribute to ListViewSmarty object.
     	$view = new ViewList();
     	$view->preDisplay();
-    	$this->assertInstanceOf('ListViewSmarty',$view->lv);
+    	$this->assertInstanceOf('ListViewSmarty', $view->lv);
     	
     }
     
@@ -154,7 +154,7 @@ 
     	$view->display();
     	$renderedContent1 = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent1));
+    	$this->assertGreaterThan(0, strlen($renderedContent1));
     	
 
     	//test with bean, seed and other arrtibutes set. it shuold return html. 
@@ -169,7 +169,7 @@ 
     	$view->display();
     	$renderedContent2 = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent2));
+    	$this->assertGreaterThan(0, strlen($renderedContent2));