adamjakab / SuiteCRM

tests/tests/include/MVC/SugarApplicationTest.php

Spacing +25 added lines, -25 removed lines

@@ -5,7 +5,7 @@ 
 {
 
 
-	public function testexecute(){
+	public function testexecute() {
 		
 		$SugarApplication = new SugarApplication();
 
@@ -13,14 +13,14 @@ 
 		try {
 			$SugarApplication->execute();
 			
-		} catch (Exception $e) {
-			$this->assertStringStartsWith('Cannot modify header information',$e->getMessage());
+		}catch (Exception $e) {
+			$this->assertStringStartsWith('Cannot modify header information', $e->getMessage());
 		}
 			
 	}
 
 
-	public function testloadUser(){
+	public function testloadUser() {
 		
 		//cannot test this method as it uses die which stops execution of php unit as well
 		/*  
@@ -42,7 +42,7 @@ 
 		
 	}
 
-	public function testACLFilter(){
+	public function testACLFilter() {
 
 		$SugarApplication = new SugarApplication();
 				
@@ -100,7 +100,7 @@ 
 		
 	}
 
-	public function testpreProcess(){
+	public function testpreProcess() {
 
 		$SugarApplication = new SugarApplication();
 		$SugarApplication->controller = new SugarController();
@@ -118,7 +118,7 @@ 
 	}
 
 	
-	public function testhandleOfflineClient(){
+	public function testhandleOfflineClient() {
 		$SugarApplication = new SugarApplication();
 		
 		//execute the method and test if it works and does not throws an exception.
@@ -133,7 +133,7 @@ 
 	}
 
 
-	public function testhandleAccessControl(){
+	public function testhandleAccessControl() {
 		
 		$SugarApplication = new SugarApplication();
 		$SugarApplication->controller = new SugarController();
@@ -141,10 +141,10 @@ 
 		$result = $SugarApplication->handleAccessControl();
 		
 		//check that it returns Null
-		$this->assertEquals(NULL,$result);
+		$this->assertEquals(NULL, $result);
 		
 		//check that controller->hasAccess is true i-e default setting.
-		$this->assertEquals(True,$SugarApplication->controller->hasAccess);
+		$this->assertEquals(True, $SugarApplication->controller->hasAccess);
 
 	}
 
@@ -155,10 +155,10 @@ 
 			SugarApplication::preLoadLanguages();
 			
 			//check that method call got the current_language global variable set.
-			$this->assertTrue(isset($GLOBALS['current_language'] ));
+			$this->assertTrue(isset($GLOBALS['current_language']));
 			
 			//check that method call got the app_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0 );
+			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0);
 			
 		}
 		catch (Exception $e) {
@@ -167,7 +167,7 @@ 
 	
 	}
 
-	public function testloadLanguages(){
+	public function testloadLanguages() {
 	
 		$SugarApplication = new SugarApplication();
 		$SugarApplication->controller = new SugarController();
@@ -176,16 +176,16 @@ 
 			$SugarApplication->loadLanguages();
 				
 			//check that method call got the current_language global variable set.
-			$this->assertTrue(isset($GLOBALS['current_language'] ));
+			$this->assertTrue(isset($GLOBALS['current_language']));
 				
 			//check that method call got the app_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0 );
+			$this->assertTrue(is_array($GLOBALS['app_strings']) && count($GLOBALS['app_strings']) > 0);
 			
 			//check that method call got the app_list_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['app_list_strings']) && count($GLOBALS['app_list_strings']) > 0 );
+			$this->assertTrue(is_array($GLOBALS['app_list_strings']) && count($GLOBALS['app_list_strings']) > 0);
 
 			//check that method call got the mod_strings global variable set.
-			$this->assertTrue(is_array($GLOBALS['mod_strings']) && count($GLOBALS['mod_strings']) > 0 );
+			$this->assertTrue(is_array($GLOBALS['mod_strings']) && count($GLOBALS['mod_strings']) > 0);
 				
 		}
 		catch (Exception $e) {
@@ -208,7 +208,7 @@ 
 	}
 
 
-	public function testloadDisplaySettings(){
+	public function testloadDisplaySettings() {
 
     	$SugarApplication = new SugarApplication();
     	
@@ -224,7 +224,7 @@ 
     	
 	}
 
-	public function testloadLicense(){
+	public function testloadLicense() {
 
 		$SugarApplication = new SugarApplication();
 		
@@ -241,7 +241,7 @@ 
 		
 	}
 
-	public function testloadGlobals(){
+	public function testloadGlobals() {
 
 		$SugarApplication = new SugarApplication();
 		$SugarApplication->controller = new SugarController();
@@ -260,7 +260,7 @@ 
 	}
 
 
-	public function teststartSession(){
+	public function teststartSession() {
 	
 		$SugarApplication = new SugarApplication();
 		$SugarApplication->controller = new SugarController();
@@ -279,7 +279,7 @@ 
 	}
 	
 	
-	public function testendSession(){
+	public function testendSession() {
 
 		
 		$SugarApplication = new SugarApplication();
@@ -328,7 +328,7 @@ 
 		//there should be one more array element after method execution.
 		$user_error_message_count = count($_SESSION['user_error_message']);
 		SugarApplication::appendErrorMessage('some error');
-		$this->assertGreaterThan($user_error_message_count , count($_SESSION['user_error_message']));
+		$this->assertGreaterThan($user_error_message_count, count($_SESSION['user_error_message']));
 	}
 
     public function testgetErrorMessages()
@@ -343,8 +343,8 @@ 
 	public function testsetCookie( )
 	{
 		//execute the method and check that the method adds the key value pair to cookies array.
-		SugarApplication::setCookie('key','value');
-		$this->assertEquals('value' , $_COOKIE['key'] );
+		SugarApplication::setCookie('key', 'value');
+		$this->assertEquals('value', $_COOKIE['key']);
 			
 	}
 

tests/tests/include/MVC/View/SugarViewTest.php

Spacing +25 added lines, -25 removed lines

@@ -13,7 +13,7 @@ 
     	//execute the method and check if it works and doesn't throws an exception
     	try {
     		$SugarView->init();
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	 
@@ -41,9 +41,9 @@ 
     		$renderedContent = ob_get_contents();
     		ob_end_clean();
 
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+    		$this->assertGreaterThan(0, strlen($renderedContent));
     		  		
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
      		$this->fail();
     	}
     	    	
@@ -57,8 +57,8 @@ 
     	//execute the method and check if it works and doesn't throws an exception
     	try {
     		$errors = $SugarView->displayErrors();
-    		$this->assertSame(NULL,$errors);
-    	} catch (Exception $e) {
+    		$this->assertSame(NULL, $errors);
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -77,7 +77,7 @@ 
     	try {
     		$SugarView->preDisplay();
     	
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	 
@@ -96,7 +96,7 @@ 
     	try {
     		$SugarView->display();
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -121,9 +121,9 @@ 
     		$renderedContent = ob_get_contents();
     		ob_end_clean();
     		
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+    		$this->assertGreaterThan(0, strlen($renderedContent));
     	
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
       
@@ -137,7 +137,7 @@ 
     	try {
     		$SugarView->getModuleMenuHTML();
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -155,7 +155,7 @@ 
     	try {
     		$SugarView->includeClassicFile('config.php');
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -169,7 +169,7 @@ 
     {
 		//check if it returns any text i-e JS code    	
     	$js = SugarView::getJavascriptValidation();  	
-    	$this->assertGreaterThan(0,strlen($js));
+    	$this->assertGreaterThan(0, strlen($js));
     }
 
   
@@ -188,9 +188,9 @@ 
     		$renderedContent = ob_get_contents();
     		ob_end_clean();
     	
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+    		$this->assertGreaterThan(0, strlen($renderedContent));
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	  		
@@ -212,9 +212,9 @@ 
     		$renderedContent = ob_get_contents();
     		ob_end_clean();
     		 
-    		$this->assertGreaterThan(0,strlen($renderedContent));
+    		$this->assertGreaterThan(0, strlen($renderedContent));
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -257,15 +257,15 @@ 
     	
     	//first execute the method with default value
     	$moduleTitle = $SugarView->getModuleTitle();		 
-    	$this->assertGreaterThan(0,strlen($moduleTitle));
+    	$this->assertGreaterThan(0, strlen($moduleTitle));
   	
     	//second execute the method with true value
     	$moduleTitle = $SugarView->getModuleTitle(true);
-    	$this->assertGreaterThan(0,strlen($moduleTitle));    
+    	$this->assertGreaterThan(0, strlen($moduleTitle));    
 
     	//third execute the method with false value
     	$moduleTitle = $SugarView->getModuleTitle(false);
-    	$this->assertGreaterThan(0,strlen($moduleTitle));    	
+    	$this->assertGreaterThan(0, strlen($moduleTitle));    	
     	
     }
 
@@ -277,15 +277,15 @@ 
 
     	//first execute the method with missing attributes. it should return Null.
     	$metaDataFile = $SugarView->getMetaDataFile();
-    	$this->assertEquals(NULL,$metaDataFile);
+    	$this->assertEquals(NULL, $metaDataFile);
 
 
     	//second execute the method with valid attributes set. it should return a file path string.
-    	$SugarView->type ='detail' ;
+    	$SugarView->type = 'detail';
     	$SugarView->module = 'Users';
     	
     	$metaDataFile = $SugarView->getMetaDataFile();
-    	$this->assertGreaterThan(0,strlen($metaDataFile));
+    	$this->assertGreaterThan(0, strlen($metaDataFile));
     	
     }
 
@@ -298,7 +298,7 @@ 
     	
     	//execute the method. it should return a title string.
     	$browserTitle = $SugarView->getBrowserTitle();
-    	$this->assertGreaterThan(0,strlen($browserTitle));    	
+    	$this->assertGreaterThan(0, strlen($browserTitle));    	
     	
     }
 
@@ -310,12 +310,12 @@ 
     	 
     	//execute the method. it should return a string.
     	$breadCrumbSymbol = $SugarView->getBreadCrumbSymbol();
-    	$this->assertGreaterThan(0,strlen($breadCrumbSymbol));    	
+    	$this->assertGreaterThan(0, strlen($breadCrumbSymbol));    	
     		
     }
 
 
-    public function testcheckPostMaxSizeError(){
+    public function testcheckPostMaxSizeError() {
 
     	$SugarView = new SugarView();
     	

tests/tests/include/MVC/View/ViewFactoryTest.php

Spacing +23 added lines, -23 removed lines

@@ -2,77 +2,77 @@
 
 
 
-class ViewFactoryTest extends PHPUnit_Framework_TestCase{
+class ViewFactoryTest extends PHPUnit_Framework_TestCase {
 
-	public function testloadView(){
+	public function testloadView() {
 		error_reporting(E_ERROR | E_WARNING | E_PARSE);
 		
 		//check with invalid input. must return sugaview instance
-		$view = ViewFactory::loadView('default','');
-		$this->assertInstanceOf('SugarView',$view);
+		$view = ViewFactory::loadView('default', '');
+		$this->assertInstanceOf('SugarView', $view);
 		
 		//check with a valid module without a specific view, must return sugarview instance
-		$view = ViewFactory::loadView('default','Users');
-		$this->assertInstanceOf('SugarView',$view);
+		$view = ViewFactory::loadView('default', 'Users');
+		$this->assertInstanceOf('SugarView', $view);
 		
 		//check with a valid module and specific view, must reutern speciifc view instance
-		$view = ViewFactory::loadView('list','Users');
-		$this->assertInstanceOf('UsersViewList',$view);		
+		$view = ViewFactory::loadView('list', 'Users');
+		$this->assertInstanceOf('UsersViewList', $view);		
 		
 	}
 
-	public function test_loadConfig(){
+	public function test_loadConfig() {
 		//check with a invalid module, method must not change the view options.
-		$view = ViewFactory::loadView('default','');
+		$view = ViewFactory::loadView('default', '');
 		$options = $view->options;
 		ViewFactory::_loadConfig($view, 'default');
-		$this->assertSame($options,$view->options);
+		$this->assertSame($options, $view->options);
 		
 		
 		//check with a valid module which does not implement it's own view config. method must not change the view options.
-		 $view = ViewFactory::loadView('detail','Users');
+		 $view = ViewFactory::loadView('detail', 'Users');
 		 $options = $view->options;
 		 ViewFactory::_loadConfig($view, 'detail');
-		 $this->assertSame($options,$view->options);
+		 $this->assertSame($options, $view->options);
 		 
 		
 		//check with a valid module which implement it's own view config. method still must not change the view options because it needs.
-		$view = ViewFactory::loadView('area_detail_map','jjwg_Areas');
+		$view = ViewFactory::loadView('area_detail_map', 'jjwg_Areas');
 		$view->module = 'jjwg_Areas';
 		$options = $view->options;
 		ViewFactory::_loadConfig($view, 'area_detail_map');
-		$this->assertSame($options,$view->options);		
+		$this->assertSame($options, $view->options);		
 		
 		
 	}
 
-	public function test_buildFromFile(){
+	public function test_buildFromFile() {
 
 		//checck with valid values and test if it returns correct view instance
 		$type = 'list';
 		$target_module = 'Users';
 		$bean = Null;
-		$view = ViewFactory::_buildFromFile('modules/' . $target_module . '/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
-		$this->assertInstanceOf('UsersViewList',$view);
+		$view = ViewFactory::_buildFromFile('modules/'.$target_module.'/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
+		$this->assertInstanceOf('UsersViewList', $view);
 		
 		//checck with valid values and test if it returns correct view instance
 		$type = 'detail';
 		$target_module = 'Users';
 		$bean = Null;
-		$view = ViewFactory::_buildFromFile('modules/' . $target_module . '/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
-		$this->assertInstanceOf('UsersViewDetail',$view);
+		$view = ViewFactory::_buildFromFile('modules/'.$target_module.'/views/view.'.$type.'.php', $bean, array(), $type, $target_module);
+		$this->assertInstanceOf('UsersViewDetail', $view);
 		
 	}
 
-	public function test_buildClass(){
+	public function test_buildClass() {
 
 		//checck with valid values and test if it returns correct view instance
 		$view = ViewFactory::_buildClass('UsersViewList', Null, array());
-		$this->assertInstanceOf('UsersViewList',$view);		
+		$this->assertInstanceOf('UsersViewList', $view);		
 		
 		//checck with valid values and test if it returns correct view instance
 		$view = ViewFactory::_buildClass('UsersViewDetail', Null, array());
-		$this->assertInstanceOf('UsersViewDetail',$view);
+		$this->assertInstanceOf('UsersViewDetail', $view);
 				
 	}
 }

tests/tests/include/MVC/View/views/view.metadataTest.php

Spacing +35 added lines, -35 removed lines

@@ -3,56 +3,56 @@ 
 class ViewMetadataTest extends PHPUnit_Framework_TestCase
 {
 
- 	public function testdisplayCheckBoxes(){
+ 	public function testdisplayCheckBoxes() {
 
  		$view = new ViewMetadata();
  		
  		//check with empty values array. it should return html sting
  		ob_start();
  		$values = Array();
- 		$view->displayCheckBoxes('test',$values);		
+ 		$view->displayCheckBoxes('test', $values);		
  		$renderedContent1 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent1));
+ 		$this->assertGreaterThan(0, strlen($renderedContent1));
  		
  		
  		//check with prefilled values array. it should return html sting longer than earlier
  		ob_start();
- 		$values = Array('option1','option2');
- 		$view->displayCheckBoxes('test',$values);
+ 		$values = Array('option1', 'option2');
+ 		$view->displayCheckBoxes('test', $values);
  		$renderedContent2 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
+ 		$this->assertGreaterThan(strlen($renderedContent1), strlen($renderedContent2));
  			
  	}
  	
- 	public function testdisplaySelect(){
+ 	public function testdisplaySelect() {
 
  		$view = new ViewMetadata();
  			
  		//check with empty values array. it should return html sting
  		ob_start();
  		$values = Array();
- 		$view->displaySelect('test',$values);
+ 		$view->displaySelect('test', $values);
  		$renderedContent1 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent1));
+ 		$this->assertGreaterThan(0, strlen($renderedContent1));
  			
  			
  		//check with prefilled values array. it should return html sting longer than earlier
  		ob_start();
- 		$values = Array('option1','option2');
- 		$view->displaySelect('test',$values);
+ 		$values = Array('option1', 'option2');
+ 		$view->displaySelect('test', $values);
  		$renderedContent2 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
+ 		$this->assertGreaterThan(strlen($renderedContent1), strlen($renderedContent2));
  			
  		
  	}
  	
  	
  	
- 	public function testdisplayTextBoxes(){
+ 	public function testdisplayTextBoxes() {
 
  		$view = new ViewMetadata();
  		
@@ -62,35 +62,35 @@ 
  		$view->displayTextBoxes($values);
  		$renderedContent1 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent1));
+ 		$this->assertGreaterThan(0, strlen($renderedContent1));
  		
  		
  		//check with prefilled values array. it should return html sting longer than earlier
  		ob_start();
- 		$values = Array('option1','option2');
+ 		$values = Array('option1', 'option2');
  		$view->displayTextBoxes($values);
  		$renderedContent2 = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(strlen($renderedContent1),strlen($renderedContent2));
+ 		$this->assertGreaterThan(strlen($renderedContent1), strlen($renderedContent2));
  			
  		
  	}
  	
  	 	
- 	public function testprintValue(){
+ 	public function testprintValue() {
 
  		$view = new ViewMetadata();
  		
  		ob_start();
- 		$values = Array('option1','option2');
+ 		$values = Array('option1', 'option2');
  		$view->printValue($values);
  		$renderedContent = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent));
+ 		$this->assertGreaterThan(0, strlen($renderedContent));
  		
  	}
  	
- 	public function testdisplay(){
+ 	public function testdisplay() {
  		error_reporting(E_ERROR | E_PARSE);
  		
  		$view = new ViewMetadata();
@@ -100,21 +100,21 @@ 
  		$view->display();
  		$renderedContent = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent));
+ 		$this->assertGreaterThan(0, strlen($renderedContent));
  			
  		
  		//test with REQUEST parameters set
- 		$_REQUEST['modules'] = Array('Calls','Meetings');
+ 		$_REQUEST['modules'] = Array('Calls', 'Meetings');
  		ob_start();
  		$view->display();
  		$renderedContent = ob_get_contents();
  		ob_end_clean();
- 		$this->assertGreaterThan(0,strlen($renderedContent));
+ 		$this->assertGreaterThan(0, strlen($renderedContent));
  			
 	}
 
 	
-	public function testgetModules(){
+	public function testgetModules() {
 		
 		//execute the method and test if it returns a array.
 		$modules = VardefBrowser::getModules();
@@ -122,7 +122,7 @@ 
 	
 	}
 	
-	public function testfindFieldsWithAttributes(){
+	public function testfindFieldsWithAttributes() {
 		
 		//check with emptty attributes array
 		$attributes = Array();
@@ -140,13 +140,13 @@ 
 		$this->assertTrue(is_array($fields3));
 				
 		//check that all three arrays returned, are not same.
-		$this->assertNotSame($fields1,$fields2);
-		$this->assertNotSame($fields1,$fields3);
-		$this->assertNotSame($fields2,$fields3);
+		$this->assertNotSame($fields1, $fields2);
+		$this->assertNotSame($fields1, $fields3);
+		$this->assertNotSame($fields2, $fields3);
 		
 	}
 	
-	public function testfindVardefs(){
+	public function testfindVardefs() {
 	
 		//check with empty modules array
 		$modules = Array();
@@ -160,12 +160,12 @@ 
 		$this->assertTrue(is_array($defs2));
 		
 		//check that two arrays returned, are not same.
-		$this->assertNotSame($defs1,$defs2);
+		$this->assertNotSame($defs1, $defs2);
 		
 	}
 	
 	
-	public function testfindFieldAttributes(){
+	public function testfindFieldAttributes() {
 	
 		//check with emptty attributes array
 		$attributes = Array();
@@ -176,7 +176,7 @@ 
 		//check with emptty attributes array and prefilled modules array.
 		$attributes = Array();
 		$modules = Array('Users');
-		$fields2 = VardefBrowser::findFieldAttributes($attributes,$modules,true,true);
+		$fields2 = VardefBrowser::findFieldAttributes($attributes, $modules, true, true);
 		$this->assertTrue(is_array($fields2));
 	
 		
@@ -187,9 +187,9 @@ 
 		
 		
 		//check that all three arrays returned, are not same.
-		$this->assertNotSame($fields1,$fields2);
-		$this->assertNotSame($fields1,$fields3);
-		$this->assertNotSame($fields2,$fields3);
+		$this->assertNotSame($fields1, $fields2);
+		$this->assertNotSame($fields1, $fields3);
+		$this->assertNotSame($fields2, $fields3);
 		
 	}	
 	

tests/tests/include/MVC/View/views/view.ajaxuiTest.php

Spacing +5 added lines, -5 removed lines

@@ -7,9 +7,9 @@ 
  	{
  		//execute the contructor and check for the Object type and type attribute
  		$view = new ViewAjaxUI();
- 		$this->assertInstanceOf('ViewAjaxUI',$view);
- 		$this->assertInstanceOf('SugarView',$view);
- 		$this->assertTrue( is_array($view->options));
+ 		$this->assertInstanceOf('ViewAjaxUI', $view);
+ 		$this->assertInstanceOf('SugarView', $view);
+ 		$this->assertTrue(is_array($view->options));
  		
  	}
 
@@ -22,8 +22,8 @@ 
  		try {
  			$view->display();
  				
- 		} catch (Exception $e) {
- 			$this->assertStringStartsWith('Cannot modify header information',$e->getMessage());
+ 		}catch (Exception $e) {
+ 			$this->assertStringStartsWith('Cannot modify header information', $e->getMessage());
  		}
  		
  	}

tests/tests/include/MVC/View/views/view.listTest.php

Spacing +18 added lines, -18 removed lines

@@ -7,9 +7,9 @@ 
     {
     	//execute the contructor and check for the Object type and type attribute
     	$view = new ViewList();
-    	$this->assertInstanceOf('ViewList',$view);
-    	$this->assertInstanceOf('SugarView',$view);
-    	$this->assertAttributeEquals('list','type', $view);
+    	$this->assertInstanceOf('ViewList', $view);
+    	$this->assertInstanceOf('SugarView', $view);
+    	$this->assertAttributeEquals('list', 'type', $view);
     }
 
 
@@ -21,7 +21,7 @@ 
     	try {
     		$view->oldSearch();
  
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	 
@@ -35,7 +35,7 @@ 
     	try {
     		$view->newSearch();
     		 
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -53,14 +53,14 @@ 
     	$view->listViewPrepare();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
+    	$this->assertGreaterThan(0, strlen($renderedContent));
     	
     	
     	//test with some REQUEST parameters preset. it should return some html and set the REQUEST key we provided in current_query_by_page REQUEST Param.
     	$view = new ViewList();
     	$view->module = "Users";
-    	$GLOBALS['module']= "Users";
-    	$_REQUEST["Users2_USER_offset"]= 1;
+    	$GLOBALS['module'] = "Users";
+    	$_REQUEST["Users2_USER_offset"] = 1;
     	$_REQUEST['current_query_by_page'] = base64_encode(serialize(Array("key"=>"value")));
     	$view->bean = New User();
     	
@@ -68,8 +68,8 @@ 
     	$view->listViewPrepare();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
-    	$this->assertEquals('value',$_REQUEST['key']);
+    	$this->assertGreaterThan(0, strlen($renderedContent));
+    	$this->assertEquals('value', $_REQUEST['key']);
     	
     }
 
@@ -85,7 +85,7 @@ 
     	$view->listViewProcess();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
+    	$this->assertGreaterThan(0, strlen($renderedContent));
     	    	
     }
     
@@ -95,7 +95,7 @@ 
     	$view1 = new ViewList();
     	$view1->module = "Users";
     	$view1->prepareSearchForm();    	
-    	$this->assertInstanceOf('SearchForm',$view1->searchForm);
+    	$this->assertInstanceOf('SearchForm', $view1->searchForm);
     	
     	
     	//test with REQUEST parameters set. it will set searchform attribute to a searchform object.
@@ -105,7 +105,7 @@ 
     	$_REQUEST['searchFormTab'] = 'advanced_search';
     	$view2->prepareSearchForm();
     	 
-    	$this->assertInstanceOf('SearchForm',$view2->searchForm);
+    	$this->assertInstanceOf('SearchForm', $view2->searchForm);
  
     }
 
@@ -119,7 +119,7 @@ 
     	$view->processSearchForm();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
+    	$this->assertGreaterThan(0, strlen($renderedContent));
   
     	
     	//test with use_old_search = true. there is a $view variable which is never set so it doesn't returns anything.
@@ -131,7 +131,7 @@ 
     	$view->processSearchForm();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertEquals(0,strlen($renderedContent));
+    	$this->assertEquals(0, strlen($renderedContent));
 
     }
     
@@ -141,7 +141,7 @@ 
 		//execute the method and test if it sets the lv attribute to ListViewSmarty object.
     	$view = new ViewList();
     	$view->preDisplay();
-    	$this->assertInstanceOf('ListViewSmarty',$view->lv);
+    	$this->assertInstanceOf('ListViewSmarty', $view->lv);
     	
     }
     
@@ -154,7 +154,7 @@ 
     	$view->display();
     	$renderedContent1 = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent1));
+    	$this->assertGreaterThan(0, strlen($renderedContent1));
     	
 
     	//test with bean, seed and other arrtibutes set. it shuold return html. 
@@ -169,7 +169,7 @@ 
     	$view->display();
     	$renderedContent2 = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent2));
+    	$this->assertGreaterThan(0, strlen($renderedContent2));
     	
     	
     

tests/tests/include/MVC/View/views/view.detailTest.php

Spacing +6 added lines, -6 removed lines

@@ -7,9 +7,9 @@ 
     {
     	//execute the contructor and check for the Object type and type attribute
     	$view = new ViewDetail();
-    	$this->assertInstanceOf('ViewDetail',$view);
-    	$this->assertInstanceOf('SugarView',$view);
-    	$this->assertAttributeEquals('detail','type', $view);
+    	$this->assertInstanceOf('ViewDetail', $view);
+    	$this->assertInstanceOf('SugarView', $view);
+    	$this->assertAttributeEquals('detail', 'type', $view);
     		
     }
 	
@@ -22,7 +22,7 @@ 
     	$view->bean = new User();
     	$view->ss = new Sugar_Smarty();    	
     	$view->preDisplay();    	
-    	$this->assertInstanceOf('DetailView2',$view->dv);
+    	$this->assertInstanceOf('DetailView2', $view->dv);
     	$this->asserttrue(is_array($view->dv->defs));
     	
     	
@@ -32,7 +32,7 @@ 
     	$view->bean = new Meeting();
     	$view->ss = new Sugar_Smarty();    	
     	$view->preDisplay();
-    	$this->assertInstanceOf('DetailView2',$view->dv);
+    	$this->assertInstanceOf('DetailView2', $view->dv);
     	$this->asserttrue(is_array($view->dv->defs));
     	
     } 	
@@ -54,7 +54,7 @@ 
     	$view->display();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
+    	$this->assertGreaterThan(0, strlen($renderedContent));
     	
     }
 }

tests/tests/include/MVC/View/views/view.noaccessTest.php

Spacing +3 added lines, -3 removed lines

@@ -15,10 +15,10 @@
 		$renderedContent = ob_get_contents();
 		ob_end_clean();
 		
-		$this->assertAttributeEquals('noaccess','type', $view);
-		$this->assertGreaterThan(0,strlen($renderedContent));
+		$this->assertAttributeEquals('noaccess', 'type', $view);
+		$this->assertGreaterThan(0, strlen($renderedContent));
 		
-		$this->assertEquals(False,json_decode($renderedContent)); //check that it doesn't return json.
+		$this->assertEquals(False, json_decode($renderedContent)); //check that it doesn't return json.
 
  	}
 }

tests/tests/include/MVC/View/views/view.modulelistmenuTest.php

Spacing +4 added lines, -4 removed lines

@@ -8,8 +8,8 @@ 
  		//execute the contructor and check for the Object type and options attribute
  		$view = new ViewModulelistmenu();
  			
- 		$this->assertInstanceOf('ViewModulelistmenu',$view);
- 		$this->assertInstanceOf('SugarView',$view);
+ 		$this->assertInstanceOf('ViewModulelistmenu', $view);
+ 		$this->assertInstanceOf('SugarView', $view);
  		$this->assertTrue(is_array($view->options)); 		
  		
  	}	
@@ -25,8 +25,8 @@ 
  		$renderedContent = ob_get_contents();
  		ob_end_clean();
 
- 		$this->assertGreaterThan(0,strlen($renderedContent));
- 		$this->assertEquals(false,is_array($renderedContent));
+ 		$this->assertGreaterThan(0, strlen($renderedContent));
+ 		$this->assertEquals(false, is_array($renderedContent));
  	}
 }
 ?>