Inspection of "added test suite from JimMackin(https://github.com..." - adamjakab/SuiteCRM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — CI ( ee6bd7...0f01dd )

by Adam

created 2016-03-07 16:43 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
                                                           'date_modified'    => array('default' => ''),
                                                           'assigned_user_id' => array('type'    => 'assigned_user_name', 
                                                                                       'default' => $current_user->name));
-$dashletData['mkt_dyntestDashlet']['columns'] =  array(   'name' => array('width'   => '40', 
+$dashletData['mkt_dyntestDashlet']['columns'] = array('name' => array('width'   => '40', 
                                                                       'label'   => 'LBL_LIST_NAME',
                                                                       'link'    => true,
                                                                       'default' => true), 

Please login to merge, or discard this patch.

modules/mkt_dyntest/metadata/editviewdefs.php 1 patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -1,30 +1,30 @@  discard block
 block discarded – undo
 <?php
 $module_name = 'mkt_dyntest';
 $viewdefs [$module_name] = 
-array (
+array(
   'EditView' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
       'maxColumns' => '2',
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
       ),
       'useTabs' => false,
       'tabDefs' => 
-      array (
+      array(
         'DEFAULT' => 
-        array (
+        array(
           'newTab' => false,
           'panelDefault' => 'expanded',
         ),
@@ -32,30 +32,30 @@  discard block
 block discarded – undo
       'syncDetailEditViews' => true,
     ),
     'panels' => 
-    array (
+    array(
       'default' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 'name',
         ),
         1 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'level1',
             'studio' => 'visible',
             'label' => 'LBL_LEVEL1',
           ),
           1 => 
-          array (
+          array(
             'name' => 'level2',
             'studio' => 'visible',
             'label' => 'LBL_LEVEL2',
           ),
         ),
         2 => 
-        array (
+        array(
           0 => 'description',
         ),
       ),

Please login to merge, or discard this patch.

modules/mkt_dyntest/metadata/metafiles.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -32,11 +32,11 @@
 block discarded – undo
  */
 $module_name = 'AOS_Products';
  $metafiles[$module_name] = array(
-	'detailviewdefs'  => 	'modules/' . $module_name . '/metadata/detailviewdefs.php', 	
-	'editviewdefs'    => 	'modules/' . $module_name . '/metadata/editviewdefs.php',
- 	'listviewdefs'    => 	'modules/' . $module_name . '/metadata/listviewdefs.php',
- 	'searchdefs'      =>    'modules/' . $module_name . '/metadata/searchdefs.php',
- 	'popupdefs'	      =>    'modules/' . $module_name . '/metadata/popupdefs.php',
- 	'searchfields'	  =>    'modules/' . $module_name . '/metadata/SearchFields.php',
+	'detailviewdefs'  => 	'modules/'.$module_name.'/metadata/detailviewdefs.php', 	
+	'editviewdefs'    => 	'modules/'.$module_name.'/metadata/editviewdefs.php',
+ 	'listviewdefs'    => 	'modules/'.$module_name.'/metadata/listviewdefs.php',
+ 	'searchdefs'      =>    'modules/'.$module_name.'/metadata/searchdefs.php',
+ 	'popupdefs'	      =>    'modules/'.$module_name.'/metadata/popupdefs.php',
+ 	'searchfields'	  =>    'modules/'.$module_name.'/metadata/SearchFields.php',
  );
 ?>

Please login to merge, or discard this patch.

modules/mkt_dyntest/metadata/detailviewdefs.php 1 patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@  discard block
 block discarded – undo
 <?php
 $module_name = 'mkt_dyntest';
 $viewdefs [$module_name] = 
-array (
+array(
   'DetailView' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
       'form' => 
-      array (
+      array(
         'buttons' => 
-        array (
+        array(
           0 => 'EDIT',
           1 => 'DUPLICATE',
           2 => 'DELETE',
@@ -18,23 +18,23 @@  discard block
 block discarded – undo
       ),
       'maxColumns' => '2',
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
       ),
       'useTabs' => false,
       'tabDefs' => 
-      array (
+      array(
         'DEFAULT' => 
-        array (
+        array(
           'newTab' => false,
           'panelDefault' => 'expanded',
         ),
@@ -42,30 +42,30 @@  discard block
 block discarded – undo
       'syncDetailEditViews' => true,
     ),
     'panels' => 
-    array (
+    array(
       'default' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 'name',
         ),
         1 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'level1',
             'studio' => 'visible',
             'label' => 'LBL_LEVEL1',
           ),
           1 => 
-          array (
+          array(
             'name' => 'level2',
             'studio' => 'visible',
             'label' => 'LBL_LEVEL2',
           ),
         ),
         2 => 
-        array (
+        array(
           0 => 'description',
         ),
       ),

Please login to merge, or discard this patch.

modules/mkt_dyntest/metadata/subpanels/default.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
  ********************************************************************************/
 
 
-$module_name='mkt_dyntest';
+$module_name = 'mkt_dyntest';
 $subpanel_layout = array(
 	'top_buttons' => array(
 		array('widget_class' => 'SubPanelTopCreateButton'),

Please login to merge, or discard this patch.

modules/mkt_dyntest/metadata/popupdefs.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -45,9 +45,9 @@  discard block
 block discarded – undo
 						'varName' => $object_name,
 						'orderBy' => $_module_name.'.name',
 						'whereClauses' => 
-							array('name' => $_module_name . '.name', 
+							array('name' => $_module_name.'.name', 
 								),
-						    'searchInputs'=> array($_module_name. '_number', 'name', 'priority','status'),
+						    'searchInputs'=> array($_module_name.'_number', 'name', 'priority', 'status'),
 							
 						);
 ?>

Please login to merge, or discard this patch.

modules/mkt_dyntest/mkt_dyntest_sugar.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -50,7 +50,7 @@  discard block
 block discarded – undo
 	var $object_name = 'mkt_dyntest';
 	var $table_name = 'mkt_dyntest';
 	var $importable = false;
-	var $disable_row_level_security = true ; // to ensure that modules created and deployed under CE will continue to function under team security if the instance is upgraded to PRO
+	var $disable_row_level_security = true; // to ensure that modules created and deployed under CE will continue to function under team security if the instance is upgraded to PRO
 
 	var $id;
 	var $name;
@@ -70,12 +70,12 @@  discard block
 block discarded – undo
 	var $level1;
 	var $level2;
 	
-	function __construct(){
+	function __construct() {
 		parent::__construct();
 	}
 	
-	function bean_implements($interface){
-		switch($interface){
+	function bean_implements($interface) {
+		switch ($interface) {
 			case 'ACL': return true;
 		}
 		return false;

Please login to merge, or discard this patch.

modules/mkt_dyntest/vardefs.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -42,9 +42,9 @@  discard block
 block discarded – undo
 	'audited'=>true,
     'inline_edit'=>true,
 		'duplicate_merge'=>true,
-		'fields'=>array (
+		'fields'=>array(
   'level1' => 
-  array (
+  array(
     'required' => false,
     'name' => 'level1',
     'vname' => 'LBL_LEVEL1',
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
     'dependency' => false,
   ),
   'level2' => 
-  array (
+  array(
     'required' => false,
     'name' => 'level2',
     'vname' => 'LBL_LEVEL2',
@@ -93,12 +93,12 @@  discard block
 block discarded – undo
     'parentenum' => 'level1',
   ),
 ),
-	'relationships'=>array (
+	'relationships'=>array(
 ),
 	'optimistic_locking'=>true,
 		'unified_search'=>true,
 	);
-if (!class_exists('VardefManager')){
+if (!class_exists('VardefManager')) {
         require_once('include/SugarObjects/VardefManager.php');
 }
-VardefManager::createVardef('mkt_dyntest','mkt_dyntest', array('basic','assignable'));
\ No newline at end of file
+VardefManager::createVardef('mkt_dyntest', 'mkt_dyntest', array('basic', 'assignable'));
\ No newline at end of file

Please login to merge, or discard this patch.

tests/bootstrap.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@
 block discarded – undo
 
 chdir('..');
 
-define('sugarEntry',TRUE);
+define('sugarEntry', TRUE);
 
 global $sugar_config, $db;
 require_once 'include/utils.php';

Please login to merge, or discard this patch.

		@@ -50,7 +50,7 @@ discard block
		block discarded – undo
50	50	var $object_name = 'mkt_dyntest';
51	51	var $table_name = 'mkt_dyntest';
52	52	var $importable = false;
53		- var $disable_row_level_security = true ; // to ensure that modules created and deployed under CE will continue to function under team security if the instance is upgraded to PRO
	53	+ var $disable_row_level_security = true; // to ensure that modules created and deployed under CE will continue to function under team security if the instance is upgraded to PRO
54	54
55	55	var $id;
56	56	var $name;
		@@ -70,12 +70,12 @@ discard block
		block discarded – undo
70	70	var $level1;
71	71	var $level2;
72	72
73		- function __construct(){
	73	+ function __construct() {
74	74	parent::__construct();
75	75	}
76	76
77		- function bean_implements($interface){
78		- switch($interface){
	77	+ function bean_implements($interface) {
	78	+ switch ($interface) {
79	79	case 'ACL': return true;
80	80	}
81	81	return false;

		@@ -1,5 +1,5 @@ discard block
		block discarded – undo
1	1	<?php
2		-if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
	2	+if (!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
3	3	/*********************************************************************************
4	4	* SugarCRM Community Edition is a customer relationship management program developed by
5	5	* SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
		@@ -47,7 +47,7 @@ discard block
		block discarded – undo
47	47	'date_modified' => array('default' => ''),
48	48	'assigned_user_id' => array('type' => 'assigned_user_name',
49	49	'default' => $current_user->name));
50		-$dashletData['mkt_dyntestDashlet']['columns'] = array( 'name' => array('width' => '40',
	50	+$dashletData['mkt_dyntestDashlet']['columns'] = array('name' => array('width' => '40',
51	51	'label' => 'LBL_LIST_NAME',
52	52	'link' => true,
53	53	'default' => true),

		@@ -1,30 +1,30 @@ discard block
		block discarded – undo
1	1	<?php
2	2	$module_name = 'mkt_dyntest';
3	3	$viewdefs [$module_name] =
4		-array (
	4	+array(
5	5	'EditView' =>
6		- array (
	6	+ array(
7	7	'templateMeta' =>
8		- array (
	8	+ array(
9	9	'maxColumns' => '2',
10	10	'widths' =>
11		- array (
	11	+ array(
12	12	0 =>
13		- array (
	13	+ array(
14	14	'label' => '10',
15	15	'field' => '30',
16	16	),
17	17	1 =>
18		- array (
	18	+ array(
19	19	'label' => '10',
20	20	'field' => '30',
21	21	),
22	22	),
23	23	'useTabs' => false,
24	24	'tabDefs' =>
25		- array (
	25	+ array(
26	26	'DEFAULT' =>
27		- array (
	27	+ array(
28	28	'newTab' => false,
29	29	'panelDefault' => 'expanded',
30	30	),
		@@ -32,30 +32,30 @@ discard block
		block discarded – undo
32	32	'syncDetailEditViews' => true,
33	33	),
34	34	'panels' =>
35		- array (
	35	+ array(
36	36	'default' =>
37		- array (
	37	+ array(
38	38	0 =>
39		- array (
	39	+ array(
40	40	0 => 'name',
41	41	),
42	42	1 =>
43		- array (
	43	+ array(
44	44	0 =>
45		- array (
	45	+ array(
46	46	'name' => 'level1',
47	47	'studio' => 'visible',
48	48	'label' => 'LBL_LEVEL1',
49	49	),
50	50	1 =>
51		- array (
	51	+ array(
52	52	'name' => 'level2',
53	53	'studio' => 'visible',
54	54	'label' => 'LBL_LEVEL2',
55	55	),
56	56	),
57	57	2 =>
58		- array (
	58	+ array(
59	59	0 => 'description',
60	60	),
61	61	),

		@@ -32,11 +32,11 @@
		block discarded – undo
32	32	*/
33	33	$module_name = 'AOS_Products';
34	34	$metafiles[$module_name] = array(
35		- 'detailviewdefs' => 'modules/' . $module_name . '/metadata/detailviewdefs.php',
36		- 'editviewdefs' => 'modules/' . $module_name . '/metadata/editviewdefs.php',
37		- 'listviewdefs' => 'modules/' . $module_name . '/metadata/listviewdefs.php',
38		- 'searchdefs' => 'modules/' . $module_name . '/metadata/searchdefs.php',
39		- 'popupdefs' => 'modules/' . $module_name . '/metadata/popupdefs.php',
40		- 'searchfields' => 'modules/' . $module_name . '/metadata/SearchFields.php',
	35	+ 'detailviewdefs' => 'modules/'.$module_name.'/metadata/detailviewdefs.php',
	36	+ 'editviewdefs' => 'modules/'.$module_name.'/metadata/editviewdefs.php',
	37	+ 'listviewdefs' => 'modules/'.$module_name.'/metadata/listviewdefs.php',
	38	+ 'searchdefs' => 'modules/'.$module_name.'/metadata/searchdefs.php',
	39	+ 'popupdefs' => 'modules/'.$module_name.'/metadata/popupdefs.php',
	40	+ 'searchfields' => 'modules/'.$module_name.'/metadata/SearchFields.php',
41	41	);
42	42	?>

		@@ -1,15 +1,15 @@ discard block
		block discarded – undo
1	1	<?php
2	2	$module_name = 'mkt_dyntest';
3	3	$viewdefs [$module_name] =
4		-array (
	4	+array(
5	5	'DetailView' =>
6		- array (
	6	+ array(
7	7	'templateMeta' =>
8		- array (
	8	+ array(
9	9	'form' =>
10		- array (
	10	+ array(
11	11	'buttons' =>
12		- array (
	12	+ array(
13	13	0 => 'EDIT',
14	14	1 => 'DUPLICATE',
15	15	2 => 'DELETE',
		@@ -18,23 +18,23 @@ discard block
		block discarded – undo
18	18	),
19	19	'maxColumns' => '2',
20	20	'widths' =>
21		- array (
	21	+ array(
22	22	0 =>
23		- array (
	23	+ array(
24	24	'label' => '10',
25	25	'field' => '30',
26	26	),
27	27	1 =>
28		- array (
	28	+ array(
29	29	'label' => '10',
30	30	'field' => '30',
31	31	),
32	32	),
33	33	'useTabs' => false,
34	34	'tabDefs' =>
35		- array (
	35	+ array(
36	36	'DEFAULT' =>
37		- array (
	37	+ array(
38	38	'newTab' => false,
39	39	'panelDefault' => 'expanded',
40	40	),
		@@ -42,30 +42,30 @@ discard block
		block discarded – undo
42	42	'syncDetailEditViews' => true,
43	43	),
44	44	'panels' =>
45		- array (
	45	+ array(
46	46	'default' =>
47		- array (
	47	+ array(
48	48	0 =>
49		- array (
	49	+ array(
50	50	0 => 'name',
51	51	),
52	52	1 =>
53		- array (
	53	+ array(
54	54	0 =>
55		- array (
	55	+ array(
56	56	'name' => 'level1',
57	57	'studio' => 'visible',
58	58	'label' => 'LBL_LEVEL1',
59	59	),
60	60	1 =>
61		- array (
	61	+ array(
62	62	'name' => 'level2',
63	63	'studio' => 'visible',
64	64	'label' => 'LBL_LEVEL2',
65	65	),
66	66	),
67	67	2 =>
68		- array (
	68	+ array(
69	69	0 => 'description',
70	70	),
71	71	),

		@@ -42,9 +42,9 @@ discard block
		block discarded – undo
42	42	'audited'=>true,
43	43	'inline_edit'=>true,
44	44	'duplicate_merge'=>true,
45		- 'fields'=>array (
	45	+ 'fields'=>array(
46	46	'level1' =>
47		- array (
	47	+ array(
48	48	'required' => false,
49	49	'name' => 'level1',
50	50	'vname' => 'LBL_LEVEL1',
		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	'dependency' => false,
69	69	),
70	70	'level2' =>
71		- array (
	71	+ array(
72	72	'required' => false,
73	73	'name' => 'level2',
74	74	'vname' => 'LBL_LEVEL2',
		@@ -93,12 +93,12 @@ discard block
		block discarded – undo
93	93	'parentenum' => 'level1',
94	94	),
95	95	),
96		- 'relationships'=>array (
	96	+ 'relationships'=>array(
97	97	),
98	98	'optimistic_locking'=>true,
99	99	'unified_search'=>true,
100	100	);
101		-if (!class_exists('VardefManager')){
	101	+if (!class_exists('VardefManager')) {
102	102	require_once('include/SugarObjects/VardefManager.php');
103	103	}
104		-VardefManager::createVardef('mkt_dyntest','mkt_dyntest', array('basic','assignable'));
105	104	\ No newline at end of file
	105	+VardefManager::createVardef('mkt_dyntest', 'mkt_dyntest', array('basic', 'assignable'));
106	106	\ No newline at end of file

		@@ -25,7 +25,7 @@
		block discarded – undo
25	25
26	26	chdir('..');
27	27
28		-define('sugarEntry',TRUE);
	28	+define('sugarEntry', TRUE);
29	29
30	30	global $sugar_config, $db;
31	31	require_once 'include/utils.php';

adamjakab / SuiteCRM

Push — CI ( ee6bd7...0f01dd )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch