Inspection of "added test suite from JimMackin(https://github.com..." - adamjakab/SuiteCRM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — CI ( ee6bd7...0f01dd )

by Adam

created 2016-03-07 16:43 UTC

Status

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -107,8 +107,7 @@  discard block
 block discarded – undo
     	try {
     		$aod_index->commit();
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -171,8 +170,7 @@  discard block
 block discarded – undo
     	try {
     		$aod_index->remove("Accounts", 1);
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	  	

Please login to merge, or discard this patch.

tests/tests/modules/Prospects/ProspectTest.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -85,8 +85,7 @@
 block discarded – undo
     	try {
     		//$prospect->converted_prospect('1', '2', '3', '4');
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	

Please login to merge, or discard this patch.

tests/tests/modules/EAPM/EAPMTest.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -109,8 +109,7 @@  discard block
 block discarded – undo
 		try {
 			$eapm->fill_in_additional_detail_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 
@@ -124,8 +123,7 @@  discard block
 block discarded – undo
 		try {
 			$eapm->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 
@@ -153,8 +151,7 @@  discard block
 block discarded – undo
 		try {
 			$eapm->delete_user_accounts(1);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

Please login to merge, or discard this patch.

tests/tests/modules/Accounts/AccountTest.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -65,8 +65,7 @@  discard block
 block discarded – undo
 		try {
 			$Account->remove_redundant_http();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 
@@ -82,8 +81,7 @@  discard block
 block discarded – undo
 		try {
 			$Account->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}		
 
@@ -98,8 +96,7 @@  discard block
 block discarded – undo
 		try {
 			$Account->fill_in_additional_detail_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

Please login to merge, or discard this patch.

tests/tests/modules/Users/UserTest.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -221,8 +221,7 @@  discard block
 block discarded – undo
 		try {
 			$user->savePreferencesToDB();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1095,8 +1094,7 @@  discard block
 block discarded – undo
     	try {
     		$result = $user->afterImportSave();
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->assertStringStartsWith('Cannot modify header information', $e->getMessage());
     	}
     	

Please login to merge, or discard this patch.

tests/tests/modules/Bugs/BugTest.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -81,8 +81,7 @@
 block discarded – undo
 		try {
 			$bug->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 

Please login to merge, or discard this patch.

tests/tests/modules/ProspectLists/ProspectListTest.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -179,8 +179,7 @@  discard block
 block discarded – undo
 		try {
 			$prospectList->mark_relationships_deleted('');
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		 
@@ -196,8 +195,7 @@  discard block
 block discarded – undo
 		try {
 			$prospectList->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		 
@@ -224,8 +222,7 @@  discard block
 block discarded – undo
 		try {
 			$prospectList->update_currency_id('','');
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		 

Please login to merge, or discard this patch.

tests/tests/modules/Schedulers/SchedulerTest.php 1 patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

@@ -76,8 +76,7 @@  discard block
 block discarded – undo
 		try {
 			$scheduler->checkPendingJobs(new SugarJobQueue());
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}			
 		
@@ -193,8 +192,7 @@  discard block
 block discarded – undo
 		try {
 			$scheduler->checkCurl();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -226,8 +224,7 @@  discard block
 block discarded – undo
 		try {
 			$scheduler->rebuildDefaultSchedulers();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -262,8 +259,7 @@  discard block
 block discarded – undo
 		try {
 			$scheduler->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -277,8 +273,7 @@  discard block
 block discarded – undo
 		try {
 			$scheduler->fill_in_additional_detail_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 	

Please login to merge, or discard this patch.

tests/tests/modules/Campaigns/CampaignTest.php 1 patch

Braces +6 added lines, -11 removed lines patch added patch discarded remove patch

@@ -75,8 +75,7 @@  discard block
 block discarded – undo
 			$campaign->clear_campaign_prospect_list_relationship('');
 			$campaign->clear_campaign_prospect_list_relationship('1');
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -93,8 +92,7 @@  discard block
 block discarded – undo
 			$campaign->mark_relationships_deleted('');
 			$campaign->mark_relationships_deleted('1');
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -110,8 +108,7 @@  discard block
 block discarded – undo
 		try {
 			$campaign->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -127,8 +124,7 @@  discard block
 block discarded – undo
 		try {
 			$campaign->fill_in_additional_detail_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 				
@@ -144,8 +140,7 @@  discard block
 block discarded – undo
 		try {
 			$campaign->update_currency_id('','');
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 			
@@ -177,7 +172,7 @@  discard block
 block discarded – undo
         foreach($expected as $expectedKey => $expectedVal){
             if($expectedKey == 'LAUNCH_WIZARD_IMAGE' || $expectedKey == 'TRACK_CAMPAIGN_IMAGE'){
                 $this->assertRegExp($expected[$expectedKey],$actual[$expectedKey]);
-            }else {
+            } else {
                 $this->assertSame($expected[$expectedKey], $actual[$expectedKey]);
             }
         }

Please login to merge, or discard this patch.

		@@ -107,8 +107,7 @@ discard block
		block discarded – undo
107	107	try {
108	108	$aod_index->commit();
109	109	$this->assertTrue(true);
110		- }
111		- catch (Exception $e) {
	110	+ } catch (Exception $e) {
112	111	$this->fail();
113	112	}
114	113
		@@ -171,8 +170,7 @@ discard block
		block discarded – undo
171	170	try {
172	171	$aod_index->remove("Accounts", 1);
173	172	$this->assertTrue(true);
174		- }
175		- catch (Exception $e) {
	173	+ } catch (Exception $e) {
176	174	$this->fail();
177	175	}
178	176

		@@ -85,8 +85,7 @@
		block discarded – undo
85	85	try {
86	86	//$prospect->converted_prospect('1', '2', '3', '4');
87	87	$this->assertTrue(true);
88		- }
89		- catch (Exception $e) {
	88	+ } catch (Exception $e) {
90	89	$this->fail();
91	90	}
92	91

		@@ -109,8 +109,7 @@ discard block
		block discarded – undo
109	109	try {
110	110	$eapm->fill_in_additional_detail_fields();
111	111	$this->assertTrue(true);
112		- }
113		- catch (Exception $e) {
	112	+ } catch (Exception $e) {
114	113	$this->fail();
115	114	}
116	115
		@@ -124,8 +123,7 @@ discard block
		block discarded – undo
124	123	try {
125	124	$eapm->fill_in_additional_list_fields();
126	125	$this->assertTrue(true);
127		- }
128		- catch (Exception $e) {
	126	+ } catch (Exception $e) {
129	127	$this->fail();
130	128	}
131	129
		@@ -153,8 +151,7 @@ discard block
		block discarded – undo
153	151	try {
154	152	$eapm->delete_user_accounts(1);
155	153	$this->assertTrue(true);
156		- }
157		- catch (Exception $e) {
	154	+ } catch (Exception $e) {
158	155	$this->fail();
159	156	}
160	157

		@@ -65,8 +65,7 @@ discard block
		block discarded – undo
65	65	try {
66	66	$Account->remove_redundant_http();
67	67	$this->assertTrue(true);
68		- }
69		- catch (Exception $e) {
	68	+ } catch (Exception $e) {
70	69	$this->fail();
71	70	}
72	71
		@@ -82,8 +81,7 @@ discard block
		block discarded – undo
82	81	try {
83	82	$Account->fill_in_additional_list_fields();
84	83	$this->assertTrue(true);
85		- }
86		- catch (Exception $e) {
	84	+ } catch (Exception $e) {
87	85	$this->fail();
88	86	}
89	87
		@@ -98,8 +96,7 @@ discard block
		block discarded – undo
98	96	try {
99	97	$Account->fill_in_additional_detail_fields();
100	98	$this->assertTrue(true);
101		- }
102		- catch (Exception $e) {
	99	+ } catch (Exception $e) {
103	100	$this->fail();
104	101	}
105	102

		@@ -221,8 +221,7 @@ discard block
		block discarded – undo
221	221	try {
222	222	$user->savePreferencesToDB();
223	223	$this->assertTrue(true);
224		- }
225		- catch (Exception $e) {
	224	+ } catch (Exception $e) {
226	225	$this->fail();
227	226	}
228	227
		@@ -1095,8 +1094,7 @@ discard block
		block discarded – undo
1095	1094	try {
1096	1095	$result = $user->afterImportSave();
1097	1096	$this->assertTrue(true);
1098		- }
1099		- catch (Exception $e) {
	1097	+ } catch (Exception $e) {
1100	1098	$this->assertStringStartsWith('Cannot modify header information', $e->getMessage());
1101	1099	}
1102	1100

		@@ -81,8 +81,7 @@
		block discarded – undo
81	81	try {
82	82	$bug->fill_in_additional_list_fields();
83	83	$this->assertTrue(true);
84		- }
85		- catch (Exception $e) {
	84	+ } catch (Exception $e) {
86	85	$this->fail();
87	86	}
88	87

		@@ -179,8 +179,7 @@ discard block
		block discarded – undo
179	179	try {
180	180	$prospectList->mark_relationships_deleted('');
181	181	$this->assertTrue(true);
182		- }
183		- catch (Exception $e) {
	182	+ } catch (Exception $e) {
184	183	$this->fail();
185	184	}
186	185
		@@ -196,8 +195,7 @@ discard block
		block discarded – undo
196	195	try {
197	196	$prospectList->fill_in_additional_list_fields();
198	197	$this->assertTrue(true);
199		- }
200		- catch (Exception $e) {
	198	+ } catch (Exception $e) {
201	199	$this->fail();
202	200	}
203	201
		@@ -224,8 +222,7 @@ discard block
		block discarded – undo
224	222	try {
225	223	$prospectList->update_currency_id('','');
226	224	$this->assertTrue(true);
227		- }
228		- catch (Exception $e) {
	225	+ } catch (Exception $e) {
229	226	$this->fail();
230	227	}
231	228

		@@ -76,8 +76,7 @@ discard block
		block discarded – undo
76	76	try {
77	77	$scheduler->checkPendingJobs(new SugarJobQueue());
78	78	$this->assertTrue(true);
79		- }
80		- catch (Exception $e) {
	79	+ } catch (Exception $e) {
81	80	$this->fail();
82	81	}
83	82
		@@ -193,8 +192,7 @@ discard block
		block discarded – undo
193	192	try {
194	193	$scheduler->checkCurl();
195	194	$this->assertTrue(true);
196		- }
197		- catch (Exception $e) {
	195	+ } catch (Exception $e) {
198	196	$this->fail();
199	197	}
200	198
		@@ -226,8 +224,7 @@ discard block
		block discarded – undo
226	224	try {
227	225	$scheduler->rebuildDefaultSchedulers();
228	226	$this->assertTrue(true);
229		- }
230		- catch (Exception $e) {
	227	+ } catch (Exception $e) {
231	228	$this->fail();
232	229	}
233	230
		@@ -262,8 +259,7 @@ discard block
		block discarded – undo
262	259	try {
263	260	$scheduler->fill_in_additional_list_fields();
264	261	$this->assertTrue(true);
265		- }
266		- catch (Exception $e) {
	262	+ } catch (Exception $e) {
267	263	$this->fail();
268	264	}
269	265
		@@ -277,8 +273,7 @@ discard block
		block discarded – undo
277	273	try {
278	274	$scheduler->fill_in_additional_detail_fields();
279	275	$this->assertTrue(true);
280		- }
281		- catch (Exception $e) {
	276	+ } catch (Exception $e) {
282	277	$this->fail();
283	278	}
284	279

		@@ -75,8 +75,7 @@ discard block
		block discarded – undo
75	75	$campaign->clear_campaign_prospect_list_relationship('');
76	76	$campaign->clear_campaign_prospect_list_relationship('1');
77	77	$this->assertTrue(true);
78		- }
79		- catch (Exception $e) {
	78	+ } catch (Exception $e) {
80	79	$this->fail();
81	80	}
82	81
		@@ -93,8 +92,7 @@ discard block
		block discarded – undo
93	92	$campaign->mark_relationships_deleted('');
94	93	$campaign->mark_relationships_deleted('1');
95	94	$this->assertTrue(true);
96		- }
97		- catch (Exception $e) {
	95	+ } catch (Exception $e) {
98	96	$this->fail();
99	97	}
100	98
		@@ -110,8 +108,7 @@ discard block
		block discarded – undo
110	108	try {
111	109	$campaign->fill_in_additional_list_fields();
112	110	$this->assertTrue(true);
113		- }
114		- catch (Exception $e) {
	111	+ } catch (Exception $e) {
115	112	$this->fail();
116	113	}
117	114
		@@ -127,8 +124,7 @@ discard block
		block discarded – undo
127	124	try {
128	125	$campaign->fill_in_additional_detail_fields();
129	126	$this->assertTrue(true);
130		- }
131		- catch (Exception $e) {
	127	+ } catch (Exception $e) {
132	128	$this->fail();
133	129	}
134	130
		@@ -144,8 +140,7 @@ discard block
		block discarded – undo
144	140	try {
145	141	$campaign->update_currency_id('','');
146	142	$this->assertTrue(true);
147		- }
148		- catch (Exception $e) {
	143	+ } catch (Exception $e) {
149	144	$this->fail();
150	145	}
151	146
		@@ -177,7 +172,7 @@ discard block
		block discarded – undo
177	172	foreach($expected as $expectedKey => $expectedVal){
178	173	if($expectedKey == 'LAUNCH_WIZARD_IMAGE' \|\| $expectedKey == 'TRACK_CAMPAIGN_IMAGE'){
179	174	$this->assertRegExp($expected[$expectedKey],$actual[$expectedKey]);
180		- }else {
	175	+ } else {
181	176	$this->assertSame($expected[$expectedKey], $actual[$expectedKey]);
182	177	}
183	178	}

adamjakab / SuiteCRM

Push — CI ( ee6bd7...0f01dd )

Status

Category

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

Braces +6 added lines, -11 removed lines patch added patch discarded remove patch