Inspection of "added test suite from JimMackin(https://github.com..." - adamjakab/SuiteCRM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — CI ( ee6bd7...0f01dd )

by Adam

created 2016-03-07 16:43 UTC

Status

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -42,8 +42,7 @@
 block discarded – undo
     	try {
     		$tracker->makeInvisibleForAll(1);
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	

Please login to merge, or discard this patch.

tests/tests/modules/Meetings/MeetingTest.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -286,8 +286,7 @@  discard block
 block discarded – undo
 		try {
 			$meeting->send_assignment_notifications($notify_user, $admin);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -358,8 +357,7 @@  discard block
 block discarded – undo
 		try {
 			$meeting->save_relationship_changes();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -389,8 +387,7 @@  discard block
 block discarded – undo
 			
 			$this->assertTrue(true);
 			
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}		
 				

Please login to merge, or discard this patch.

tests/tests/modules/Project/ProjectTest.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -69,8 +69,7 @@
 block discarded – undo
     	try {
     		$project->save_relationship_changes(true);
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
         	

Please login to merge, or discard this patch.

tests/tests/modules/vCals/vCalTest.php 1 patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

@@ -45,8 +45,7 @@  discard block
 block discarded – undo
 		try {
 			$vcal->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 
@@ -62,8 +61,7 @@  discard block
 block discarded – undo
 		try {
 			$vcal->fill_in_additional_detail_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -78,8 +76,7 @@  discard block
 block discarded – undo
 		try {
 			$vcal->get_list_view_data();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -146,8 +143,7 @@  discard block
 block discarded – undo
 		try {
 			$vcal->cache_sugar_vcal($user_focus);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -163,8 +159,7 @@  discard block
 block discarded – undo
 		try {
 			$vcal->cache_sugar_vcal_freebusy($user_focus);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 				

Please login to merge, or discard this patch.

tests/tests/modules/SugarFeed/SugarFeedTest.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -47,8 +47,7 @@
 block discarded – undo
     	try {
     		SugarFeed::flushBackendCache();
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	

Please login to merge, or discard this patch.

tests/tests/modules/Opportunities/OpportunityTest.php 1 patch

Braces +6 added lines, -12 removed lines patch added patch discarded remove patch

@@ -91,8 +91,7 @@  discard block
 block discarded – undo
 			$opportunity->fill_in_additional_list_fields();
 			
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -107,8 +106,7 @@  discard block
 block discarded – undo
 				
 			$opportunity->fill_in_additional_detail_fields();				
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -133,8 +131,7 @@  discard block
 block discarded – undo
 		
 			$opportunity->update_currency_id(array('GBP','EUR'), 'USD');
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -222,8 +219,7 @@  discard block
 block discarded – undo
 		try {
 			$opportunity->save_relationship_changes(true);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -236,8 +232,7 @@  discard block
 block discarded – undo
 		try {
 			$opportunity->set_opportunity_contact_relationship("1");
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -301,8 +296,7 @@  discard block
 block discarded – undo
 		try {
 			getCurrencyType();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

Please login to merge, or discard this patch.

tests/tests/modules/SavedSearch/SavedSearchTest.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -113,8 +113,7 @@  discard block
 block discarded – undo
 		try {
 			$savedSearch->returnSavedSearch($id);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 	
@@ -129,8 +128,7 @@  discard block
 block discarded – undo
 		try {
 			$result = $savedSearch->returnSavedSearchContents($id);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

Please login to merge, or discard this patch.

tests/tests/modules/AOW_WorkFlow/AOW_WorkFlowTest.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -60,8 +60,7 @@  discard block
 block discarded – undo
     	try {
     		$aowWorkFlow->load_flow_beans();
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
 
@@ -86,8 +85,7 @@  discard block
 block discarded – undo
     	try {
     		$aowWorkFlow->run_flow();
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
 

Please login to merge, or discard this patch.

tests/tests/modules/Cases/CaseTest.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -52,8 +52,7 @@  discard block
 block discarded – undo
 			$aCase->save_relationship_changes(false);
 			
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -67,8 +66,7 @@  discard block
 block discarded – undo
 		try {
 			$aCase->set_case_contact_relationship(1);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -82,8 +80,7 @@  discard block
 block discarded – undo
 		try {
 			$aCase->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 

Please login to merge, or discard this patch.

		@@ -286,8 +286,7 @@ discard block
		block discarded – undo
286	286	try {
287	287	$meeting->send_assignment_notifications($notify_user, $admin);
288	288	$this->assertTrue(true);
289		- }
290		- catch (Exception $e) {
	289	+ } catch (Exception $e) {
291	290	$this->fail();
292	291	}
293	292
		@@ -358,8 +357,7 @@ discard block
		block discarded – undo
358	357	try {
359	358	$meeting->save_relationship_changes();
360	359	$this->assertTrue(true);
361		- }
362		- catch (Exception $e) {
	360	+ } catch (Exception $e) {
363	361	$this->fail();
364	362	}
365	363
		@@ -389,8 +387,7 @@ discard block
		block discarded – undo
389	387
390	388	$this->assertTrue(true);
391	389
392		- }
393		- catch (Exception $e) {
	390	+ } catch (Exception $e) {
394	391	$this->fail();
395	392	}
396	393

		@@ -42,8 +42,7 @@
		block discarded – undo
42	42	try {
43	43	$tracker->makeInvisibleForAll(1);
44	44	$this->assertTrue(true);
45		- }
46		- catch (Exception $e) {
	45	+ } catch (Exception $e) {
47	46	$this->fail();
48	47	}
49	48

		@@ -69,8 +69,7 @@
		block discarded – undo
69	69	try {
70	70	$project->save_relationship_changes(true);
71	71	$this->assertTrue(true);
72		- }
73		- catch (Exception $e) {
	72	+ } catch (Exception $e) {
74	73	$this->fail();
75	74	}
76	75

		@@ -45,8 +45,7 @@ discard block
		block discarded – undo
45	45	try {
46	46	$vcal->fill_in_additional_list_fields();
47	47	$this->assertTrue(true);
48		- }
49		- catch (Exception $e) {
	48	+ } catch (Exception $e) {
50	49	$this->fail();
51	50	}
52	51
		@@ -62,8 +61,7 @@ discard block
		block discarded – undo
62	61	try {
63	62	$vcal->fill_in_additional_detail_fields();
64	63	$this->assertTrue(true);
65		- }
66		- catch (Exception $e) {
	64	+ } catch (Exception $e) {
67	65	$this->fail();
68	66	}
69	67
		@@ -78,8 +76,7 @@ discard block
		block discarded – undo
78	76	try {
79	77	$vcal->get_list_view_data();
80	78	$this->assertTrue(true);
81		- }
82		- catch (Exception $e) {
	79	+ } catch (Exception $e) {
83	80	$this->fail();
84	81	}
85	82
		@@ -146,8 +143,7 @@ discard block
		block discarded – undo
146	143	try {
147	144	$vcal->cache_sugar_vcal($user_focus);
148	145	$this->assertTrue(true);
149		- }
150		- catch (Exception $e) {
	146	+ } catch (Exception $e) {
151	147	$this->fail();
152	148	}
153	149
		@@ -163,8 +159,7 @@ discard block
		block discarded – undo
163	159	try {
164	160	$vcal->cache_sugar_vcal_freebusy($user_focus);
165	161	$this->assertTrue(true);
166		- }
167		- catch (Exception $e) {
	162	+ } catch (Exception $e) {
168	163	$this->fail();
169	164	}
170	165

		@@ -47,8 +47,7 @@
		block discarded – undo
47	47	try {
48	48	SugarFeed::flushBackendCache();
49	49	$this->assertTrue(true);
50		- }
51		- catch (Exception $e) {
	50	+ } catch (Exception $e) {
52	51	$this->fail();
53	52	}
54	53

		@@ -91,8 +91,7 @@ discard block
		block discarded – undo
91	91	$opportunity->fill_in_additional_list_fields();
92	92
93	93	$this->assertTrue(true);
94		- }
95		- catch (Exception $e) {
	94	+ } catch (Exception $e) {
96	95	$this->fail();
97	96	}
98	97
		@@ -107,8 +106,7 @@ discard block
		block discarded – undo
107	106
108	107	$opportunity->fill_in_additional_detail_fields();
109	108	$this->assertTrue(true);
110		- }
111		- catch (Exception $e) {
	109	+ } catch (Exception $e) {
112	110	$this->fail();
113	111	}
114	112
		@@ -133,8 +131,7 @@ discard block
		block discarded – undo
133	131
134	132	$opportunity->update_currency_id(array('GBP','EUR'), 'USD');
135	133	$this->assertTrue(true);
136		- }
137		- catch (Exception $e) {
	134	+ } catch (Exception $e) {
138	135	$this->fail();
139	136	}
140	137
		@@ -222,8 +219,7 @@ discard block
		block discarded – undo
222	219	try {
223	220	$opportunity->save_relationship_changes(true);
224	221	$this->assertTrue(true);
225		- }
226		- catch (Exception $e) {
	222	+ } catch (Exception $e) {
227	223	$this->fail();
228	224	}
229	225
		@@ -236,8 +232,7 @@ discard block
		block discarded – undo
236	232	try {
237	233	$opportunity->set_opportunity_contact_relationship("1");
238	234	$this->assertTrue(true);
239		- }
240		- catch (Exception $e) {
	235	+ } catch (Exception $e) {
241	236	$this->fail();
242	237	}
243	238
		@@ -301,8 +296,7 @@ discard block
		block discarded – undo
301	296	try {
302	297	getCurrencyType();
303	298	$this->assertTrue(true);
304		- }
305		- catch (Exception $e) {
	299	+ } catch (Exception $e) {
306	300	$this->fail();
307	301	}
308	302

		@@ -113,8 +113,7 @@ discard block
		block discarded – undo
113	113	try {
114	114	$savedSearch->returnSavedSearch($id);
115	115	$this->assertTrue(true);
116		- }
117		- catch (Exception $e) {
	116	+ } catch (Exception $e) {
118	117	$this->fail();
119	118	}
120	119
		@@ -129,8 +128,7 @@ discard block
		block discarded – undo
129	128	try {
130	129	$result = $savedSearch->returnSavedSearchContents($id);
131	130	$this->assertTrue(true);
132		- }
133		- catch (Exception $e) {
	131	+ } catch (Exception $e) {
134	132	$this->fail();
135	133	}
136	134

		@@ -60,8 +60,7 @@ discard block
		block discarded – undo
60	60	try {
61	61	$aowWorkFlow->load_flow_beans();
62	62	$this->assertTrue(true);
63		- }
64		- catch (Exception $e) {
	63	+ } catch (Exception $e) {
65	64	$this->fail();
66	65	}
67	66
		@@ -86,8 +85,7 @@ discard block
		block discarded – undo
86	85	try {
87	86	$aowWorkFlow->run_flow();
88	87	$this->assertTrue(true);
89		- }
90		- catch (Exception $e) {
	88	+ } catch (Exception $e) {
91	89	$this->fail();
92	90	}
93	91

		@@ -52,8 +52,7 @@ discard block
		block discarded – undo
52	52	$aCase->save_relationship_changes(false);
53	53
54	54	$this->assertTrue(true);
55		- }
56		- catch (Exception $e) {
	55	+ } catch (Exception $e) {
57	56	$this->fail();
58	57	}
59	58
		@@ -67,8 +66,7 @@ discard block
		block discarded – undo
67	66	try {
68	67	$aCase->set_case_contact_relationship(1);
69	68	$this->assertTrue(true);
70		- }
71		- catch (Exception $e) {
	69	+ } catch (Exception $e) {
72	70	$this->fail();
73	71	}
74	72
		@@ -82,8 +80,7 @@ discard block
		block discarded – undo
82	80	try {
83	81	$aCase->fill_in_additional_list_fields();
84	82	$this->assertTrue(true);
85		- }
86		- catch (Exception $e) {
	83	+ } catch (Exception $e) {
87	84	$this->fail();
88	85	}
89	86

adamjakab / SuiteCRM

Push — CI ( ee6bd7...0f01dd )

Status

Category

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +6 added lines, -12 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch