Inspection of "added test suite from JimMackin(https://github.com..." - adamjakab/SuiteCRM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — CI ( ee6bd7...0f01dd )

by Adam

created 2016-03-07 16:43 UTC

Status

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -123,8 +123,7 @@  discard block
 block discarded – undo
     	try {
     		$mergeRecord->fill_in_additional_list_fields();
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -146,8 +145,7 @@  discard block
 block discarded – undo
     	try {
     		$mergeRecord->fill_in_additional_detail_fields();
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	

Please login to merge, or discard this patch.

tests/tests/modules/InboundEmail/InboundEmailTest.php 1 patch

Braces +31 added lines, -62 removed lines patch added patch discarded remove patch

@@ -227,8 +227,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->renameFolder("mailbox1", "new_mailbox");
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 			
@@ -739,8 +738,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->deletePop3Cache();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 	
@@ -770,8 +768,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->pop3_cleanUp();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -844,8 +841,7 @@  discard block
 block discarded – undo
 			$this->assertEquals("could not open socket connection to POP3 server", $result);		
 			
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -867,8 +863,7 @@  discard block
 block discarded – undo
 			$this->assertEquals(false, $result);
 				
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 	
@@ -888,8 +883,7 @@  discard block
 block discarded – undo
 		
 			$result = $inboundEmail->getMessagesInEmailCache(0, 1);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 	
@@ -900,8 +894,7 @@  discard block
 block discarded – undo
 		try {
 			$result = $inboundEmail->getMessagesInEmailCache(1, 0);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 			
@@ -988,8 +981,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->checkEmail("INBOX");
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1001,8 +993,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->checkEmail("INBOX");
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1020,8 +1011,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->syncEmail();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 			
@@ -1039,8 +1029,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->deleteCachedMessages("1,2", "test");
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 			
@@ -1151,8 +1140,7 @@  discard block
 block discarded – undo
 			$inboundEmail->markEmails('1','answered');
 			
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1535,8 +1523,7 @@  discard block
 block discarded – undo
 		try {
 			$result = $inboundEmail->handleAutoresponse($email,$contactAddr);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1579,8 +1566,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->handleMailboxType($email, $header);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1629,8 +1615,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->handleCreateCase($email, 1);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1707,8 +1692,7 @@  discard block
 block discarded – undo
 		try {
 			$result = $inboundEmail->getMessageTextFromSingleMimePart(1,1,$structure);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1754,8 +1738,7 @@  discard block
 block discarded – undo
 		try {
 			$result = $inboundEmail->getMessageText(1, "PLAIN", $structure, $fullHeader);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1825,8 +1808,7 @@  discard block
 block discarded – undo
 		try {
 			$result = $inboundEmail->buildBreadCrumbs(array(), "ALTERNATIVE", '1');
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1846,8 +1828,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->buildBreadCrumbsHTML(array());
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1918,8 +1899,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->saveAttachments("1", array(), "1", '0', true);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -1983,8 +1963,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->saveAttachmentBinaries(new Note(), "1", "1.1", $part, 1);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -2064,8 +2043,7 @@  discard block
 block discarded – undo
 		try {
 			$result = $inboundEmail->getDuplicateEmailId("1", "1");
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -2085,8 +2063,7 @@  discard block
 block discarded – undo
 		try {
 			$result = $inboundEmail->importOneEmail("1", "1");
 			$this->assertEquals(false,$result);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -2307,8 +2284,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->disconnectMailserver();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -2338,8 +2314,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->checkImap();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 			
@@ -2463,8 +2438,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->cleanOutCache();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -2481,8 +2455,7 @@  discard block
 block discarded – undo
 		try {
 			$result = $inboundEmail->copyEmails(1, "INBOX", 1, "TRASH", array(1));
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -2543,8 +2516,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->deleteMessageOnMailServerForPop3("1");
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -2791,8 +2763,7 @@  discard block
 block discarded – undo
 		try {
 			$inboundEmail->insertMailBoxFolders(array("INBOX","OUTBOX"));
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -2886,8 +2857,7 @@  discard block
 block discarded – undo
     	try {
     		$inboundEmail->getNewEmailsForSyncedMailbox();    	
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -2904,8 +2874,7 @@  discard block
 block discarded – undo
     		$inboundEmail->importMessages();
     		
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
  

Please login to merge, or discard this patch.

tests/tests/modules/AOR_Reports/AOR_ReportTest.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -83,8 +83,7 @@
 block discarded – undo
     	try {
     		$aor_Report->load_report_beans();
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	

Please login to merge, or discard this patch.

tests/tests/modules/Notes/NoteTest.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -49,8 +49,7 @@  discard block
 block discarded – undo
 		try {
 			$note->mark_deleted(1);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -106,8 +105,7 @@  discard block
 block discarded – undo
 		try {
 			$note->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -121,8 +119,7 @@  discard block
 block discarded – undo
 		try {
 			$note->fill_in_additional_detail_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

Please login to merge, or discard this patch.

tests/tests/modules/Tasks/TaskTest.php 1 patch

Braces +4 added lines, -7 removed lines patch added patch discarded remove patch

@@ -86,8 +86,7 @@  discard block
 block discarded – undo
 		try {
 			$task->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -103,8 +102,7 @@  discard block
 block discarded – undo
 		try {
 			$task->fill_in_additional_detail_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -120,8 +118,7 @@  discard block
 block discarded – undo
 		try {
 			$task->fill_in_additional_parent_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}		
 		
@@ -162,7 +159,7 @@  discard block
 block discarded – undo
         foreach($expected as $expectedKey => $expectedVal){
             if($expectedKey == 'SET_COMPLETE'){
                 $this->assertRegExp($expected[$expectedKey],$actual[$expectedKey]);
-            }else {
+            } else {
                 $this->assertSame($expected[$expectedKey], $actual[$expectedKey]);
             }
         }

Please login to merge, or discard this patch.

tests/tests/modules/OAuthTokens/OAuthTokenTest.php 1 patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

@@ -214,8 +214,7 @@  discard block
 block discarded – undo
 		try {
 			OAuthToken::cleanup();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -234,8 +233,7 @@  discard block
 block discarded – undo
 		try {
 			OAuthToken::deleteByConsumer("1");
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -248,8 +246,7 @@  discard block
 block discarded – undo
 		try {
 			OAuthToken::deleteByUser("1");
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

Please login to merge, or discard this patch.

tests/tests/modules/DocumentRevisions/DocumentRevisionTest.php 1 patch

Braces +4 added lines, -8 removed lines patch added patch discarded remove patch

@@ -94,8 +94,7 @@  discard block
 block discarded – undo
 		try {
 			$documentRevision->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 
@@ -109,8 +108,7 @@  discard block
 block discarded – undo
 		try {
 			$documentRevision->fill_in_additional_detail_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 
@@ -143,8 +141,7 @@  discard block
 block discarded – undo
 		try {
 			$documentRevision->fill_document_name_revision();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -158,8 +155,7 @@  discard block
 block discarded – undo
 		try {
 			$documentRevision->list_view_parse_additional_sections(new Sugar_Smarty(), $xTemplateSection);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 

Please login to merge, or discard this patch.

tests/tests/modules/ProjectTask/ProjectTaskTest.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -91,8 +91,7 @@  discard block
 block discarded – undo
 		try {
 			$projectTask->updateParentProjectTaskPercentage();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -131,8 +130,7 @@  discard block
 block discarded – undo
 		try {
 			$projectTask->updateStatistic();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

Please login to merge, or discard this patch.

tests/tests/modules/Documents/DocumentTest.php 1 patch

Braces +4 added lines, -7 removed lines patch added patch discarded remove patch

@@ -93,8 +93,7 @@  discard block
 block discarded – undo
 		try {
 			$document->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 
@@ -129,8 +128,7 @@  discard block
 block discarded – undo
 		try {
 			$document->list_view_parse_additional_sections(new Sugar_Smarty(), $xTemplateSection);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -194,7 +192,7 @@  discard block
 block discarded – undo
         foreach($expected as $expectedKey => $expectedVal){
             if($expectedKey == 'FILE_URL'){
                 $this->assertRegExp($expected[$expectedKey],$actual[$expectedKey]);
-            }else {
+            } else {
                 $this->assertSame($expected[$expectedKey], $actual[$expectedKey]);
             }
         }
@@ -208,8 +206,7 @@  discard block
 block discarded – undo
     	try {
     		$document->mark_relationships_deleted(1);
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
 

Please login to merge, or discard this patch.

		@@ -123,8 +123,7 @@ discard block
		block discarded – undo
123	123	try {
124	124	$mergeRecord->fill_in_additional_list_fields();
125	125	$this->assertTrue(true);
126		- }
127		- catch (Exception $e) {
	126	+ } catch (Exception $e) {
128	127	$this->fail();
129	128	}
130	129
		@@ -146,8 +145,7 @@ discard block
		block discarded – undo
146	145	try {
147	146	$mergeRecord->fill_in_additional_detail_fields();
148	147	$this->assertTrue(true);
149		- }
150		- catch (Exception $e) {
	148	+ } catch (Exception $e) {
151	149	$this->fail();
152	150	}
153	151

		@@ -227,8 +227,7 @@ discard block
		block discarded – undo
227	227	try {
228	228	$inboundEmail->renameFolder("mailbox1", "new_mailbox");
229	229	$this->assertTrue(true);
230		- }
231		- catch (Exception $e) {
	230	+ } catch (Exception $e) {
232	231	$this->fail();
233	232	}
234	233
		@@ -739,8 +738,7 @@ discard block
		block discarded – undo
739	738	try {
740	739	$inboundEmail->deletePop3Cache();
741	740	$this->assertTrue(true);
742		- }
743		- catch (Exception $e) {
	741	+ } catch (Exception $e) {
744	742	$this->fail();
745	743	}
746	744
		@@ -770,8 +768,7 @@ discard block
		block discarded – undo
770	768	try {
771	769	$inboundEmail->pop3_cleanUp();
772	770	$this->assertTrue(true);
773		- }
774		- catch (Exception $e) {
	771	+ } catch (Exception $e) {
775	772	$this->fail();
776	773	}
777	774
		@@ -844,8 +841,7 @@ discard block
		block discarded – undo
844	841	$this->assertEquals("could not open socket connection to POP3 server", $result);
845	842
846	843	$this->assertTrue(true);
847		- }
848		- catch (Exception $e) {
	844	+ } catch (Exception $e) {
849	845	$this->fail();
850	846	}
851	847
		@@ -867,8 +863,7 @@ discard block
		block discarded – undo
867	863	$this->assertEquals(false, $result);
868	864
869	865	$this->assertTrue(true);
870		- }
871		- catch (Exception $e) {
	866	+ } catch (Exception $e) {
872	867	$this->fail();
873	868	}
874	869
		@@ -888,8 +883,7 @@ discard block
		block discarded – undo
888	883
889	884	$result = $inboundEmail->getMessagesInEmailCache(0, 1);
890	885	$this->assertTrue(true);
891		- }
892		- catch (Exception $e) {
	886	+ } catch (Exception $e) {
893	887	$this->fail();
894	888	}
895	889
		@@ -900,8 +894,7 @@ discard block
		block discarded – undo
900	894	try {
901	895	$result = $inboundEmail->getMessagesInEmailCache(1, 0);
902	896	$this->assertTrue(true);
903		- }
904		- catch (Exception $e) {
	897	+ } catch (Exception $e) {
905	898	$this->fail();
906	899	}
907	900
		@@ -988,8 +981,7 @@ discard block
		block discarded – undo
988	981	try {
989	982	$inboundEmail->checkEmail("INBOX");
990	983	$this->assertTrue(true);
991		- }
992		- catch (Exception $e) {
	984	+ } catch (Exception $e) {
993	985	$this->fail();
994	986	}
995	987
		@@ -1001,8 +993,7 @@ discard block
		block discarded – undo
1001	993	try {
1002	994	$inboundEmail->checkEmail("INBOX");
1003	995	$this->assertTrue(true);
1004		- }
1005		- catch (Exception $e) {
	996	+ } catch (Exception $e) {
1006	997	$this->fail();
1007	998	}
1008	999
		@@ -1020,8 +1011,7 @@ discard block
		block discarded – undo
1020	1011	try {
1021	1012	$inboundEmail->syncEmail();
1022	1013	$this->assertTrue(true);
1023		- }
1024		- catch (Exception $e) {
	1014	+ } catch (Exception $e) {
1025	1015	$this->fail();
1026	1016	}
1027	1017
		@@ -1039,8 +1029,7 @@ discard block
		block discarded – undo
1039	1029	try {
1040	1030	$inboundEmail->deleteCachedMessages("1,2", "test");
1041	1031	$this->assertTrue(true);
1042		- }
1043		- catch (Exception $e) {
	1032	+ } catch (Exception $e) {
1044	1033	$this->fail();
1045	1034	}
1046	1035
		@@ -1151,8 +1140,7 @@ discard block
		block discarded – undo
1151	1140	$inboundEmail->markEmails('1','answered');
1152	1141
1153	1142	$this->assertTrue(true);
1154		- }
1155		- catch (Exception $e) {
	1143	+ } catch (Exception $e) {
1156	1144	$this->fail();
1157	1145	}
1158	1146
		@@ -1535,8 +1523,7 @@ discard block
		block discarded – undo
1535	1523	try {
1536	1524	$result = $inboundEmail->handleAutoresponse($email,$contactAddr);
1537	1525	$this->assertTrue(true);
1538		- }
1539		- catch (Exception $e) {
	1526	+ } catch (Exception $e) {
1540	1527	$this->fail();
1541	1528	}
1542	1529
		@@ -1579,8 +1566,7 @@ discard block
		block discarded – undo
1579	1566	try {
1580	1567	$inboundEmail->handleMailboxType($email, $header);
1581	1568	$this->assertTrue(true);
1582		- }
1583		- catch (Exception $e) {
	1569	+ } catch (Exception $e) {
1584	1570	$this->fail();
1585	1571	}
1586	1572
		@@ -1629,8 +1615,7 @@ discard block
		block discarded – undo
1629	1615	try {
1630	1616	$inboundEmail->handleCreateCase($email, 1);
1631	1617	$this->assertTrue(true);
1632		- }
1633		- catch (Exception $e) {
	1618	+ } catch (Exception $e) {
1634	1619	$this->fail();
1635	1620	}
1636	1621
		@@ -1707,8 +1692,7 @@ discard block
		block discarded – undo
1707	1692	try {
1708	1693	$result = $inboundEmail->getMessageTextFromSingleMimePart(1,1,$structure);
1709	1694	$this->assertTrue(true);
1710		- }
1711		- catch (Exception $e) {
	1695	+ } catch (Exception $e) {
1712	1696	$this->fail();
1713	1697	}
1714	1698
		@@ -1754,8 +1738,7 @@ discard block
		block discarded – undo
1754	1738	try {
1755	1739	$result = $inboundEmail->getMessageText(1, "PLAIN", $structure, $fullHeader);
1756	1740	$this->assertTrue(true);
1757		- }
1758		- catch (Exception $e) {
	1741	+ } catch (Exception $e) {
1759	1742	$this->fail();
1760	1743	}
1761	1744
		@@ -1825,8 +1808,7 @@ discard block
		block discarded – undo
1825	1808	try {
1826	1809	$result = $inboundEmail->buildBreadCrumbs(array(), "ALTERNATIVE", '1');
1827	1810	$this->assertTrue(true);
1828		- }
1829		- catch (Exception $e) {
	1811	+ } catch (Exception $e) {
1830	1812	$this->fail();
1831	1813	}
1832	1814
		@@ -1846,8 +1828,7 @@ discard block
		block discarded – undo
1846	1828	try {
1847	1829	$inboundEmail->buildBreadCrumbsHTML(array());
1848	1830	$this->assertTrue(true);
1849		- }
1850		- catch (Exception $e) {
	1831	+ } catch (Exception $e) {
1851	1832	$this->fail();
1852	1833	}
1853	1834
		@@ -1918,8 +1899,7 @@ discard block
		block discarded – undo
1918	1899	try {
1919	1900	$inboundEmail->saveAttachments("1", array(), "1", '0', true);
1920	1901	$this->assertTrue(true);
1921		- }
1922		- catch (Exception $e) {
	1902	+ } catch (Exception $e) {
1923	1903	$this->fail();
1924	1904	}
1925	1905
		@@ -1983,8 +1963,7 @@ discard block
		block discarded – undo
1983	1963	try {
1984	1964	$inboundEmail->saveAttachmentBinaries(new Note(), "1", "1.1", $part, 1);
1985	1965	$this->assertTrue(true);
1986		- }
1987		- catch (Exception $e) {
	1966	+ } catch (Exception $e) {
1988	1967	$this->fail();
1989	1968	}
1990	1969
		@@ -2064,8 +2043,7 @@ discard block
		block discarded – undo
2064	2043	try {
2065	2044	$result = $inboundEmail->getDuplicateEmailId("1", "1");
2066	2045	$this->assertTrue(true);
2067		- }
2068		- catch (Exception $e) {
	2046	+ } catch (Exception $e) {
2069	2047	$this->fail();
2070	2048	}
2071	2049
		@@ -2085,8 +2063,7 @@ discard block
		block discarded – undo
2085	2063	try {
2086	2064	$result = $inboundEmail->importOneEmail("1", "1");
2087	2065	$this->assertEquals(false,$result);
2088		- }
2089		- catch (Exception $e) {
	2066	+ } catch (Exception $e) {
2090	2067	$this->fail();
2091	2068	}
2092	2069
		@@ -2307,8 +2284,7 @@ discard block
		block discarded – undo
2307	2284	try {
2308	2285	$inboundEmail->disconnectMailserver();
2309	2286	$this->assertTrue(true);
2310		- }
2311		- catch (Exception $e) {
	2287	+ } catch (Exception $e) {
2312	2288	$this->fail();
2313	2289	}
2314	2290
		@@ -2338,8 +2314,7 @@ discard block
		block discarded – undo
2338	2314	try {
2339	2315	$inboundEmail->checkImap();
2340	2316	$this->assertTrue(true);
2341		- }
2342		- catch (Exception $e) {
	2317	+ } catch (Exception $e) {
2343	2318	$this->fail();
2344	2319	}
2345	2320
		@@ -2463,8 +2438,7 @@ discard block
		block discarded – undo
2463	2438	try {
2464	2439	$inboundEmail->cleanOutCache();
2465	2440	$this->assertTrue(true);
2466		- }
2467		- catch (Exception $e) {
	2441	+ } catch (Exception $e) {
2468	2442	$this->fail();
2469	2443	}
2470	2444
		@@ -2481,8 +2455,7 @@ discard block
		block discarded – undo
2481	2455	try {
2482	2456	$result = $inboundEmail->copyEmails(1, "INBOX", 1, "TRASH", array(1));
2483	2457	$this->assertTrue(true);
2484		- }
2485		- catch (Exception $e) {
	2458	+ } catch (Exception $e) {
2486	2459	$this->fail();
2487	2460	}
2488	2461
		@@ -2543,8 +2516,7 @@ discard block
		block discarded – undo
2543	2516	try {
2544	2517	$inboundEmail->deleteMessageOnMailServerForPop3("1");
2545	2518	$this->assertTrue(true);
2546		- }
2547		- catch (Exception $e) {
	2519	+ } catch (Exception $e) {
2548	2520	$this->fail();
2549	2521	}
2550	2522
		@@ -2791,8 +2763,7 @@ discard block
		block discarded – undo
2791	2763	try {
2792	2764	$inboundEmail->insertMailBoxFolders(array("INBOX","OUTBOX"));
2793	2765	$this->assertTrue(true);
2794		- }
2795		- catch (Exception $e) {
	2766	+ } catch (Exception $e) {
2796	2767	$this->fail();
2797	2768	}
2798	2769
		@@ -2886,8 +2857,7 @@ discard block
		block discarded – undo
2886	2857	try {
2887	2858	$inboundEmail->getNewEmailsForSyncedMailbox();
2888	2859	$this->assertTrue(true);
2889		- }
2890		- catch (Exception $e) {
	2860	+ } catch (Exception $e) {
2891	2861	$this->fail();
2892	2862	}
2893	2863
		@@ -2904,8 +2874,7 @@ discard block
		block discarded – undo
2904	2874	$inboundEmail->importMessages();
2905	2875
2906	2876	$this->assertTrue(true);
2907		- }
2908		- catch (Exception $e) {
	2877	+ } catch (Exception $e) {
2909	2878	$this->fail();
2910	2879	}
2911	2880

		@@ -83,8 +83,7 @@
		block discarded – undo
83	83	try {
84	84	$aor_Report->load_report_beans();
85	85	$this->assertTrue(true);
86		- }
87		- catch (Exception $e) {
	86	+ } catch (Exception $e) {
88	87	$this->fail();
89	88	}
90	89

		@@ -49,8 +49,7 @@ discard block
		block discarded – undo
49	49	try {
50	50	$note->mark_deleted(1);
51	51	$this->assertTrue(true);
52		- }
53		- catch (Exception $e) {
	52	+ } catch (Exception $e) {
54	53	$this->fail();
55	54	}
56	55
		@@ -106,8 +105,7 @@ discard block
		block discarded – undo
106	105	try {
107	106	$note->fill_in_additional_list_fields();
108	107	$this->assertTrue(true);
109		- }
110		- catch (Exception $e) {
	108	+ } catch (Exception $e) {
111	109	$this->fail();
112	110	}
113	111
		@@ -121,8 +119,7 @@ discard block
		block discarded – undo
121	119	try {
122	120	$note->fill_in_additional_detail_fields();
123	121	$this->assertTrue(true);
124		- }
125		- catch (Exception $e) {
	122	+ } catch (Exception $e) {
126	123	$this->fail();
127	124	}
128	125

		@@ -86,8 +86,7 @@ discard block
		block discarded – undo
86	86	try {
87	87	$task->fill_in_additional_list_fields();
88	88	$this->assertTrue(true);
89		- }
90		- catch (Exception $e) {
	89	+ } catch (Exception $e) {
91	90	$this->fail();
92	91	}
93	92
		@@ -103,8 +102,7 @@ discard block
		block discarded – undo
103	102	try {
104	103	$task->fill_in_additional_detail_fields();
105	104	$this->assertTrue(true);
106		- }
107		- catch (Exception $e) {
	105	+ } catch (Exception $e) {
108	106	$this->fail();
109	107	}
110	108
		@@ -120,8 +118,7 @@ discard block
		block discarded – undo
120	118	try {
121	119	$task->fill_in_additional_parent_fields();
122	120	$this->assertTrue(true);
123		- }
124		- catch (Exception $e) {
	121	+ } catch (Exception $e) {
125	122	$this->fail();
126	123	}
127	124
		@@ -162,7 +159,7 @@ discard block
		block discarded – undo
162	159	foreach($expected as $expectedKey => $expectedVal){
163	160	if($expectedKey == 'SET_COMPLETE'){
164	161	$this->assertRegExp($expected[$expectedKey],$actual[$expectedKey]);
165		- }else {
	162	+ } else {
166	163	$this->assertSame($expected[$expectedKey], $actual[$expectedKey]);
167	164	}
168	165	}

		@@ -214,8 +214,7 @@ discard block
		block discarded – undo
214	214	try {
215	215	OAuthToken::cleanup();
216	216	$this->assertTrue(true);
217		- }
218		- catch (Exception $e) {
	217	+ } catch (Exception $e) {
219	218	$this->fail();
220	219	}
221	220
		@@ -234,8 +233,7 @@ discard block
		block discarded – undo
234	233	try {
235	234	OAuthToken::deleteByConsumer("1");
236	235	$this->assertTrue(true);
237		- }
238		- catch (Exception $e) {
	236	+ } catch (Exception $e) {
239	237	$this->fail();
240	238	}
241	239
		@@ -248,8 +246,7 @@ discard block
		block discarded – undo
248	246	try {
249	247	OAuthToken::deleteByUser("1");
250	248	$this->assertTrue(true);
251		- }
252		- catch (Exception $e) {
	249	+ } catch (Exception $e) {
253	250	$this->fail();
254	251	}
255	252

		@@ -94,8 +94,7 @@ discard block
		block discarded – undo
94	94	try {
95	95	$documentRevision->fill_in_additional_list_fields();
96	96	$this->assertTrue(true);
97		- }
98		- catch (Exception $e) {
	97	+ } catch (Exception $e) {
99	98	$this->fail();
100	99	}
101	100
		@@ -109,8 +108,7 @@ discard block
		block discarded – undo
109	108	try {
110	109	$documentRevision->fill_in_additional_detail_fields();
111	110	$this->assertTrue(true);
112		- }
113		- catch (Exception $e) {
	111	+ } catch (Exception $e) {
114	112	$this->fail();
115	113	}
116	114
		@@ -143,8 +141,7 @@ discard block
		block discarded – undo
143	141	try {
144	142	$documentRevision->fill_document_name_revision();
145	143	$this->assertTrue(true);
146		- }
147		- catch (Exception $e) {
	144	+ } catch (Exception $e) {
148	145	$this->fail();
149	146	}
150	147
		@@ -158,8 +155,7 @@ discard block
		block discarded – undo
158	155	try {
159	156	$documentRevision->list_view_parse_additional_sections(new Sugar_Smarty(), $xTemplateSection);
160	157	$this->assertTrue(true);
161		- }
162		- catch (Exception $e) {
	158	+ } catch (Exception $e) {
163	159	$this->fail();
164	160	}
165	161

		@@ -91,8 +91,7 @@ discard block
		block discarded – undo
91	91	try {
92	92	$projectTask->updateParentProjectTaskPercentage();
93	93	$this->assertTrue(true);
94		- }
95		- catch (Exception $e) {
	94	+ } catch (Exception $e) {
96	95	$this->fail();
97	96	}
98	97
		@@ -131,8 +130,7 @@ discard block
		block discarded – undo
131	130	try {
132	131	$projectTask->updateStatistic();
133	132	$this->assertTrue(true);
134		- }
135		- catch (Exception $e) {
	133	+ } catch (Exception $e) {
136	134	$this->fail();
137	135	}
138	136

		@@ -93,8 +93,7 @@ discard block
		block discarded – undo
93	93	try {
94	94	$document->fill_in_additional_list_fields();
95	95	$this->assertTrue(true);
96		- }
97		- catch (Exception $e) {
	96	+ } catch (Exception $e) {
98	97	$this->fail();
99	98	}
100	99
		@@ -129,8 +128,7 @@ discard block
		block discarded – undo
129	128	try {
130	129	$document->list_view_parse_additional_sections(new Sugar_Smarty(), $xTemplateSection);
131	130	$this->assertTrue(true);
132		- }
133		- catch (Exception $e) {
	131	+ } catch (Exception $e) {
134	132	$this->fail();
135	133	}
136	134
		@@ -194,7 +192,7 @@ discard block
		block discarded – undo
194	192	foreach($expected as $expectedKey => $expectedVal){
195	193	if($expectedKey == 'FILE_URL'){
196	194	$this->assertRegExp($expected[$expectedKey],$actual[$expectedKey]);
197		- }else {
	195	+ } else {
198	196	$this->assertSame($expected[$expectedKey], $actual[$expectedKey]);
199	197	}
200	198	}
		@@ -208,8 +206,7 @@ discard block
		block discarded – undo
208	206	try {
209	207	$document->mark_relationships_deleted(1);
210	208	$this->assertTrue(true);
211		- }
212		- catch (Exception $e) {
	209	+ } catch (Exception $e) {
213	210	$this->fail();
214	211	}
215	212

adamjakab / SuiteCRM

Push — CI ( ee6bd7...0f01dd )

Status

Category

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +31 added lines, -62 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +4 added lines, -7 removed lines patch added patch discarded remove patch

Braces +3 added lines, -6 removed lines patch added patch discarded remove patch

Braces +4 added lines, -8 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +4 added lines, -7 removed lines patch added patch discarded remove patch