adamjakab / SuiteCRM

tests/tests/modules/Audit/AuditTest.php

Spacing +9 added lines, -9 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 require_once('modules/Audit/Audit.php');
-class AuditTest extends PHPUnit_Framework_TestCase  {
+class AuditTest extends PHPUnit_Framework_TestCase {
 
 	
 	public function testAudit() {
@@ -9,8 +9,8 @@ 
 		
 		//execute the contructor and check for the Object type and  attributes
 		$audit = new Audit();
-		$this->assertInstanceOf('Audit',$audit);
-		$this->assertInstanceOf('SugarBean',$audit);
+		$this->assertInstanceOf('Audit', $audit);
+		$this->assertInstanceOf('SugarBean', $audit);
 		$this->assertAttributeEquals('Audit', 'module_dir', $audit);
 		$this->assertAttributeEquals('Audit', 'object_name', $audit);
 
@@ -22,11 +22,11 @@ 
 		$audit = new Audit();
 		
 		//test without setting name
-		$this->assertEquals(Null,$audit->get_summary_text());
+		$this->assertEquals(Null, $audit->get_summary_text());
 		
 		//test with name set
 		$audit->name = "test";
-		$this->assertEquals('test',$audit->get_summary_text());
+		$this->assertEquals('test', $audit->get_summary_text());
 		
 	}
 
@@ -154,12 +154,12 @@ 
 		$audit = new Audit();
 		
 		//test with name field
-		$result = $audit->getAssociatedFieldName("name","1");
-		$this->assertEquals("1",$result);
+		$result = $audit->getAssociatedFieldName("name", "1");
+		$this->assertEquals("1", $result);
 		
 		//test with parent_id field
-		$result = $audit->getAssociatedFieldName("parent_id","1");
-		$this->assertEquals(null,$result);
+		$result = $audit->getAssociatedFieldName("parent_id", "1");
+		$this->assertEquals(null, $result);
 	
 	}
 	

tests/tests/modules/AOR_Scheduled_Reports/AOR_Scheduled_ReportsTest.php

Spacing +12 added lines, -12 removed lines

@@ -3,13 +3,13 @@ 
 class AOR_Scheduled_ReportsTest extends PHPUnit_Framework_TestCase {
 
 	
-	public function testAOR_Scheduled_Reports(){
+	public function testAOR_Scheduled_Reports() {
 
 		//execute the contructor and check for the Object type and  attributes
 		$aorScheduledReports = new AOR_Scheduled_Reports();
-		$this->assertInstanceOf('AOR_Scheduled_Reports',$aorScheduledReports);
-		$this->assertInstanceOf('Basic',$aorScheduledReports);
-		$this->assertInstanceOf('SugarBean',$aorScheduledReports);
+		$this->assertInstanceOf('AOR_Scheduled_Reports', $aorScheduledReports);
+		$this->assertInstanceOf('Basic', $aorScheduledReports);
+		$this->assertInstanceOf('SugarBean', $aorScheduledReports);
 			
 		$this->assertAttributeEquals('AOR_Scheduled_Reports', 'module_dir', $aorScheduledReports);
 		$this->assertAttributeEquals('AOR_Scheduled_Reports', 'object_name', $aorScheduledReports);
@@ -20,7 +20,7 @@ 
 		
 	}
 
-	public function testbean_implements(){
+	public function testbean_implements() {
 
 		error_reporting(E_ERROR | E_PARSE);
 		
@@ -31,12 +31,12 @@ 
 		
     }
 
-	public function testSaveAndGet_email_recipients(){
+	public function testSaveAndGet_email_recipients() {
 
 		$aorScheduledReports = new AOR_Scheduled_Reports();
 		$aorScheduledReports->name = "test";
 		$aorScheduledReports->description = "test description";		
-		$_POST['email_recipients']= Array('email_target_type'=> array('Email Address','all','Specify User')  ,'email' =>array('test@test.com','','1') );  
+		$_POST['email_recipients'] = Array('email_target_type'=> array('Email Address', 'all', 'Specify User'), 'email' =>array('test@test.com', '', '1'));  
 
 		
 		//test save and test for record ID to verify that record is saved 
@@ -47,12 +47,12 @@ 
 		
 		
 		//test get_email_recipients 
-		$expected = array('test@test.com','','1');
+		$expected = array('test@test.com', '', '1');
 		$aorScheduledReports->retrieve($aorScheduledReports->id);
 		$emails = $aorScheduledReports->get_email_recipients();
 		
 		$this->assertTrue(is_array($emails)); 	
-		$this->assertEquals('test@test.com',$emails[0]);
+		$this->assertEquals('test@test.com', $emails[0]);
 
 		
 		$aorScheduledReports->mark_deleted($aorScheduledReports->id);
@@ -62,17 +62,17 @@ 
 
 
     
-	public function testshouldRun(){
+	public function testshouldRun() {
   
 		
 		$aorScheduledReports = new AOR_Scheduled_Reports();
 		$aorScheduledReports->schedule = " 8 * * * *";
 		
 		//test without a last_run date
-		$this->assertFalse($aorScheduledReports->shouldRun(new DateTime()) );
+		$this->assertFalse($aorScheduledReports->shouldRun(new DateTime()));
 		
 		//test without a older last_run date
-		$aorScheduledReports->last_run = date("d-m-y H:i:s", mktime(0,0,0,10,3,2014));
+		$aorScheduledReports->last_run = date("d-m-y H:i:s", mktime(0, 0, 0, 10, 3, 2014));
 		$this->assertTrue($aorScheduledReports->shouldRun(new DateTime()));
 
 		

tests/tests/modules/AOK_Knowledge_Base_Categories/AOK_Knowledge_Base_CategoriesTest.php

Spacing +4 added lines, -4 removed lines

@@ -2,13 +2,13 @@
 
 class AOK_Knowledge_Base_CategoriesTest extends PHPUnit_Framework_TestCase {
 	
-	public function testAOK_Knowledge_Base_Categories(){	
+	public function testAOK_Knowledge_Base_Categories() {	
 
 		//execute the contructor and check for the Object type and type attribute
 		$aok_KBCategories = new AOK_Knowledge_Base_Categories();
-		$this->assertInstanceOf('AOK_Knowledge_Base_Categories',$aok_KBCategories);
-		$this->assertInstanceOf('Basic',$aok_KBCategories);
-		$this->assertInstanceOf('SugarBean',$aok_KBCategories);
+		$this->assertInstanceOf('AOK_Knowledge_Base_Categories', $aok_KBCategories);
+		$this->assertInstanceOf('Basic', $aok_KBCategories);
+		$this->assertInstanceOf('SugarBean', $aok_KBCategories);
 		
 		$this->assertAttributeEquals('AOK_Knowledge_Base_Categories', 'module_dir', $aok_KBCategories);
 		$this->assertAttributeEquals('AOK_Knowledge_Base_Categories', 'object_name', $aok_KBCategories);

tests/tests/modules/jjwg_Areas/jjwg_AreasTest.php

Spacing +50 added lines, -50 removed lines

@@ -9,9 +9,9 @@ 
     	//execute the contructor and check for the Object type and  attributes
     	$jjwgAreas = new jjwg_Areas();
     	
-    	$this->assertInstanceOf('jjwg_Areas',$jjwgAreas);
-    	$this->assertInstanceOf('Basic',$jjwgAreas);
-    	$this->assertInstanceOf('SugarBean',$jjwgAreas);
+    	$this->assertInstanceOf('jjwg_Areas', $jjwgAreas);
+    	$this->assertInstanceOf('Basic', $jjwgAreas);
+    	$this->assertInstanceOf('SugarBean', $jjwgAreas);
     	 
     	$this->assertAttributeEquals('jjwg_Areas', 'module_dir', $jjwgAreas);
     	$this->assertAttributeEquals('jjwg_Areas', 'object_name', $jjwgAreas);
@@ -37,9 +37,9 @@ 
     	$jjwgAreas = new jjwg_Areas();
     	$jjwgAreas->configuration();
     	
-    	$this->assertInstanceOf('jjwg_Maps',$jjwgAreas->jjwg_Maps);
+    	$this->assertInstanceOf('jjwg_Maps', $jjwgAreas->jjwg_Maps);
     	$this->assertTrue(is_array($jjwgAreas->settings));
-    	$this->assertGreaterThan(0,count($jjwgAreas->settings));
+    	$this->assertGreaterThan(0, count($jjwgAreas->settings));
     	
     }
 
@@ -51,26 +51,26 @@ 
     	
     	//test without pre settting attributes
     	$jjwgAreas->retrieve();
-    	$this->assertEquals(false ,$jjwgAreas->polygon);
-    	$this->assertEquals(0,$jjwgAreas->area);
-    	$this->assertEquals(null,$jjwgAreas->centroid);
+    	$this->assertEquals(false, $jjwgAreas->polygon);
+    	$this->assertEquals(0, $jjwgAreas->area);
+    	$this->assertEquals(null, $jjwgAreas->centroid);
     	
     	
     	//test with required attributes preset
-    	$jjwgAreas->coordinates= "100,80,10\r\n101,81,11\r\n102,82,12";
+    	$jjwgAreas->coordinates = "100,80,10\r\n101,81,11\r\n102,82,12";
     	
-    	$expected_polygon = array (
-    			array ('lng' => '100', 'lat' => '80','elv' => '10' ),
-    			array ('lng' => '101', 'lat' => '81', 'elv' => '11'),
-    			array ('lng' => '102', 'lat' => '82', 'elv' => '12' )
+    	$expected_polygon = array(
+    			array('lng' => '100', 'lat' => '80', 'elv' => '10'),
+    			array('lng' => '101', 'lat' => '81', 'elv' => '11'),
+    			array('lng' => '102', 'lat' => '82', 'elv' => '12')
     	);
     	$expected_centroid = array("lng"=>67.3333333333333285963817615993320941925048828125, "lat" =>54.0, "elv"=>0);
     	
     	$jjwgAreas->retrieve();
     	
-    	$this->assertSame($expected_polygon ,$jjwgAreas->polygon);
-    	$this->assertEquals(20,$jjwgAreas->area);
-    	$this->assertSame($expected_centroid,$jjwgAreas->centroid);
+    	$this->assertSame($expected_polygon, $jjwgAreas->polygon);
+    	$this->assertEquals(20, $jjwgAreas->area);
+    	$this->assertSame($expected_centroid, $jjwgAreas->centroid);
     	     	
     }
 
@@ -85,11 +85,11 @@ 
     	
     	
     	//test with required attributes preset
-    	$jjwgAreas->coordinates= "100,80,10\r\n101,81,11\r\n102,82,12";
-    	$expected = array (
-					  array ('lng' => '100', 'lat' => '80','elv' => '10' ),
-					  array ('lng' => '101', 'lat' => '81', 'elv' => '11'),
-					  array ('lng' => '102', 'lat' => '82', 'elv' => '12' )
+    	$jjwgAreas->coordinates = "100,80,10\r\n101,81,11\r\n102,82,12";
+    	$expected = array(
+					  array('lng' => '100', 'lat' => '80', 'elv' => '10'),
+					  array('lng' => '101', 'lat' => '81', 'elv' => '11'),
+					  array('lng' => '102', 'lat' => '82', 'elv' => '12')
 				);
     	$actual = $jjwgAreas->define_polygon();
 		$this->assertSame($actual, $expected);
@@ -110,7 +110,7 @@ 
     	
     	//test with required attributes preset
     	$jjwgAreas->name = "test";
-    	$jjwgAreas->centroid = array("lng"=> 100 , "lat"=> 50);
+    	$jjwgAreas->centroid = array("lng"=> 100, "lat"=> 50);
     	
     	$expected = array("name"=>"test", "lat"=>50, "lng"=>100);
     	$result = $jjwgAreas->define_area_loc();
@@ -129,11 +129,11 @@ 
     	
     	
     	//test with coordinates setup 
-    	$jjwgAreas->coordinates= "100,80,10\r\n101,81,11\r\n102,82,12";
+    	$jjwgAreas->coordinates = "100,80,10\r\n101,81,11\r\n102,82,12";
     	$expected = array("lng"=>67.3333333333333285963817615993320941925048828125, "lat" =>54.0, "elv"=>0);
     	
     	$result = $jjwgAreas->define_centroid();
-    	$this->assertSame($expected,$result);
+    	$this->assertSame($expected, $result);
     
     }
     
@@ -148,10 +148,10 @@ 
     	
     	
     	//test with coordinates setup
-    	$jjwgAreas->coordinates= "100,80,10\r\n101,81,11\r\n102,82,12";
+    	$jjwgAreas->coordinates = "100,80,10\r\n101,81,11\r\n102,82,12";
   	 
     	$result = $jjwgAreas->define_area();
-    	$this->assertEquals(20,$result);    	
+    	$this->assertEquals(20, $result);    	
     	
     }
     
@@ -180,13 +180,13 @@ 
     	$jjwgAreas = new jjwg_Areas();
     	
     	//test with invalid values
-    	$this->assertEquals(false, $jjwgAreas->is_valid_lng('') );
-    	$this->assertEquals(false, $jjwgAreas->is_valid_lng(181) );
-    	$this->assertEquals(false, $jjwgAreas->is_valid_lng(-181) );
+    	$this->assertEquals(false, $jjwgAreas->is_valid_lng(''));
+    	$this->assertEquals(false, $jjwgAreas->is_valid_lng(181));
+    	$this->assertEquals(false, $jjwgAreas->is_valid_lng(-181));
     	 
     	//test with valid values
-    	$this->assertEquals(true, $jjwgAreas->is_valid_lng(180) );
-    	$this->assertEquals(true, $jjwgAreas->is_valid_lng(-180) );
+    	$this->assertEquals(true, $jjwgAreas->is_valid_lng(180));
+    	$this->assertEquals(true, $jjwgAreas->is_valid_lng(-180));
     	
     }
 
@@ -196,13 +196,13 @@ 
     	$jjwgAreas = new jjwg_Areas();
     	
     	//test with invalid values
-    	$this->assertEquals(false, $jjwgAreas->is_valid_lat('') );
-    	$this->assertEquals(false, $jjwgAreas->is_valid_lat(91) );
-    	$this->assertEquals(false, $jjwgAreas->is_valid_lat(-91) );
+    	$this->assertEquals(false, $jjwgAreas->is_valid_lat(''));
+    	$this->assertEquals(false, $jjwgAreas->is_valid_lat(91));
+    	$this->assertEquals(false, $jjwgAreas->is_valid_lat(-91));
     	 
     	//test with valid values
-    	$this->assertEquals(true, $jjwgAreas->is_valid_lat(90) );
-    	$this->assertEquals(true, $jjwgAreas->is_valid_lat(-90) );
+    	$this->assertEquals(true, $jjwgAreas->is_valid_lat(90));
+    	$this->assertEquals(true, $jjwgAreas->is_valid_lat(-90));
     	
     }
 
@@ -214,11 +214,11 @@ 
     	$marker = array("name"=>"test", "lat"=>100, "lng"=>40);
     
     	//test without setting up coordinates
-    	$this->assertEquals(false, $jjwgAreas->is_marker_in_area($marker) );
+    	$this->assertEquals(false, $jjwgAreas->is_marker_in_area($marker));
     
     	//test with coordinates set
-    	$jjwgAreas->coordinates= "100,40,0.0 101,81,0.0 102,32,0.0";
-    	$this->assertEquals(false, $jjwgAreas->is_marker_in_area($marker) );
+    	$jjwgAreas->coordinates = "100,40,0.0 101,81,0.0 102,32,0.0";
+    	$this->assertEquals(false, $jjwgAreas->is_marker_in_area($marker));
     	 
     }
 
@@ -227,13 +227,13 @@ 
     	$jjwgAreas = new jjwg_Areas();
     	
     	//test without setting up coordinates
-    	$this->assertEquals(false,  $jjwgAreas->is_point_in_area(100,40) );
+    	$this->assertEquals(false, $jjwgAreas->is_point_in_area(100, 40));
     	
     	 
     	//test with coordinates set
-    	$jjwgAreas->coordinates= "100,40,10 101,81,11 102,82,12";
-    	$this->assertEquals(false,  $jjwgAreas->is_point_in_area(101,40) );
-    	$this->assertEquals(true,  $jjwgAreas->is_point_in_area(100,40) );
+    	$jjwgAreas->coordinates = "100,40,10 101,81,11 102,82,12";
+    	$this->assertEquals(false, $jjwgAreas->is_point_in_area(101, 40));
+    	$this->assertEquals(true, $jjwgAreas->is_point_in_area(100, 40));
 
     }
     
@@ -243,12 +243,12 @@ 
     	$jjwgAreas = new jjwg_Areas();
  
     	//test without setting up coordinates
-    	$this->assertEquals(false,  $jjwgAreas->point_in_polygon('100,40,0.0') );
+    	$this->assertEquals(false, $jjwgAreas->point_in_polygon('100,40,0.0'));
 
     	
     	//test with coordinates set
-    	$jjwgAreas->coordinates= "100,40,10 101,81,11 102,82,12";
-    	$this->assertEquals(true,  $jjwgAreas->point_in_polygon('100,40,0.0') );
+    	$jjwgAreas->coordinates = "100,40,10 101,81,11 102,82,12";
+    	$this->assertEquals(true, $jjwgAreas->point_in_polygon('100,40,0.0'));
     		
     }
  
@@ -256,9 +256,9 @@ 
         
     	$jjwgAreas = new jjwg_Areas();
     	
-    	$vertices= array("100,40,10", "101,81,11", "102,82,12");
-    	$this->assertEquals(false, $jjwgAreas->point_on_vertex("100,40,0.0",$vertices));
-    	$this->assertEquals(true, $jjwgAreas->point_on_vertex("100,40,10",$vertices));
+    	$vertices = array("100,40,10", "101,81,11", "102,82,12");
+    	$this->assertEquals(false, $jjwgAreas->point_on_vertex("100,40,0.0", $vertices));
+    	$this->assertEquals(true, $jjwgAreas->point_on_vertex("100,40,10", $vertices));
     						
     }
 
@@ -266,7 +266,7 @@ 
 
     	$jjwgAreas = new jjwg_Areas();
     	
-    	$expected = array("x"=>100,"y"=>40);
+    	$expected = array("x"=>100, "y"=>40);
     	$actual = $jjwgAreas->point_string_to_coordinates("100,40,10");
     	$this->assertEquals($expected, $actual);
     	

tests/tests/modules/Administration/AdministrationTest.php

Spacing +16 added lines, -16 removed lines

@@ -7,16 +7,16 @@ 
 
     	//execute the contructor and check for the Object type and type attribute
     	$admin = new Administration();
-    	$this->assertInstanceOf('Administration',$admin);
-    	$this->assertInstanceOf('SugarBean',$admin);
+    	$this->assertInstanceOf('Administration', $admin);
+    	$this->assertInstanceOf('SugarBean', $admin);
     	 
     	$this->assertAttributeEquals('Administration', 'module_dir', $admin);
     	$this->assertAttributeEquals('Administration', 'object_name', $admin);
     	$this->assertAttributeEquals('config', 'table_name', $admin);
     	$this->assertAttributeEquals(true, 'new_schema', $admin);
     	$this->assertAttributeEquals(true, 'disable_custom_fields', $admin);
-    	$this->assertAttributeEquals( array('disclosure', 'notify','system','portal','proxy','massemailer','ldap','captcha','sugarpdf') , 'config_categories', $admin);
-    	$this->assertAttributeEquals( array("notify_send_by_default", "mail_smtpauth_req", "notify_on", 'portal_on', 'skypeout_on', 'system_mailmerge_on', 'proxy_auth', 'proxy_on', 'system_ldap_enabled','captcha_on') , 'checkbox_fields', $admin);
+    	$this->assertAttributeEquals(array('disclosure', 'notify', 'system', 'portal', 'proxy', 'massemailer', 'ldap', 'captcha', 'sugarpdf'), 'config_categories', $admin);
+    	$this->assertAttributeEquals(array("notify_send_by_default", "mail_smtpauth_req", "notify_on", 'portal_on', 'skypeout_on', 'system_mailmerge_on', 'proxy_auth', 'proxy_on', 'system_ldap_enabled', 'captcha_on'), 'checkbox_fields', $admin);
     
     }
 
@@ -26,31 +26,31 @@ 
     	
     	//execute with default parameters and test if it returns object itself   	
     	$result = $admin->retrieveSettings();
-    	$this->assertInstanceOf('Administration',$result);
-    	$this->assertSame($admin,$result);
+    	$this->assertInstanceOf('Administration', $result);
+    	$this->assertSame($admin, $result);
  
     	    	    	
     	
     	//execute with a invalid category and test if it returns object itself.
     	$result = $admin->retrieveSettings('test');
-    	$this->assertInstanceOf('Administration',$result);
-    	$this->assertSame($admin,$result);
-    	$this->assertEquals(true,$admin->settings['test']);
+    	$this->assertInstanceOf('Administration', $result);
+    	$this->assertSame($admin, $result);
+    	$this->assertEquals(true, $admin->settings['test']);
     	
 
     	
     	//execute with a valid category and test if it returns object itself.
     	$result = $admin->retrieveSettings('notify');
-    	$this->assertInstanceOf('Administration',$result);
-    	$this->assertSame($admin,$result);
+    	$this->assertInstanceOf('Administration', $result);
+    	$this->assertSame($admin, $result);
     	
     	
 
     	//execute with a valid category and clean=true and test if it returns object itself.
     	$admin = new Administration();
-    	$result = $admin->retrieveSettings('notify',true);
-    	$this->assertInstanceOf('Administration',$result);
-    	$this->assertSame($admin,$result);
+    	$result = $admin->retrieveSettings('notify', true);
+    	$this->assertInstanceOf('Administration', $result);
+    	$this->assertSame($admin, $result);
     	
     	
     }
@@ -64,7 +64,7 @@ 
     	//execute the method and verify that it sets the correct config key
     	$admin->saveConfig();
     	$actual = $admin->settings['proxy_test'];	
-    	$this->assertEquals($actual, "test value" );
+    	$this->assertEquals($actual, "test value");
     	    
     }
 
@@ -76,7 +76,7 @@ 
     	$result = $admin->saveSetting('category', 'key', 'test value');
     	$admin->retrieveSettings('category');
     	$actual = $admin->settings['category_key']; 
-    	$this->assertEquals($actual, "test value" );
+    	$this->assertEquals($actual, "test value");
     	
     }
 

tests/tests/modules/Emails/EmailTest.php

Spacing +79 added lines, -79 removed lines

@@ -9,8 +9,8 @@ 
 		
 		//execute the contructor and check for the Object type and  attributes
 		$email = new Email();
-		$this->assertInstanceOf('Email',$email);
-		$this->assertInstanceOf('SugarBean',$email);
+		$this->assertInstanceOf('Email', $email);
+		$this->assertInstanceOf('SugarBean', $email);
 			
 		$this->assertAttributeEquals('Emails', 'module_dir', $email);
 		$this->assertAttributeEquals('Email', 'object_name', $email);
@@ -29,11 +29,11 @@ 
 		$email = new Email();
 		$email->email2init();
 		
-		$this->assertInstanceOf('EmailUI',$email->et);
+		$this->assertInstanceOf('EmailUI', $email->et);
 		
 	}
 
-	public function testbean_implements(){
+	public function testbean_implements() {
 
 		$email = new Email();
 		$this->assertEquals(false, $email->bean_implements('')); //test with blank value
@@ -56,9 +56,9 @@ 
 
 		$email = new Email();
 		
-		$this->assertEquals(false,$email->safeAttachmentName("test.ext"));
-		$this->assertEquals(false,$email->safeAttachmentName("test.exe"));
-		$this->assertEquals(true,$email->safeAttachmentName("test.cgi"));
+		$this->assertEquals(false, $email->safeAttachmentName("test.ext"));
+		$this->assertEquals(false, $email->safeAttachmentName("test.exe"));
+		$this->assertEquals(true, $email->safeAttachmentName("test.cgi"));
 
 	} 
 
@@ -70,7 +70,7 @@ 
 		
 		$email->email2init();
 		$addresses = "abc<abc@xyz.com>,xyz<xyz@abc.com>";
-		$expected = array (array('email' =>'abc@xyz.com', 'display' => 'abc'), array('email' => 'xyz@abc.com','display' => 'xyz'));
+		$expected = array(array('email' =>'abc@xyz.com', 'display' => 'abc'), array('email' => 'xyz@abc.com', 'display' => 'xyz'));
 		
 		$result = $email->email2ParseAddresses($addresses);
 		$this->assertSame($expected, $result);
@@ -85,12 +85,12 @@ 
 		//test with simplest format
 		$addresses = "abc@xyz.com,xyz@abc.com";
 		$result = $email->email2ParseAddressesForAddressesOnly($addresses);
-		$this->assertEquals(array("abc@xyz.com", "xyz@abc.com"), $result );
+		$this->assertEquals(array("abc@xyz.com", "xyz@abc.com"), $result);
 
 		//test with more used format
 		$addresses = "abc<abc@xyz.com>,xyz<xyz@abc.com>";
 		$result = $email->email2ParseAddressesForAddressesOnly($addresses);
-		$this->assertEquals(array("abc@xyz.com", "xyz@abc.com"), $result );
+		$this->assertEquals(array("abc@xyz.com", "xyz@abc.com"), $result);
 		
 	}
 
@@ -102,7 +102,7 @@ 
 
 		//test without a filename
 		$result = $email->email2GetMime();
-		$this->assertEquals("application/octet-stream", $result );
+		$this->assertEquals("application/octet-stream", $result);
 		
 		//test with a filename
 		$result = $email->email2GetMime('config.php');
@@ -115,8 +115,8 @@ 
 
 		$email = new Email();
 		
-		$this->assertEquals("some text", $email->decodeDuringSend("some text") );
-		$this->assertEquals("&lt; some text &gt;", $email->decodeDuringSend("sugarLessThan some text sugarGreaterThan") );
+		$this->assertEquals("some text", $email->decodeDuringSend("some text"));
+		$this->assertEquals("&lt; some text &gt;", $email->decodeDuringSend("sugarLessThan some text sugarGreaterThan"));
 		
 	}
 
@@ -126,17 +126,17 @@ 
 		$email = new Email();
 		
 		//test with required parametr set
-		$this->assertEquals(true,  $email->isDraftEmail(array('saveDraft'=>'1')) );
+		$this->assertEquals(true, $email->isDraftEmail(array('saveDraft'=>'1')));
 		
 		
 		//test with one of required attribute set
 		$email->type = 'draft';
-		$this->assertEquals(false,  $email->isDraftEmail());
+		$this->assertEquals(false, $email->isDraftEmail());
 		
 		
 		//test with both of required attribute set
 		$email->status = 'draft';
-		$this->assertEquals(true,  $email->isDraftEmail());
+		$this->assertEquals(true, $email->isDraftEmail());
 		
 	}
 
@@ -159,7 +159,7 @@ 
     	$this->assertEquals("", $result);    	
     	
     	//test with valid array
-    	$result = $email->_arrayToDelimitedString(array('value1','value2'));
+    	$result = $email->_arrayToDelimitedString(array('value1', 'value2'));
     	$this->assertEquals("value1,value2", $result);
     	
     }
@@ -305,10 +305,10 @@ 
 		//retrieve and verify that email addresses were saved properly 
 		$email->retrieveEmailAddresses();
 		
-		$this->assertNotSame(false, strpos($email->from_addr, "from_test@email.com") );
-		$this->assertNotSame(false, strpos($email->to_addrs, "to_test@email.com") );
-		$this->assertNotSame(false, strpos($email->cc_addrs, "cc_test@email.com") );
-		$this->assertNotSame(false, strpos($email->bcc_addrs, "bcc_test@email.com") );
+		$this->assertNotSame(false, strpos($email->from_addr, "from_test@email.com"));
+		$this->assertNotSame(false, strpos($email->to_addrs, "to_test@email.com"));
+		$this->assertNotSame(false, strpos($email->cc_addrs, "cc_test@email.com"));
+		$this->assertNotSame(false, strpos($email->bcc_addrs, "bcc_test@email.com"));
 
 	}
 
@@ -368,7 +368,7 @@ 
 		$email = $email->retrieve($id);
 	
 		$email->type = 'out';
-		$email->status ='draft';
+		$email->status = 'draft';
 		$_REQUEST['record'] = $id;
 	
 		$email->handleAttachments();
@@ -385,7 +385,7 @@ 
 		$email->delete($id);
 	
 		$result = $email->retrieve($id);
-		$this->assertEquals(null,$result);
+		$this->assertEquals(null, $result);
 	
 	}	
 
@@ -398,22 +398,22 @@ 
 		$email->id = 1;
 	
 		//test saveTempNoteAttachments method to create a note for email
-		$email->saveTempNoteAttachments("test_file","test", "text/plain");
+		$email->saveTempNoteAttachments("test_file", "test", "text/plain");
 	
 	
 	
 		//test doesImportedEmailHaveAttachment method to verify note created.
 		$result = $email->doesImportedEmailHaveAttachment($email->id);
-		$this->assertEquals(1,$result);
+		$this->assertEquals(1, $result);
 	
 	
 	
 		//test getNotes method and verify that it retrieves the created note.
 		$email->getNotes($email->id);
 		$this->assertTrue(is_array($email->attachments));
-		foreach($email->attachments as $note){
+		foreach ($email->attachments as $note) {
 			$this->assertTrue(isset($note));
-			$this->assertInstanceOf('Note',$note);
+			$this->assertInstanceOf('Note', $note);
 		}
 	
 	
@@ -436,7 +436,7 @@ 
 		//test with more used format
 		$addresses = "abc<abc@xyz.com>,xyz<xyz@abc.com>";
 		$result = $email->cleanEmails($addresses);
-		$this->assertEquals('abc <abc@xyz.com>, xyz <xyz@abc.com>', $result );
+		$this->assertEquals('abc <abc@xyz.com>, xyz <xyz@abc.com>', $result);
 		
 	}
 
@@ -605,7 +605,7 @@ 
 		$email = new Email();
 		
 		$result = $email->getUserEditorPreference();
-		$this->assertEquals("html",$result);
+		$this->assertEquals("html", $result);
 		
 	}
 
@@ -618,9 +618,9 @@ 
 		$addrs_names = "abc;xyz";
 		$addrs_emails = "abc@email.com;xyz@email.com";
 		
-		$expected = array(  array ('email' => 'abc@email.com', 'display' => 'abc', 'contact_id' => '1' ), array ('email' => 'xyz@email.com', 'display' => 'xyz', 'contact_id' => '2' ) );
+		$expected = array(array('email' => 'abc@email.com', 'display' => 'abc', 'contact_id' => '1'), array('email' => 'xyz@email.com', 'display' => 'xyz', 'contact_id' => '2'));
 		
-		$actual = $email->parse_addrs($addrs , $addrs_ids, $addrs_names, $addrs_emails);
+		$actual = $email->parse_addrs($addrs, $addrs_ids, $addrs_names, $addrs_emails);
 		
 		$this->assertSame($expected, $actual);
 		
@@ -638,7 +638,7 @@ 
 		
 
 		//test for array without empty values
-		$expected = array("val1","val2");
+		$expected = array("val1", "val2");
 		$fields = array("val1", "val2");
 		$actual = $email->remove_empty_fields($fields);
 		$this->assertSame($expected, $actual);
@@ -654,12 +654,12 @@ 
 		$email->description = "some text with sign";
 		
 		//test for strings with signature present  
-		$sig = array("signature_html"=>"sign", "signature"=>"sign" );
+		$sig = array("signature_html"=>"sign", "signature"=>"sign");
 		$result = $email->hasSignatureInBody($sig);
 		$this->assertEquals(true, $result);
 
 		//test for strings with signature absent
-		$sig = array("signature_html"=>"signature", "signature"=>"signature" );
+		$sig = array("signature_html"=>"signature", "signature"=>"signature");
 		$result = $email->hasSignatureInBody($sig);
 		$this->assertEquals(false, $result);
 		
@@ -686,7 +686,7 @@ 
 		
 		//test without assigned_user_id in url
 		$url = "index.php?module=Users&offset=6&stamp=1453274421025259800&return_module=Users&action=DetailView&record=seed_max_id";
-		$expected = array (
+		$expected = array(
 				'module' => 'Users',
 				'action' => 'DetailView',
 				'group' => '',
@@ -697,13 +697,13 @@ 
 				'return_module' => 'Users',
 		);
 		$actual = $email->getStartPage($url);
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 		
 		
 		//test with assigned_user_id in url
 		$url = "index.php?module=Users&offset=6&stamp=1453274421025259800&return_module=Users&action=DetailView&record=seed_max_id&assigned_user_id=1";		
-		$expected = array (
+		$expected = array(
 				'module' => 'Users',
 				'action' => 'DetailView',
 				'group' => '',
@@ -716,7 +716,7 @@ 
 				'current_view' => 'DetailView&module=Users&assigned_user_id=1&type='
 		);
 		$actual = $email->getStartPage($url);
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 	}
 
@@ -726,10 +726,10 @@ 
 
 		$email = new Email();
 		
-		$result = $email->setMailer(new SugarPHPMailer(),'','');
+		$result = $email->setMailer(new SugarPHPMailer(), '', '');
 		
-		$this->assertInstanceOf('SugarPHPMailer',$result);
-		$this->assertInstanceOf('OutboundEmail',$result->oe);	
+		$this->assertInstanceOf('SugarPHPMailer', $result);
+		$this->assertInstanceOf('OutboundEmail', $result->oe);	
 
 	}
 
@@ -745,18 +745,18 @@ 
 		$result = $email->handleBody(new SugarPHPMailer());
 		
 		$this->assertEquals("some email description containing email text & ' \n ", $email->description);
-		$this->assertInstanceOf('SugarPHPMailer',$result);
+		$this->assertInstanceOf('SugarPHPMailer', $result);
 		
 		
 		//test with REQUEST parameters set
-		$_REQUEST['setEditor'] =1;
+		$_REQUEST['setEditor'] = 1;
 		$_REQUEST['description_html'] = "1";
 		$email->description_html = "some email description containing email text &amp; &#39; <br>&nbsp;";
 		
 		$result = $email->handleBody(new SugarPHPMailer());
 
 		$this->assertEquals("some email description containing email text & &#39; \n&nbsp;", $email->description);
-		$this->assertInstanceOf('SugarPHPMailer',$result);
+		$this->assertInstanceOf('SugarPHPMailer', $result);
 		
 	}
 
@@ -778,13 +778,13 @@ 
 
 
 	
-	public function testlistviewACLHelper(){
+	public function testlistviewACLHelper() {
 
 		$email = new Email();
 		
-		$expected = array("MAIN"=>"a", "PARENT"=>"a", "CONTACT"=>"a" );
+		$expected = array("MAIN"=>"a", "PARENT"=>"a", "CONTACT"=>"a");
 		$actual = $email->listviewACLHelper();
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 
 	}
 
@@ -792,10 +792,10 @@ 
 
 		$email = new Email();
 		
-		$expected = array( 'email' => 'do_not_reply@example.com', 'name' => 'SuiteCRM');
+		$expected = array('email' => 'do_not_reply@example.com', 'name' => 'SuiteCRM');
 		$actual = $email->getSystemDefaultEmail();
 		
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 	}
 
@@ -806,14 +806,14 @@ 
     	
     	//test with empty string params
     	$expected = "SELECT emails.*, users.user_name as assigned_user_name\n FROM emails\n LEFT JOIN users ON emails.assigned_user_id=users.id \nWHERE  emails.deleted=0 \n ORDER BY date_sent DESC";
-    	$actual = $email->create_new_list_query('','');
-    	$this->assertSame($expected,$actual);
+    	$actual = $email->create_new_list_query('', '');
+    	$this->assertSame($expected, $actual);
 
 
     	//test with valid string params
     	$expected = "SELECT emails.*, users.user_name as assigned_user_name\n FROM emails\n LEFT JOIN users ON emails.assigned_user_id=users.id \nWHERE users.user_name = \"\" AND  emails.deleted=0 \n ORDER BY emails.id";
-    	$actual = $email->create_new_list_query('emails.id','users.user_name = ""');
-    	$this->assertSame($expected,$actual);
+    	$actual = $email->create_new_list_query('emails.id', 'users.user_name = ""');
+    	$this->assertSame($expected, $actual);
     	
     } 
 
@@ -829,7 +829,7 @@ 
 		$email->fill_in_additional_list_fields();
 		
 		$this->assertEquals('DetailView', $email->link_action);
-		$this->assertEquals('', $email->attachment_image );
+		$this->assertEquals('', $email->attachment_image);
 
 		
 	}
@@ -846,7 +846,7 @@ 
 		$email->fill_in_additional_list_fields();
 		
 		$this->assertEquals('Administrator', $email->created_by_name);
-		$this->assertEquals('Administrator', $email->modified_by_name );
+		$this->assertEquals('Administrator', $email->modified_by_name);
 		$this->assertEquals('', $email->type_name);
 		$this->assertEquals('', $email->name);
 		$this->assertEquals('DetailView', $email->link_action);
@@ -862,13 +862,13 @@ 
     	 
     	//test with empty string params
     	$expected = "SELECT emails.* FROM emails where emails.deleted=0 ORDER BY emails.name";
-    	$actual = $email->create_export_query('','');
-    	$this->assertSame($expected,$actual);
+    	$actual = $email->create_export_query('', '');
+    	$this->assertSame($expected, $actual);
     	
     	//test with valid string params
     	$expected = "SELECT emails.* FROM emails where users.user_name = \"\" AND emails.deleted=0 ORDER BY emails.id";
-    	$actual = $email->create_export_query('emails.id','users.user_name = ""'); 
-    	$this->assertSame($expected,$actual);
+    	$actual = $email->create_export_query('emails.id', 'users.user_name = ""'); 
+    	$this->assertSame($expected, $actual);
     	
     }
 
@@ -883,7 +883,7 @@ 
 		$email->link_action = "DetailView";
 		$email->type_name = "out";
 				
-		$expected = array (
+		$expected = array(
 				'ID' => 1,
 				'FROM_ADDR_NAME' => 'Admin',
 				'TYPE' => 'Archived',
@@ -900,10 +900,10 @@ 
 		);
 		
 		$actual = $email->get_list_view_data();
-		foreach($expected as $expectedKey => $expectedVal){
-            if($expectedKey == 'CREATE_RELATED'){
-                $this->assertRegExp($expected[$expectedKey],$actual[$expectedKey]);
-            }else {
+		foreach ($expected as $expectedKey => $expectedVal) {
+            if ($expectedKey == 'CREATE_RELATED') {
+                $this->assertRegExp($expected[$expectedKey], $actual[$expectedKey]);
+            } else {
                 $this->assertSame($expected[$expectedKey], $actual[$expectedKey]);
             }
         }
@@ -919,7 +919,7 @@ 
             ."~";
     	
     	$actual = $email->quickCreateForm();
-    	$this->assertRegExp($expected,$actual);
+    	$this->assertRegExp($expected, $actual);
     }
 
 
@@ -940,7 +940,7 @@ 
     	
     	$expected = "SELECT emails.id , emails.mailbox_id, emails.name, emails.date_sent, emails.status, emails.type, emails.flagged, emails.reply_to_status,\n		                      emails_text.from_addr, emails_text.to_addrs  FROM emails   JOIN emails_text on emails.id = emails_text.email_id   WHERE (emails.type= 'inbound' OR emails.type='archived' OR emails.type='out') AND emails.deleted = 0 ";
     	$actual = $email->_genereateSearchImportedEmailsQuery();
-    	$this->assertSame($expected,$actual);
+    	$this->assertSame($expected, $actual);
     	    	 
     }
 
@@ -953,30 +953,30 @@ 
     	//test without request params
     	$expected = "";
     	$actual = $email->_generateSearchImportWhereClause();
-    	$this->assertSame($expected,$actual);
+    	$this->assertSame($expected, $actual);
 
     	
     	//test with searchDateFrom request param only
-    	$_REQUEST['searchDateFrom']= "2015-01-01 00:00:00";
+    	$_REQUEST['searchDateFrom'] = "2015-01-01 00:00:00";
     	$expected = "emails.date_sent >= '' ";
     	$actual = $email->_generateSearchImportWhereClause();
-    	$this->assertSame($expected,$actual);
+    	$this->assertSame($expected, $actual);
 
     	
     	//test with searchDateTo request param only
     	$_REQUEST['searchDateFrom'] = "";
-    	$_REQUEST['searchDateTo']= "2015-01-01 00:00:00";
+    	$_REQUEST['searchDateTo'] = "2015-01-01 00:00:00";
     	$expected = "emails.date_sent <= '' ";
     	$actual = $email->_generateSearchImportWhereClause();
-    	$this->assertSame($expected,$actual);
+    	$this->assertSame($expected, $actual);
     	
     	
     	//test with both request params
-    	$_REQUEST['searchDateFrom']= "2015-01-01 00:00:00";
-    	$_REQUEST['searchDateTo']= "2015-01-01 00:00:00";
+    	$_REQUEST['searchDateFrom'] = "2015-01-01 00:00:00";
+    	$_REQUEST['searchDateTo'] = "2015-01-01 00:00:00";
     	$expected = "( emails.date_sent >= '' AND\n                                          emails.date_sent <= '' )";
     	$actual = $email->_generateSearchImportWhereClause();
-    	$this->assertSame($expected,$actual);
+    	$this->assertSame($expected, $actual);
     	   
     }
 
@@ -987,7 +987,7 @@ 
 
 		$this->assertEquals("test string", $email->trimLongTo("test string")); //test without any separator
 		$this->assertEquals("test string 1...", $email->trimLongTo("test string 1, test string2")); //test with , separator
-		$this->assertEquals("test string 1...", $email->trimLongTo("test string 1; test string2"));//test with ; separator
+		$this->assertEquals("test string 1...", $email->trimLongTo("test string 1; test string2")); //test with ; separator
 		
 	}
 
@@ -996,11 +996,11 @@ 
 		$email = new Email();
 		
 		//test without setting name
-		$this->assertEquals(Null,$email->get_summary_text());
+		$this->assertEquals(Null, $email->get_summary_text());
 		
 		//test with name set
 		$email->name = "test";
-		$this->assertEquals('test',$email->get_summary_text());
+		$this->assertEquals('test', $email->get_summary_text());
 
 	}
 
@@ -1037,13 +1037,13 @@ 
 		//test with empty string
 		$expected = "<div><input	title=\"\"\n						class=\"button\"\n						type=\"button\" name=\"button\"\n						onClick=\"window.location='index.php?module=Emails&action=Check&type=';\"\n						style=\"margin-bottom:2px\"\n						value=\"    \"></div>";
 		$actual = $email->checkInbox('');
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		 
 
 		//test with valid string
 		$expected = "<div><input	title=\"\"\n						class=\"button\"\n						type=\"button\" name=\"button\"\n						onClick=\"window.location='index.php?module=Emails&action=Check&type=test';\"\n						style=\"margin-bottom:2px\"\n						value=\"    \"></div>";
 		$actual = $email->checkInbox('test');
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 						
 	}
 

tests/tests/modules/CampaignLog/CampaignLogTest.php

Spacing +7 added lines, -7 removed lines

@@ -1,15 +1,15 @@ 
 <?php
 
 
-class CampaignLogTest extends PHPUnit_Framework_TestCase  {
+class CampaignLogTest extends PHPUnit_Framework_TestCase {
 
 
     public function testCampaignLog() {
 
     	//execute the contructor and check for the Object type and  attributes
     	$campaignLog = new CampaignLog();
-    	$this->assertInstanceOf('CampaignLog',$campaignLog);
-    	$this->assertInstanceOf('SugarBean',$campaignLog);
+    	$this->assertInstanceOf('CampaignLog', $campaignLog);
+    	$this->assertInstanceOf('SugarBean', $campaignLog);
     		
     	$this->assertAttributeEquals('CampaignLog', 'module_dir', $campaignLog);
     	$this->assertAttributeEquals('CampaignLog', 'object_name', $campaignLog);
@@ -18,7 +18,7 @@ 
 
     }
 
-    public function testget_list_view_data(){
+    public function testget_list_view_data() {
 
     	error_reporting(E_ERROR | E_PARSE);
 
@@ -27,16 +27,16 @@ 
     	//execute the method and verify it returns an array
     	$actual = $campaignLog->get_list_view_data();
     	$this->assertTrue(is_array($actual));
-    	$this->assertSame(array(),$actual);
+    	$this->assertSame(array(), $actual);
     	
     }
     
 
-    public function testretrieve_email_address(){
+    public function testretrieve_email_address() {
   
     	$campaignLog = new CampaignLog();
     	$actual = $campaignLog->retrieve_email_address();
-    	$this->assertGreaterThanOrEqual("",$actual);
+    	$this->assertGreaterThanOrEqual("", $actual);
     }
 
 

tests/tests/modules/AOR_Charts/AOR_ChartTest.php

Spacing +57 added lines, -57 removed lines

@@ -3,13 +3,13 @@ 
 require_once 'modules/AOR_Charts/lib/pChart/pChart.php';
 class AOR_ChartTest extends PHPUnit_Framework_TestCase {
 	
-	public function testAOR_Chart(){
+	public function testAOR_Chart() {
 
 		//execute the contructor and check for the Object type and  attributes
 		$aorChart = new AOR_Chart();
-		$this->assertInstanceOf('AOR_Chart',$aorChart);
-		$this->assertInstanceOf('Basic',$aorChart);
-		$this->assertInstanceOf('SugarBean',$aorChart);
+		$this->assertInstanceOf('AOR_Chart', $aorChart);
+		$this->assertInstanceOf('Basic', $aorChart);
+		$this->assertInstanceOf('SugarBean', $aorChart);
 		 
 		$this->assertAttributeEquals('AOR_Charts', 'module_dir', $aorChart);
 		$this->assertAttributeEquals('AOR_Chart', 'object_name', $aorChart);
@@ -20,7 +20,7 @@ 
 	
 	}
 
-    public function testsave_lines(){
+    public function testsave_lines() {
 
     	error_reporting(E_ERROR | E_PARSE);
     	
@@ -51,75 +51,75 @@ 
     }
 
 
-    public function testbuildChartImageBar(){
+    public function testbuildChartImageBar() {
 
    	
     	$aorChart = new AOR_Chart();
     	  	
     	$chartData = new pData();
-    	$chartData->addPoints(10,'data');
-    	$chartData->addPoints(10,'Labels');
+    	$chartData->addPoints(10, 'data');
+    	$chartData->addPoints(10, 'Labels');
        	
     	 
     	//execute with recordImageMap true and verify that the chartPicture is changed
-    	$chartPicture = new pImage(700,700,$chartData);
-    	$aorChart->buildChartImageBar($chartPicture,true);
-    	$this->assertNotEquals($chartPicture, new pImage(700,700,$chartData) );
+    	$chartPicture = new pImage(700, 700, $chartData);
+    	$aorChart->buildChartImageBar($chartPicture, true);
+    	$this->assertNotEquals($chartPicture, new pImage(700, 700, $chartData));
     	
     	
     	//execute with recordImageMap false and verify that the chartPicture is changed
-    	$chartPicture = new pImage(700,700,$chartData);
-    	$aorChart->buildChartImageBar($chartPicture,false);
-    	$this->assertNotEquals($chartPicture, new pImage(700,700,$chartData) );
+    	$chartPicture = new pImage(700, 700, $chartData);
+    	$aorChart->buildChartImageBar($chartPicture, false);
+    	$this->assertNotEquals($chartPicture, new pImage(700, 700, $chartData));
 
     	unset($chartData);
     	unset($chartPicture);
     }
 
-    public function testbuildChartImagePie(){
+    public function testbuildChartImagePie() {
 
     	
     	$aorChart = new AOR_Chart();
     	
     	$chartData = new pData();
-    	$chartData->addPoints(10,'data');
-    	$chartData->addPoints(10,'Labels');
+    	$chartData->addPoints(10, 'data');
+    	$chartData->addPoints(10, 'Labels');
     	 
     		
     	//execute with recordImageMap false  and verify that the chartPicture is changed
-    	$chartPicture = new pImage(700,700,$chartData);
-    	$aorChart->buildChartImagePie($chartPicture,$chartData,array(array('x'=>10), array('x'=>20)),700, 700, 'x',false);
-    	$this->assertNotEquals($chartPicture, new pImage(700,700,$chartData) );
+    	$chartPicture = new pImage(700, 700, $chartData);
+    	$aorChart->buildChartImagePie($chartPicture, $chartData, array(array('x'=>10), array('x'=>20)), 700, 700, 'x', false);
+    	$this->assertNotEquals($chartPicture, new pImage(700, 700, $chartData));
     	
     	
     	//execute with recordImageMap true and verify that the chartPicture is changed
-    	$chartPicture = new pImage(700,700,$chartData);
-    	$aorChart->buildChartImagePie($chartPicture,$chartData,array(array('x'=>10), array('x'=>20)),700, 700, 'x',true);
-    	$this->assertNotEquals($chartPicture, new pImage(700,700,$chartData) );
+    	$chartPicture = new pImage(700, 700, $chartData);
+    	$aorChart->buildChartImagePie($chartPicture, $chartData, array(array('x'=>10), array('x'=>20)), 700, 700, 'x', true);
+    	$this->assertNotEquals($chartPicture, new pImage(700, 700, $chartData));
     	
     	unset($chartData);
     	unset($chartPicture);
     	
     }
 
-    public function testbuildChartImageLine(){
+    public function testbuildChartImageLine() {
 
     	$aorChart = new AOR_Chart();
     	
     	$chartData = new pData();
-    	$chartData->addPoints(10,'data');
-    	$chartData->addPoints(10,'Labels');
+    	$chartData->addPoints(10, 'data');
+    	$chartData->addPoints(10, 'Labels');
     	
     		 
     	//execute with recordImageMap true  and verify that the chartPicture is changed
-    	$chartPicture = new pImage(700,700,$chartData);
-    	$aorChart->buildChartImageLine($chartPicture,true);
-    	$this->assertNotEquals($chartPicture, new pImage(700,700,$chartData) );
+    	$chartPicture = new pImage(700, 700, $chartData);
+    	$aorChart->buildChartImageLine($chartPicture, true);
+    	$this->assertNotEquals($chartPicture, new pImage(700, 700, $chartData));
     	 
     	//execute with recordImageMap false  and verify that the chartPicture is changed
-    	$chartPicture = new pImage(700,700,$chartData);
-    	$aorChart->buildChartImageLine($chartPicture,false);
-    	$this->assertNotEquals($chartPicture, new pImage(700,700,$chartData) );
+    	$chartPicture = new pImage(700, 700, $chartData);
+    	$aorChart->buildChartImageLine($chartPicture, false);
+    	$this->assertNotEquals($chartPicture, new pImage(700, 700, $chartData));
     	 
     	
     	unset($chartData);
@@ -127,7 +127,7 @@ 
     	
     }
 
-    public function testbuildChartImageRadar(){
+    public function testbuildChartImageRadar() {
 
     	
     	$aorChart = new AOR_Chart();
@@ -135,12 +135,12 @@ 
     	//preset the required objects and properties
     	$chartData = new pData();
     	$chartData->loadPalette("modules/AOR_Charts/lib/pChart/palettes/navy.color", TRUE);
-    	$chartData->addPoints(10,'data');
-    	$chartData->addPoints('10','Labels');
-    	$chartData->addPoints(120,'data');
-    	$chartData->addPoints('120','Labels');
+    	$chartData->addPoints(10, 'data');
+    	$chartData->addPoints('10', 'Labels');
+    	$chartData->addPoints(120, 'data');
+    	$chartData->addPoints('120', 'Labels');
    
-    	$chartData->setSerieDescription("Months","Month");
+    	$chartData->setSerieDescription("Months", "Month");
     	$chartData->setAbscissa("Labels");
     	 
     	$imageWidth = 700;
@@ -148,18 +148,18 @@ 
     	
     	
     	//execute with recordImageMap true and verify that the chartPicture is changed
-    	$chartPicture = new pImage($imageWidth,$imageHeight,$chartData);
-    	$chartPicture->setGraphArea(60,60,$imageWidth-60,$imageHeight-100);
-    	$aorChart->buildChartImageRadar($chartPicture,$chartData,true);
-    	$this->assertNotEquals($chartPicture, new pImage(700,700,$chartData) );
+    	$chartPicture = new pImage($imageWidth, $imageHeight, $chartData);
+    	$chartPicture->setGraphArea(60, 60, $imageWidth - 60, $imageHeight - 100);
+    	$aorChart->buildChartImageRadar($chartPicture, $chartData, true);
+    	$this->assertNotEquals($chartPicture, new pImage(700, 700, $chartData));
     	
     	
     	
     	//execute with recordImageMap false and verify that the chartPicture is changed
-    	$chartPicture = new pImage(700,700,$chartData);
-    	$chartPicture->setGraphArea(60,60,$imageWidth-60,$imageHeight-100);
-    	$aorChart->buildChartImageRadar($chartPicture,$chartData,false);
-    	$this->assertNotEquals($chartPicture, new pImage(700,700,$chartData) );
+    	$chartPicture = new pImage(700, 700, $chartData);
+    	$chartPicture->setGraphArea(60, 60, $imageWidth - 60, $imageHeight - 100);
+    	$aorChart->buildChartImageRadar($chartPicture, $chartData, false);
+    	$this->assertNotEquals($chartPicture, new pImage(700, 700, $chartData));
     	
 
     	unset($chartData);
@@ -167,7 +167,7 @@ 
     	
     }
 
-    public function testbuildChartImage(){
+    public function testbuildChartImage() {
 
         $this->markTestSkipped("Skipping testing chart image");
 
@@ -186,35 +186,35 @@ 
     	$fields['x'] = json_decode('{"label": "x"}'); 
     	$fields['y'] = json_decode('{"label": "y"}'); 
 
-    	$reportData = array(array('xx'=>10,'yy'=>10), array('xx'=>20, 'yy'=>20));
+    	$reportData = array(array('xx'=>10, 'yy'=>10), array('xx'=>20, 'yy'=>20));
 
     	//execute the method and verify it returns expected results
     	$aorChart->type = 'bar';
     	$result = $aorChart->buildChartImage($reportData, $fields);
-    	$this->assertEquals('data:image/png;base64,',$result);
+    	$this->assertEquals('data:image/png;base64,', $result);
     	
     	
     	//execute the method and verify it returns expected results
     	$aorChart->type = 'Line';
     	$result = $aorChart->buildChartImage($reportData, $fields);
-    	$this->assertEquals('',$result);
+    	$this->assertEquals('', $result);
     	
     	
     	//execute the method and verify it returns expected results
     	$aorChart->type = 'pie';
     	$result = $aorChart->buildChartImage($reportData, $fields);
-    	$this->assertEquals('data:image/png;base64,',$result);
+    	$this->assertEquals('data:image/png;base64,', $result);
     	
     	
     	//execute the method and verify it returns expected results
     	$aorChart->type = 'radar';
-    	$result = $aorChart->buildChartImage($reportData, $fields,true);
-		$this->assertEquals('data:image/png;base64,',$result);
+    	$result = $aorChart->buildChartImage($reportData, $fields, true);
+		$this->assertEquals('data:image/png;base64,', $result);
  
     	 
     }
 
-    public function testbuildChartHTML(){
+    public function testbuildChartHTML() {
         $this->markTestSkipped("Skipping testing chart HTML");
     	$aorChart = new AOR_Chart();
 
@@ -226,7 +226,7 @@ 
     	$fields['x'] = json_decode('{"label": "x"}');
     	$fields['y'] = json_decode('{"label": "y"}');
     	
-    	$reportData = array(array('xx'=>10,'yy'=>10), array('xx'=>20, 'yy'=>20));
+    	$reportData = array(array('xx'=>10, 'yy'=>10), array('xx'=>20, 'yy'=>20));
    
     	$aorChart->type = 'bar';
 
@@ -236,8 +236,8 @@ 
     	$this->assertSame($expected, $result);
     	
     	//test with type CHART_TYPE_CHARTJS verify it returns expected results
-    	$expected = "<h3></h3><canvas id='chart' width='400' height='400'></canvas>        <script>\n        \$(document).ready(function(){\n            SUGAR.util.doWhen(\"typeof Chart != 'undefined'\", function(){\n                var data = {\"labels\":[\"10 [a]\",\"20 [e]\"],\"datasets\":[{\"fillColor\":\"rgba(151,187,205,0.2)\",\"strokeColor\":\"rgba(151,187,205,1)\",\"pointColor\":\"rgba(151,187,205,1)\",\"pointStrokeColor\":\"#fff\",\"pointHighlightFill\":\"#fff\",\"pointHighlightStroke\":\"rgba(151,187,205,1)4\",\"data\":[10,20]}]};\n                var ctx = document.getElementById(\"chart\").getContext(\"2d\");\n                console.log('Creating new chart');\n                var config = [];\n                var chart = new Chart(ctx).Bar(data, config);\n                var legend = chart.generateLegend();\n                $('#chart').after(legend);\n            });\n        });\n        </script>" ;    	
-    	$result = $aorChart->buildChartHTML($reportData, $fields,0, AOR_Report::CHART_TYPE_CHARTJS);    	
+    	$expected = "<h3></h3><canvas id='chart' width='400' height='400'></canvas>        <script>\n        \$(document).ready(function(){\n            SUGAR.util.doWhen(\"typeof Chart != 'undefined'\", function(){\n                var data = {\"labels\":[\"10 [a]\",\"20 [e]\"],\"datasets\":[{\"fillColor\":\"rgba(151,187,205,0.2)\",\"strokeColor\":\"rgba(151,187,205,1)\",\"pointColor\":\"rgba(151,187,205,1)\",\"pointStrokeColor\":\"#fff\",\"pointHighlightFill\":\"#fff\",\"pointHighlightStroke\":\"rgba(151,187,205,1)4\",\"data\":[10,20]}]};\n                var ctx = document.getElementById(\"chart\").getContext(\"2d\");\n                console.log('Creating new chart');\n                var config = [];\n                var chart = new Chart(ctx).Bar(data, config);\n                var legend = chart.generateLegend();\n                $('#chart').after(legend);\n            });\n        });\n        </script>";    	
+    	$result = $aorChart->buildChartHTML($reportData, $fields, 0, AOR_Report::CHART_TYPE_CHARTJS);    	
     	$this->assertSame($expected, $result);
     	 
 

tests/tests/modules/Relationships/RelationshipTest.php

Spacing +8 added lines, -8 removed lines

@@ -10,8 +10,8 @@ 
 		//execute the contructor and check for the Object type and  attributes
 		$relationship = new Relationship();
 		
-		$this->assertInstanceOf('Relationship',$relationship);
-		$this->assertInstanceOf('SugarBean',$relationship);
+		$this->assertInstanceOf('Relationship', $relationship);
+		$this->assertInstanceOf('SugarBean', $relationship);
 			
 		$this->assertAttributeEquals('Relationships', 'module_dir', $relationship);
 		$this->assertAttributeEquals('Relationship', 'object_name', $relationship);
@@ -102,7 +102,7 @@ 
 	}
 
 
-	public function testget_other_module(){
+	public function testget_other_module() {
 
 		//unset and reconnect Db to resolve mysqli fetch exeception
 		global $db;
@@ -116,12 +116,12 @@ 
 		$this->assertEquals(false, $result);
 		
 		//test with valid relationship
-		$result = $relationship->get_other_module("roles_users", "Roles",$db);
+		$result = $relationship->get_other_module("roles_users", "Roles", $db);
 		$this->assertEquals("Users", $result);		
 
 	}
 
-	public function testretrieve_by_sides(){
+	public function testretrieve_by_sides() {
 
 		//unset and reconnect Db to resolve mysqli fetch exeception
 		global $db;
@@ -149,7 +149,7 @@ 
 		
 	}
 
-	public function testretrieve_by_modules(){
+	public function testretrieve_by_modules() {
 
 		//unset and reconnect Db to resolve mysqli fetch exeception
 		global $db;
@@ -268,7 +268,7 @@ 
 	}
 
 
-	public function testtrace_relationship_module(){
+	public function testtrace_relationship_module() {
 
 		//unset and reconnect Db to resolve mysqli fetch exeception
 		global $db;
@@ -277,7 +277,7 @@ 
 		
 		$relationship = new Relationship();
 		$result = $relationship->trace_relationship_module("Roles", "Users");
-		$this->assertInstanceOf('User',$result);
+		$this->assertInstanceOf('User', $result);
 		
 	}