adamjakab / SuiteCRM

tests/tests/modules/SecurityGroups/SecurityGroupTest.php

Indentation +312 added lines, -312 removed lines

@@ -4,320 +4,320 @@ 
 class SecurityGroupTest extends PHPUnit_Framework_TestCase {
 
 
-	public function testSecurityGroup(){
+    public function testSecurityGroup(){
 
-		//execute the contructor and check for the Object type and  attributes
-		$securityGroup = new SecurityGroup();
+        //execute the contructor and check for the Object type and  attributes
+        $securityGroup = new SecurityGroup();
 		
-		$this->assertInstanceOf('SecurityGroup',$securityGroup);
-		$this->assertInstanceOf('Basic',$securityGroup);
-		$this->assertInstanceOf('SugarBean',$securityGroup);
+        $this->assertInstanceOf('SecurityGroup',$securityGroup);
+        $this->assertInstanceOf('Basic',$securityGroup);
+        $this->assertInstanceOf('SugarBean',$securityGroup);
 			
-		$this->assertAttributeEquals('securitygroups', 'table_name', $securityGroup);
-		$this->assertAttributeEquals('SecurityGroups', 'module_dir', $securityGroup);
-		$this->assertAttributeEquals('SecurityGroup', 'object_name', $securityGroup);
+        $this->assertAttributeEquals('securitygroups', 'table_name', $securityGroup);
+        $this->assertAttributeEquals('SecurityGroups', 'module_dir', $securityGroup);
+        $this->assertAttributeEquals('SecurityGroup', 'object_name', $securityGroup);
 		
-	}
+    }
 
 
-	public function testgetGroupWhere()
-	{
-		error_reporting(E_ERROR | E_PARSE);
+    public function testgetGroupWhere()
+    {
+        error_reporting(E_ERROR | E_PARSE);
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		//test with securitygroups module
-		$expected = " securitygroups.id in (\n                select secg.id from securitygroups secg\n                inner join securitygroups_users secu on secg.id = secu.securitygroup_id and secu.deleted = 0\n                    and secu.user_id = '1'\n                where secg.deleted = 0\n            )";
-		$actual = $securityGroup->getGroupWhere("securitygroups","SecurityGroups",1);
-		$this->assertSame($expected,$actual);
+        //test with securitygroups module
+        $expected = " securitygroups.id in (\n                select secg.id from securitygroups secg\n                inner join securitygroups_users secu on secg.id = secu.securitygroup_id and secu.deleted = 0\n                    and secu.user_id = '1'\n                where secg.deleted = 0\n            )";
+        $actual = $securityGroup->getGroupWhere("securitygroups","SecurityGroups",1);
+        $this->assertSame($expected,$actual);
 		
 		
-		//test with //test with securitygroups module module
-		$expected = " EXISTS (SELECT  1\n                  FROM    securitygroups secg\n                          INNER JOIN securitygroups_users secu \n                            ON secg.id = secu.securitygroup_id \n                               AND secu.deleted = 0 \n                               AND secu.user_id = '1'\n                          INNER JOIN securitygroups_records secr \n                            ON secg.id = secr.securitygroup_id \n                               AND secr.deleted = 0 \n                               AND secr.module = 'Users'\n                       WHERE   secr.record_id = users.id\n                               AND secg.deleted = 0) ";
-		$actual = $securityGroup->getGroupWhere("users","Users",1);
-		$this->assertSame($expected,$actual);
+        //test with //test with securitygroups module module
+        $expected = " EXISTS (SELECT  1\n                  FROM    securitygroups secg\n                          INNER JOIN securitygroups_users secu \n                            ON secg.id = secu.securitygroup_id \n                               AND secu.deleted = 0 \n                               AND secu.user_id = '1'\n                          INNER JOIN securitygroups_records secr \n                            ON secg.id = secr.securitygroup_id \n                               AND secr.deleted = 0 \n                               AND secr.module = 'Users'\n                       WHERE   secr.record_id = users.id\n                               AND secg.deleted = 0) ";
+        $actual = $securityGroup->getGroupWhere("users","Users",1);
+        $this->assertSame($expected,$actual);
 				
-	}
+    }
 
-	public function testgetGroupUsersWhere()
-	{
-		$securityGroup = new SecurityGroup();
+    public function testgetGroupUsersWhere()
+    {
+        $securityGroup = new SecurityGroup();
 		
-		$expected = " users.id in (\n            select sec.user_id from securitygroups_users sec\n            inner join securitygroups_users secu on sec.securitygroup_id = secu.securitygroup_id and secu.deleted = 0\n                and secu.user_id = '1'\n            where sec.deleted = 0\n        )";
-		$actual = $securityGroup->getGroupUsersWhere(1);
+        $expected = " users.id in (\n            select sec.user_id from securitygroups_users sec\n            inner join securitygroups_users secu on sec.securitygroup_id = secu.securitygroup_id and secu.deleted = 0\n                and secu.user_id = '1'\n            where sec.deleted = 0\n        )";
+        $actual = $securityGroup->getGroupUsersWhere(1);
 	
-		$this->assertSame($expected,$actual);
+        $this->assertSame($expected,$actual);
 		
-	}
+    }
 
-	public function testgetGroupJoin()
-	{
+    public function testgetGroupJoin()
+    {
 
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		//test with securitygroups module
-		$expected = " LEFT JOIN (select distinct secg.id from securitygroups secg\n    inner join securitygroups_users secu on secg.id = secu.securitygroup_id and secu.deleted = 0\n            and secu.user_id = '1'\n    where secg.deleted = 0\n) securitygroup_join on securitygroup_join.id = securitygroups.id ";
-		$actual = $securityGroup->getGroupJoin("securitygroups","SecurityGroups",1);
-		$this->assertSame($expected,$actual);
+        //test with securitygroups module
+        $expected = " LEFT JOIN (select distinct secg.id from securitygroups secg\n    inner join securitygroups_users secu on secg.id = secu.securitygroup_id and secu.deleted = 0\n            and secu.user_id = '1'\n    where secg.deleted = 0\n) securitygroup_join on securitygroup_join.id = securitygroups.id ";
+        $actual = $securityGroup->getGroupJoin("securitygroups","SecurityGroups",1);
+        $this->assertSame($expected,$actual);
 		
 		
-		//test with //test with securitygroups module
-		$expected = " LEFT JOIN (select distinct secr.record_id as id from securitygroups secg\n    inner join securitygroups_users secu on secg.id = secu.securitygroup_id and secu.deleted = 0\n            and secu.user_id = '1'\n    inner join securitygroups_records secr on secg.id = secr.securitygroup_id and secr.deleted = 0\n             and secr.module = 'Users'\n    where secg.deleted = 0\n) securitygroup_join on securitygroup_join.id = users.id ";
-		$actual = $securityGroup->getGroupJoin("users","Users",1);
-		$this->assertSame($expected,$actual);
+        //test with //test with securitygroups module
+        $expected = " LEFT JOIN (select distinct secr.record_id as id from securitygroups secg\n    inner join securitygroups_users secu on secg.id = secu.securitygroup_id and secu.deleted = 0\n            and secu.user_id = '1'\n    inner join securitygroups_records secr on secg.id = secr.securitygroup_id and secr.deleted = 0\n             and secr.module = 'Users'\n    where secg.deleted = 0\n) securitygroup_join on securitygroup_join.id = users.id ";
+        $actual = $securityGroup->getGroupJoin("users","Users",1);
+        $this->assertSame($expected,$actual);
 				
-	}
+    }
 
 
-	public function testgetGroupUsersJoin()
-	{
+    public function testgetGroupUsersJoin()
+    {
 
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		$expected = " LEFT JOIN (\n            select distinct sec.user_id as id from securitygroups_users sec\n            inner join securitygroups_users secu on sec.securitygroup_id = secu.securitygroup_id and secu.deleted = 0\n                and secu.user_id = '1'\n            where sec.deleted = 0\n        ) securitygroup_join on securitygroup_join.id = users.id ";
-		$actual = $securityGroup->getGroupUsersJoin(1);
-		$this->assertSame($expected,$actual);
+        $expected = " LEFT JOIN (\n            select distinct sec.user_id as id from securitygroups_users sec\n            inner join securitygroups_users secu on sec.securitygroup_id = secu.securitygroup_id and secu.deleted = 0\n                and secu.user_id = '1'\n            where sec.deleted = 0\n        ) securitygroup_join on securitygroup_join.id = users.id ";
+        $actual = $securityGroup->getGroupUsersJoin(1);
+        $this->assertSame($expected,$actual);
 
-	}
+    }
 
 
-	public function testgroupHasAccess()
-	{
+    public function testgroupHasAccess()
+    {
 		
-		//test for listview
-		$result = SecurityGroup::groupHasAccess('', '[SELECT_ID_LIST]');
-		$this->assertEquals(True,$result);
+        //test for listview
+        $result = SecurityGroup::groupHasAccess('', '[SELECT_ID_LIST]');
+        $this->assertEquals(True,$result);
 		
 		
-		//test with invalid values
-		$result = SecurityGroup::groupHasAccess('', '');
-		$this->assertEquals(false,$result);
+        //test with invalid values
+        $result = SecurityGroup::groupHasAccess('', '');
+        $this->assertEquals(false,$result);
 		
 		
-		//test with valid values
-		$result = SecurityGroup::groupHasAccess('Users', '1');
-		$this->assertEquals(false,$result);
+        //test with valid values
+        $result = SecurityGroup::groupHasAccess('Users', '1');
+        $this->assertEquals(false,$result);
 				
-	}
+    }
 
-	public function testinherit()
-	{
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+    public function testinherit()
+    {
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$account = new Account();
-		$account->id = 1;
+        $account = new Account();
+        $account->id = 1;
 
-		$_REQUEST['subpanel_field_name'] = "id";
+        $_REQUEST['subpanel_field_name'] = "id";
 			
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			SecurityGroup::inherit($account,false);
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
-		
-	}
-
-	public function testassign_default_groups()
-	{
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            SecurityGroup::inherit($account,false);
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
+		
+    }
+
+    public function testassign_default_groups()
+    {
 	
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
-		
-		$account = new Account();
-		$account->id = 1;
-		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			SecurityGroup::assign_default_groups($account,false);
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
-		
-	}
-
-	public function testinherit_creator()
-	{
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
+		
+        $account = new Account();
+        $account->id = 1;
+		
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            SecurityGroup::assign_default_groups($account,false);
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
+		
+    }
+
+    public function testinherit_creator()
+    {
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$account = new Account();
-		$account->id = 1;
-		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			SecurityGroup::inherit_creator($account,false);
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        $account = new Account();
+        $account->id = 1;
+		
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            SecurityGroup::inherit_creator($account,false);
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-	}
+    }
 
-	public function testinherit_assigned()
-	{
+    public function testinherit_assigned()
+    {
 
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$account = new Account();
-		$account->id = 1;
-		$account->assigned_user_id = 1;
+        $account = new Account();
+        $account->id = 1;
+        $account->assigned_user_id = 1;
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			SecurityGroup::inherit_assigned($account,false);
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            SecurityGroup::inherit_assigned($account,false);
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-	}
+    }
 
-	public function testinherit_parent()
-	{
+    public function testinherit_parent()
+    {
 
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$account = new Account();
-		$account->id = 1;
+        $account = new Account();
+        $account->id = 1;
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			SecurityGroup::inherit_parent($account,false);
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            SecurityGroup::inherit_parent($account,false);
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
 		
-	}
+    }
 
-	public function testinherit_parentQuery() 
-	{
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+    public function testinherit_parentQuery() 
+    {
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$account = new Account();
-		$account->id = 1;
+        $account = new Account();
+        $account->id = 1;
 
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			SecurityGroup::inherit_parentQuery($account, "Accounts", 1, 1 , $account->module_dir);
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            SecurityGroup::inherit_parentQuery($account, "Accounts", 1, 1 , $account->module_dir);
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-	}
+    }
 
 
-	public function testinheritOne() {
+    public function testinheritOne() {
 
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		$result = $securityGroup->inheritOne(1, 1, "Accounts");
-		$this->assertEquals(false, $result);
+        $result = $securityGroup->inheritOne(1, 1, "Accounts");
+        $this->assertEquals(false, $result);
 		
-	}
+    }
 
 
-	public function testgetMembershipCount() {
+    public function testgetMembershipCount() {
 
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		$result = $securityGroup->getMembershipCount("1");
-		$this->assertEquals(0, $result);
+        $result = $securityGroup->getMembershipCount("1");
+        $this->assertEquals(0, $result);
 			
-	}
+    }
 
 	
-	public function testSaveAndRetrieveAndRemoveDefaultGroups() {
+    public function testSaveAndRetrieveAndRemoveDefaultGroups() {
 
 
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		//create a security group first
-		$securityGroup->name = "test";
-		$securityGroup->save();
+        //create a security group first
+        $securityGroup->name = "test";
+        $securityGroup->save();
 		
 	
-		//execute saveDefaultGroup method
-		$securityGroup->saveDefaultGroup($securityGroup->id, "test_module");
+        //execute saveDefaultGroup method
+        $securityGroup->saveDefaultGroup($securityGroup->id, "test_module");
 		
-		//execute retrieveDefaultGroups method
-		$result = $securityGroup->retrieveDefaultGroups();
+        //execute retrieveDefaultGroups method
+        $result = $securityGroup->retrieveDefaultGroups();
 		
-		//verify that default group is created
-		$this->assertTrue(is_array($result));
-		$this->assertGreaterThan(0, count($result));
+        //verify that default group is created
+        $this->assertTrue(is_array($result));
+        $this->assertGreaterThan(0, count($result));
 
 		
-		//execute removeDefaultGroup method for each default group			
-		foreach($result as $key=>$value){			
-			$securityGroup->removeDefaultGroup($key);
-		}
+        //execute removeDefaultGroup method for each default group			
+        foreach($result as $key=>$value){			
+            $securityGroup->removeDefaultGroup($key);
+        }
 		
 		
-		//retrieve back and verify that default securith groups are deleted 
-		$result = $securityGroup->retrieveDefaultGroups();
-		$this->assertEquals(0, count($result));
+        //retrieve back and verify that default securith groups are deleted 
+        $result = $securityGroup->retrieveDefaultGroups();
+        $this->assertEquals(0, count($result));
 		
 		
-		//delete the security group as well for cleanup
-		$securityGroup->mark_deleted($securityGroup->id);
+        //delete the security group as well for cleanup
+        $securityGroup->mark_deleted($securityGroup->id);
 		
 
-	}
+    }
 
 
-	public function testgetSecurityModules() {
+    public function testgetSecurityModules() {
 
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 			
-		$expected = array (
+        $expected = array (
             'Meetings',
             'Cases',
             'AOS_Products',
@@ -352,142 +352,142 @@ 
             'ACLRoles',
             'jjwg_Maps',
             'AOS_Product_Categories',
-				);
+                );
 		
 		
-		$actual = $securityGroup->getSecurityModules();
+        $actual = $securityGroup->getSecurityModules();
         $actualKeys = array_keys($actual);
         sort($expected);
         sort($actualKeys);
-		$this->assertSame($expected,$actualKeys);
+        $this->assertSame($expected,$actualKeys);
 		
-	}
+    }
 
 
-	public function testgetLinkName() {
+    public function testgetLinkName() {
 		
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		$result = $securityGroup->getLinkName("Accounts","Contacts");
-		$this->assertEquals("contacts",$result);
+        $result = $securityGroup->getLinkName("Accounts","Contacts");
+        $this->assertEquals("contacts",$result);
 		
 		
-		$result = $securityGroup->getLinkName("SecurityGroups","ACLRoles");
-		$this->assertEquals("aclroles",$result);
+        $result = $securityGroup->getLinkName("SecurityGroups","ACLRoles");
+        $this->assertEquals("aclroles",$result);
 		
-		error_reporting(E_ALL);
-		//error_reporting(E_ERROR | E_PARSE);
-	}
+        error_reporting(E_ALL);
+        //error_reporting(E_ERROR | E_PARSE);
+    }
 
 
-	public function testaddGroupToRecord() 
-	{
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+    public function testaddGroupToRecord() 
+    {
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$securityGroup->addGroupToRecord("Accounts", 1, 1);
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $securityGroup->addGroupToRecord("Accounts", 1, 1);
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-	}
+    }
 
 
-	public function testremoveGroupFromRecord() 
-	{
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+    public function testremoveGroupFromRecord() 
+    {
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$securityGroup->removeGroupFromRecord("Accounts", 1, 1);
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $securityGroup->removeGroupFromRecord("Accounts", 1, 1);
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-	}
+    }
 
 
-	public function testgetUserSecurityGroups()
-	{
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+    public function testgetUserSecurityGroups()
+    {
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		$result = $securityGroup->getUserSecurityGroups("1");
+        $result = $securityGroup->getUserSecurityGroups("1");
 		
-		$this->assertTrue(is_array($result));
+        $this->assertTrue(is_array($result));
 		
-	}
+    }
 
-	public function testgetAllSecurityGroups()
-	{
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+    public function testgetAllSecurityGroups()
+    {
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		$result = $securityGroup->getAllSecurityGroups();
+        $result = $securityGroup->getAllSecurityGroups();
 		
-		$this->assertTrue(is_array($result));
+        $this->assertTrue(is_array($result));
 		
-	}
+    }
 
-	public function testgetMembers()
-	{
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+    public function testgetMembers()
+    {
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		$result = $securityGroup->getMembers();
+        $result = $securityGroup->getMembers();
 		
-		$this->assertTrue(is_array($result));
+        $this->assertTrue(is_array($result));
 		
-	}
+    }
 
 
-	public function testgetPrimaryGroupID()
-	{
-		//unset and reconnect Db to resolve mysqli fetch exeception
-		global $db;
-		unset ($db->database);
-		$db->checkConnection();
+    public function testgetPrimaryGroupID()
+    {
+        //unset and reconnect Db to resolve mysqli fetch exeception
+        global $db;
+        unset ($db->database);
+        $db->checkConnection();
 		
-		$securityGroup = new SecurityGroup();
+        $securityGroup = new SecurityGroup();
 		
-		$result = $securityGroup->getPrimaryGroupID();
+        $result = $securityGroup->getPrimaryGroupID();
 		
-		$this->assertEquals(null, $result);
+        $this->assertEquals(null, $result);
 		
-	}
+    }
 
 }
 ?>
\ No newline at end of file

Spacing +30 added lines, -30 removed lines

@@ -4,14 +4,14 @@ 
 class SecurityGroupTest extends PHPUnit_Framework_TestCase {
 
 
-	public function testSecurityGroup(){
+	public function testSecurityGroup() {
 
 		//execute the contructor and check for the Object type and  attributes
 		$securityGroup = new SecurityGroup();
 		
-		$this->assertInstanceOf('SecurityGroup',$securityGroup);
-		$this->assertInstanceOf('Basic',$securityGroup);
-		$this->assertInstanceOf('SugarBean',$securityGroup);
+		$this->assertInstanceOf('SecurityGroup', $securityGroup);
+		$this->assertInstanceOf('Basic', $securityGroup);
+		$this->assertInstanceOf('SugarBean', $securityGroup);
 			
 		$this->assertAttributeEquals('securitygroups', 'table_name', $securityGroup);
 		$this->assertAttributeEquals('SecurityGroups', 'module_dir', $securityGroup);
@@ -28,14 +28,14 @@ 
 		
 		//test with securitygroups module
 		$expected = " securitygroups.id in (\n                select secg.id from securitygroups secg\n                inner join securitygroups_users secu on secg.id = secu.securitygroup_id and secu.deleted = 0\n                    and secu.user_id = '1'\n                where secg.deleted = 0\n            )";
-		$actual = $securityGroup->getGroupWhere("securitygroups","SecurityGroups",1);
-		$this->assertSame($expected,$actual);
+		$actual = $securityGroup->getGroupWhere("securitygroups", "SecurityGroups", 1);
+		$this->assertSame($expected, $actual);
 		
 		
 		//test with //test with securitygroups module module
 		$expected = " EXISTS (SELECT  1\n                  FROM    securitygroups secg\n                          INNER JOIN securitygroups_users secu \n                            ON secg.id = secu.securitygroup_id \n                               AND secu.deleted = 0 \n                               AND secu.user_id = '1'\n                          INNER JOIN securitygroups_records secr \n                            ON secg.id = secr.securitygroup_id \n                               AND secr.deleted = 0 \n                               AND secr.module = 'Users'\n                       WHERE   secr.record_id = users.id\n                               AND secg.deleted = 0) ";
-		$actual = $securityGroup->getGroupWhere("users","Users",1);
-		$this->assertSame($expected,$actual);
+		$actual = $securityGroup->getGroupWhere("users", "Users", 1);
+		$this->assertSame($expected, $actual);
 				
 	}
 
@@ -46,7 +46,7 @@ 
 		$expected = " users.id in (\n            select sec.user_id from securitygroups_users sec\n            inner join securitygroups_users secu on sec.securitygroup_id = secu.securitygroup_id and secu.deleted = 0\n                and secu.user_id = '1'\n            where sec.deleted = 0\n        )";
 		$actual = $securityGroup->getGroupUsersWhere(1);
 	
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 	}
 
@@ -57,14 +57,14 @@ 
 		
 		//test with securitygroups module
 		$expected = " LEFT JOIN (select distinct secg.id from securitygroups secg\n    inner join securitygroups_users secu on secg.id = secu.securitygroup_id and secu.deleted = 0\n            and secu.user_id = '1'\n    where secg.deleted = 0\n) securitygroup_join on securitygroup_join.id = securitygroups.id ";
-		$actual = $securityGroup->getGroupJoin("securitygroups","SecurityGroups",1);
-		$this->assertSame($expected,$actual);
+		$actual = $securityGroup->getGroupJoin("securitygroups", "SecurityGroups", 1);
+		$this->assertSame($expected, $actual);
 		
 		
 		//test with //test with securitygroups module
 		$expected = " LEFT JOIN (select distinct secr.record_id as id from securitygroups secg\n    inner join securitygroups_users secu on secg.id = secu.securitygroup_id and secu.deleted = 0\n            and secu.user_id = '1'\n    inner join securitygroups_records secr on secg.id = secr.securitygroup_id and secr.deleted = 0\n             and secr.module = 'Users'\n    where secg.deleted = 0\n) securitygroup_join on securitygroup_join.id = users.id ";
-		$actual = $securityGroup->getGroupJoin("users","Users",1);
-		$this->assertSame($expected,$actual);
+		$actual = $securityGroup->getGroupJoin("users", "Users", 1);
+		$this->assertSame($expected, $actual);
 				
 	}
 
@@ -76,7 +76,7 @@ 
 		
 		$expected = " LEFT JOIN (\n            select distinct sec.user_id as id from securitygroups_users sec\n            inner join securitygroups_users secu on sec.securitygroup_id = secu.securitygroup_id and secu.deleted = 0\n                and secu.user_id = '1'\n            where sec.deleted = 0\n        ) securitygroup_join on securitygroup_join.id = users.id ";
 		$actual = $securityGroup->getGroupUsersJoin(1);
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 
 	}
 
@@ -86,17 +86,17 @@ 
 		
 		//test for listview
 		$result = SecurityGroup::groupHasAccess('', '[SELECT_ID_LIST]');
-		$this->assertEquals(True,$result);
+		$this->assertEquals(True, $result);
 		
 		
 		//test with invalid values
 		$result = SecurityGroup::groupHasAccess('', '');
-		$this->assertEquals(false,$result);
+		$this->assertEquals(false, $result);
 		
 		
 		//test with valid values
 		$result = SecurityGroup::groupHasAccess('Users', '1');
-		$this->assertEquals(false,$result);
+		$this->assertEquals(false, $result);
 				
 	}
 
@@ -114,7 +114,7 @@ 
 			
 		//execute the method and test if it works and does not throws an exception.
 		try {
-			SecurityGroup::inherit($account,false);
+			SecurityGroup::inherit($account, false);
 			$this->assertTrue(true);
 		}
 		catch (Exception $e) {
@@ -136,7 +136,7 @@ 
 		
 		//execute the method and test if it works and does not throws an exception.
 		try {
-			SecurityGroup::assign_default_groups($account,false);
+			SecurityGroup::assign_default_groups($account, false);
 			$this->assertTrue(true);
 		}
 		catch (Exception $e) {
@@ -157,7 +157,7 @@ 
 		
 		//execute the method and test if it works and does not throws an exception.
 		try {
-			SecurityGroup::inherit_creator($account,false);
+			SecurityGroup::inherit_creator($account, false);
 			$this->assertTrue(true);
 		}
 		catch (Exception $e) {
@@ -180,7 +180,7 @@ 
 		
 		//execute the method and test if it works and does not throws an exception.
 		try {
-			SecurityGroup::inherit_assigned($account,false);
+			SecurityGroup::inherit_assigned($account, false);
 			$this->assertTrue(true);
 		}
 		catch (Exception $e) {
@@ -202,7 +202,7 @@ 
 		
 		//execute the method and test if it works and does not throws an exception.
 		try {
-			SecurityGroup::inherit_parent($account,false);
+			SecurityGroup::inherit_parent($account, false);
 			$this->assertTrue(true);
 		}
 		catch (Exception $e) {
@@ -224,7 +224,7 @@ 
 
 		//execute the method and test if it works and does not throws an exception.
 		try {
-			SecurityGroup::inherit_parentQuery($account, "Accounts", 1, 1 , $account->module_dir);
+			SecurityGroup::inherit_parentQuery($account, "Accounts", 1, 1, $account->module_dir);
 			$this->assertTrue(true);
 		}
 		catch (Exception $e) {
@@ -291,7 +291,7 @@ 
 
 		
 		//execute removeDefaultGroup method for each default group			
-		foreach($result as $key=>$value){			
+		foreach ($result as $key=>$value) {			
 			$securityGroup->removeDefaultGroup($key);
 		}
 		
@@ -317,7 +317,7 @@ 
 		
 		$securityGroup = new SecurityGroup();
 			
-		$expected = array (
+		$expected = array(
             'Meetings',
             'Cases',
             'AOS_Products',
@@ -359,7 +359,7 @@ 
         $actualKeys = array_keys($actual);
         sort($expected);
         sort($actualKeys);
-		$this->assertSame($expected,$actualKeys);
+		$this->assertSame($expected, $actualKeys);
 		
 	}
 
@@ -374,12 +374,12 @@ 
 		
 		$securityGroup = new SecurityGroup();
 		
-		$result = $securityGroup->getLinkName("Accounts","Contacts");
-		$this->assertEquals("contacts",$result);
+		$result = $securityGroup->getLinkName("Accounts", "Contacts");
+		$this->assertEquals("contacts", $result);
 		
 		
-		$result = $securityGroup->getLinkName("SecurityGroups","ACLRoles");
-		$this->assertEquals("aclroles",$result);
+		$result = $securityGroup->getLinkName("SecurityGroups", "ACLRoles");
+		$this->assertEquals("aclroles", $result);
 		
 		error_reporting(E_ALL);
 		//error_reporting(E_ERROR | E_PARSE);

Braces +8 added lines, -16 removed lines

@@ -116,8 +116,7 @@ 
 		try {
 			SecurityGroup::inherit($account,false);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -138,8 +137,7 @@ 
 		try {
 			SecurityGroup::assign_default_groups($account,false);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -159,8 +157,7 @@ 
 		try {
 			SecurityGroup::inherit_creator($account,false);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -182,8 +179,7 @@ 
 		try {
 			SecurityGroup::inherit_assigned($account,false);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -204,8 +200,7 @@ 
 		try {
 			SecurityGroup::inherit_parent($account,false);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -226,8 +221,7 @@ 
 		try {
 			SecurityGroup::inherit_parentQuery($account, "Accounts", 1, 1 , $account->module_dir);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -399,8 +393,7 @@ 
 		try {
 			$securityGroup->addGroupToRecord("Accounts", 1, 1);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -420,8 +413,7 @@ 
 		try {
 			$securityGroup->removeGroupFromRecord("Accounts", 1, 1);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

tests/tests/modules/Releases/ReleaseTest.php

Indentation +77 added lines, -77 removed lines

@@ -3,117 +3,117 @@
 class ReleaseTest extends PHPUnit_Framework_TestCase {
 
 
-	public function testRelease() {
+    public function testRelease() {
 
-		//execute the contructor and check for the Object type and  attributes
-		$release = new Release();
+        //execute the contructor and check for the Object type and  attributes
+        $release = new Release();
 		
-		$this->assertInstanceOf('Release',$release);
-		$this->assertInstanceOf('SugarBean',$release);
+        $this->assertInstanceOf('Release',$release);
+        $this->assertInstanceOf('SugarBean',$release);
 		 
-		$this->assertAttributeEquals('releases', 'table_name', $release);
-		$this->assertAttributeEquals('Releases', 'module_dir', $release);
-		$this->assertAttributeEquals('Release', 'object_name', $release);
+        $this->assertAttributeEquals('releases', 'table_name', $release);
+        $this->assertAttributeEquals('Releases', 'module_dir', $release);
+        $this->assertAttributeEquals('Release', 'object_name', $release);
 		
-		$this->assertAttributeEquals(true, 'new_schema', $release);
+        $this->assertAttributeEquals(true, 'new_schema', $release);
 		 	
-	}
+    }
 
-	public function testget_summary_text()
-	{
-		error_reporting(E_ERROR | E_PARSE);
+    public function testget_summary_text()
+    {
+        error_reporting(E_ERROR | E_PARSE);
 		
-		$release = new Release();
+        $release = new Release();
 		
-		//test without setting name
-		$this->assertEquals(Null,$release->get_summary_text());
+        //test without setting name
+        $this->assertEquals(Null,$release->get_summary_text());
 		
-		//test with name set
-		$release->name = "test";
-		$this->assertEquals('test',$release->get_summary_text());
-	}
+        //test with name set
+        $release->name = "test";
+        $this->assertEquals('test',$release->get_summary_text());
+    }
 
-	public function testget_releases()
-	{
-		$release = new Release();
+    public function testget_releases()
+    {
+        $release = new Release();
 		
-		//test with default params
-		$result = $release->get_releases();
-		$this->assertTrue(is_array($result));
+        //test with default params
+        $result = $release->get_releases();
+        $this->assertTrue(is_array($result));
 
-		//test with custom params
-		$result = $release->get_releases(true,'Hidden','name is not null');
-		$this->assertTrue(is_array($result));
+        //test with custom params
+        $result = $release->get_releases(true,'Hidden','name is not null');
+        $this->assertTrue(is_array($result));
 		
-	}
+    }
 
-	public function testfill_in_additional_list_fields()
-	{
-		$release = new Release();
+    public function testfill_in_additional_list_fields()
+    {
+        $release = new Release();
 
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$release->fill_in_additional_list_fields();
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $release->fill_in_additional_list_fields();
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-	}
+    }
 
-	public function testfill_in_additional_detail_fields() {
+    public function testfill_in_additional_detail_fields() {
 
-		$release = new Release();
+        $release = new Release();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$release->fill_in_additional_detail_fields();
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $release->fill_in_additional_detail_fields();
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-	}
+    }
 
-	public function testget_list_view_data(){
+    public function testget_list_view_data(){
 
-		$release = new Release();
+        $release = new Release();
 		
-		$release->name = "test";
-		$release->status = "Hidden";
+        $release->name = "test";
+        $release->status = "Hidden";
 		
-		$expected = array (
-				    'NAME' => 'test',
-				    'STATUS' => 'Hidden',
-				    'ENCODED_NAME' => 'test',
-				    'ENCODED_STATUS' => null
-		);
+        $expected = array (
+                    'NAME' => 'test',
+                    'STATUS' => 'Hidden',
+                    'ENCODED_NAME' => 'test',
+                    'ENCODED_STATUS' => null
+        );
 		
-		$actual = $release->get_list_view_data();
+        $actual = $release->get_list_view_data();
 		
-		$this->assertSame($expected, $actual);
+        $this->assertSame($expected, $actual);
 		
-	}
+    }
 
 
-	public function testbuild_generic_where_clause () {
+    public function testbuild_generic_where_clause () {
 
-		$release = new Release();
+        $release = new Release();
 
-		//test with empty string params
-		$expected = "name like '%'";
-		$actual = $release->build_generic_where_clause('');
-		$this->assertSame($expected,$actual);
+        //test with empty string params
+        $expected = "name like '%'";
+        $actual = $release->build_generic_where_clause('');
+        $this->assertSame($expected,$actual);
 		
 			
-		//test with valid string params
-		$expected = "name like '%'";
-		$actual = $release->build_generic_where_clause('test');
-		$this->assertSame($expected,$actual);
+        //test with valid string params
+        $expected = "name like '%'";
+        $actual = $release->build_generic_where_clause('test');
+        $this->assertSame($expected,$actual);
 	
-	}
+    }
 
 
 }

Spacing +10 added lines, -10 removed lines

@@ -8,8 +8,8 @@ 
 		//execute the contructor and check for the Object type and  attributes
 		$release = new Release();
 		
-		$this->assertInstanceOf('Release',$release);
-		$this->assertInstanceOf('SugarBean',$release);
+		$this->assertInstanceOf('Release', $release);
+		$this->assertInstanceOf('SugarBean', $release);
 		 
 		$this->assertAttributeEquals('releases', 'table_name', $release);
 		$this->assertAttributeEquals('Releases', 'module_dir', $release);
@@ -26,11 +26,11 @@ 
 		$release = new Release();
 		
 		//test without setting name
-		$this->assertEquals(Null,$release->get_summary_text());
+		$this->assertEquals(Null, $release->get_summary_text());
 		
 		//test with name set
 		$release->name = "test";
-		$this->assertEquals('test',$release->get_summary_text());
+		$this->assertEquals('test', $release->get_summary_text());
 	}
 
 	public function testget_releases()
@@ -42,7 +42,7 @@ 
 		$this->assertTrue(is_array($result));
 
 		//test with custom params
-		$result = $release->get_releases(true,'Hidden','name is not null');
+		$result = $release->get_releases(true, 'Hidden', 'name is not null');
 		$this->assertTrue(is_array($result));
 		
 	}
@@ -77,14 +77,14 @@ 
 		
 	}
 
-	public function testget_list_view_data(){
+	public function testget_list_view_data() {
 
 		$release = new Release();
 		
 		$release->name = "test";
 		$release->status = "Hidden";
 		
-		$expected = array (
+		$expected = array(
 				    'NAME' => 'test',
 				    'STATUS' => 'Hidden',
 				    'ENCODED_NAME' => 'test',
@@ -98,20 +98,20 @@ 
 	}
 
 
-	public function testbuild_generic_where_clause () {
+	public function testbuild_generic_where_clause() {
 
 		$release = new Release();
 
 		//test with empty string params
 		$expected = "name like '%'";
 		$actual = $release->build_generic_where_clause('');
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 			
 		//test with valid string params
 		$expected = "name like '%'";
 		$actual = $release->build_generic_where_clause('test');
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 	
 	}
 

Braces +2 added lines, -4 removed lines

@@ -55,8 +55,7 @@ 
 		try {
 			$release->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -70,8 +69,7 @@ 
 		try {
 			$release->fill_in_additional_detail_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

tests/tests/modules/Calls/CallTest.php

Indentation +226 added lines, -226 removed lines

@@ -4,179 +4,179 @@ 
 class CallTest extends PHPUnit_Framework_TestCase {
 
 
-	public function testCall() 
-	{
-		//execute the contructor and check for the Object type and  attributes
-		$call = new Call();
-		$this->assertInstanceOf('Call',$call);
-		$this->assertInstanceOf('SugarBean',$call);
+    public function testCall() 
+    {
+        //execute the contructor and check for the Object type and  attributes
+        $call = new Call();
+        $this->assertInstanceOf('Call',$call);
+        $this->assertInstanceOf('SugarBean',$call);
 			
-		$this->assertAttributeEquals('Calls', 'module_dir', $call);
-		$this->assertAttributeEquals('Call', 'object_name', $call);
-		$this->assertAttributeEquals('calls', 'table_name', $call);
-		$this->assertAttributeEquals('calls_users', 'rel_users_table', $call);
-		$this->assertAttributeEquals('calls_contacts', 'rel_contacts_table', $call);
-		$this->assertAttributeEquals('calls_leads', 'rel_leads_table', $call);
-		$this->assertAttributeEquals(true, 'new_schema', $call);
-		$this->assertAttributeEquals(true, 'importable', $call);
-		$this->assertAttributeEquals(false, 'syncing', $call);
-		$this->assertAttributeEquals(true, 'update_vcal', $call);
-		$this->assertAttributeEquals(array (0 => '00', 15 => '15', 30 => '30', 45 => '45'), 'minutes_values', $call);
-		
-	}
+        $this->assertAttributeEquals('Calls', 'module_dir', $call);
+        $this->assertAttributeEquals('Call', 'object_name', $call);
+        $this->assertAttributeEquals('calls', 'table_name', $call);
+        $this->assertAttributeEquals('calls_users', 'rel_users_table', $call);
+        $this->assertAttributeEquals('calls_contacts', 'rel_contacts_table', $call);
+        $this->assertAttributeEquals('calls_leads', 'rel_leads_table', $call);
+        $this->assertAttributeEquals(true, 'new_schema', $call);
+        $this->assertAttributeEquals(true, 'importable', $call);
+        $this->assertAttributeEquals(false, 'syncing', $call);
+        $this->assertAttributeEquals(true, 'update_vcal', $call);
+        $this->assertAttributeEquals(array (0 => '00', 15 => '15', 30 => '30', 45 => '45'), 'minutes_values', $call);
+		
+    }
 
 
-	public function testACLAccess()
-	{
-		error_reporting(E_ERROR | E_PARSE);
+    public function testACLAccess()
+    {
+        error_reporting(E_ERROR | E_PARSE);
 		
-		$call = new Call();
+        $call = new Call();
 		
-		//test without setting recurring_source attribute
-		$this->assertTrue($call->ACLAccess(''));
-		$this->assertTrue($call->ACLAccess('edit')); 
+        //test without setting recurring_source attribute
+        $this->assertTrue($call->ACLAccess(''));
+        $this->assertTrue($call->ACLAccess('edit')); 
 		
-		//test with recurring_source attribute set
-		$call->recurring_source = "test"; 
-		$this->assertFalse($call->ACLAccess('edit'));
+        //test with recurring_source attribute set
+        $call->recurring_source = "test"; 
+        $this->assertFalse($call->ACLAccess('edit'));
 		
-	}
+    }
 
 	
-	public function testSaveAndMarkDeleted() 
-	{
-		$call = new Call();
+    public function testSaveAndMarkDeleted() 
+    {
+        $call = new Call();
 		
-		$call->name = "test";	
-		$call->id = $call->save();
+        $call->name = "test";	
+        $call->id = $call->save();
 			
-		//test for record ID to verify that record is saved
-		$this->assertTrue(isset($call->id));
-		$this->assertEquals(36, strlen($call->id));
+        //test for record ID to verify that record is saved
+        $this->assertTrue(isset($call->id));
+        $this->assertEquals(36, strlen($call->id));
 			
 			
-		//mark the record as deleted and verify that this record cannot be retrieved anymore.
-		$call->mark_deleted($call->id);
-		$result = $call->retrieve($call->id);
-		$this->assertEquals(null,$result);
+        //mark the record as deleted and verify that this record cannot be retrieved anymore.
+        $call->mark_deleted($call->id);
+        $result = $call->retrieve($call->id);
+        $this->assertEquals(null,$result);
 		
-	}
+    }
 
 
-	public function testget_contacts()
-	{
-		$call = new Call();
-		$call->id = 1;
+    public function testget_contacts()
+    {
+        $call = new Call();
+        $call->id = 1;
 		
-		//execute the method and verify if it returns an array
-		$result = $call->get_contacts();
-		$this->assertTrue(is_array($result));
+        //execute the method and verify if it returns an array
+        $result = $call->get_contacts();
+        $this->assertTrue(is_array($result));
 		
-	}
+    }
 
 
-	public function testget_summary_text()
-	{
-		$call = new Call();
+    public function testget_summary_text()
+    {
+        $call = new Call();
 		
-		//test without setting name
-		$this->assertEquals(Null,$call->get_summary_text());
+        //test without setting name
+        $this->assertEquals(Null,$call->get_summary_text());
 		
-		//test with name set
-		$call->name = "test";
-		$this->assertEquals('test',$call->get_summary_text());
+        //test with name set
+        $call->name = "test";
+        $this->assertEquals('test',$call->get_summary_text());
 		
-	}
+    }
 
-	public function testcreate_list_query()
-	{
-		$call = new Call();
+    public function testcreate_list_query()
+    {
+        $call = new Call();
 		
 			                        
-		//test with empty string params
-		$expected = "SELECT \n			calls.*,\n			users.user_name as assigned_user_name FROM calls \n			LEFT JOIN users\n			ON calls.assigned_user_id=users.id where  calls.deleted=0   ORDER BY calls.name";
-		$actual = $call->create_list_query('','');
-		$this->assertSame($expected,$actual);
+        //test with empty string params
+        $expected = "SELECT \n			calls.*,\n			users.user_name as assigned_user_name FROM calls \n			LEFT JOIN users\n			ON calls.assigned_user_id=users.id where  calls.deleted=0   ORDER BY calls.name";
+        $actual = $call->create_list_query('','');
+        $this->assertSame($expected,$actual);
 		
 		
-		//test with valid string params
-		$expected = "SELECT \n			calls.*,\n			users.user_name as assigned_user_name FROM calls \n			LEFT JOIN users\n			ON calls.assigned_user_id=users.id where users.user_name=\"\" AND  calls.deleted=0   ORDER BY calls.name";
-		$actual = $call->create_list_query('name','users.user_name=""');
-		$this->assertSame($expected,$actual);
+        //test with valid string params
+        $expected = "SELECT \n			calls.*,\n			users.user_name as assigned_user_name FROM calls \n			LEFT JOIN users\n			ON calls.assigned_user_id=users.id where users.user_name=\"\" AND  calls.deleted=0   ORDER BY calls.name";
+        $actual = $call->create_list_query('name','users.user_name=""');
+        $this->assertSame($expected,$actual);
 		
-	}
+    }
 	
-	public function testcreate_export_query()
-	{
-		$call = new Call();
+    public function testcreate_export_query()
+    {
+        $call = new Call();
 		
 		 
-		//test with empty string params
-		$expected = "SELECT calls.*, users.user_name as assigned_user_name  FROM calls   LEFT JOIN users ON calls.assigned_user_id=users.id where calls.deleted=0 ORDER BY calls.name";
-		$actual = $call->create_export_query('','');
-		$this->assertSame($expected,$actual);
-		//var_dump($actual);	
+        //test with empty string params
+        $expected = "SELECT calls.*, users.user_name as assigned_user_name  FROM calls   LEFT JOIN users ON calls.assigned_user_id=users.id where calls.deleted=0 ORDER BY calls.name";
+        $actual = $call->create_export_query('','');
+        $this->assertSame($expected,$actual);
+        //var_dump($actual);	
 
-		//test with empty string params
-		$expected = "SELECT calls.*, users.user_name as assigned_user_name  FROM calls   LEFT JOIN users ON calls.assigned_user_id=users.id where users.user_name=\"\" AND calls.deleted=0 ORDER BY calls.name";
-		$actual = $call->create_export_query('name','users.user_name=""');
-		$this->assertSame($expected,$actual);
-		//var_dump($actual);
+        //test with empty string params
+        $expected = "SELECT calls.*, users.user_name as assigned_user_name  FROM calls   LEFT JOIN users ON calls.assigned_user_id=users.id where users.user_name=\"\" AND calls.deleted=0 ORDER BY calls.name";
+        $actual = $call->create_export_query('name','users.user_name=""');
+        $this->assertSame($expected,$actual);
+        //var_dump($actual);
 		
 		
-	}
+    }
 
-	public function testfill_in_additional_detail_fields()
-	{
+    public function testfill_in_additional_detail_fields()
+    {
 
-		$call = new Call();
+        $call = new Call();
 		
-		//execute the method and verify it sets up the intended fields
-		$call->fill_in_additional_detail_fields();
+        //execute the method and verify it sets up the intended fields
+        $call->fill_in_additional_detail_fields();
 
-		$this->assertEquals("0", $call->duration_hours);
-		$this->assertEquals("15", $call->duration_minutes);
-		$this->assertEquals(-1, $call->reminder_time);
-		$this->assertEquals(false, $call->reminder_checked);
-		$this->assertEquals(-1, $call->email_reminder_time);
-		$this->assertEquals(false, $call->email_reminder_checked);
-		$this->assertEquals("Accounts", $call->parent_type);
-		
-	}
+        $this->assertEquals("0", $call->duration_hours);
+        $this->assertEquals("15", $call->duration_minutes);
+        $this->assertEquals(-1, $call->reminder_time);
+        $this->assertEquals(false, $call->reminder_checked);
+        $this->assertEquals(-1, $call->email_reminder_time);
+        $this->assertEquals(false, $call->email_reminder_checked);
+        $this->assertEquals("Accounts", $call->parent_type);
+		
+    }
 
 
-	public function testget_list_view_data(){
-		
-		$call = new Call();
-		
-		$call->assigned_user_id = 1;
-		$call->created_by = 1;
-		$call->modified_user_id = 1;
-		
-		//execute the method and verify that it retunrs expected results
-		$expected = array (
-				'MODIFIED_USER_ID' => 1,
-				'CREATED_BY' => 1,
-				'DELETED' => 0,
-				'ASSIGNED_USER_ID' => 1,				
-				'STATUS' => 'Planned',
-				'REMINDER_TIME' => '-1',
-				'EMAIL_REMINDER_TIME' => '-1',
-				'EMAIL_REMINDER_SENT' => '0',
-				'REPEAT_INTERVAL' => '1',
-				'SET_COMPLETE' => '~'
-                                  . preg_quote('<a id=\'\' onclick=\'SUGAR.util.closeActivityPanel.show("Calls","","Held","listview","1");\'><img src="themes/SuiteR/images/close_inline.png?v=')
-                                  .'[\w-]+'
-                                  .preg_quote('"     border=\'0\' alt="Close" /></a>').'~',
-				'DATE_START' => '<font class=\'overdueTask\'></font>',
-				'CONTACT_ID' => NULL,
-				'CONTACT_NAME' => NULL,
-				'PARENT_NAME' => '',
-				'REMINDER_CHECKED' => false,
-				'EMAIL_REMINDER_CHECKED' => false,
-		);
-		
-		$actual = $call->get_list_view_data();
+    public function testget_list_view_data(){
+		
+        $call = new Call();
+		
+        $call->assigned_user_id = 1;
+        $call->created_by = 1;
+        $call->modified_user_id = 1;
+		
+        //execute the method and verify that it retunrs expected results
+        $expected = array (
+                'MODIFIED_USER_ID' => 1,
+                'CREATED_BY' => 1,
+                'DELETED' => 0,
+                'ASSIGNED_USER_ID' => 1,				
+                'STATUS' => 'Planned',
+                'REMINDER_TIME' => '-1',
+                'EMAIL_REMINDER_TIME' => '-1',
+                'EMAIL_REMINDER_SENT' => '0',
+                'REPEAT_INTERVAL' => '1',
+                'SET_COMPLETE' => '~'
+                                    . preg_quote('<a id=\'\' onclick=\'SUGAR.util.closeActivityPanel.show("Calls","","Held","listview","1");\'><img src="themes/SuiteR/images/close_inline.png?v=')
+                                    .'[\w-]+'
+                                    .preg_quote('"     border=\'0\' alt="Close" /></a>').'~',
+                'DATE_START' => '<font class=\'overdueTask\'></font>',
+                'CONTACT_ID' => NULL,
+                'CONTACT_NAME' => NULL,
+                'PARENT_NAME' => '',
+                'REMINDER_CHECKED' => false,
+                'EMAIL_REMINDER_CHECKED' => false,
+        );
+		
+        $actual = $call->get_list_view_data();
         foreach($expected as $expectedKey => $expectedVal){
             if($expectedKey == 'SET_COMPLETE'){
                 $this->assertRegExp($expected[$expectedKey],$actual[$expectedKey]);
@@ -185,145 +185,145 @@ 
             }
         }
 		
-		$this->assertEquals("Administrator", $call->assigned_user_name);
-		$this->assertEquals("Administrator", $call->created_by_name);
-		$this->assertEquals("Administrator", $call->modified_by_name);
+        $this->assertEquals("Administrator", $call->assigned_user_name);
+        $this->assertEquals("Administrator", $call->created_by_name);
+        $this->assertEquals("Administrator", $call->modified_by_name);
 		
-	}
+    }
 
 	
-	public function testset_notification_body() 
-	{
+    public function testset_notification_body() 
+    {
 		
-		$call = new Call();
+        $call = new Call();
 		
-		//test with attributes preset and verify template variables are set accordingly
+        //test with attributes preset and verify template variables are set accordingly
 		
-		$call->name = "test";
-		$call->duration_hours = "1";
-		$call->duration_minutes = "10";
-		$call->status = "Planned";
-		$call->description = "some text";
-		$call->date_start = '2015-09-01 00:02:03';
-		$call->current_notify_user = new User(1);
-		$call->current_notify_user->new_assigned_user_name = "Admin";
+        $call->name = "test";
+        $call->duration_hours = "1";
+        $call->duration_minutes = "10";
+        $call->status = "Planned";
+        $call->description = "some text";
+        $call->date_start = '2015-09-01 00:02:03';
+        $call->current_notify_user = new User(1);
+        $call->current_notify_user->new_assigned_user_name = "Admin";
 		
-		$result = $call->set_notification_body(new Sugar_Smarty(), $call);
+        $result = $call->set_notification_body(new Sugar_Smarty(), $call);
 		
-		$this->assertEquals($call->name ,$result->_tpl_vars['CALL_SUBJECT']);
-		$this->assertEquals($call->current_notify_user->new_assigned_user_name ,$result->_tpl_vars['CALL_TO']);
-		$this->assertEquals($call->duration_hours ,$result->_tpl_vars['CALL_HOURS']);
-		$this->assertEquals($call->duration_minutes ,$result->_tpl_vars['CALL_MINUTES']);
-		$this->assertEquals($call->status ,$result->_tpl_vars['CALL_STATUS']);
-		$this->assertEquals('09/01/2015 00:02 UTC(+00:00)' ,$result->_tpl_vars['CALL_STARTDATE']);
-		$this->assertEquals($call->description ,$result->_tpl_vars['CALL_DESCRIPTION']);
+        $this->assertEquals($call->name ,$result->_tpl_vars['CALL_SUBJECT']);
+        $this->assertEquals($call->current_notify_user->new_assigned_user_name ,$result->_tpl_vars['CALL_TO']);
+        $this->assertEquals($call->duration_hours ,$result->_tpl_vars['CALL_HOURS']);
+        $this->assertEquals($call->duration_minutes ,$result->_tpl_vars['CALL_MINUTES']);
+        $this->assertEquals($call->status ,$result->_tpl_vars['CALL_STATUS']);
+        $this->assertEquals('09/01/2015 00:02 UTC(+00:00)' ,$result->_tpl_vars['CALL_STARTDATE']);
+        $this->assertEquals($call->description ,$result->_tpl_vars['CALL_DESCRIPTION']);
 		
-	}
+    }
 
 
-	public function testget_call_users() 
-	{
+    public function testget_call_users() 
+    {
 		
-		$call = new Call();
-		$call->id = 1;
+        $call = new Call();
+        $call->id = 1;
 		
-		//execute the method and verify it returns an array
-		$result = $call->get_call_users();
-		$this->assertTrue(is_array($result));
+        //execute the method and verify it returns an array
+        $result = $call->get_call_users();
+        $this->assertTrue(is_array($result));
 		
-	}
+    }
 
 
-	public function testget_invite_calls()
-	{
+    public function testget_invite_calls()
+    {
 
-		$call = new Call();
-		$user = new User(1);
+        $call = new Call();
+        $user = new User(1);
 		
-		//execute the method and verify it returns an array
-		$result = $call->get_invite_calls($user);
-		$this->assertTrue(is_array($result));
+        //execute the method and verify it returns an array
+        $result = $call->get_invite_calls($user);
+        $this->assertTrue(is_array($result));
 		
-	}
+    }
 	
 	
-	public function testset_accept_status()
-	{
-		$call = new Call();
-		$call->id = 1;
+    public function testset_accept_status()
+    {
+        $call = new Call();
+        $call->id = 1;
 		
 		
-		//test for calls Users and delete the created linked records afterwards
-		$user = new User();
-		$user->id = '1';
+        //test for calls Users and delete the created linked records afterwards
+        $user = new User();
+        $user->id = '1';
 		
-		$call->set_accept_status($user,"test");
+        $call->set_accept_status($user,"test");
 
-		$call_users = $call->get_linked_beans('users', $call->object_name);
-		$this->assertEquals(1, count($call_users) );
+        $call_users = $call->get_linked_beans('users', $call->object_name);
+        $this->assertEquals(1, count($call_users) );
 		
 		
-		$call->delete_linked($call->id);
+        $call->delete_linked($call->id);
 				
-	}
+    }
 	
 	
-	public function testget_notification_recipients() 
-	{
+    public function testget_notification_recipients() 
+    {
 
-		$call = new Call();
+        $call = new Call();
 		
-		//test without setting any user list
-		$result = $call->get_notification_recipients();
-		$this->assertTrue(is_array($result));
+        //test without setting any user list
+        $result = $call->get_notification_recipients();
+        $this->assertTrue(is_array($result));
 		
-		//test with a user in notofication list set
-		$call->users_arr = array(1);
-		$result = $call->get_notification_recipients();
-		$this->assertTrue(is_array($result));
-		$this->assertEquals(1,count($result));
+        //test with a user in notofication list set
+        $call->users_arr = array(1);
+        $result = $call->get_notification_recipients();
+        $this->assertTrue(is_array($result));
+        $this->assertEquals(1,count($result));
 			
-	}
+    }
 
     public function testbean_implements()
     {
-    	$call = new Call();
-    	$this->assertEquals(false, $call->bean_implements('')); //test with blank value
-    	$this->assertEquals(false, $call->bean_implements('test')); //test with invalid value
-    	$this->assertEquals(true, $call->bean_implements('ACL')); //test with valid value
+        $call = new Call();
+        $this->assertEquals(false, $call->bean_implements('')); //test with blank value
+        $this->assertEquals(false, $call->bean_implements('test')); //test with invalid value
+        $this->assertEquals(true, $call->bean_implements('ACL')); //test with valid value
     	
-	}
+    }
 
-	public function testlistviewACLHelper()
-	{
+    public function testlistviewACLHelper()
+    {
 		
-		$call = new Call();
-		$expected = array( "MAIN"=>"a", "PARENT"=>"a", "CONTACT"=>"a");
-		$actual = $call->listviewACLHelper();
-		$this->assertSame($expected,$actual);
+        $call = new Call();
+        $expected = array( "MAIN"=>"a", "PARENT"=>"a", "CONTACT"=>"a");
+        $actual = $call->listviewACLHelper();
+        $this->assertSame($expected,$actual);
 		
-	}
+    }
 
-	public function testsave_relationship_changes() 
-	{
-		$call = new Call();
-		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$call->save_relationship_changes(true);
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
-		
-	}
+    public function testsave_relationship_changes() 
+    {
+        $call = new Call();
+		
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $call->save_relationship_changes(true);
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
+		
+    }
 
     public function testgetDefaultStatus()
     {
-    	$call = new Call();
-    	$result = $call->getDefaultStatus();
-    	$this->assertEquals("Planned",$result);
+        $call = new Call();
+        $result = $call->getDefaultStatus();
+        $this->assertEquals("Planned",$result);
     
     }
 

Spacing +33 added lines, -33 removed lines

@@ -8,8 +8,8 @@ 
 	{
 		//execute the contructor and check for the Object type and  attributes
 		$call = new Call();
-		$this->assertInstanceOf('Call',$call);
-		$this->assertInstanceOf('SugarBean',$call);
+		$this->assertInstanceOf('Call', $call);
+		$this->assertInstanceOf('SugarBean', $call);
 			
 		$this->assertAttributeEquals('Calls', 'module_dir', $call);
 		$this->assertAttributeEquals('Call', 'object_name', $call);
@@ -21,7 +21,7 @@ 
 		$this->assertAttributeEquals(true, 'importable', $call);
 		$this->assertAttributeEquals(false, 'syncing', $call);
 		$this->assertAttributeEquals(true, 'update_vcal', $call);
-		$this->assertAttributeEquals(array (0 => '00', 15 => '15', 30 => '30', 45 => '45'), 'minutes_values', $call);
+		$this->assertAttributeEquals(array(0 => '00', 15 => '15', 30 => '30', 45 => '45'), 'minutes_values', $call);
 		
 	}
 
@@ -58,7 +58,7 @@ 
 		//mark the record as deleted and verify that this record cannot be retrieved anymore.
 		$call->mark_deleted($call->id);
 		$result = $call->retrieve($call->id);
-		$this->assertEquals(null,$result);
+		$this->assertEquals(null, $result);
 		
 	}
 
@@ -80,11 +80,11 @@ 
 		$call = new Call();
 		
 		//test without setting name
-		$this->assertEquals(Null,$call->get_summary_text());
+		$this->assertEquals(Null, $call->get_summary_text());
 		
 		//test with name set
 		$call->name = "test";
-		$this->assertEquals('test',$call->get_summary_text());
+		$this->assertEquals('test', $call->get_summary_text());
 		
 	}
 
@@ -95,14 +95,14 @@ 
 			                        
 		//test with empty string params
 		$expected = "SELECT \n			calls.*,\n			users.user_name as assigned_user_name FROM calls \n			LEFT JOIN users\n			ON calls.assigned_user_id=users.id where  calls.deleted=0   ORDER BY calls.name";
-		$actual = $call->create_list_query('','');
-		$this->assertSame($expected,$actual);
+		$actual = $call->create_list_query('', '');
+		$this->assertSame($expected, $actual);
 		
 		
 		//test with valid string params
 		$expected = "SELECT \n			calls.*,\n			users.user_name as assigned_user_name FROM calls \n			LEFT JOIN users\n			ON calls.assigned_user_id=users.id where users.user_name=\"\" AND  calls.deleted=0   ORDER BY calls.name";
-		$actual = $call->create_list_query('name','users.user_name=""');
-		$this->assertSame($expected,$actual);
+		$actual = $call->create_list_query('name', 'users.user_name=""');
+		$this->assertSame($expected, $actual);
 		
 	}
 	
@@ -113,14 +113,14 @@ 
 		 
 		//test with empty string params
 		$expected = "SELECT calls.*, users.user_name as assigned_user_name  FROM calls   LEFT JOIN users ON calls.assigned_user_id=users.id where calls.deleted=0 ORDER BY calls.name";
-		$actual = $call->create_export_query('','');
-		$this->assertSame($expected,$actual);
+		$actual = $call->create_export_query('', '');
+		$this->assertSame($expected, $actual);
 		//var_dump($actual);	
 
 		//test with empty string params
 		$expected = "SELECT calls.*, users.user_name as assigned_user_name  FROM calls   LEFT JOIN users ON calls.assigned_user_id=users.id where users.user_name=\"\" AND calls.deleted=0 ORDER BY calls.name";
-		$actual = $call->create_export_query('name','users.user_name=""');
-		$this->assertSame($expected,$actual);
+		$actual = $call->create_export_query('name', 'users.user_name=""');
+		$this->assertSame($expected, $actual);
 		//var_dump($actual);
 		
 		
@@ -145,7 +145,7 @@ 
 	}
 
 
-	public function testget_list_view_data(){
+	public function testget_list_view_data() {
 		
 		$call = new Call();
 		
@@ -154,7 +154,7 @@ 
 		$call->modified_user_id = 1;
 		
 		//execute the method and verify that it retunrs expected results
-		$expected = array (
+		$expected = array(
 				'MODIFIED_USER_ID' => 1,
 				'CREATED_BY' => 1,
 				'DELETED' => 0,
@@ -177,10 +177,10 @@ 
 		);
 		
 		$actual = $call->get_list_view_data();
-        foreach($expected as $expectedKey => $expectedVal){
-            if($expectedKey == 'SET_COMPLETE'){
-                $this->assertRegExp($expected[$expectedKey],$actual[$expectedKey]);
-            }else {
+        foreach ($expected as $expectedKey => $expectedVal) {
+            if ($expectedKey == 'SET_COMPLETE') {
+                $this->assertRegExp($expected[$expectedKey], $actual[$expectedKey]);
+            } else {
                 $this->assertSame($expected[$expectedKey], $actual[$expectedKey]);
             }
         }
@@ -210,13 +210,13 @@ 
 		
 		$result = $call->set_notification_body(new Sugar_Smarty(), $call);
 		
-		$this->assertEquals($call->name ,$result->_tpl_vars['CALL_SUBJECT']);
-		$this->assertEquals($call->current_notify_user->new_assigned_user_name ,$result->_tpl_vars['CALL_TO']);
-		$this->assertEquals($call->duration_hours ,$result->_tpl_vars['CALL_HOURS']);
-		$this->assertEquals($call->duration_minutes ,$result->_tpl_vars['CALL_MINUTES']);
-		$this->assertEquals($call->status ,$result->_tpl_vars['CALL_STATUS']);
-		$this->assertEquals('09/01/2015 00:02 UTC(+00:00)' ,$result->_tpl_vars['CALL_STARTDATE']);
-		$this->assertEquals($call->description ,$result->_tpl_vars['CALL_DESCRIPTION']);
+		$this->assertEquals($call->name, $result->_tpl_vars['CALL_SUBJECT']);
+		$this->assertEquals($call->current_notify_user->new_assigned_user_name, $result->_tpl_vars['CALL_TO']);
+		$this->assertEquals($call->duration_hours, $result->_tpl_vars['CALL_HOURS']);
+		$this->assertEquals($call->duration_minutes, $result->_tpl_vars['CALL_MINUTES']);
+		$this->assertEquals($call->status, $result->_tpl_vars['CALL_STATUS']);
+		$this->assertEquals('09/01/2015 00:02 UTC(+00:00)', $result->_tpl_vars['CALL_STARTDATE']);
+		$this->assertEquals($call->description, $result->_tpl_vars['CALL_DESCRIPTION']);
 		
 	}
 
@@ -257,10 +257,10 @@ 
 		$user = new User();
 		$user->id = '1';
 		
-		$call->set_accept_status($user,"test");
+		$call->set_accept_status($user, "test");
 
 		$call_users = $call->get_linked_beans('users', $call->object_name);
-		$this->assertEquals(1, count($call_users) );
+		$this->assertEquals(1, count($call_users));
 		
 		
 		$call->delete_linked($call->id);
@@ -281,7 +281,7 @@ 
 		$call->users_arr = array(1);
 		$result = $call->get_notification_recipients();
 		$this->assertTrue(is_array($result));
-		$this->assertEquals(1,count($result));
+		$this->assertEquals(1, count($result));
 			
 	}
 
@@ -298,9 +298,9 @@ 
 	{
 		
 		$call = new Call();
-		$expected = array( "MAIN"=>"a", "PARENT"=>"a", "CONTACT"=>"a");
+		$expected = array("MAIN"=>"a", "PARENT"=>"a", "CONTACT"=>"a");
 		$actual = $call->listviewACLHelper();
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 	}
 
@@ -323,7 +323,7 @@ 
     {
     	$call = new Call();
     	$result = $call->getDefaultStatus();
-    	$this->assertEquals("Planned",$result);
+    	$this->assertEquals("Planned", $result);
     
     }
 

Braces +2 added lines, -3 removed lines

@@ -180,7 +180,7 @@ 
         foreach($expected as $expectedKey => $expectedVal){
             if($expectedKey == 'SET_COMPLETE'){
                 $this->assertRegExp($expected[$expectedKey],$actual[$expectedKey]);
-            }else {
+            } else {
                 $this->assertSame($expected[$expectedKey], $actual[$expectedKey]);
             }
         }
@@ -312,8 +312,7 @@ 
 		try {
 			$call->save_relationship_changes(true);
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

tests/tests/modules/AOS_Quotes/AOS_QuotesTest.php

Indentation +29 added lines, -29 removed lines

@@ -2,49 +2,49 @@
 
 class AOS_QuotesTest extends PHPUnit_Framework_TestCase {
 	
-	function testAOS_Quotes(){	
+    function testAOS_Quotes(){	
 
-		//execute the contructor and check for the Object type and  attributes
-		$aosQuotes = new AOS_Quotes();
-		$this->assertInstanceOf('AOS_Quotes',$aosQuotes);
-		$this->assertInstanceOf('Basic',$aosQuotes);
-		$this->assertInstanceOf('SugarBean',$aosQuotes);
+        //execute the contructor and check for the Object type and  attributes
+        $aosQuotes = new AOS_Quotes();
+        $this->assertInstanceOf('AOS_Quotes',$aosQuotes);
+        $this->assertInstanceOf('Basic',$aosQuotes);
+        $this->assertInstanceOf('SugarBean',$aosQuotes);
 			
-		$this->assertAttributeEquals('AOS_Quotes', 'module_dir', $aosQuotes);
-		$this->assertAttributeEquals('AOS_Quotes', 'object_name', $aosQuotes);
-		$this->assertAttributeEquals('aos_quotes', 'table_name', $aosQuotes);
-		$this->assertAttributeEquals(true, 'new_schema', $aosQuotes);
-		$this->assertAttributeEquals(true, 'disable_row_level_security', $aosQuotes);
-		$this->assertAttributeEquals(true, 'importable', $aosQuotes);
-		$this->assertAttributeEquals(true, 'lineItems', $aosQuotes);
+        $this->assertAttributeEquals('AOS_Quotes', 'module_dir', $aosQuotes);
+        $this->assertAttributeEquals('AOS_Quotes', 'object_name', $aosQuotes);
+        $this->assertAttributeEquals('aos_quotes', 'table_name', $aosQuotes);
+        $this->assertAttributeEquals(true, 'new_schema', $aosQuotes);
+        $this->assertAttributeEquals(true, 'disable_row_level_security', $aosQuotes);
+        $this->assertAttributeEquals(true, 'importable', $aosQuotes);
+        $this->assertAttributeEquals(true, 'lineItems', $aosQuotes);
 		
-	}
+    }
 	
-	function testSaveAndMark_deleted(){
+    function testSaveAndMark_deleted(){
 
-		error_reporting(E_ERROR | E_PARSE);
+        error_reporting(E_ERROR | E_PARSE);
 		
-		$aosQuotes = new AOS_Quotes();
+        $aosQuotes = new AOS_Quotes();
 		
-		$aosQuotes->name = "test";
-		$aosQuotes->total_amt = 100;
-		$aosQuotes->total_amt_usdollar= 100;
+        $aosQuotes->name = "test";
+        $aosQuotes->total_amt = 100;
+        $aosQuotes->total_amt_usdollar= 100;
 		
-		$aosQuotes->save();
+        $aosQuotes->save();
 			
 			
-		//test for record ID to verify that record is saved
-		$this->assertTrue(isset($aosQuotes->id));
-		$this->assertEquals(36, strlen($aosQuotes->id));
+        //test for record ID to verify that record is saved
+        $this->assertTrue(isset($aosQuotes->id));
+        $this->assertEquals(36, strlen($aosQuotes->id));
 
 		
-		//mark the record as deleted and verify that this record cannot be retrieved anymore.
-		$aosQuotes->mark_deleted($aosQuotes->id);
-		$result = $aosQuotes->retrieve($aosQuotes->id);
-		$this->assertEquals(null,$result);
+        //mark the record as deleted and verify that this record cannot be retrieved anymore.
+        $aosQuotes->mark_deleted($aosQuotes->id);
+        $result = $aosQuotes->retrieve($aosQuotes->id);
+        $this->assertEquals(null,$result);
 		
 	
-	}
+    }
 	
 	
 }

Spacing +7 added lines, -7 removed lines

@@ -2,13 +2,13 @@ 
 
 class AOS_QuotesTest extends PHPUnit_Framework_TestCase {
 	
-	function testAOS_Quotes(){	
+	function testAOS_Quotes() {	
 
 		//execute the contructor and check for the Object type and  attributes
 		$aosQuotes = new AOS_Quotes();
-		$this->assertInstanceOf('AOS_Quotes',$aosQuotes);
-		$this->assertInstanceOf('Basic',$aosQuotes);
-		$this->assertInstanceOf('SugarBean',$aosQuotes);
+		$this->assertInstanceOf('AOS_Quotes', $aosQuotes);
+		$this->assertInstanceOf('Basic', $aosQuotes);
+		$this->assertInstanceOf('SugarBean', $aosQuotes);
 			
 		$this->assertAttributeEquals('AOS_Quotes', 'module_dir', $aosQuotes);
 		$this->assertAttributeEquals('AOS_Quotes', 'object_name', $aosQuotes);
@@ -20,7 +20,7 @@ 
 		
 	}
 	
-	function testSaveAndMark_deleted(){
+	function testSaveAndMark_deleted() {
 
 		error_reporting(E_ERROR | E_PARSE);
 		
@@ -28,7 +28,7 @@ 
 		
 		$aosQuotes->name = "test";
 		$aosQuotes->total_amt = 100;
-		$aosQuotes->total_amt_usdollar= 100;
+		$aosQuotes->total_amt_usdollar = 100;
 		
 		$aosQuotes->save();
 			
@@ -41,7 +41,7 @@ 
 		//mark the record as deleted and verify that this record cannot be retrieved anymore.
 		$aosQuotes->mark_deleted($aosQuotes->id);
 		$result = $aosQuotes->retrieve($aosQuotes->id);
-		$this->assertEquals(null,$result);
+		$this->assertEquals(null, $result);
 		
 	
 	}

tests/tests/modules/AOR_Fields/AOR_FieldTest.php

Indentation +37 added lines, -37 removed lines

@@ -3,53 +3,53 @@
 
 class AOR_FieldTest extends PHPUnit_Framework_TestCase {
 		
-	public function testAOR_Field(){
+    public function testAOR_Field(){
 
-		//execute the contructor and check for the Object type and  attributes
-		$aor_Field = new AOR_Field();
-		$this->assertInstanceOf('AOR_Field',$aor_Field);
-		$this->assertInstanceOf('Basic',$aor_Field);
-		$this->assertInstanceOf('SugarBean',$aor_Field);
+        //execute the contructor and check for the Object type and  attributes
+        $aor_Field = new AOR_Field();
+        $this->assertInstanceOf('AOR_Field',$aor_Field);
+        $this->assertInstanceOf('Basic',$aor_Field);
+        $this->assertInstanceOf('SugarBean',$aor_Field);
 			
-		$this->assertAttributeEquals('AOR_Fields', 'module_dir', $aor_Field);
-		$this->assertAttributeEquals('AOR_Field', 'object_name', $aor_Field);
-		$this->assertAttributeEquals('aor_fields', 'table_name', $aor_Field);
-		$this->assertAttributeEquals(true, 'new_schema', $aor_Field);
-		$this->assertAttributeEquals(true, 'disable_row_level_security', $aor_Field);
-		$this->assertAttributeEquals(true, 'importable', $aor_Field);
-		$this->assertAttributeEquals(false, 'tracker_visibility', $aor_Field);
+        $this->assertAttributeEquals('AOR_Fields', 'module_dir', $aor_Field);
+        $this->assertAttributeEquals('AOR_Field', 'object_name', $aor_Field);
+        $this->assertAttributeEquals('aor_fields', 'table_name', $aor_Field);
+        $this->assertAttributeEquals(true, 'new_schema', $aor_Field);
+        $this->assertAttributeEquals(true, 'disable_row_level_security', $aor_Field);
+        $this->assertAttributeEquals(true, 'importable', $aor_Field);
+        $this->assertAttributeEquals(false, 'tracker_visibility', $aor_Field);
 		
-	}
+    }
 
     public function testsave_lines(){
 
-    	error_reporting(E_ERROR | E_PARSE);
+        error_reporting(E_ERROR | E_PARSE);
     	 
-    	$aor_Field = new AOR_Field();
+        $aor_Field = new AOR_Field();
 
-    	//preset the required data 
-    	$post_data = Array();
-    	$post_data['field'][] = 'test field';
-    	$post_data['name'][] = 'test';
-    	$post_data['module_path'][] = 'test path';
-    	$post_data['display'][] = '1';
-    	$post_data['link'][] = '1';
-    	$post_data['label'][] = 'test label';
-    	$post_data['field_function'][] = 'test function';
-    	$post_data['total'][] = 'total';
-    	$post_data['group_by'][] = '1';
-    	$post_data['group_order'][] = 'desc';
-    	$post_data['group_display'][] = '1';
+        //preset the required data 
+        $post_data = Array();
+        $post_data['field'][] = 'test field';
+        $post_data['name'][] = 'test';
+        $post_data['module_path'][] = 'test path';
+        $post_data['display'][] = '1';
+        $post_data['link'][] = '1';
+        $post_data['label'][] = 'test label';
+        $post_data['field_function'][] = 'test function';
+        $post_data['total'][] = 'total';
+        $post_data['group_by'][] = '1';
+        $post_data['group_order'][] = 'desc';
+        $post_data['group_display'][] = '1';
     	
     	
-    	//execute the method and test if it works and does not throws an exception.
-    	try {
-    		$aor_Field->save_lines($post_data, new AOR_Report());
-    		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
-    		$this->fail();
-    	}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $aor_Field->save_lines($post_data, new AOR_Report());
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
     	 
 
     }

Spacing +5 added lines, -5 removed lines

@@ -3,13 +3,13 @@ 
 
 class AOR_FieldTest extends PHPUnit_Framework_TestCase {
 		
-	public function testAOR_Field(){
+	public function testAOR_Field() {
 
 		//execute the contructor and check for the Object type and  attributes
 		$aor_Field = new AOR_Field();
-		$this->assertInstanceOf('AOR_Field',$aor_Field);
-		$this->assertInstanceOf('Basic',$aor_Field);
-		$this->assertInstanceOf('SugarBean',$aor_Field);
+		$this->assertInstanceOf('AOR_Field', $aor_Field);
+		$this->assertInstanceOf('Basic', $aor_Field);
+		$this->assertInstanceOf('SugarBean', $aor_Field);
 			
 		$this->assertAttributeEquals('AOR_Fields', 'module_dir', $aor_Field);
 		$this->assertAttributeEquals('AOR_Field', 'object_name', $aor_Field);
@@ -21,7 +21,7 @@ 
 		
 	}
 
-    public function testsave_lines(){
+    public function testsave_lines() {
 
     	error_reporting(E_ERROR | E_PARSE);
     	 

Braces +1 added lines, -2 removed lines

@@ -46,8 +46,7 @@
     	try {
     		$aor_Field->save_lines($post_data, new AOR_Report());
     		$this->assertTrue(true);
-    	}
-    	catch (Exception $e) {
+    	} catch (Exception $e) {
     		$this->fail();
     	}
     	 

tests/tests/modules/EmailMarketing/EmailMarketingTest.php

Indentation +64 added lines, -64 removed lines

@@ -5,98 +5,98 @@
 {
 
 
-	public function testEmailMarketing()
-	{
+    public function testEmailMarketing()
+    {
 		
-		//execute the contructor and check for the Object type and  attributes
-		$emailMarketing = new EmailMarketing();
+        //execute the contructor and check for the Object type and  attributes
+        $emailMarketing = new EmailMarketing();
 		
-		$this->assertInstanceOf('EmailMarketing',$emailMarketing);
-		$this->assertInstanceOf('SugarBean',$emailMarketing);
+        $this->assertInstanceOf('EmailMarketing',$emailMarketing);
+        $this->assertInstanceOf('SugarBean',$emailMarketing);
 			
-		$this->assertAttributeEquals('EmailMarketing', 'module_dir', $emailMarketing);
-		$this->assertAttributeEquals('EmailMarketing', 'object_name', $emailMarketing);
-		$this->assertAttributeEquals('email_marketing', 'table_name', $emailMarketing);
+        $this->assertAttributeEquals('EmailMarketing', 'module_dir', $emailMarketing);
+        $this->assertAttributeEquals('EmailMarketing', 'object_name', $emailMarketing);
+        $this->assertAttributeEquals('email_marketing', 'table_name', $emailMarketing);
 		
-		$this->assertAttributeEquals(true, 'new_schema', $emailMarketing);
+        $this->assertAttributeEquals(true, 'new_schema', $emailMarketing);
 		
-	}
+    }
 
-	public function testretrieve() 
-	{
-		error_reporting(E_ERROR | E_PARSE);		
+    public function testretrieve() 
+    {
+        error_reporting(E_ERROR | E_PARSE);		
 		
-		$emailMarketing = new EmailMarketing();
+        $emailMarketing = new EmailMarketing();
 		
-		$result = $emailMarketing->retrieve();
-		$this->assertInstanceOf('EmailMarketing',$result);
+        $result = $emailMarketing->retrieve();
+        $this->assertInstanceOf('EmailMarketing',$result);
 		
-	}
+    }
 
-	public function testget_summary_text()
-	{
-		$emailMarketing = new EmailMarketing();
+    public function testget_summary_text()
+    {
+        $emailMarketing = new EmailMarketing();
 		
-		//test without setting name
-		$this->assertEquals(Null,$emailMarketing->get_summary_text());
+        //test without setting name
+        $this->assertEquals(Null,$emailMarketing->get_summary_text());
 		
-		//test with name set
-		$emailMarketing->name = "test";
-		$this->assertEquals('test',$emailMarketing->get_summary_text());
+        //test with name set
+        $emailMarketing->name = "test";
+        $this->assertEquals('test',$emailMarketing->get_summary_text());
 		
-	}
+    }
 
-	public function testcreate_export_query()
-	{
-		$emailMarketing = new EmailMarketing();
+    public function testcreate_export_query()
+    {
+        $emailMarketing = new EmailMarketing();
 		
-		//test with empty string params
-		$expected = " SELECT  email_marketing.*  , jt0.name template_name , jt0.assigned_user_id template_name_owner  , 'EmailTemplates' template_name_mod FROM email_marketing   LEFT JOIN  email_templates jt0 ON email_marketing.template_id=jt0.id AND jt0.deleted=0\n\n AND jt0.deleted=0 where email_marketing.deleted=0"; 		
-		$actual = $emailMarketing->create_export_query('','');
-		$this->assertSame($expected,$actual);
+        //test with empty string params
+        $expected = " SELECT  email_marketing.*  , jt0.name template_name , jt0.assigned_user_id template_name_owner  , 'EmailTemplates' template_name_mod FROM email_marketing   LEFT JOIN  email_templates jt0 ON email_marketing.template_id=jt0.id AND jt0.deleted=0\n\n AND jt0.deleted=0 where email_marketing.deleted=0"; 		
+        $actual = $emailMarketing->create_export_query('','');
+        $this->assertSame($expected,$actual);
 
 		 
-		//test with valid string params
-		$expected = " SELECT  email_marketing.*  , jt0.name template_name , jt0.assigned_user_id template_name_owner  , 'EmailTemplates' template_name_mod FROM email_marketing   LEFT JOIN  email_templates jt0 ON email_marketing.template_id=jt0.id AND jt0.deleted=0\n\n AND jt0.deleted=0 where (email_marketing.name=\"\") AND email_marketing.deleted=0";
-		$actual = $emailMarketing->create_export_query('email_marketing.id','email_marketing.name=""');
-		$this->assertSame($expected,$actual);
+        //test with valid string params
+        $expected = " SELECT  email_marketing.*  , jt0.name template_name , jt0.assigned_user_id template_name_owner  , 'EmailTemplates' template_name_mod FROM email_marketing   LEFT JOIN  email_templates jt0 ON email_marketing.template_id=jt0.id AND jt0.deleted=0\n\n AND jt0.deleted=0 where (email_marketing.name=\"\") AND email_marketing.deleted=0";
+        $actual = $emailMarketing->create_export_query('email_marketing.id','email_marketing.name=""');
+        $this->assertSame($expected,$actual);
 	
-	}
+    }
 
-	public function testget_list_view_data()
-	{
+    public function testget_list_view_data()
+    {
 
-		$emailMarketing = new EmailMarketing();
+        $emailMarketing = new EmailMarketing();
 		
-		//execute the method and verify that it retunrs expected results
-		$expected = array (
-				'ALL_PROSPECT_LISTS' => '0',
-		);
+        //execute the method and verify that it retunrs expected results
+        $expected = array (
+                'ALL_PROSPECT_LISTS' => '0',
+        );
 		
-		$actual = $emailMarketing->get_list_view_data();
-		$this->assertSame($expected, $actual);
+        $actual = $emailMarketing->get_list_view_data();
+        $this->assertSame($expected, $actual);
 	
-	}
+    }
 
-	public function testbean_implements()
-	{
-		$emailMarketing = new EmailMarketing();
-		$this->assertEquals(false, $emailMarketing->bean_implements('')); //test with blank value
-		$this->assertEquals(false, $emailMarketing->bean_implements('test')); //test with invalid value
-		$this->assertEquals(true, $emailMarketing->bean_implements('ACL')); //test with valid value
+    public function testbean_implements()
+    {
+        $emailMarketing = new EmailMarketing();
+        $this->assertEquals(false, $emailMarketing->bean_implements('')); //test with blank value
+        $this->assertEquals(false, $emailMarketing->bean_implements('test')); //test with invalid value
+        $this->assertEquals(true, $emailMarketing->bean_implements('ACL')); //test with valid value
 
-	}
+    }
 
-	public function testget_all_prospect_lists() 
-	{
-		$emailMarketing = new EmailMarketing();
+    public function testget_all_prospect_lists() 
+    {
+        $emailMarketing = new EmailMarketing();
 		
-		//execute the method and verify that it retunrs expected results
-		$expected = "select prospect_lists.* from prospect_lists  left join prospect_list_campaigns on prospect_list_campaigns.prospect_list_id=prospect_lists.id where prospect_list_campaigns.deleted=0 and prospect_list_campaigns.campaign_id='' and prospect_lists.deleted=0 and prospect_lists.list_type not like 'exempt%'";
-		$actual = $emailMarketing->get_all_prospect_lists();
-		$this->assertSame($expected,$actual);
+        //execute the method and verify that it retunrs expected results
+        $expected = "select prospect_lists.* from prospect_lists  left join prospect_list_campaigns on prospect_list_campaigns.prospect_list_id=prospect_lists.id where prospect_list_campaigns.deleted=0 and prospect_list_campaigns.campaign_id='' and prospect_lists.deleted=0 and prospect_lists.list_type not like 'exempt%'";
+        $actual = $emailMarketing->get_all_prospect_lists();
+        $this->assertSame($expected,$actual);
 		
-	}
+    }
 
 }
 ?>
\ No newline at end of file

Spacing +11 added lines, -11 removed lines

@@ -11,8 +11,8 @@ 
 		//execute the contructor and check for the Object type and  attributes
 		$emailMarketing = new EmailMarketing();
 		
-		$this->assertInstanceOf('EmailMarketing',$emailMarketing);
-		$this->assertInstanceOf('SugarBean',$emailMarketing);
+		$this->assertInstanceOf('EmailMarketing', $emailMarketing);
+		$this->assertInstanceOf('SugarBean', $emailMarketing);
 			
 		$this->assertAttributeEquals('EmailMarketing', 'module_dir', $emailMarketing);
 		$this->assertAttributeEquals('EmailMarketing', 'object_name', $emailMarketing);
@@ -29,7 +29,7 @@ 
 		$emailMarketing = new EmailMarketing();
 		
 		$result = $emailMarketing->retrieve();
-		$this->assertInstanceOf('EmailMarketing',$result);
+		$this->assertInstanceOf('EmailMarketing', $result);
 		
 	}
 
@@ -38,11 +38,11 @@ 
 		$emailMarketing = new EmailMarketing();
 		
 		//test without setting name
-		$this->assertEquals(Null,$emailMarketing->get_summary_text());
+		$this->assertEquals(Null, $emailMarketing->get_summary_text());
 		
 		//test with name set
 		$emailMarketing->name = "test";
-		$this->assertEquals('test',$emailMarketing->get_summary_text());
+		$this->assertEquals('test', $emailMarketing->get_summary_text());
 		
 	}
 
@@ -52,14 +52,14 @@ 
 		
 		//test with empty string params
 		$expected = " SELECT  email_marketing.*  , jt0.name template_name , jt0.assigned_user_id template_name_owner  , 'EmailTemplates' template_name_mod FROM email_marketing   LEFT JOIN  email_templates jt0 ON email_marketing.template_id=jt0.id AND jt0.deleted=0\n\n AND jt0.deleted=0 where email_marketing.deleted=0"; 		
-		$actual = $emailMarketing->create_export_query('','');
-		$this->assertSame($expected,$actual);
+		$actual = $emailMarketing->create_export_query('', '');
+		$this->assertSame($expected, $actual);
 
 		 
 		//test with valid string params
 		$expected = " SELECT  email_marketing.*  , jt0.name template_name , jt0.assigned_user_id template_name_owner  , 'EmailTemplates' template_name_mod FROM email_marketing   LEFT JOIN  email_templates jt0 ON email_marketing.template_id=jt0.id AND jt0.deleted=0\n\n AND jt0.deleted=0 where (email_marketing.name=\"\") AND email_marketing.deleted=0";
-		$actual = $emailMarketing->create_export_query('email_marketing.id','email_marketing.name=""');
-		$this->assertSame($expected,$actual);
+		$actual = $emailMarketing->create_export_query('email_marketing.id', 'email_marketing.name=""');
+		$this->assertSame($expected, $actual);
 	
 	}
 
@@ -69,7 +69,7 @@ 
 		$emailMarketing = new EmailMarketing();
 		
 		//execute the method and verify that it retunrs expected results
-		$expected = array (
+		$expected = array(
 				'ALL_PROSPECT_LISTS' => '0',
 		);
 		
@@ -94,7 +94,7 @@ 
 		//execute the method and verify that it retunrs expected results
 		$expected = "select prospect_lists.* from prospect_lists  left join prospect_list_campaigns on prospect_list_campaigns.prospect_list_id=prospect_lists.id where prospect_list_campaigns.deleted=0 and prospect_list_campaigns.campaign_id='' and prospect_lists.deleted=0 and prospect_lists.list_type not like 'exempt%'";
 		$actual = $emailMarketing->get_all_prospect_lists();
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 	}
 

tests/tests/modules/SchedulersJobs/SchedulersJobTest.php

Indentation +228 added lines, -228 removed lines

@@ -4,344 +4,344 @@
 {
 
 
-	public function testSchedulersJob()
-	{
-		//execute the contructor and check for the Object type and  attributes
-		$schedulersJob = new SchedulersJob();
-		
-		$this->assertInstanceOf('SchedulersJob',$schedulersJob);
-		$this->assertInstanceOf('Basic',$schedulersJob);
-		$this->assertInstanceOf('SugarBean',$schedulersJob);
+    public function testSchedulersJob()
+    {
+        //execute the contructor and check for the Object type and  attributes
+        $schedulersJob = new SchedulersJob();
+		
+        $this->assertInstanceOf('SchedulersJob',$schedulersJob);
+        $this->assertInstanceOf('Basic',$schedulersJob);
+        $this->assertInstanceOf('SugarBean',$schedulersJob);
 			
-		$this->assertAttributeEquals('job_queue', 'table_name', $schedulersJob);
-		$this->assertAttributeEquals('SchedulersJobs', 'module_dir', $schedulersJob);
-		$this->assertAttributeEquals('SchedulersJob', 'object_name', $schedulersJob);
+        $this->assertAttributeEquals('job_queue', 'table_name', $schedulersJob);
+        $this->assertAttributeEquals('SchedulersJobs', 'module_dir', $schedulersJob);
+        $this->assertAttributeEquals('SchedulersJob', 'object_name', $schedulersJob);
 		
 		
-		$this->assertAttributeEquals(true, 'new_schema', $schedulersJob);
-		$this->assertAttributeEquals(true, 'process_save_dates', $schedulersJob);
-		$this->assertAttributeEquals(30, 'min_interval', $schedulersJob);
-		$this->assertAttributeEquals(true, 'job_done', $schedulersJob);
+        $this->assertAttributeEquals(true, 'new_schema', $schedulersJob);
+        $this->assertAttributeEquals(true, 'process_save_dates', $schedulersJob);
+        $this->assertAttributeEquals(30, 'min_interval', $schedulersJob);
+        $this->assertAttributeEquals(true, 'job_done', $schedulersJob);
 		
-	}
+    }
 
-	public function testcheck_date_relationships_load()
-	{
-		error_reporting(E_ERROR | E_PARSE);
+    public function testcheck_date_relationships_load()
+    {
+        error_reporting(E_ERROR | E_PARSE);
 		
-		$schedulersJob = new SchedulersJob();
-		$schedulersJob->execute_time = "2015-01-01 00:00:00";
+        $schedulersJob = new SchedulersJob();
+        $schedulersJob->execute_time = "2015-01-01 00:00:00";
 		
-		$schedulersJob->check_date_relationships_load();
+        $schedulersJob->check_date_relationships_load();
 		
-		$this->assertEquals("2015-01-01 00:00:00",$schedulersJob->execute_time_db);
+        $this->assertEquals("2015-01-01 00:00:00",$schedulersJob->execute_time_db);
 			
-	}
+    }
 
-	public function testhandleDateFormat() {
+    public function testhandleDateFormat() {
 
-		$schedulersJob = new SchedulersJob();
+        $schedulersJob = new SchedulersJob();
 		
-		//test with default params
-		$result = $schedulersJob->handleDateFormat();
-		$this->assertGreaterThan(0,strlen($result));
+        //test with default params
+        $result = $schedulersJob->handleDateFormat();
+        $this->assertGreaterThan(0,strlen($result));
 		
-		//test with a valid date param
-		$result = $schedulersJob->handleDateFormat('2015-01-01');
-		$this->assertEquals("2015-01-01 00:00:00",$result);
+        //test with a valid date param
+        $result = $schedulersJob->handleDateFormat('2015-01-01');
+        $this->assertEquals("2015-01-01 00:00:00",$result);
 		
-	}
+    }
 
 
-	public function testfireUrl()
-	{
-		$schedulersJob = new SchedulersJob();
+    public function testfireUrl()
+    {
+        $schedulersJob = new SchedulersJob();
 		
-		//test with invalid param
-		$result = $schedulersJob->fireUrl("");
-		$this->assertEquals(false,$result);		
+        //test with invalid param
+        $result = $schedulersJob->fireUrl("");
+        $this->assertEquals(false,$result);		
 		
-		//test with valid param
-		$result = $schedulersJob->fireUrl("https://suitecrm.com/");
-		$this->assertEquals(true,$result);
+        //test with valid param
+        $result = $schedulersJob->fireUrl("https://suitecrm.com/");
+        $this->assertEquals(true,$result);
 		
-	}
+    }
 
-	public function testget_list_view_data()
-	{
+    public function testget_list_view_data()
+    {
 
-		$schedulersJob = new SchedulersJob();
+        $schedulersJob = new SchedulersJob();
 		
-		$schedulersJob->job_name = "test";
-		$schedulersJob->job = "function::test";
+        $schedulersJob->job_name = "test";
+        $schedulersJob->job = "function::test";
 		
-		$expected = array(
-				'DELETED' => '0',
-				'REQUEUE' => '0',
-				'JOB_DELAY' => 0,
-				'JOB_NAME' => 'test',
-				'JOB' => 'function::test'
-		);
-		$actual = $schedulersJob->get_list_view_data();
+        $expected = array(
+                'DELETED' => '0',
+                'REQUEUE' => '0',
+                'JOB_DELAY' => 0,
+                'JOB_NAME' => 'test',
+                'JOB' => 'function::test'
+        );
+        $actual = $schedulersJob->get_list_view_data();
 
-		$this->assertSame($expected,$actual);
+        $this->assertSame($expected,$actual);
 			
-	}
+    }
 
 
-	public function testfill_in_additional_list_fields()
-	{
-		$schedulersJob = new SchedulersJob();
+    public function testfill_in_additional_list_fields()
+    {
+        $schedulersJob = new SchedulersJob();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$schedulersJob->fill_in_additional_list_fields();
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $schedulersJob->fill_in_additional_list_fields();
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 
-	}
+    }
 
-	public function testfailJob()
-	{
+    public function testfailJob()
+    {
 
-		$schedulersJob = new SchedulersJob();
+        $schedulersJob = new SchedulersJob();
 		
-		$result = $schedulersJob->failJob();
-		$this->assertEquals(true, $result);
+        $result = $schedulersJob->failJob();
+        $this->assertEquals(true, $result);
 		
-		//test for record ID to verify that record is saved
-		$this->assertTrue(isset($schedulersJob->id));
-		$this->assertEquals(36, strlen($schedulersJob->id));
+        //test for record ID to verify that record is saved
+        $this->assertTrue(isset($schedulersJob->id));
+        $this->assertEquals(36, strlen($schedulersJob->id));
 		
-		$this->assertEquals(SchedulersJob::JOB_STATUS_DONE,$schedulersJob->status);
-		$this->assertEquals(SchedulersJob::JOB_FAILURE,$schedulersJob->resolution);
+        $this->assertEquals(SchedulersJob::JOB_STATUS_DONE,$schedulersJob->status);
+        $this->assertEquals(SchedulersJob::JOB_FAILURE,$schedulersJob->resolution);
 				
-		$schedulersJob->mark_deleted($schedulersJob->id);
+        $schedulersJob->mark_deleted($schedulersJob->id);
 	
-	}
+    }
 
 
-	public function testsucceedJob()
-	{
-		$schedulersJob = new SchedulersJob();
+    public function testsucceedJob()
+    {
+        $schedulersJob = new SchedulersJob();
 		
-		$result = $schedulersJob->succeedJob();
-		$this->assertEquals(true, $result);
+        $result = $schedulersJob->succeedJob();
+        $this->assertEquals(true, $result);
 		
-		//test for record ID to verify that record is saved
-		$this->assertTrue(isset($schedulersJob->id));
-		$this->assertEquals(36, strlen($schedulersJob->id));
+        //test for record ID to verify that record is saved
+        $this->assertTrue(isset($schedulersJob->id));
+        $this->assertEquals(36, strlen($schedulersJob->id));
 		
-		$this->assertEquals(SchedulersJob::JOB_STATUS_DONE,$schedulersJob->status);
-		$this->assertEquals(SchedulersJob::JOB_SUCCESS,$schedulersJob->resolution);
+        $this->assertEquals(SchedulersJob::JOB_STATUS_DONE,$schedulersJob->status);
+        $this->assertEquals(SchedulersJob::JOB_SUCCESS,$schedulersJob->resolution);
 		
-		$schedulersJob->mark_deleted($schedulersJob->id);
+        $schedulersJob->mark_deleted($schedulersJob->id);
 		
-	}
+    }
 
 
-	public function testonFailureRetry()
-	{
-		$schedulersJob = new SchedulersJob();
+    public function testonFailureRetry()
+    {
+        $schedulersJob = new SchedulersJob();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$schedulersJob->onFailureRetry();
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $schedulersJob->onFailureRetry();
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->markTestIncomplete('method has no implementation: logic hooks not defined');
-	}
+        $this->markTestIncomplete('method has no implementation: logic hooks not defined');
+    }
 
 
-	public function testonFinalFailure()
-	{
-		$schedulersJob = new SchedulersJob();
+    public function testonFinalFailure()
+    {
+        $schedulersJob = new SchedulersJob();
 		
-		//execute the method and test if it works and does not throws an exception.
-		try {
-			$schedulersJob->onFinalFailure();
-			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
-			$this->fail();
-		}
+        //execute the method and test if it works and does not throws an exception.
+        try {
+            $schedulersJob->onFinalFailure();
+            $this->assertTrue(true);
+        }
+        catch (Exception $e) {
+            $this->fail();
+        }
 		
-		$this->markTestIncomplete('method has no implementation: logic hooks not defined');
-	}
+        $this->markTestIncomplete('method has no implementation: logic hooks not defined');
+    }
 
 
-	public function testresolveJob()
-	{
+    public function testresolveJob()
+    {
 
-		$schedulersJob = new SchedulersJob();
+        $schedulersJob = new SchedulersJob();
 		
-		//test for JOB_FAILURE
-		$result = $schedulersJob->resolveJob(SchedulersJob::JOB_FAILURE, "test");
-		$this->assertEquals(true, $result);
+        //test for JOB_FAILURE
+        $result = $schedulersJob->resolveJob(SchedulersJob::JOB_FAILURE, "test");
+        $this->assertEquals(true, $result);
 		
-		//test for record ID to verify that record is saved
-		$this->assertTrue(isset($schedulersJob->id));
-		$this->assertEquals(36, strlen($schedulersJob->id));
+        //test for record ID to verify that record is saved
+        $this->assertTrue(isset($schedulersJob->id));
+        $this->assertEquals(36, strlen($schedulersJob->id));
 		
-		$this->assertEquals(SchedulersJob::JOB_STATUS_DONE, $schedulersJob->status);
-		$this->assertEquals(SchedulersJob::JOB_FAILURE, $schedulersJob->resolution);
+        $this->assertEquals(SchedulersJob::JOB_STATUS_DONE, $schedulersJob->status);
+        $this->assertEquals(SchedulersJob::JOB_FAILURE, $schedulersJob->resolution);
 		
 		
-		//tst for JOB_SUCCESS
-		$result = $schedulersJob->resolveJob(SchedulersJob::JOB_SUCCESS, "test");
-		$this->assertEquals(true, $result);
+        //tst for JOB_SUCCESS
+        $result = $schedulersJob->resolveJob(SchedulersJob::JOB_SUCCESS, "test");
+        $this->assertEquals(true, $result);
 
-		$this->assertEquals(SchedulersJob::JOB_STATUS_DONE, $schedulersJob->status);
-		$this->assertEquals(SchedulersJob::JOB_SUCCESS, $schedulersJob->resolution);
+        $this->assertEquals(SchedulersJob::JOB_STATUS_DONE, $schedulersJob->status);
+        $this->assertEquals(SchedulersJob::JOB_SUCCESS, $schedulersJob->resolution);
 		
 		
-		$schedulersJob->mark_deleted($schedulersJob->id);
+        $schedulersJob->mark_deleted($schedulersJob->id);
 		
-	}
+    }
 
 
-	public function testpostponeJobAndMark_deleted()
-	{
-		$schedulersJob = new SchedulersJob();
+    public function testpostponeJobAndMark_deleted()
+    {
+        $schedulersJob = new SchedulersJob();
 		
-		$result = $schedulersJob->postponeJob("test message", 1);
-		$this->assertEquals(true, $result);
+        $result = $schedulersJob->postponeJob("test message", 1);
+        $this->assertEquals(true, $result);
 		
-		//test for record ID to verify that record is saved
-		$this->assertTrue(isset($schedulersJob->id));
-		$this->assertEquals(36, strlen($schedulersJob->id));
+        //test for record ID to verify that record is saved
+        $this->assertTrue(isset($schedulersJob->id));
+        $this->assertEquals(36, strlen($schedulersJob->id));
 		
-		//verify the related attributes
-		$this->assertEquals(SchedulersJob::JOB_STATUS_QUEUED,$schedulersJob->status);
-		$this->assertEquals(SchedulersJob::JOB_PARTIAL,$schedulersJob->resolution);
+        //verify the related attributes
+        $this->assertEquals(SchedulersJob::JOB_STATUS_QUEUED,$schedulersJob->status);
+        $this->assertEquals(SchedulersJob::JOB_PARTIAL,$schedulersJob->resolution);
 		
 		
 		
-		//test mark deleted method and verify record doesn't exist after deletion
-		$schedulersJob->mark_deleted($schedulersJob->id);
-		$result = $schedulersJob->retrieve($schedulersJob->id);
-		$this->assertEquals(null,$result);
+        //test mark deleted method and verify record doesn't exist after deletion
+        $schedulersJob->mark_deleted($schedulersJob->id);
+        $result = $schedulersJob->retrieve($schedulersJob->id);
+        $this->assertEquals(null,$result);
 		
-	}
+    }
 
-	public function testunexpectedExit()
-	{
-		$schedulersJob = new SchedulersJob();
+    public function testunexpectedExit()
+    {
+        $schedulersJob = new SchedulersJob();
 	
-		//create conditions to mark job_done as false
-		$schedulersJob->client = "test";
-		$schedulersJob->status = SchedulersJob::JOB_STATUS_RUNNING;
-		$schedulersJob->save();
-		$result = SchedulersJob::runJobId($schedulersJob->id,"test");
+        //create conditions to mark job_done as false
+        $schedulersJob->client = "test";
+        $schedulersJob->status = SchedulersJob::JOB_STATUS_RUNNING;
+        $schedulersJob->save();
+        $result = SchedulersJob::runJobId($schedulersJob->id,"test");
 	
 	
-		//execute the method
-		$schedulersJob->unexpectedExit();
-		$schedulersJob->retrieve($schedulersJob->id);
-		$this->assertEquals(SchedulersJob::JOB_STATUS_DONE, $schedulersJob->status);
-		$this->assertEquals(SchedulersJob::JOB_FAILURE, $schedulersJob->resolution);
+        //execute the method
+        $schedulersJob->unexpectedExit();
+        $schedulersJob->retrieve($schedulersJob->id);
+        $this->assertEquals(SchedulersJob::JOB_STATUS_DONE, $schedulersJob->status);
+        $this->assertEquals(SchedulersJob::JOB_FAILURE, $schedulersJob->resolution);
 	
-		$schedulersJob->mark_deleted($schedulersJob->id);
+        $schedulersJob->mark_deleted($schedulersJob->id);
 	
-	}
+    }
 	
 	
-	public function testrunJobId()
-	{
+    public function testrunJobId()
+    {
 		
-		//test with invalid job id
-		$result = SchedulersJob::runJobId("1");
-		$this->assertEquals("Job 1 not found.", $result);
+        //test with invalid job id
+        $result = SchedulersJob::runJobId("1");
+        $this->assertEquals("Job 1 not found.", $result);
 
 		
-		//test with valid job id
-		$schedulersJob = new SchedulersJob();
-		$schedulersJob->status = SchedulersJob::JOB_STATUS_DONE;
-		$schedulersJob->save();
+        //test with valid job id
+        $schedulersJob = new SchedulersJob();
+        $schedulersJob->status = SchedulersJob::JOB_STATUS_DONE;
+        $schedulersJob->save();
 		
-		$result = SchedulersJob::runJobId($schedulersJob->id);
-		$this->assertEquals("Job " . $schedulersJob->id . " is not marked as running.", $result);
+        $result = SchedulersJob::runJobId($schedulersJob->id);
+        $this->assertEquals("Job " . $schedulersJob->id . " is not marked as running.", $result);
 		
 		
-		//test with valid job id and status but mismatch client
-		$schedulersJob->client = "client";
-		$schedulersJob->status = SchedulersJob::JOB_STATUS_RUNNING;
-		$schedulersJob->save();
+        //test with valid job id and status but mismatch client
+        $schedulersJob->client = "client";
+        $schedulersJob->status = SchedulersJob::JOB_STATUS_RUNNING;
+        $schedulersJob->save();
 		
-		$result = SchedulersJob::runJobId($schedulersJob->id,"test_client");
+        $result = SchedulersJob::runJobId($schedulersJob->id,"test_client");
 		
-		$this->assertEquals("Job " . $schedulersJob->id . " belongs to another client, can not run as test_client.", $result);
+        $this->assertEquals("Job " . $schedulersJob->id . " belongs to another client, can not run as test_client.", $result);
 
-		$schedulersJob->mark_deleted($schedulersJob->id);
+        $schedulersJob->mark_deleted($schedulersJob->id);
 	
-	}
+    }
 
 
-	public function testerrorHandler()
-	{
-		$schedulersJob = new SchedulersJob();
+    public function testerrorHandler()
+    {
+        $schedulersJob = new SchedulersJob();
 		
-		//execute the method with different Error Types
+        //execute the method with different Error Types
 		 
-		$schedulersJob->errors = "";
-		$schedulersJob->errorHandler(E_USER_WARNING, "test err", 'testfile', '1');
-		$this->assertEquals("Warning [512]: test err in testfile on line 1\n", $schedulersJob->errors );
+        $schedulersJob->errors = "";
+        $schedulersJob->errorHandler(E_USER_WARNING, "test err", 'testfile', '1');
+        $this->assertEquals("Warning [512]: test err in testfile on line 1\n", $schedulersJob->errors );
 		
-		$schedulersJob->errors = "";
-		$schedulersJob->errorHandler(E_ERROR, "test err", 'testfile', '1');
-		$this->assertEquals("Fatal Error [1]: test err in testfile on line 1\n", $schedulersJob->errors );
+        $schedulersJob->errors = "";
+        $schedulersJob->errorHandler(E_ERROR, "test err", 'testfile', '1');
+        $this->assertEquals("Fatal Error [1]: test err in testfile on line 1\n", $schedulersJob->errors );
 		
 		
-		$schedulersJob->errors = "";
-		$schedulersJob->errorHandler(E_PARSE, "test err", 'testfile', '1');
-		$this->assertEquals("Parse Error [4]: test err in testfile on line 1\n", $schedulersJob->errors );
+        $schedulersJob->errors = "";
+        $schedulersJob->errorHandler(E_PARSE, "test err", 'testfile', '1');
+        $this->assertEquals("Parse Error [4]: test err in testfile on line 1\n", $schedulersJob->errors );
 		
 		
-		$schedulersJob->errors = "";
-		$schedulersJob->errorHandler(E_RECOVERABLE_ERROR, "test err", 'testfile', '1');
-		$this->assertEquals("Recoverable Error [4096]: test err in testfile on line 1\n", $schedulersJob->errors );
+        $schedulersJob->errors = "";
+        $schedulersJob->errorHandler(E_RECOVERABLE_ERROR, "test err", 'testfile', '1');
+        $this->assertEquals("Recoverable Error [4096]: test err in testfile on line 1\n", $schedulersJob->errors );
 		
-	}
+    }
 
 
-	public function testrunJob()
-	{
+    public function testrunJob()
+    {
 		
-		//test without a valid user
-		$schedulersJob = new SchedulersJob();
-		$schedulersJob->target = "function::processAOW_Workflow";
-		$result = $schedulersJob->runJob();
-		$this->assertEquals(false, $result);
-		$schedulersJob->mark_deleted($schedulersJob->id);
+        //test without a valid user
+        $schedulersJob = new SchedulersJob();
+        $schedulersJob->target = "function::processAOW_Workflow";
+        $result = $schedulersJob->runJob();
+        $this->assertEquals(false, $result);
+        $schedulersJob->mark_deleted($schedulersJob->id);
 		
 		
-		//test with valid user
-		$schedulersJob = new SchedulersJob();
-		$schedulersJob->assigned_user_id = 1;
+        //test with valid user
+        $schedulersJob = new SchedulersJob();
+        $schedulersJob->assigned_user_id = 1;
 		
-		$schedulersJob->target = "function::processAOW_Workflow";
-		$result = $schedulersJob->runJob();
-		$this->assertEquals(true, $result);
-		$schedulersJob->mark_deleted($schedulersJob->id);
+        $schedulersJob->target = "function::processAOW_Workflow";
+        $result = $schedulersJob->runJob();
+        $this->assertEquals(true, $result);
+        $schedulersJob->mark_deleted($schedulersJob->id);
 		
 		
-		//test with valid user
-		$schedulersJob = new SchedulersJob();
-		$schedulersJob->assigned_user_id = 1;
+        //test with valid user
+        $schedulersJob = new SchedulersJob();
+        $schedulersJob->assigned_user_id = 1;
 		
-		$schedulersJob->target = "url::https://suitecrm.com/";
-		$result = $schedulersJob->runJob();
-		$this->assertEquals(true, $result);
-		$schedulersJob->mark_deleted($schedulersJob->id);
+        $schedulersJob->target = "url::https://suitecrm.com/";
+        $result = $schedulersJob->runJob();
+        $this->assertEquals(true, $result);
+        $schedulersJob->mark_deleted($schedulersJob->id);
 			
-	}
+    }
 
 }  
 

Spacing +24 added lines, -24 removed lines

@@ -9,9 +9,9 @@ 
 		//execute the contructor and check for the Object type and  attributes
 		$schedulersJob = new SchedulersJob();
 		
-		$this->assertInstanceOf('SchedulersJob',$schedulersJob);
-		$this->assertInstanceOf('Basic',$schedulersJob);
-		$this->assertInstanceOf('SugarBean',$schedulersJob);
+		$this->assertInstanceOf('SchedulersJob', $schedulersJob);
+		$this->assertInstanceOf('Basic', $schedulersJob);
+		$this->assertInstanceOf('SugarBean', $schedulersJob);
 			
 		$this->assertAttributeEquals('job_queue', 'table_name', $schedulersJob);
 		$this->assertAttributeEquals('SchedulersJobs', 'module_dir', $schedulersJob);
@@ -34,7 +34,7 @@ 
 		
 		$schedulersJob->check_date_relationships_load();
 		
-		$this->assertEquals("2015-01-01 00:00:00",$schedulersJob->execute_time_db);
+		$this->assertEquals("2015-01-01 00:00:00", $schedulersJob->execute_time_db);
 			
 	}
 
@@ -44,11 +44,11 @@ 
 		
 		//test with default params
 		$result = $schedulersJob->handleDateFormat();
-		$this->assertGreaterThan(0,strlen($result));
+		$this->assertGreaterThan(0, strlen($result));
 		
 		//test with a valid date param
 		$result = $schedulersJob->handleDateFormat('2015-01-01');
-		$this->assertEquals("2015-01-01 00:00:00",$result);
+		$this->assertEquals("2015-01-01 00:00:00", $result);
 		
 	}
 
@@ -59,11 +59,11 @@ 
 		
 		//test with invalid param
 		$result = $schedulersJob->fireUrl("");
-		$this->assertEquals(false,$result);		
+		$this->assertEquals(false, $result);		
 		
 		//test with valid param
 		$result = $schedulersJob->fireUrl("https://suitecrm.com/");
-		$this->assertEquals(true,$result);
+		$this->assertEquals(true, $result);
 		
 	}
 
@@ -84,7 +84,7 @@ 
 		);
 		$actual = $schedulersJob->get_list_view_data();
 
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 			
 	}
 
@@ -116,8 +116,8 @@ 
 		$this->assertTrue(isset($schedulersJob->id));
 		$this->assertEquals(36, strlen($schedulersJob->id));
 		
-		$this->assertEquals(SchedulersJob::JOB_STATUS_DONE,$schedulersJob->status);
-		$this->assertEquals(SchedulersJob::JOB_FAILURE,$schedulersJob->resolution);
+		$this->assertEquals(SchedulersJob::JOB_STATUS_DONE, $schedulersJob->status);
+		$this->assertEquals(SchedulersJob::JOB_FAILURE, $schedulersJob->resolution);
 				
 		$schedulersJob->mark_deleted($schedulersJob->id);
 	
@@ -135,8 +135,8 @@ 
 		$this->assertTrue(isset($schedulersJob->id));
 		$this->assertEquals(36, strlen($schedulersJob->id));
 		
-		$this->assertEquals(SchedulersJob::JOB_STATUS_DONE,$schedulersJob->status);
-		$this->assertEquals(SchedulersJob::JOB_SUCCESS,$schedulersJob->resolution);
+		$this->assertEquals(SchedulersJob::JOB_STATUS_DONE, $schedulersJob->status);
+		$this->assertEquals(SchedulersJob::JOB_SUCCESS, $schedulersJob->resolution);
 		
 		$schedulersJob->mark_deleted($schedulersJob->id);
 		
@@ -219,15 +219,15 @@ 
 		$this->assertEquals(36, strlen($schedulersJob->id));
 		
 		//verify the related attributes
-		$this->assertEquals(SchedulersJob::JOB_STATUS_QUEUED,$schedulersJob->status);
-		$this->assertEquals(SchedulersJob::JOB_PARTIAL,$schedulersJob->resolution);
+		$this->assertEquals(SchedulersJob::JOB_STATUS_QUEUED, $schedulersJob->status);
+		$this->assertEquals(SchedulersJob::JOB_PARTIAL, $schedulersJob->resolution);
 		
 		
 		
 		//test mark deleted method and verify record doesn't exist after deletion
 		$schedulersJob->mark_deleted($schedulersJob->id);
 		$result = $schedulersJob->retrieve($schedulersJob->id);
-		$this->assertEquals(null,$result);
+		$this->assertEquals(null, $result);
 		
 	}
 
@@ -239,7 +239,7 @@ 
 		$schedulersJob->client = "test";
 		$schedulersJob->status = SchedulersJob::JOB_STATUS_RUNNING;
 		$schedulersJob->save();
-		$result = SchedulersJob::runJobId($schedulersJob->id,"test");
+		$result = SchedulersJob::runJobId($schedulersJob->id, "test");
 	
 	
 		//execute the method
@@ -267,7 +267,7 @@ 
 		$schedulersJob->save();
 		
 		$result = SchedulersJob::runJobId($schedulersJob->id);
-		$this->assertEquals("Job " . $schedulersJob->id . " is not marked as running.", $result);
+		$this->assertEquals("Job ".$schedulersJob->id." is not marked as running.", $result);
 		
 		
 		//test with valid job id and status but mismatch client
@@ -275,9 +275,9 @@ 
 		$schedulersJob->status = SchedulersJob::JOB_STATUS_RUNNING;
 		$schedulersJob->save();
 		
-		$result = SchedulersJob::runJobId($schedulersJob->id,"test_client");
+		$result = SchedulersJob::runJobId($schedulersJob->id, "test_client");
 		
-		$this->assertEquals("Job " . $schedulersJob->id . " belongs to another client, can not run as test_client.", $result);
+		$this->assertEquals("Job ".$schedulersJob->id." belongs to another client, can not run as test_client.", $result);
 
 		$schedulersJob->mark_deleted($schedulersJob->id);
 	
@@ -292,21 +292,21 @@ 
 		 
 		$schedulersJob->errors = "";
 		$schedulersJob->errorHandler(E_USER_WARNING, "test err", 'testfile', '1');
-		$this->assertEquals("Warning [512]: test err in testfile on line 1\n", $schedulersJob->errors );
+		$this->assertEquals("Warning [512]: test err in testfile on line 1\n", $schedulersJob->errors);
 		
 		$schedulersJob->errors = "";
 		$schedulersJob->errorHandler(E_ERROR, "test err", 'testfile', '1');
-		$this->assertEquals("Fatal Error [1]: test err in testfile on line 1\n", $schedulersJob->errors );
+		$this->assertEquals("Fatal Error [1]: test err in testfile on line 1\n", $schedulersJob->errors);
 		
 		
 		$schedulersJob->errors = "";
 		$schedulersJob->errorHandler(E_PARSE, "test err", 'testfile', '1');
-		$this->assertEquals("Parse Error [4]: test err in testfile on line 1\n", $schedulersJob->errors );
+		$this->assertEquals("Parse Error [4]: test err in testfile on line 1\n", $schedulersJob->errors);
 		
 		
 		$schedulersJob->errors = "";
 		$schedulersJob->errorHandler(E_RECOVERABLE_ERROR, "test err", 'testfile', '1');
-		$this->assertEquals("Recoverable Error [4096]: test err in testfile on line 1\n", $schedulersJob->errors );
+		$this->assertEquals("Recoverable Error [4096]: test err in testfile on line 1\n", $schedulersJob->errors);
 		
 	}
 

Braces +3 added lines, -6 removed lines

@@ -97,8 +97,7 @@ 
 		try {
 			$schedulersJob->fill_in_additional_list_fields();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 
@@ -151,8 +150,7 @@ 
 		try {
 			$schedulersJob->onFailureRetry();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		
@@ -168,8 +166,7 @@ 
 		try {
 			$schedulersJob->onFinalFailure();
 			$this->assertTrue(true);
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 			$this->fail();
 		}
 		

tests/tests/modules/AOP_Case_Updates/AOP_Case_UpdatesTest.php

Indentation +50 added lines, -50 removed lines

@@ -5,97 +5,97 @@
 	
     public function testAOP_Case_Updates(){
  
-    	//execute the contructor and check for the Object type and  attributes
-    	$aopCaseUpdates = new AOP_Case_Updates();
-    	$this->assertInstanceOf('AOP_Case_Updates',$aopCaseUpdates);
-    	$this->assertInstanceOf('Basic',$aopCaseUpdates);
-    	$this->assertInstanceOf('SugarBean',$aopCaseUpdates);
-    	
-    	$this->assertAttributeEquals('AOP_Case_Updates', 'module_dir', $aopCaseUpdates);
-    	$this->assertAttributeEquals('AOP_Case_Updates', 'object_name', $aopCaseUpdates);
-    	$this->assertAttributeEquals('aop_case_updates', 'table_name', $aopCaseUpdates);
-    	$this->assertAttributeEquals(true, 'new_schema', $aopCaseUpdates);
-    	$this->assertAttributeEquals(true, 'disable_row_level_security', $aopCaseUpdates);
-    	$this->assertAttributeEquals(false, 'importable', $aopCaseUpdates);
-    	$this->assertAttributeEquals(false, 'tracker_visibility', $aopCaseUpdates);
+        //execute the contructor and check for the Object type and  attributes
+        $aopCaseUpdates = new AOP_Case_Updates();
+        $this->assertInstanceOf('AOP_Case_Updates',$aopCaseUpdates);
+        $this->assertInstanceOf('Basic',$aopCaseUpdates);
+        $this->assertInstanceOf('SugarBean',$aopCaseUpdates);
+    	
+        $this->assertAttributeEquals('AOP_Case_Updates', 'module_dir', $aopCaseUpdates);
+        $this->assertAttributeEquals('AOP_Case_Updates', 'object_name', $aopCaseUpdates);
+        $this->assertAttributeEquals('aop_case_updates', 'table_name', $aopCaseUpdates);
+        $this->assertAttributeEquals(true, 'new_schema', $aopCaseUpdates);
+        $this->assertAttributeEquals(true, 'disable_row_level_security', $aopCaseUpdates);
+        $this->assertAttributeEquals(false, 'importable', $aopCaseUpdates);
+        $this->assertAttributeEquals(false, 'tracker_visibility', $aopCaseUpdates);
     	
     }
 
     public function testsave(){
  
-    	error_reporting(E_ERROR | E_PARSE);
-    	
-    	$aopCaseUpdates = new AOP_Case_Updates();
-    	$aopCaseUpdates->name = "test name";
-    	$aopCaseUpdates->description = "test description";
-    	$aopCaseUpdates->case_id = "test case id";
-    	$aopCaseUpdates->contact_id = "test id";
-    	$aopCaseUpdates->internal = 1;
-    	$aopCaseUpdates->save();
+        error_reporting(E_ERROR | E_PARSE);
+    	
+        $aopCaseUpdates = new AOP_Case_Updates();
+        $aopCaseUpdates->name = "test name";
+        $aopCaseUpdates->description = "test description";
+        $aopCaseUpdates->case_id = "test case id";
+        $aopCaseUpdates->contact_id = "test id";
+        $aopCaseUpdates->internal = 1;
+        $aopCaseUpdates->save();
     	   	
-    	//test for record ID to verify that record is saved
-    	$this->assertEquals(36, strlen($aopCaseUpdates->id));
+        //test for record ID to verify that record is saved
+        $this->assertEquals(36, strlen($aopCaseUpdates->id));
     	
-    	//mark the record as deleted for cleanup 
-    	$aopCaseUpdates->mark_deleted($aopCaseUpdates->id);
+        //mark the record as deleted for cleanup 
+        $aopCaseUpdates->mark_deleted($aopCaseUpdates->id);
     	
     }
 
     
     public function testgetCase(){
 
-    	$aopCaseUpdates = new AOP_Case_Updates();
+        $aopCaseUpdates = new AOP_Case_Updates();
     	
-    	//execute the method and verify that it returns a Case object
-    	$result = $aopCaseUpdates->getCase();
+        //execute the method and verify that it returns a Case object
+        $result = $aopCaseUpdates->getCase();
     	
-    	$this->assertInstanceOf('aCase',$result);
+        $this->assertInstanceOf('aCase',$result);
     	    	
     }
 
     public function testgetContacts(){
    
-    	$aopCaseUpdates = new AOP_Case_Updates();
+        $aopCaseUpdates = new AOP_Case_Updates();
     	
-    	//execute the method and verify that it returns an array
-    	$result = $aopCaseUpdates->getContacts();
-    	$this->assertTrue(is_array($result));
+        //execute the method and verify that it returns an array
+        $result = $aopCaseUpdates->getContacts();
+        $this->assertTrue(is_array($result));
     	
     }
 
     public function testgetUpdateContact(){
  
-    	$aopCaseUpdates = new AOP_Case_Updates();
+        $aopCaseUpdates = new AOP_Case_Updates();
     	
-    	//execute the method without contact_id and verify that it returns null
-    	$result = $aopCaseUpdates->getUpdateContact();    	
-    	$this->assertEquals(Null,$result);
+        //execute the method without contact_id and verify that it returns null
+        $result = $aopCaseUpdates->getUpdateContact();    	
+        $this->assertEquals(Null,$result);
     
     	
-    	//execute the method without contact_id and verify that it returns false
-    	$aopCaseUpdates->contact_id = 1;
-    	$result = $aopCaseUpdates->getUpdateContact();
-    	$this->assertEquals(False,$result);
+        //execute the method without contact_id and verify that it returns false
+        $aopCaseUpdates->contact_id = 1;
+        $result = $aopCaseUpdates->getUpdateContact();
+        $this->assertEquals(False,$result);
     	
     }
     
     public function testgetUser(){
     	
-    	$aopCaseUpdates = new AOP_Case_Updates();
+        $aopCaseUpdates = new AOP_Case_Updates();
     	
-    	//execute the method and verify that it returns an instance of User
-    	$result = $aopCaseUpdates->getUser();
-    	$this->assertInstanceOf('User',$result);
+        //execute the method and verify that it returns an instance of User
+        $result = $aopCaseUpdates->getUser();
+        $this->assertInstanceOf('User',$result);
     	
     }
     
     public function testgetUpdateUser(){
 
-    	$aopCaseUpdates = new AOP_Case_Updates();
+        $aopCaseUpdates = new AOP_Case_Updates();
     	
-    	//execute the method and verify that it returns an instance of User
-    	$result = $aopCaseUpdates->getUpdateUser();
-    	$this->assertInstanceOf('User',$result);    	
+        //execute the method and verify that it returns an instance of User
+        $result = $aopCaseUpdates->getUpdateUser();
+        $this->assertInstanceOf('User',$result);    	
     
     }
 

Spacing +15 added lines, -15 removed lines

@@ -3,13 +3,13 @@ 
 class AOP_Case_UpdatesTest extends PHPUnit_Framework_TestCase {
 
 	
-    public function testAOP_Case_Updates(){
+    public function testAOP_Case_Updates() {
  
     	//execute the contructor and check for the Object type and  attributes
     	$aopCaseUpdates = new AOP_Case_Updates();
-    	$this->assertInstanceOf('AOP_Case_Updates',$aopCaseUpdates);
-    	$this->assertInstanceOf('Basic',$aopCaseUpdates);
-    	$this->assertInstanceOf('SugarBean',$aopCaseUpdates);
+    	$this->assertInstanceOf('AOP_Case_Updates', $aopCaseUpdates);
+    	$this->assertInstanceOf('Basic', $aopCaseUpdates);
+    	$this->assertInstanceOf('SugarBean', $aopCaseUpdates);
     	
     	$this->assertAttributeEquals('AOP_Case_Updates', 'module_dir', $aopCaseUpdates);
     	$this->assertAttributeEquals('AOP_Case_Updates', 'object_name', $aopCaseUpdates);
@@ -21,7 +21,7 @@ 
     	
     }
 
-    public function testsave(){
+    public function testsave() {
  
     	error_reporting(E_ERROR | E_PARSE);
     	
@@ -42,18 +42,18 @@ 
     }
 
     
-    public function testgetCase(){
+    public function testgetCase() {
 
     	$aopCaseUpdates = new AOP_Case_Updates();
     	
     	//execute the method and verify that it returns a Case object
     	$result = $aopCaseUpdates->getCase();
     	
-    	$this->assertInstanceOf('aCase',$result);
+    	$this->assertInstanceOf('aCase', $result);
     	    	
     }
 
-    public function testgetContacts(){
+    public function testgetContacts() {
    
     	$aopCaseUpdates = new AOP_Case_Updates();
     	
@@ -63,39 +63,39 @@ 
     	
     }
 
-    public function testgetUpdateContact(){
+    public function testgetUpdateContact() {
  
     	$aopCaseUpdates = new AOP_Case_Updates();
     	
     	//execute the method without contact_id and verify that it returns null
     	$result = $aopCaseUpdates->getUpdateContact();    	
-    	$this->assertEquals(Null,$result);
+    	$this->assertEquals(Null, $result);
     
     	
     	//execute the method without contact_id and verify that it returns false
     	$aopCaseUpdates->contact_id = 1;
     	$result = $aopCaseUpdates->getUpdateContact();
-    	$this->assertEquals(False,$result);
+    	$this->assertEquals(False, $result);
     	
     }
     
-    public function testgetUser(){
+    public function testgetUser() {
     	
     	$aopCaseUpdates = new AOP_Case_Updates();
     	
     	//execute the method and verify that it returns an instance of User
     	$result = $aopCaseUpdates->getUser();
-    	$this->assertInstanceOf('User',$result);
+    	$this->assertInstanceOf('User', $result);
     	
     }
     
-    public function testgetUpdateUser(){
+    public function testgetUpdateUser() {
 
     	$aopCaseUpdates = new AOP_Case_Updates();
     	
     	//execute the method and verify that it returns an instance of User
     	$result = $aopCaseUpdates->getUpdateUser();
-    	$this->assertInstanceOf('User',$result);    	
+    	$this->assertInstanceOf('User', $result);    	
     
     }
 

tests/tests/modules/jjwg_Markers/jjwg_MarkersTest.php

Indentation +44 added lines, -44 removed lines

@@ -6,88 +6,88 @@
 
     public function testjjwg_Markers() {
 
-    	//execute the contructor and check for the Object type and  attributes
-    	$jjwgMarkers = new jjwg_Markers();
+        //execute the contructor and check for the Object type and  attributes
+        $jjwgMarkers = new jjwg_Markers();
     	
-    	$this->assertInstanceOf('jjwg_Markers',$jjwgMarkers);
-    	$this->assertInstanceOf('Basic',$jjwgMarkers);
-    	$this->assertInstanceOf('SugarBean',$jjwgMarkers);
+        $this->assertInstanceOf('jjwg_Markers',$jjwgMarkers);
+        $this->assertInstanceOf('Basic',$jjwgMarkers);
+        $this->assertInstanceOf('SugarBean',$jjwgMarkers);
     	 
-    	$this->assertAttributeEquals('jjwg_Markers', 'module_dir', $jjwgMarkers);
-    	$this->assertAttributeEquals('jjwg_Markers', 'object_name', $jjwgMarkers);
-    	$this->assertAttributeEquals('jjwg_markers', 'table_name', $jjwgMarkers);
+        $this->assertAttributeEquals('jjwg_Markers', 'module_dir', $jjwgMarkers);
+        $this->assertAttributeEquals('jjwg_Markers', 'object_name', $jjwgMarkers);
+        $this->assertAttributeEquals('jjwg_markers', 'table_name', $jjwgMarkers);
     	 
-    	$this->assertAttributeEquals(true, 'new_schema', $jjwgMarkers);
-    	$this->assertAttributeEquals(true, 'importable', $jjwgMarkers);
-    	$this->assertAttributeEquals(true, 'disable_row_level_security', $jjwgMarkers);
+        $this->assertAttributeEquals(true, 'new_schema', $jjwgMarkers);
+        $this->assertAttributeEquals(true, 'importable', $jjwgMarkers);
+        $this->assertAttributeEquals(true, 'disable_row_level_security', $jjwgMarkers);
 
     }
 
 
     public function testconfiguration() {
 
-    	error_reporting(E_ERROR | E_PARSE);
+        error_reporting(E_ERROR | E_PARSE);
     	
-    	$jjwgMarkers = new jjwg_Markers();
+        $jjwgMarkers = new jjwg_Markers();
     	
-    	$jjwgMarkers->configuration();
+        $jjwgMarkers->configuration();
     	 
-    	$this->assertInstanceOf('jjwg_Maps',$jjwgMarkers->jjwg_Maps);
-    	$this->assertTrue(is_array($jjwgMarkers->settings));
-    	$this->assertGreaterThan(0,count($jjwgMarkers->settings));
+        $this->assertInstanceOf('jjwg_Maps',$jjwgMarkers->jjwg_Maps);
+        $this->assertTrue(is_array($jjwgMarkers->settings));
+        $this->assertGreaterThan(0,count($jjwgMarkers->settings));
     	
     }
 
 
     public function testdefine_loc() {
 
-    	$jjwgMarkers = new jjwg_Markers();
+        $jjwgMarkers = new jjwg_Markers();
     	
-    	//test without pre settting attributes
-    	$result = $jjwgMarkers->define_loc(array());
-    	$this->assertEquals("N/A", $result['name']);
-    	$this->assertTrue(is_numeric($result['lat']));
-    	$this->assertTrue(is_numeric($result['lng']));
-    	$this->assertEquals("company", $result['image']);
+        //test without pre settting attributes
+        $result = $jjwgMarkers->define_loc(array());
+        $this->assertEquals("N/A", $result['name']);
+        $this->assertTrue(is_numeric($result['lat']));
+        $this->assertTrue(is_numeric($result['lng']));
+        $this->assertEquals("company", $result['image']);
     	
     	 
     	 
-    	//test with required attributes preset
-    	$marker = array("name"=>"test", "lat"=>50, "lng"=>100, "image"=>null);
-    	$result = $jjwgMarkers->define_loc($marker);
-    	$this->assertSame($marker, $result);
+        //test with required attributes preset
+        $marker = array("name"=>"test", "lat"=>50, "lng"=>100, "image"=>null);
+        $result = $jjwgMarkers->define_loc($marker);
+        $this->assertSame($marker, $result);
     	
     }
 
     public function testis_valid_lng() {
 
-    	$jjwgMarkers = new jjwg_Markers();
+        $jjwgMarkers = new jjwg_Markers();
 
-    	//test with invalid values
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lng('') );
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lng(181) );
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lng(-181) );
+        //test with invalid values
+        $this->assertEquals(false, $jjwgMarkers->is_valid_lng('') );
+        $this->assertEquals(false, $jjwgMarkers->is_valid_lng(181) );
+        $this->assertEquals(false, $jjwgMarkers->is_valid_lng(-181) );
     	 
-    	//test with valid values
-    	$this->assertEquals(true, $jjwgMarkers->is_valid_lng(180) );
-    	$this->assertEquals(true, $jjwgMarkers->is_valid_lng(-180) );
+        //test with valid values
+        $this->assertEquals(true, $jjwgMarkers->is_valid_lng(180) );
+        $this->assertEquals(true, $jjwgMarkers->is_valid_lng(-180) );
     	
     }
 
 
     public function testis_valid_lat() {
 
-    	$jjwgMarkers = new jjwg_Markers();
+        $jjwgMarkers = new jjwg_Markers();
     	
-    	//test with invalid values
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lat('') );
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lat(91) );
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lat(-91) );
+        //test with invalid values
+        $this->assertEquals(false, $jjwgMarkers->is_valid_lat('') );
+        $this->assertEquals(false, $jjwgMarkers->is_valid_lat(91) );
+        $this->assertEquals(false, $jjwgMarkers->is_valid_lat(-91) );
     	 
     	
-    	//test with valid values
-    	$this->assertEquals(true, $jjwgMarkers->is_valid_lat(90) );
-    	$this->assertEquals(true, $jjwgMarkers->is_valid_lat(-90) );
+        //test with valid values
+        $this->assertEquals(true, $jjwgMarkers->is_valid_lat(90) );
+        $this->assertEquals(true, $jjwgMarkers->is_valid_lat(-90) );
     
     }
 

Spacing +15 added lines, -15 removed lines

@@ -9,9 +9,9 @@ 
     	//execute the contructor and check for the Object type and  attributes
     	$jjwgMarkers = new jjwg_Markers();
     	
-    	$this->assertInstanceOf('jjwg_Markers',$jjwgMarkers);
-    	$this->assertInstanceOf('Basic',$jjwgMarkers);
-    	$this->assertInstanceOf('SugarBean',$jjwgMarkers);
+    	$this->assertInstanceOf('jjwg_Markers', $jjwgMarkers);
+    	$this->assertInstanceOf('Basic', $jjwgMarkers);
+    	$this->assertInstanceOf('SugarBean', $jjwgMarkers);
     	 
     	$this->assertAttributeEquals('jjwg_Markers', 'module_dir', $jjwgMarkers);
     	$this->assertAttributeEquals('jjwg_Markers', 'object_name', $jjwgMarkers);
@@ -32,9 +32,9 @@ 
     	
     	$jjwgMarkers->configuration();
     	 
-    	$this->assertInstanceOf('jjwg_Maps',$jjwgMarkers->jjwg_Maps);
+    	$this->assertInstanceOf('jjwg_Maps', $jjwgMarkers->jjwg_Maps);
     	$this->assertTrue(is_array($jjwgMarkers->settings));
-    	$this->assertGreaterThan(0,count($jjwgMarkers->settings));
+    	$this->assertGreaterThan(0, count($jjwgMarkers->settings));
     	
     }
 
@@ -64,13 +64,13 @@ 
     	$jjwgMarkers = new jjwg_Markers();
 
     	//test with invalid values
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lng('') );
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lng(181) );
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lng(-181) );
+    	$this->assertEquals(false, $jjwgMarkers->is_valid_lng(''));
+    	$this->assertEquals(false, $jjwgMarkers->is_valid_lng(181));
+    	$this->assertEquals(false, $jjwgMarkers->is_valid_lng(-181));
     	 
     	//test with valid values
-    	$this->assertEquals(true, $jjwgMarkers->is_valid_lng(180) );
-    	$this->assertEquals(true, $jjwgMarkers->is_valid_lng(-180) );
+    	$this->assertEquals(true, $jjwgMarkers->is_valid_lng(180));
+    	$this->assertEquals(true, $jjwgMarkers->is_valid_lng(-180));
     	
     }
 
@@ -80,14 +80,14 @@ 
     	$jjwgMarkers = new jjwg_Markers();
     	
     	//test with invalid values
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lat('') );
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lat(91) );
-    	$this->assertEquals(false, $jjwgMarkers->is_valid_lat(-91) );
+    	$this->assertEquals(false, $jjwgMarkers->is_valid_lat(''));
+    	$this->assertEquals(false, $jjwgMarkers->is_valid_lat(91));
+    	$this->assertEquals(false, $jjwgMarkers->is_valid_lat(-91));
     	 
     	
     	//test with valid values
-    	$this->assertEquals(true, $jjwgMarkers->is_valid_lat(90) );
-    	$this->assertEquals(true, $jjwgMarkers->is_valid_lat(-90) );
+    	$this->assertEquals(true, $jjwgMarkers->is_valid_lat(90));
+    	$this->assertEquals(true, $jjwgMarkers->is_valid_lat(-90));
     
     }