adamjakab /
SuiteCRM
| Conditions | 13 |
| Paths | 960 |
| Total Lines | 69 |
| Code Lines | 46 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 182 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 42 | function additionalDetailsMeeting($fields) { |
||
| 43 | global $timedate; |
||
| 44 | static $mod_strings; |
||
| 45 | if(empty($mod_strings)) { |
||
| 46 | global $current_language; |
||
| 47 | $mod_strings = return_module_language($current_language, 'Meetings'); |
||
| 48 | } |
||
| 49 | // ini_set('display_errors', true); |
||
| 50 | // print_r($fields); |
||
| 51 | $overlib_string = ''; |
||
| 52 | $overlib_string .= '<input id="type" type="hidden" value="Meeting"/>'; |
||
| 53 | if(!empty($fields['ID'])) { |
||
| 54 | $overlib_string .= '<input id="id" type="hidden" value="'. $fields['ID']; |
||
| 55 | $overlib_string .= '"/>'; |
||
| 56 | } |
||
| 57 | |||
| 58 | $overlib_string .= '<h2><img src="index.php?entryPoint=getImage&themeName=' . SugarThemeRegistry::current()->name .'&imageName=Meetings.gif"/> '.$mod_strings['LBL_MEETING'].'</h2>'; |
||
|
|
|||
| 59 | |||
| 60 | if(!empty($fields['NAME'])) { |
||
| 61 | $overlib_string .= '<b>'.$mod_strings['LBL_SUBJECT'].'</b> <a href="index.php?action=DetailView&module=Meetings&record='.$fields['ID'].'">'. $fields['NAME'] . '</a>'; |
||
| 62 | $overlib_string .= '<br>'; |
||
| 63 | } |
||
| 64 | if(!empty($fields['DATE_START'])) { |
||
| 65 | // Make it easy to select for sorting in schedule bar |
||
| 66 | $data_date = $timedate->fromUser($fields['DATE_START'])->format('Y-m-d H:i:s'); |
||
| 67 | $overlib_string .= '<span data-field="DATE_START" data-date="'.$data_date.'">'; |
||
| 68 | $overlib_string .= '<b>'. $mod_strings['LBL_DATE_TIME'] . '</b> ' . $fields['DATE_START'] . ' <br>'; |
||
| 69 | $overlib_string .= '</span>'; |
||
| 70 | } |
||
| 71 | |||
| 72 | if(isset($fields['DURATION_HOURS']) || isset($fields['DURATION_MINUTES'])) { |
||
| 73 | $overlib_string .= '<b>'. $mod_strings['LBL_DURATION'] . '</b> '; |
||
| 74 | if(isset($fields['DURATION_HOURS'])) { |
||
| 75 | $overlib_string .= $fields['DURATION_HOURS'] . $mod_strings['LBL_HOURS_ABBREV'] . ' '; |
||
| 76 | } |
||
| 77 | if(isset($fields['DURATION_MINUTES'])) { |
||
| 78 | $overlib_string .= $fields['DURATION_MINUTES'] . $mod_strings['LBL_MINSS_ABBREV']; |
||
| 79 | } |
||
| 80 | $overlib_string .= '<br>'; |
||
| 81 | } |
||
| 82 | if (!empty($fields['PARENT_ID'])) |
||
| 83 | { |
||
| 84 | $overlib_string .= "<b>". $mod_strings['LBL_RELATED_TO'] . "</b> ". |
||
| 85 | "<a href='index.php?module=".$fields['PARENT_TYPE']."&action=DetailView&record=".$fields['PARENT_ID']."'>". |
||
| 86 | $fields['PARENT_TYPE'] .' - '. $fields['PARENT_NAME'] . "</a>"; |
||
| 87 | $overlib_string .= '<br>'; |
||
| 88 | } |
||
| 89 | |||
| 90 | if(!empty($fields['STATUS'])) { |
||
| 91 | $overlib_string .= '<b>'. $mod_strings['LBL_STATUS'] . '</b> ' . $fields['STATUS']; |
||
| 92 | $overlib_string .= '<br>'; |
||
| 93 | } |
||
| 94 | |||
| 95 | if(!empty($fields['DESCRIPTION'])) { |
||
| 96 | $overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ' . substr($fields['DESCRIPTION'], 0, 300); |
||
| 97 | if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...'; |
||
| 98 | $overlib_string .= '<br>'; |
||
| 99 | } |
||
| 100 | $overlib_string .= '<br>'; |
||
| 101 | |||
| 102 | $editLink = "index.php?action=EditView&module=Meetings&record={$fields['ID']}"; |
||
| 103 | $viewLink = "index.php?action=DetailView&module=Meetings&record={$fields['ID']}"; |
||
| 104 | |||
| 105 | return array('fieldToAddTo' => 'NAME', |
||
| 106 | 'string' => $overlib_string, |
||
| 107 | 'editLink' => $editLink, |
||
| 108 | 'viewLink' => $viewLink); |
||
| 109 | |||
| 110 | } |
||
| 111 | |||
| 112 | ?> |
Since your code implements the magic setter
_set, this function will be called for any write access on an undefined variable. You can add the@propertyannotation to your class or interface to document the existence of this variable.Since the property has write access only, you can use the @property-write annotation instead.
Of course, you may also just have mistyped another name, in which case you should fix the error.
See also the PhpDoc documentation for @property.