adamjakab /
SuiteCRM
| Conditions | 34 |
| Paths | > 20000 |
| Total Lines | 115 |
| Code Lines | 70 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 1190 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 254 | function copyInputsIntoSession(){ |
||
| 255 | if(isset($_REQUEST['setup_db_type'])){$_SESSION['setup_db_type'] = $_REQUEST['setup_db_type'];} |
||
| 256 | if(isset($_REQUEST['setup_db_admin_user_name'])){$_SESSION['setup_db_admin_user_name'] = $_REQUEST['setup_db_admin_user_name'];} |
||
| 257 | if(isset($_REQUEST['setup_db_admin_password'])){$_SESSION['setup_db_admin_password'] = $_REQUEST['setup_db_admin_password'];} |
||
| 258 | if(isset($_REQUEST['setup_db_database_name'])){$_SESSION['setup_db_database_name'] = $_REQUEST['setup_db_database_name'];} |
||
| 259 | if(isset($_REQUEST['setup_db_host_name'])){$_SESSION['setup_db_host_name'] = $_REQUEST['setup_db_host_name'];} |
||
| 260 | |||
| 261 | //FTS Support |
||
| 262 | if (isset($_REQUEST['setup_fts_type'])) { |
||
| 263 | $_SESSION['setup_fts_type'] = $_REQUEST['setup_fts_type']; |
||
| 264 | } |
||
| 265 | if (isset($_REQUEST['setup_fts_host'])) { |
||
| 266 | $_SESSION['setup_fts_host'] = $_REQUEST['setup_fts_host']; |
||
| 267 | } |
||
| 268 | if (isset($_REQUEST['setup_fts_port'])) { |
||
| 269 | $_SESSION['setup_fts_port'] = $_REQUEST['setup_fts_port']; |
||
| 270 | } |
||
| 271 | |||
| 272 | if(isset($_SESSION['setup_db_type']) && (!isset($_SESSION['setup_db_manager']) || isset($_REQUEST['setup_db_type']))) { |
||
| 273 | $_SESSION['setup_db_manager'] = DBManagerFactory::getManagerByType($_SESSION['setup_db_type']); |
||
| 274 | } |
||
| 275 | |||
| 276 | if(isset($_REQUEST['setup_db_host_instance'])){ |
||
| 277 | $_SESSION['setup_db_host_instance'] = $_REQUEST['setup_db_host_instance']; |
||
| 278 | } |
||
| 279 | |||
| 280 | if(isset($_REQUEST['setup_db_port_num'])){ |
||
| 281 | $_SESSION['setup_db_port_num'] = $_REQUEST['setup_db_port_num']; |
||
| 282 | } |
||
| 283 | |||
| 284 | // on a silent install, copy values from $_SESSION into $_REQUEST |
||
| 285 | if (isset($_REQUEST['goto']) && $_REQUEST['goto'] == 'SilentInstall') { |
||
| 286 | if (isset($_SESSION['dbUSRData']) && !empty($_SESSION['dbUSRData'])) |
||
| 287 | $_REQUEST['dbUSRData'] = $_SESSION['dbUSRData']; |
||
| 288 | else $_REQUEST['dbUSRData'] = 'same'; |
||
| 289 | |||
| 290 | if (isset($_SESSION['setup_db_sugarsales_user']) && !empty($_SESSION['setup_db_sugarsales_user'])) |
||
| 291 | $_REQUEST['setup_db_sugarsales_user'] = $_SESSION['setup_db_sugarsales_user']; |
||
| 292 | else $_REQUEST['dbUSRData'] = 'same'; |
||
| 293 | |||
| 294 | $_REQUEST['setup_db_sugarsales_password'] = $_SESSION['setup_db_sugarsales_password']; |
||
| 295 | $_REQUEST['setup_db_sugarsales_password_retype'] = $_SESSION['setup_db_sugarsales_password']; |
||
| 296 | } |
||
| 297 | |||
| 298 | //make sure we are creating or using provided user for app db connections |
||
| 299 | $_SESSION['setup_db_create_sugarsales_user'] = true;//get_boolean_from_request('setup_db_create_sugarsales_user'); |
||
| 300 | $db = getInstallDbInstance(); |
||
| 301 | if( !$db->supports("create_user") ){ |
||
| 302 | //if the DB doesn't support creating users, make the admin user/password same as connecting user/password |
||
| 303 | $_SESSION['setup_db_sugarsales_user'] = $_SESSION['setup_db_admin_user_name']; |
||
| 304 | $_SESSION['setup_db_sugarsales_password'] = $_SESSION['setup_db_admin_password']; |
||
| 305 | $_SESSION['setup_db_sugarsales_password_retype'] = $_SESSION['setup_db_sugarsales_password']; |
||
| 306 | $_SESSION['setup_db_create_sugarsales_user'] = false; |
||
| 307 | $_SESSION['setup_db_create_database'] = false; |
||
| 308 | |||
| 309 | } else { |
||
| 310 | $_SESSION['setup_db_create_database'] = true; |
||
| 311 | //retrieve the value from dropdown in order to know what settings the user |
||
| 312 | //wants to use for the sugar db user. |
||
| 313 | |||
| 314 | //use provided db admin by default |
||
| 315 | $_SESSION['dbUSRData'] = 'same'; |
||
| 316 | |||
| 317 | if(isset($_REQUEST['dbUSRData']) && !empty($_REQUEST['dbUSRData'])){ |
||
| 318 | $_SESSION['dbUSRData'] = $_REQUEST['dbUSRData']; |
||
| 319 | } |
||
| 320 | |||
| 321 | |||
| 322 | if($_SESSION['dbUSRData'] == 'auto'){ |
||
| 323 | //create user automatically |
||
| 324 | $_SESSION['setup_db_create_sugarsales_user'] = true; |
||
| 325 | $_SESSION['setup_db_sugarsales_user'] = "sugar".create_db_user_creds(5); |
||
| 326 | $_SESSION['setup_db_sugarsales_password'] = create_db_user_creds(10); |
||
| 327 | $_SESSION['setup_db_sugarsales_password_retype'] = $_SESSION['setup_db_sugarsales_password']; |
||
| 328 | }elseif($_SESSION['dbUSRData'] == 'provide'){ |
||
| 329 | //use provided user info |
||
| 330 | $_SESSION['setup_db_create_sugarsales_user'] = false; |
||
| 331 | $_SESSION['setup_db_sugarsales_user'] = $_REQUEST['setup_db_sugarsales_user']; |
||
| 332 | $_SESSION['setup_db_sugarsales_password'] = $_REQUEST['setup_db_sugarsales_password']; |
||
| 333 | $_SESSION['setup_db_sugarsales_password_retype'] = $_REQUEST['setup_db_sugarsales_password_retype']; |
||
| 334 | }elseif($_SESSION['dbUSRData'] == 'create'){ |
||
| 335 | // create user with provided info |
||
| 336 | $_SESSION['setup_db_create_sugarsales_user'] = true; |
||
| 337 | $_SESSION['setup_db_sugarsales_user'] = $_REQUEST['setup_db_sugarsales_user']; |
||
| 338 | $_SESSION['setup_db_sugarsales_password'] = $_REQUEST['setup_db_sugarsales_password']; |
||
| 339 | $_SESSION['setup_db_sugarsales_password_retype'] = $_REQUEST['setup_db_sugarsales_password_retype']; |
||
| 340 | }else{ |
||
| 341 | //Use the same login as provided admin user |
||
| 342 | $_SESSION['setup_db_create_sugarsales_user'] = false; |
||
| 343 | $_SESSION['setup_db_sugarsales_user'] = $_SESSION['setup_db_admin_user_name']; |
||
| 344 | $_SESSION['setup_db_sugarsales_password'] = $_SESSION['setup_db_admin_password']; |
||
| 345 | $_SESSION['setup_db_sugarsales_retype'] = $_SESSION['setup_db_admin_password']; |
||
| 346 | } |
||
| 347 | } |
||
| 348 | |||
| 349 | if(!isset($_SESSION['demoData']) || empty($_SESSION['demoData'])){ |
||
| 350 | $_SESSION['demoData'] = 'no'; |
||
| 351 | } |
||
| 352 | if(isset($_REQUEST['demoData'])){$_SESSION['demoData'] = $_REQUEST['demoData'] ;} |
||
| 353 | |||
| 354 | if($db->supports('create_db')) { |
||
| 355 | if(!empty($_SESSION['setup_db_create_database'])) { |
||
| 356 | // if we're dropping DB, no need to drop tables |
||
| 357 | $_SESSION['setup_db_drop_tables'] = false; |
||
| 358 | } |
||
| 359 | } else { |
||
| 360 | // we can't create DB, so can't drop it |
||
| 361 | $_SESSION['setup_db_create_database'] = false; |
||
| 362 | } |
||
| 363 | |||
| 364 | if (isset($_REQUEST['goto']) && $_REQUEST['goto'] == 'SilentInstall' && isset($_SESSION['setup_db_drop_tables'])) { |
||
| 365 | //set up for Oracle Silent Installer |
||
| 366 | $_REQUEST['setup_db_drop_tables'] = $_SESSION['setup_db_drop_tables'] ; |
||
| 367 | } |
||
| 368 | } |
||
| 369 | |||
| 373 |
Loading history...
When comparing two booleans, it is generally considered safer to use the strict comparison operator.