Helper::camelCase()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 11
Code Lines 7

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 8
CRAP Score 1

Importance

Changes 0
Metric Value
dl 0
loc 11
ccs 8
cts 8
cp 1
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 7
nc 1
nop 1
crap 1
1
<?php
2
/**
3
 * Helper class
4
 */
5
6
namespace IBM\Watson\Common;
7
8
/**
9
 * Helper class
10
 *
11
 * This class defines various static utility functions that are used
12
 * throughout the Watson system
13
 */
14
class Helper
15
{
16
    /**
17
     * Convert string to camelCase. Strings already in camelCase will not be affected.
18
     * @param string $str Input string
19
     * @return string camelCased output string
20
     */
21 18
    public static function camelCase($str)
22
    {
23 18
        $str = self::convertToLowercase($str);
24 18
        return preg_replace_callback(
25 18
            '/_([a-z])/',
26 18
            function ($match) {
27 6
                return strtoupper($match[1]);
28 18
            },
29
            $str
30 12
        );
31
    }
32
33
    /**
34
     * Initialize an object with given array of parameters
35
     *
36
     * @param mixed $target     The object to set parameters on
37
     * @param array $parameters An array of parametes to set
38
     */
39 57
    public static function initialize($target, $parameters)
40
    {
41 57
        if (is_array($parameters)) {
42 51
            foreach ($parameters as $key => $value) {
43 9
                $method = 'set'.ucfirst(static::camelCase($key));
44 9
                if (method_exists($target, $method)) {
45 9
                    $target->$method($value);
46 6
                }
47 34
            }
48 34
        }
49 57
    }
50
51
    /**
52
     * Convert strings with underscore to be all lowercase before camelCase is performed.
53
     * @param string $str Input string
54
     * @return string Output string
55
     */
56 18
    protected static function convertToLowercase($str)
57
    {
58 18
        $explodedStr = explode('_', $str);
59
60 18
        if (count($explodedStr) > 1) {
61 6
            foreach ($explodedStr as $value) {
62 6
                $lowercasedStr[] = strtolower($value);
0 ignored issues
show
Coding Style Comprehensibility introduced by
$lowercasedStr was never initialized. Although not strictly required by PHP, it is generally a good practice to add $lowercasedStr = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
63 4
            }
64 6
            $str = implode('_', $lowercasedStr);
0 ignored issues
show
Bug introduced by
The variable $lowercasedStr does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
65 4
        }
66
67 18
        return $str;
68
    }
69
}
70