IBM\Watson\Common\Hydrator\ArrayHydrator

Complexity

Total Complexity

3

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	hydrate()	0	17	3

<?php

declare(strict_types=1);

namespace IBM\Watson\Common\Hydrator;

use Psr\Http\Message\ResponseInterface;

/**
 * The ArrayHydrator will hydrate a json response into an associative array.
 */
class ArrayHydrator extends AbstractHydrator
{
    /**
     * @param \Psr\Http\Message\ResponseInterface $response Response to hydrate.
     * @param string|null                         $class    Class to hydrate to.
     *
     * @return array
     *
     * @throws \BadMethodCallException
     */
    public function hydrate(ResponseInterface $response, string $class = null): array
    {
        if (!$this->isJsonResponse($response)) {
            $message = 'The ArrayHydrator cannot hydrate a response with Content-Type: ';
            throw new \BadMethodCallException($message.$response->getHeaderLine(self::HEADER_CONTENT_TYPE));
        }

        $body = $this->getBodyContent($response);
        if (JSON_ERROR_NONE !== \json_last_error()) {
            throw new \BadMethodCallException(sprintf(
                'Error (%d) when trying to json_decode response: %s',
                \json_last_error(),
                \json_last_error_msg()
            ));
        }

        return $body;

The expression return $body could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }
}