AbstractClient::__construct() - Code Metrics - Inspection of "Code quality" - adam-paterson/ibm-watson-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#19)

by Adam

created 2017-10-07 08:56 UTC

AbstractClient::__construct() A

↳ Parent: AbstractClient

Complexity

Conditions	4
Paths	8

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	4

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	9
ccs	5
cts	5
cp	1
rs	9.2
cc	4
eloc	7
nc	8
nop	3
crap	4

<?php

namespace IBM\Watson\Common;

use Http\Client\HttpClient;
use Http\Discovery\HttpClientDiscovery;
use IBM\Watson\Common\Hydrator\HydratorInterface;
use IBM\Watson\Common\Hydrator\ModelHydrator;

abstract class AbstractClient
{
    /**
     * @var \IBM\Watson\Common\Hydrator\ModelHydrator
     */
    protected $hydrator;

    /**
     * @var \Http\Client\HttpClient
     */
    protected $httpClient;

    /**
     * @var \IBM\Watson\Common\RequestBuilder
     */
    protected $requestBuilder;

    /**
     * Client constructor.
     *
     * @param \Http\Client\HttpClient|null                       $httpClient
     * @param \IBM\Watson\Common\Hydrator\HydratorInterface|null $hydrator
     * @param \IBM\Watson\Common\RequestBuilder|null             $requestBuilder
     *
     * @throws \Http\Discovery\Exception\NotFoundException
     */
    public function __construct(
        HttpClient $httpClient = null,
        HydratorInterface $hydrator = null,
        RequestBuilder $requestBuilder = null
    ) {
        $this->httpClient = $httpClient ?: HttpClientDiscovery::find();
        $this->hydrator = $hydrator ?: new ModelHydrator;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->requestBuilder = $requestBuilder ?: new RequestBuilder;
    }
}


1		<?php
2
3		namespace IBM\Watson\Common;
4
5		use Http\Client\HttpClient;
6		use Http\Discovery\HttpClientDiscovery;
7		use IBM\Watson\Common\Hydrator\HydratorInterface;
8		use IBM\Watson\Common\Hydrator\ModelHydrator;
9
10		abstract class AbstractClient
11		{
12		/**
13		* @var \IBM\Watson\Common\Hydrator\ModelHydrator
14		*/
15		protected $hydrator;
16
17		/**
18		* @var \Http\Client\HttpClient
19		*/
20		protected $httpClient;
21
22		/**
23		* @var \IBM\Watson\Common\RequestBuilder
24		*/
25		protected $requestBuilder;
26
27		/**
28		* Client constructor.
29		*
30		* @param \Http\Client\HttpClient\|null $httpClient
31		* @param \IBM\Watson\Common\Hydrator\HydratorInterface\|null $hydrator
32		* @param \IBM\Watson\Common\RequestBuilder\|null $requestBuilder
33		*
34		* @throws \Http\Discovery\Exception\NotFoundException
35		*/
36	15	public function __construct(
37		HttpClient $httpClient = null,
38		HydratorInterface $hydrator = null,
39		RequestBuilder $requestBuilder = null
40		) {
41	15	$this->httpClient = $httpClient ?: HttpClientDiscovery::find();
42	15	$this->hydrator = $hydrator ?: new ModelHydrator;
		0 ignored issues – show Documentation Bug introduced 2017-10-06 12:00 UTC by Report Bug Copy Issue Report `$hydrator ?: new \IBM\Wa...ydrator\ModelHydrator()` is of type `object<IBM\Watson\Common...ator\HydratorInterface>`, but the property `$hydrator` was declared to be of type `object<IBM\Watson\Common\Hydrator\ModelHydrator>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
43	15	$this->requestBuilder = $requestBuilder ?: new RequestBuilder;
44	15	}
45		}
46

adam-paterson / ibm-watson-sdk

Pull Request — develop (#19)

AbstractClient::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like