IBM\Watson\Common\Hydrator\ArrayHydrator::hydrate()

Complexity

Conditions	3
Paths	3

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function hydrate(ResponseInterface $response, string $class = null): array
    {
        if (!$this->isJsonResponse($response)) {
            $message = 'The ArrayHydrator cannot hydrate a response with Content-Type: ';

            throw new \BadMethodCallException($message.$response->getHeaderLine(self::HEADER_CONTENT_TYPE));
        }

        $body = $this->getBodyContent($response);
        if (JSON_ERROR_NONE !== \json_last_error()) {
            throw new \BadMethodCallException(sprintf(
                'Error (%d) when trying to json_decode response: %s',
                \json_last_error(),
                \json_last_error_msg()
            ));
        }

        return $body;

The expression return $body could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }