Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | class ArrayHydratorTest extends TestCase |
||
11 | { |
||
12 | private $response; |
||
13 | private $hydrator; |
||
14 | |||
15 | public function setUp() |
||
21 | |||
22 | public function testSuccessfulHydration() |
||
35 | |||
36 | /** |
||
37 | * @expectedException \IBM\Watson\Common\Exception\HydrationException |
||
38 | * @expectedExceptionMessage The ArrayHydrator cannot hydrate response with Content-Type: text/plain |
||
39 | */ |
||
40 | public function testHydrateFailsForNoneJsonResponses() |
||
46 | |||
47 | /** |
||
48 | * @expectedException \IBM\Watson\Common\Exception\HydrationException |
||
49 | */ |
||
50 | View Code Duplication | public function testHydrateFailsWhenJsonDecodeFails() |
|
57 | } |
||
58 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: