AbstractHydrator::getBodyContent() - Code Metrics - Inspection of "Add ArrayHydrator" - adam-paterson/ibm-watson-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#22)

by Adam

created 2018-09-21 21:18 UTC

AbstractHydrator::getBodyContent() A

↳ Parent: AbstractHydrator

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	1
dl	0
loc	13
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace IBM\Watson\Common\Hydrator;

use IBM\Watson\Common\Exception\JsonException;
use Psr\Http\Message\ResponseInterface;

/**
 * AbstractHydrator provides common protected methods other hydrators might need to use.
 */
abstract class AbstractHydrator implements HydratorInterface
{
    const HEADER_CONTENT_TYPE = 'Content-Type';

    /**
     * @param \Psr\Http\Message\ResponseInterface $response Response to check.
     *
     * @return bool
     */
    protected function isJsonResponse(ResponseInterface $response): bool
    {
        return 0 === \strpos($response->getHeaderLine(self::HEADER_CONTENT_TYPE), 'application/json');
    }

    /**
     * @param \Psr\Http\Message\ResponseInterface $response Response to parse.
     *
     * @return string
     */
    protected function getBody(ResponseInterface $response): string
    {
        return $response->getBody()->__toString();
    }

    /**
     * @param \Psr\Http\Message\ResponseInterface $response Response to parse.
     *
     * @return array
     *
     * @throws \IBM\Watson\Common\Exception\JsonException
     */
    protected function getBodyContent(ResponseInterface $response): array
    {
        $json = json_decode($this->getBody($response), true);

        if (JSON_ERROR_NONE !== json_last_error()) {
            throw new JsonException(sprintf(
                'Error (%d) when trying to json_decode response: %s',
                \json_last_error(),
                \json_last_error_msg()
            ));
        }

        return $json;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace IBM\Watson\Common\Hydrator;
6
7			use IBM\Watson\Common\Exception\JsonException;
8			use Psr\Http\Message\ResponseInterface;
9
10			/**
11			* AbstractHydrator provides common protected methods other hydrators might need to use.
12			*/
13			abstract class AbstractHydrator implements HydratorInterface
14			{
15			const HEADER_CONTENT_TYPE = 'Content-Type';
16
17			/**
18			* @param \Psr\Http\Message\ResponseInterface $response Response to check.
19			*
20			* @return bool
21			*/
22			protected function isJsonResponse(ResponseInterface $response): bool
23			{
24			return 0 === \strpos($response->getHeaderLine(self::HEADER_CONTENT_TYPE), 'application/json');
25			}
26
27			/**
28			* @param \Psr\Http\Message\ResponseInterface $response Response to parse.
29			*
30			* @return string
31			*/
32			protected function getBody(ResponseInterface $response): string
33			{
34			return $response->getBody()->__toString();
35			}
36
37			/**
38			* @param \Psr\Http\Message\ResponseInterface $response Response to parse.
39			*
40			* @return array
41			*
42			* @throws \IBM\Watson\Common\Exception\JsonException
43			*/
44			protected function getBodyContent(ResponseInterface $response): array
45			{
46			$json = json_decode($this->getBody($response), true);
47
48			if (JSON_ERROR_NONE !== json_last_error()) {
49			throw new JsonException(sprintf(
50			'Error (%d) when trying to json_decode response: %s',
51			\json_last_error(),
52			\json_last_error_msg()
53			));
54			}
55
56			return $json;
57			}
58			}
59

adam-paterson / ibm-watson-sdk

Pull Request — develop (#22)

AbstractHydrator::getBodyContent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like