Coyote\Http\Controllers\CommentController::save()

Complexity

Conditions	4
Paths	4

Size

Total Lines	45
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function save(CommentRequest $request, Dispatcher $dispatcher, Comment $comment = null)
    {
        $this->authorize('update', $comment);

        $comment->fill($request->all())->creating(function (Comment $model) use ($request) {

The method fill() does not exist on null.

            $model->user_id = $this->userId;
            $model->forceFill($request->only(['resource_id', 'resource_type']));
        });

        if ($comment->parent_id) {
            $comment->forceFill($comment->parent->only(['resource_id', 'resource_type']));
        }

        $actor = new Stream_Actor($this->auth);

        $this->transaction(function () use ($comment, $dispatcher, $actor) {

The import $dispatcher is not used and could be removed.

            $comment->save();
            $target = $this->target($comment);

It seems like $comment can also be of type null; however, parameter $comment of Coyote\Http\Controllers\CommentController::target() does only seem to accept Coyote\Comment, maybe add an additional type check?

            stream(
                $comment->wasRecentlyCreated ? new Stream_Create($actor) : new Stream_Update($actor),
                (new Stream_Comment())->comment($comment),

It seems like $comment can also be of type null; however, parameter $comment of Coyote\Services\Stream\Objects\Comment::comment() does only seem to accept Coyote\Comment, maybe add an additional type check?

                (new $target)->map($comment->resource)
            );
        });

        if ($comment->wasRecentlyCreated) {
            $subscribers = $comment
                ->resource
                ->subscribers()
                ->with('user')
                ->get()
                ->pluck('user') // get all subscribers
                ->exceptUser($this->auth); // exclude current logged user

            $dispatcher->send($subscribers, new CommentedNotification($comment));

It seems like $comment can also be of type null; however, parameter $comment of Coyote\Notifications\Job\CommentedNotification::__construct() does only seem to accept Coyote\Comment, maybe add an additional type check?

//            if ($comment->parent_id && $comment->user_id !== $comment->parent->user_id) {
//                $comment->parent->notify(new RepliedNotification($comment));
//            }
        }

        CommentResource::withoutWrapping();

        return new CommentResource($comment->load(['user', 'children']));
    }