Guide::voters() - Code Metrics - Inspection of "bugfix: pokazywanie dodanego komentarza na liscie" - adam-boduch/coyote - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3b518a...cd2a02 )

by Adam

created 2021-11-13 14:33 UTC

Guide::voters() A

↳ Parent: Guide

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace Coyote;

use Coyote\Guide\Role;
use Coyote\Guide\Vote;
use Coyote\Models\Asset;
use Coyote\Models\Subscription;
use Illuminate\Database\Eloquent\Model;

/**
 * @property int $id
 * @property User $user
 * @property string $title
 * @property string $excerpt
 * @property string $text
 * @property Tag[] $tags
 * @property int $user_id
 * @property Comment[] $comments
 * @property Comment[] $commentsWithChildren
 * @property string $slug
 * @property int $votes
 * @property string $role
 * @property Role[] $roles
 */
class Guide extends Model
{
    use Taggable;

    protected $fillable = ['title', 'excerpt', 'text'];

    public function getSlugAttribute(): string
    {
        return str_slug($this->title, '_');
    }

    /**
     * @return \Illuminate\Database\Eloquent\Relations\HasMany
     */
    public function voters()
    {
        return $this->hasMany(Vote::class);
    }

    public function user()
    {
        return $this->belongsTo(User::class);
    }

    public function subscribers()
    {
        return $this->morphMany(Subscription::class, 'resource');
    }

    /**
     * @return \Illuminate\Database\Eloquent\Relations\MorphOne
     */
    public function page()
    {
        return $this->morphOne(Page::class, 'content');
    }

    /**
     * @return \Illuminate\Database\Eloquent\Relations\MorphToMany
     */
    public function tags()
    {
        return $this->morphToMany(Tag::class, 'resource', 'tag_resources');
    }

    public function comments()
    {
        return $this->morphMany(Comment::class, 'resource');
    }

    public function roles()
    {
        return $this->hasMany(Role::class);
    }

    /**
     * @return \Illuminate\Database\Eloquent\Relations\MorphMany
     */
    public function assets()
    {
        return $this->morphMany(Asset::class, 'content');
    }

    public function commentsWithChildren()
    {
        $userRelation = fn ($builder) => $builder->select(['id', 'name', 'photo', 'deleted_at', 'is_blocked', 'is_online'])->withTrashed();

        return $this
            ->comments()
            ->whereNull('parent_id')
            ->orderBy('id', 'DESC')
            ->with([
                'children' => function ($builder) use ($userRelation) {
                    return $builder->orderBy('id')->with(['user' => $userRelation]);
                },
                'user' => $userRelation
            ]);
    }

    public function loadUserVoterRelation(?int $userId): void
    {
        if (!$userId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            return;
        }

        $this->load(['voters' => fn ($builder) => $builder->select(['id', 'guide_id', 'user_id'])->where('user_id', $userId)]);
    }

    public function loadUserRoleRelation(?int $userId): void
    {
        if (!$userId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            return;
        }

        $this->load(['roles' => fn ($builder) => $builder->select(['id', 'guide_id', 'role'])->where('user_id', $userId)]);
    }
}


1			<?php
2
3			namespace Coyote;
4
5			use Coyote\Guide\Role;
6			use Coyote\Guide\Vote;
7			use Coyote\Models\Asset;
8			use Coyote\Models\Subscription;
9			use Illuminate\Database\Eloquent\Model;
10
11			/**
12			* @property int $id
13			* @property User $user
14			* @property string $title
15			* @property string $excerpt
16			* @property string $text
17			* @property Tag[] $tags
18			* @property int $user_id
19			* @property Comment[] $comments
20			* @property Comment[] $commentsWithChildren
21			* @property string $slug
22			* @property int $votes
23			* @property string $role
24			* @property Role[] $roles
25			*/
26			class Guide extends Model
27			{
28			use Taggable;
29
30			protected $fillable = ['title', 'excerpt', 'text'];
31
32			public function getSlugAttribute(): string
33			{
34			return str_slug($this->title, '_');
35			}
36
37			/**
38			* @return \Illuminate\Database\Eloquent\Relations\HasMany
39			*/
40			public function voters()
41			{
42			return $this->hasMany(Vote::class);
43			}
44
45			public function user()
46			{
47			return $this->belongsTo(User::class);
48			}
49
50			public function subscribers()
51			{
52			return $this->morphMany(Subscription::class, 'resource');
53			}
54
55			/**
56			* @return \Illuminate\Database\Eloquent\Relations\MorphOne
57			*/
58			public function page()
59			{
60			return $this->morphOne(Page::class, 'content');
61			}
62
63			/**
64			* @return \Illuminate\Database\Eloquent\Relations\MorphToMany
65			*/
66			public function tags()
67			{
68			return $this->morphToMany(Tag::class, 'resource', 'tag_resources');
69			}
70
71			public function comments()
72			{
73			return $this->morphMany(Comment::class, 'resource');
74			}
75
76			public function roles()
77			{
78			return $this->hasMany(Role::class);
79			}
80
81			/**
82			* @return \Illuminate\Database\Eloquent\Relations\MorphMany
83			*/
84			public function assets()
85			{
86			return $this->morphMany(Asset::class, 'content');
87			}
88
89			public function commentsWithChildren()
90			{
91			$userRelation = fn ($builder) => $builder->select(['id', 'name', 'photo', 'deleted_at', 'is_blocked', 'is_online'])->withTrashed();
92
93			return $this
94			->comments()
95			->whereNull('parent_id')
96			->orderBy('id', 'DESC')
97			->with([
98			'children' => function ($builder) use ($userRelation) {
99			return $builder->orderBy('id')->with(['user' => $userRelation]);
100			},
101			'user' => $userRelation
102			]);
103			}
104
105			public function loadUserVoterRelation(?int $userId): void
106			{
107			if (!$userId) {
			0 ignored issues – show Bug Best Practice introduced 2021-11-13 14:44 UTC by Report Bug Copy Issue Report The expression `$userId` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be 0. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
108			return;
109			}
110
111			$this->load(['voters' => fn ($builder) => $builder->select(['id', 'guide_id', 'user_id'])->where('user_id', $userId)]);
112			}
113
114			public function loadUserRoleRelation(?int $userId): void
115			{
116			if (!$userId) {
			0 ignored issues – show Bug Best Practice introduced 2021-11-13 14:44 UTC by Report Bug Copy Issue Report The expression `$userId` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be 0. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
117			return;
118			}
119
120			$this->load(['roles' => fn ($builder) => $builder->select(['id', 'guide_id', 'role'])->where('user_id', $userId)]);
121			}
122			}
123

adam-boduch / coyote

Push — master ( 3b518a...cd2a02 )

Guide::voters() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like