Coyote\Services\Guide\RoleCalculator

Complexity

Total Complexity

3

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	calculateRole()	0	6	1
A	setRole()	0	9	1
A	__construct()	0	2	1

<?php

namespace Coyote\Services\Guide;

use Coyote\Guide;

class RoleCalculator
{
    public function __construct(private Guide $guide)
    {
    }

    public function setRole(int $userId, string $role): void
    {
        $currentRole = $this->guide->roles()->forUser($userId)->firstOrNew();

        $currentRole->role = $role;
        $currentRole->user_id = $userId;
        $currentRole->save();

        $this->guide->role = $this->calculateRole();
    }

    private function calculateRole(): string
    {
        $roles = array_count_values($this->guide->roles()->get(['role'])->pluck('role')->toArray());
        arsort($roles);

        return key($roles);

The expression return key($roles) could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}