PaymentController::makeTransaction() - Code Metrics - Inspection of "wyswietlanie kuponu rabatowego" - adam-boduch/coyote - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — feature/coupons (8ab0b9)

by Adam

created 2017-07-13 16:24 UTC

PaymentController::makeTransaction() B

↳ Parent: PaymentController

Complexity

Conditions	5
Paths	4

Size

Total Lines	31
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	16
nc	4
nop	2
dl	0
loc	31
rs	8.439
c	1
b	0
f	0

<?php

namespace Coyote\Http\Controllers\Job;

use Coyote\Events\PaymentPaid;
use Coyote\Http\Controllers\Controller;
use Coyote\Http\Forms\Job\PaymentForm;
use Coyote\Payment;
use Coyote\Repositories\Contracts\CountryRepositoryInterface as CountryRepository;
use Coyote\Repositories\Contracts\CouponRepositoryInterface as CouponRepository;
use Coyote\Services\Invoice\Calculator;
use Coyote\Services\Invoice\CalculatorFactory;
use Coyote\Services\UrlBuilder\UrlBuilder;
use Coyote\Services\Invoice\Generator as InvoiceGenerator;
use Illuminate\Database\Connection as Db;
use Illuminate\Http\Request;
use Braintree\Configuration;
use Braintree\ClientToken;
use Braintree\Transaction;
use Braintree\Exception;

class PaymentController extends Controller
{
    /**
     * @var InvoiceGenerator
     */
    private $invoice;

    /**
     * @var CountryRepository
     */
    private $country;

    /**
     * @var Db
     */
    private $db;

    /**
     * @var CouponRepository
     */
    private $coupon;

    /**
     * @var array
     */
    private $vatRates;

    /**
     * @param InvoiceGenerator $invoice
     * @param Db $db
     * @param CountryRepository $country
     * @param CouponRepository $coupon
     */
    public function __construct(InvoiceGenerator $invoice, Db $db, CountryRepository $country, CouponRepository $coupon)
    {
        parent::__construct();

        $this->invoice = $invoice;
        $this->db = $db;
        $this->country = $country;
        $this->coupon = $coupon;

        $this->middleware(function (Request $request, $next) {
            /** @var \Coyote\Payment $payment */
            $payment = $request->route('payment');

            abort_if($payment->status_id == Payment::PAID, 404);

            return $next($request);
        });

        $this->breadcrumb->push('Praca', route('job.home'));
        $this->vatRates = $this->country->vatRatesList();

        Configuration::environment(config('services.braintree.env'));
        Configuration::merchantId(config('services.braintree.merchant_id'));
        Configuration::publicKey(config('services.braintree.public_key'));
        Configuration::privateKey(config('services.braintree.private_key'));
    }

    /**
     * @param \Coyote\Payment $payment
     * @return \Illuminate\View\View
     */
    public function index($payment)
    {
        $this->breadcrumb->push($payment->job->title, UrlBuilder::job($payment->job));
        $this->breadcrumb->push('Promowanie ogłoszenia');

        /** @var PaymentForm $form */
        $form = $this->getForm($payment);

        // calculate price based on payment details
        $calculator = CalculatorFactory::payment($payment);
        $calculator->vatRate = $this->vatRates[$form->get('invoice')->get('country_id')->getValue()] ?? $calculator->vatRate;

        $coupon = $this->coupon->firstOrNew(['code' => $form->get('coupon')->getValue()]);

        $this->request->attributes->set('validate_coupon_url', route('job.coupon'));

        return $this->view('job.payment', [
            'form'              => $form,
            'payment'           => $payment,
            'vat_rates'         => $this->vatRates,
            'calculator'        => $calculator->toArray(),
            'default_vat_rate'  => $payment->plan->vat_rate,
            'client_token'      => ClientToken::generate(),
            'coupon'            => $coupon->toArray()
        ]);
    }

    /**
     * @param \Coyote\Payment $payment
     * @return \Illuminate\Http\RedirectResponse
     * @throws \Exception
     */
    public function process($payment)
    {
        /** @var PaymentForm $form */
        $form = $this->getForm($payment);
        $form->validate();

        $calculator = CalculatorFactory::payment($payment);
        $calculator->vatRate = $this->vatRates[$form->get('invoice')->getValue()['country_id']] ?? $calculator->vatRate;

        $coupon = $this->coupon->findBy('code', $form->get('coupon')->getValue());
        $calculator->setCoupon($coupon);

        return $this->handlePayment(function () use ($payment, $form, $calculator, $coupon) {
            $this->makeTransaction($payment, $calculator);

            // save invoice data. keep in mind that we do not setup invoice number until payment is done.
            /** @var \Coyote\Invoice $invoice */
            $invoice = $this->invoice->create(
                array_merge($form->get('enable_invoice')->isChecked() ? $form->all()['invoice'] : [], ['user_id' => $this->auth->id]),
                $payment,
                $calculator
            );

            if ($coupon) {
                $payment->coupon_id = $coupon->id;

                $coupon->delete();
            }

            // associate invoice with payment
            $payment->invoice()->associate($invoice);
            $payment->save();

            // boost job offer, send invoice and reindex
            event(new PaymentPaid($payment, $this->auth));

            return redirect()
                ->to(UrlBuilder::job($payment->job))
                ->with('success', trans('payment.success'));
        });
    }

    /**
     * @param \Coyote\Payment $payment
     * @return \Coyote\Services\FormBuilder\Form
     */
    private function getForm($payment)
    {
        return $this->createForm(PaymentForm::class, $payment);
    }

    /**
     * @param Payment $payment
     * @param Calculator $calculator
     * @throws Exception\ValidationsFailed
     */
    private function makeTransaction(Payment $payment, Calculator $calculator)
    {
        if (!$calculator->grossPrice()) {
            return;
        }

        /** @var mixed $result */
        $result = Transaction::sale([
            'amount'                => number_format($calculator->grossPrice(), 2, '.', ''),
            'orderId'               => $payment->id,
            'paymentMethodNonce'    => $this->request->input("payment_method_nonce"),
            'options' => [
                'submitForSettlement' => true
            ]
        ]);

        /** @var $result \Braintree\Result\Error */
        if (!$result->success || is_null($result->transaction)) {
            /** @var \Braintree\Error\Validation $error */
            $error = array_first($result->errors->deepAll());
            logger()->error(var_export($result, true));

            if (is_null($error)) {
                throw new Exception\ValidationsFailed();
            }

            throw new Exception\ValidationsFailed($error->message, $error->code);
        }

        logger()->debug('Successfully payment', ['result' => $result]);
    }

    /**
     * @param \Exception $exception
     * @param string $message
     * @return \Illuminate\Http\RedirectResponse
     */
    private function handlePaymentException($exception, $message)
    {
        $back = back()->withInput()->with('error', $message);

        // remove sensitive data
        $this->request->merge(['number' => '***', 'cvc' => '***']);
        $_POST['number'] = $_POST['cvc'] = '***';

        $this->db->rollBack();
        // log error. sensitive data won't be saved (we removed them)
        logger()->error($exception);

        if (app()->environment('production')) {
            app('sentry')->captureException($exception);
        }

        return $back;
    }

    /**
     * @param \Closure $callback
     * @return \Illuminate\Http\RedirectResponse|mixed
     */
    private function handlePayment(\Closure $callback)
    {
        $this->db->beginTransaction();

        try {
            $result = $callback();
            $this->db->commit();

            return $result;
        } catch (Exception\Authentication $e) {
            return $this->handlePaymentException($e, trans('payment.forbidden'));

        } catch (Exception\Authorization $e) {
            return $this->handlePaymentException($e, trans('payment.unauthorized'));

        } catch (Exception\Timeout $e) {
            return $this->handlePaymentException($e, trans('payment.timeout'));

        } catch (Exception\ServerError $e) {
            return $this->handlePaymentException($e, trans('payment.unauthorized'));

        } catch (Exception\ValidationsFailed $e) {
            return $this->handlePaymentException($e, $e->getMessage() ?: trans('payment.validation'));
        } catch (\Exception $e) {
            return $this->handlePaymentException($e, trans('payment.unhandled'));

        }
    }
}


1			<?php
2
3			namespace Coyote\Http\Controllers\Job;
4
5			use Coyote\Events\PaymentPaid;
6			use Coyote\Http\Controllers\Controller;
7			use Coyote\Http\Forms\Job\PaymentForm;
8			use Coyote\Payment;
9			use Coyote\Repositories\Contracts\CountryRepositoryInterface as CountryRepository;
10			use Coyote\Repositories\Contracts\CouponRepositoryInterface as CouponRepository;
11			use Coyote\Services\Invoice\Calculator;
12			use Coyote\Services\Invoice\CalculatorFactory;
13			use Coyote\Services\UrlBuilder\UrlBuilder;
14			use Coyote\Services\Invoice\Generator as InvoiceGenerator;
15			use Illuminate\Database\Connection as Db;
16			use Illuminate\Http\Request;
17			use Braintree\Configuration;
18			use Braintree\ClientToken;
19			use Braintree\Transaction;
20			use Braintree\Exception;
21
22			class PaymentController extends Controller
23			{
24			/**
25			* @var InvoiceGenerator
26			*/
27			private $invoice;
28
29			/**
30			* @var CountryRepository
31			*/
32			private $country;
33
34			/**
35			* @var Db
36			*/
37			private $db;
38
39			/**
40			* @var CouponRepository
41			*/
42			private $coupon;
43
44			/**
45			* @var array
46			*/
47			private $vatRates;
48
49			/**
50			* @param InvoiceGenerator $invoice
51			* @param Db $db
52			* @param CountryRepository $country
53			* @param CouponRepository $coupon
54			*/
55			public function __construct(InvoiceGenerator $invoice, Db $db, CountryRepository $country, CouponRepository $coupon)
56			{
57			parent::__construct();
58
59			$this->invoice = $invoice;
60			$this->db = $db;
61			$this->country = $country;
62			$this->coupon = $coupon;
63
64			$this->middleware(function (Request $request, $next) {
65			/** @var \Coyote\Payment $payment */
66			$payment = $request->route('payment');
67
68			abort_if($payment->status_id == Payment::PAID, 404);
69
70			return $next($request);
71			});
72
73			$this->breadcrumb->push('Praca', route('job.home'));
74			$this->vatRates = $this->country->vatRatesList();
75
76			Configuration::environment(config('services.braintree.env'));
77			Configuration::merchantId(config('services.braintree.merchant_id'));
78			Configuration::publicKey(config('services.braintree.public_key'));
79			Configuration::privateKey(config('services.braintree.private_key'));
80			}
81
82			/**
83			* @param \Coyote\Payment $payment
84			* @return \Illuminate\View\View
85			*/
86			public function index($payment)
87			{
88			$this->breadcrumb->push($payment->job->title, UrlBuilder::job($payment->job));
89			$this->breadcrumb->push('Promowanie ogłoszenia');
90
91			/** @var PaymentForm $form */
92			$form = $this->getForm($payment);
93
94			// calculate price based on payment details
95			$calculator = CalculatorFactory::payment($payment);
96			$calculator->vatRate = $this->vatRates[$form->get('invoice')->get('country_id')->getValue()] ?? $calculator->vatRate;
97
98			$coupon = $this->coupon->firstOrNew(['code' => $form->get('coupon')->getValue()]);
99
100			$this->request->attributes->set('validate_coupon_url', route('job.coupon'));
101
102			return $this->view('job.payment', [
103			'form' => $form,
104			'payment' => $payment,
105			'vat_rates' => $this->vatRates,
106			'calculator' => $calculator->toArray(),
107			'default_vat_rate' => $payment->plan->vat_rate,
108			'client_token' => ClientToken::generate(),
109			'coupon' => $coupon->toArray()
110			]);
111			}
112
113			/**
114			* @param \Coyote\Payment $payment
115			* @return \Illuminate\Http\RedirectResponse
116			* @throws \Exception
117			*/
118			public function process($payment)
119			{
120			/** @var PaymentForm $form */
121			$form = $this->getForm($payment);
122			$form->validate();
123
124			$calculator = CalculatorFactory::payment($payment);
125			$calculator->vatRate = $this->vatRates[$form->get('invoice')->getValue()['country_id']] ?? $calculator->vatRate;
126
127			$coupon = $this->coupon->findBy('code', $form->get('coupon')->getValue());
128			$calculator->setCoupon($coupon);
129
130			return $this->handlePayment(function () use ($payment, $form, $calculator, $coupon) {
131			$this->makeTransaction($payment, $calculator);
132
133			// save invoice data. keep in mind that we do not setup invoice number until payment is done.
134			/** @var \Coyote\Invoice $invoice */
135			$invoice = $this->invoice->create(
136			array_merge($form->get('enable_invoice')->isChecked() ? $form->all()['invoice'] : [], ['user_id' => $this->auth->id]),
137			$payment,
138			$calculator
139			);
140
141			if ($coupon) {
142			$payment->coupon_id = $coupon->id;
143
144			$coupon->delete();
145			}
146
147			// associate invoice with payment
148			$payment->invoice()->associate($invoice);
149			$payment->save();
150
151			// boost job offer, send invoice and reindex
152			event(new PaymentPaid($payment, $this->auth));
153
154			return redirect()
155			->to(UrlBuilder::job($payment->job))
156			->with('success', trans('payment.success'));
157			});
158			}
159
160			/**
161			* @param \Coyote\Payment $payment
162			* @return \Coyote\Services\FormBuilder\Form
163			*/
164			private function getForm($payment)
165			{
166			return $this->createForm(PaymentForm::class, $payment);
167			}
168
169			/**
170			* @param Payment $payment
171			* @param Calculator $calculator
172			* @throws Exception\ValidationsFailed
173			*/
174			private function makeTransaction(Payment $payment, Calculator $calculator)
175			{
176			if (!$calculator->grossPrice()) {
177			return;
178			}
179
180			/** @var mixed $result */
181			$result = Transaction::sale([
182			'amount' => number_format($calculator->grossPrice(), 2, '.', ''),
183			'orderId' => $payment->id,
184			'paymentMethodNonce' => $this->request->input("payment_method_nonce"),
185			'options' => [
186			'submitForSettlement' => true
187			]
188			]);
189
190			/** @var $result \Braintree\Result\Error */
191			if (!$result->success \|\| is_null($result->transaction)) {
192			/** @var \Braintree\Error\Validation $error */
193			$error = array_first($result->errors->deepAll());
194			logger()->error(var_export($result, true));
195
196			if (is_null($error)) {
197			throw new Exception\ValidationsFailed();
198			}
199
200			throw new Exception\ValidationsFailed($error->message, $error->code);
201			}
202
203			logger()->debug('Successfully payment', ['result' => $result]);
204			}
205
206			/**
207			* @param \Exception $exception
208			* @param string $message
209			* @return \Illuminate\Http\RedirectResponse
210			*/
211			private function handlePaymentException($exception, $message)
212			{
213			$back = back()->withInput()->with('error', $message);
214
215			// remove sensitive data
216			$this->request->merge(['number' => '*', 'cvc' => '*']);
217			$_POST['number'] = $_POST['cvc'] = '***';
218
219			$this->db->rollBack();
220			// log error. sensitive data won't be saved (we removed them)
221			logger()->error($exception);
222
223			if (app()->environment('production')) {
224			app('sentry')->captureException($exception);
225			}
226
227			return $back;
228			}
229
230			/**
231			* @param \Closure $callback
232			* @return \Illuminate\Http\RedirectResponse\|mixed
233			*/
234			private function handlePayment(\Closure $callback)
235			{
236			$this->db->beginTransaction();
237
238			try {
239			$result = $callback();
240			$this->db->commit();
241
242			return $result;
243			} catch (Exception\Authentication $e) {
244			return $this->handlePaymentException($e, trans('payment.forbidden'));
			0 ignored issues – show Bug introduced 2017-06-03 14:37 UTC by Report Bug Copy Issue Report It seems like `trans('payment.forbidden')` targeting `trans()` can also be of type `object<Illuminate\Contra...Translation\Translator>`; however, `Coyote\Http\Controllers\...andlePaymentException()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
245			} catch (Exception\Authorization $e) {
246			return $this->handlePaymentException($e, trans('payment.unauthorized'));
			0 ignored issues – show Bug introduced 2017-06-03 14:37 UTC by Report Bug Copy Issue Report It seems like `trans('payment.unauthorized')` targeting `trans()` can also be of type `object<Illuminate\Contra...Translation\Translator>`; however, `Coyote\Http\Controllers\...andlePaymentException()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
247			} catch (Exception\Timeout $e) {
248			return $this->handlePaymentException($e, trans('payment.timeout'));
			0 ignored issues – show Bug introduced 2017-06-03 14:37 UTC by Report Bug Copy Issue Report It seems like `trans('payment.timeout')` targeting `trans()` can also be of type `object<Illuminate\Contra...Translation\Translator>`; however, `Coyote\Http\Controllers\...andlePaymentException()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
249			} catch (Exception\ServerError $e) {
250			return $this->handlePaymentException($e, trans('payment.unauthorized'));
			0 ignored issues – show Bug introduced 2017-06-03 14:37 UTC by Report Bug Copy Issue Report It seems like `trans('payment.unauthorized')` targeting `trans()` can also be of type `object<Illuminate\Contra...Translation\Translator>`; however, `Coyote\Http\Controllers\...andlePaymentException()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
251			} catch (Exception\ValidationsFailed $e) {
252			return $this->handlePaymentException($e, $e->getMessage() ?: trans('payment.validation'));
253			} catch (\Exception $e) {
254			return $this->handlePaymentException($e, trans('payment.unhandled'));
			0 ignored issues – show Bug introduced 2017-06-03 14:37 UTC by Report Bug Copy Issue Report It seems like `trans('payment.unhandled')` targeting `trans()` can also be of type `object<Illuminate\Contra...Translation\Translator>`; however, `Coyote\Http\Controllers\...andlePaymentException()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
255			}
256			}
257			}
258

adam-boduch / coyote

Branch — feature/coupons (8ab0b9)

PaymentController::makeTransaction() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like