PollRequest::isFraudDetected() - Code Metrics - Inspection of "dodatkowa walidacja glosow" - adam-boduch/coyote - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f2dd02...330c2d )

by Adam

created 2021-10-06 18:25 UTC

PollRequest::isFraudDetected() A

↳ Parent: PollRequest

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	5
nc	3
nop	0
dl	0
loc	10
rs	10
c	1
b	0
f	0

<?php

namespace Coyote\Http\Requests;

use Coyote\Poll;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Foundation\Http\FormRequest;

class PollRequest extends FormRequest
{
    private Poll $poll;

    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        $this->poll = $this->route('poll');

        if ($this->user() === null || $this->isFraudDetected()) {
            return false;
        }

        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            'items' => 'required|array|max:' . $this->poll->max_items,
            'items.*' => 'required|integer|in:' . $this->poll->items()->pluck('id')->implode(',')
        ];
    }

    protected function failedAuthorization()
    {
        throw new AuthorizationException('Brak uprawnień do oddania głosu w ankiecie.');
    }

    private function isFraudDetected(): bool
    {
        /** @var \Illuminate\Support\Collection $collection */
        $collection = $this->poll->votes;

        $userId = $this->user()->id;
        $ip = $this->getClientIp();
        $fingerprint = request()->fingerprint;

        return $collection->contains('user_id', $userId) || $collection->contains('ip', $ip) || $collection->contains('fingerprint', $fingerprint);
    }
}


1			<?php
2
3			namespace Coyote\Http\Requests;
4
5			use Coyote\Poll;
6			use Illuminate\Auth\Access\AuthorizationException;
7			use Illuminate\Foundation\Http\FormRequest;
8
9			class PollRequest extends FormRequest
10			{
11			private Poll $poll;
12
13			/**
14			* Determine if the user is authorized to make this request.
15			*
16			* @return bool
17			*/
18			public function authorize()
19			{
20			$this->poll = $this->route('poll');
21
22			if ($this->user() === null \|\| $this->isFraudDetected()) {
23			return false;
24			}
25
26			return true;
27			}
28
29			/**
30			* Get the validation rules that apply to the request.
31			*
32			* @return array
33			*/
34			public function rules()
35			{
36			return [
37			'items' => 'required\|array\|max:' . $this->poll->max_items,
38			'items.*' => 'required\|integer\|in:' . $this->poll->items()->pluck('id')->implode(',')
39			];
40			}
41
42			protected function failedAuthorization()
43			{
44			throw new AuthorizationException('Brak uprawnień do oddania głosu w ankiecie.');
45			}
46
47			private function isFraudDetected(): bool
48			{
49			/** @var \Illuminate\Support\Collection $collection */
50			$collection = $this->poll->votes;
51
52			$userId = $this->user()->id;
53			$ip = $this->getClientIp();
54			$fingerprint = request()->fingerprint;
55
56			return $collection->contains('user_id', $userId) \|\| $collection->contains('ip', $ip) \|\| $collection->contains('fingerprint', $fingerprint);
57			}
58			}
59

adam-boduch / coyote

Push — master ( f2dd02...330c2d )

PollRequest::isFraudDetected() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like