JobForm::buildForm() - Code Metrics - Inspection of "testy dopasowane do nowej wersji" - adam-boduch/coyote - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — feature/job-plans (e266db)

by Adam

created 2017-06-29 14:12 UTC

JobForm::buildForm() B

↳ Parent: JobForm

Complexity

Conditions	1
Paths	1

Size

Total Lines	154
Code Lines	113

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	113
nc	1
nop	0
dl	0
loc	154
rs	8.2857
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Coyote\Http\Forms\Job;

use Coyote\Country;
use Coyote\Currency;
use Coyote\Job;
use Coyote\Repositories\Contracts\FeatureRepositoryInterface as FeatureRepository;
use Coyote\Services\FormBuilder\Form;
use Coyote\Services\FormBuilder\FormEvents;
use Coyote\Services\Geocoder\GeocoderInterface;
use Coyote\Services\Parser\Helpers\City;
use Coyote\Tag;
use Illuminate\Validation\Rule;

class JobForm extends Form
{
    /**
     * @var string
     */
    protected $theme = self::THEME_INLINE;

    /**
     * @var Job
     */
    protected $data;

    /**
     * It's public so we can use use attr from twig
     *
     * @var array
     */
    public $attr = [
        'method' => self::POST,
    ];

    /**
     * @var GeocoderInterface
     */
    private $geocoder;

    /**
     * @var FeatureRepository
     */
    private $feature;

    /**
     * @param GeocoderInterface $geocoder
     * @param FeatureRepository $feature
     */
    public function __construct(GeocoderInterface $geocoder, FeatureRepository $feature)
    {
        parent::__construct();

        $this->geocoder = $geocoder;
        $this->feature = $feature;

        $this->addEventListener(FormEvents::POST_SUBMIT, function (JobForm $form) {
            // call macro and flush collection items
            $this->data->tags->flush();
            $this->data->locations->flush();

            $this->data->features->flush();


            foreach ($form->get('tags')->getChildrenValues() as $tag) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $pivot = $this->data->tags()->newPivot(['priority' => $tag['priority']]);
                $model = (new Tag($tag))->setRelation('pivot', $pivot);

                $this->data->tags->add($model);

            }

            foreach ($form->get('features')->getChildrenValues() as $feature) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $checked = (int) $feature['checked'];

                $pivot = $this->data->features()->newPivot([
                    'checked'       => $checked,
                    'value'         => $checked ? ($feature['value'] ?? null) : null
                ]);

                $model = $this->feature->find($feature['id'])->setRelation('pivot', $pivot);

                $this->data->features->add($model);

            }

            $cities = (new City())->grab($form->get('city')->getValue());

            foreach ($cities as $city) {
                $this->data->locations->add(new Job\Location($this->geocode($city)));
            }

            $this->data->country()->associate((new Country())->find($form->get('country_id')->getValue()));
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
        });

        $this->addEventListener(FormEvents::PRE_RENDER, function (JobForm $form) {
            $session = $form->getRequest()->session();

            if ($session->hasOldInput('tags')) {

                $assoc = [];

                foreach ($form->get('tags')->getChildrenValues() as $tag) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    $assoc[] = [
                        'name' => $tag['name'],
                        'pivot' => [
                            'priority' => $tag['priority']
                        ]
                    ];
                }

                $form->get('tags')->setValue($assoc);
            }

            if ($session->hasOldInput('features')) {

                $assoc = [];

                foreach ($form->get('features')->getChildrenValues() as $feature) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    $assoc[] = [
                        'id' => $feature['id'],
                        'name' => $feature['name'],
                        'default' => $feature['default'],
                        'pivot' => [
                            'checked' => (int) $feature['checked'],
                            'value' => $feature['value'] ?? ''
                        ]
                    ];
                }

                $form->get('features')->setValue($assoc);
            }

            // tags as json (for vue.js)
            $form->get('tags')->setValue(collect($form->get('tags')->getChildrenValues())->toJson());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            // features as json (for vue.js)
            $form->get('features')->setValue(collect($form->get('features')->getChildrenValues())->toJson());
        });
    }

    public function buildForm()
    {
        $this
            ->setAttr(['class' => 'submit-form', 'v-cloak' => 'v-cloak'])
            ->setUrl(route('job.submit'))
            ->add('id', 'hidden')
            ->add('slug', 'hidden')
            ->add('firm_id', 'hidden')
            ->add('title', 'text', [
                'rules' => 'min:2|max:60',
                'label' => 'Tytuł oferty',
                'required' => true,
                'help' => 'Pozostało <strong>${ charCounter(\'job.title\', 60) }</strong> znaków',
                'attr' => [
                    'placeholder' => 'Np. Senior Java Developer',
                    'maxlength' => 60,
                    'v-model' => 'job.title'
                ],
                'row_attr' => [
                    'class' => 'col-sm-9'
                ]
            ])
            ->add('seniority_id', 'select', [
                'rules' => 'integer',
                'label' => 'Staż pracy',
                'choices' => Job::getSeniorityList(),
                'empty_value' => '--',
                'row_attr' => [
                    'class' => 'col-sm-2'
                ]
            ])
            ->add('country_id', 'select', [
                'rules' => 'required|integer',
                'choices' => Country::getCountriesList()
            ])
            ->add('city', 'text', [
                'rules' => 'string|city',
                'attr' => [
                    'placeholder' => 'Np. Wrocław, Warszawa'
                ]
            ])
            ->add('is_remote', 'checkbox', [
                'label' => 'Możliwa praca zdalna w zakresie',
                'rules' => 'bool',
                'attr' => [
                    'id' => 'remote'
                ],
                'label_attr' => [
                    'for' => 'remote'
                ]
            ])
            ->add('remote_range', 'select', [
                'rules' => 'integer|min:10|max:100',
                'choices' => Job::getRemoteRangeList(),
                'attr' => [
                    'placeholder' => '--',
                    'class' => 'input-sm input-inline',
                    'style' => 'width: 100px'
                ]
            ])
            ->add('salary_from', 'text', [
                'rules' => 'integer',
                'help' => 'Podanie tych informacji nie jest obowiązkowe, ale dzięki temu Twoja oferta zainteresuje więcej osób. Obiecujemy!',
                'attr' => [
                    'class' => 'input-inline'
                ]
            ])
            ->add('salary_to', 'text', [
                'rules' => 'integer',
                'attr' => [
                    'class' => 'input-inline'
                ]
            ])
            ->add('is_gross', 'select', [
                'rules' => 'required|boolean',
                'choices' => Job::getTaxList(),
                'attr' => [
                    'class' => 'input-inline'
                ]
            ])
            ->add('currency_id', 'select', [
                'rules' => 'required|integer',
                'choices' => Currency::getCurrenciesList(),
                'attr' => [
                    'class' => 'input-inline'
                ]
            ])
            ->add('rate_id', 'select', [
                'rules' => 'required|integer',
                'choices' => Job::getRatesList(),
                'attr' => [
                    'class' => 'input-inline'
                ]
            ])
            ->add('employment_id', 'select', [
                'rules' => 'required|integer',
                'choices' => Job::getEmploymentList(),
                'attr' => [
                    'class' => 'input-inline'
                ]
            ])
            ->add('deadline', 'number', [
                'label' => 'Data ważnosci oferty',
                'rules' => 'integer|min:1|max:365',
                'help' => 'Oferta będzie widoczna na stronie do dnia <strong>${ deadlineDate }</strong>',
                'attr' => [
                    'min' => 1,
                    'max' => 365,
                    'class' => 'input-inline',
                    'v-model' => 'job.deadline'
                ]
            ])
            ->add('tags', 'collection', [
                'child_attr' => [
                    'type' => 'child_form',
                    'class' => TagsForm::class
                ]
            ])
            ->add('features', 'collection', [
                'label' => 'Narzędzia oraz metodologia pracy',
                'help' => 'Zaznaczenie tych pól nie jest obowiązkowe, jednak wpływaja one na pozycję oferty na liście wyszukiwania.',
                'child_attr' => [
                    'type' => 'child_form',
                    'class' => FeaturesForm::class
                ]
            ])
            ->add('description', 'textarea', [
                'label' => 'Opis oferty (opcjonalnie)',
                'help' => 'Miejsce na szczegółowy opis oferty. Pole to jednak nie jest wymagane.',
                'style' => 'height: 140px',
                'row_attr' => [
                    'class' => 'form-group-border'
                ]
            ])
            ->add('enable_apply', 'choice', [
                'multiple' => false,
                'choices' => [

                    true => 'Zezwól na wysyłanie CV poprzez serwis 4programmers.net',
                    false => '...lub podaj informacje w jaki sposób kandydaci mogą aplikować na to stanowisko',
                ]
            ])
            ->add('recruitment', 'textarea', [
                'rules' => 'required_if:enable_apply,0|string',
                'style' => 'height: 40px'
            ])
            ->add('email', 'email', [
                'rules' => 'sometimes|required|email',
                'help' => 'Podaj adres e-mail na jaki wyślemy Ci informacje o kandydatach. Adres e-mail nie będzie widoczny dla osób postronnych.'
            ]);

        $this->setupPlanFields();
        $this->setupDefaultValues();
    }

    protected function setupDefaultValues()
    {
        // default attributes only if model does not exist and wasn't filled before.
        if (!$this->data->exists && !$this->data->isDirty(['title']) && !$this->isSubmitted()) {
            $this->get('email')->setValue($this->request->user()->email);

            // @todo Uzyc mechanizmu geolokalizacji
            $this->get('country_id')->setValue(array_search('Polska', $this->get('country_id')->getChoices()));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $this->get('remote_range')->setValue(100);
        }
    }

    protected function setupPlanFields()
    {
        // can't show that fields if plan is enabled
        if ($this->data->isPlanOngoing()) {
            return;
        }

        $this
            ->add('plan_id', 'hidden', [
                'rules' => [
                    'required',
                    'int',
                    Rule::exists('plans', 'id')->where('is_active', 1)
                ],
                'attr' => [
                    'id' => 'plan_id',
                    'v-model' => 'job.plan_id'
                ]
            ]);
    }

    /**
     * @param string $city
     * @return array
     */
    private function geocode($city)
    {
        $location = [
            'city'          => $city
        ];

        try {
            $location = $this->geocoder->geocode($city);

            if (!$location->city) {
                $location->city = $city;
            }

            $location = $location->toArray();
        } catch (\Exception $e) {
            logger()->error($e->getMessage());
        }

        return $location;
    }
}


Branch — feature/job-plans (e266db)

JobForm::buildForm() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

9 paths for user data to reach this point

General Strategies to prevent injection

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Coyote\Http\Forms\Job;
4
5			use Coyote\Country;
6			use Coyote\Currency;
7			use Coyote\Job;
8			use Coyote\Repositories\Contracts\FeatureRepositoryInterface as FeatureRepository;
9			use Coyote\Services\FormBuilder\Form;
10			use Coyote\Services\FormBuilder\FormEvents;
11			use Coyote\Services\Geocoder\GeocoderInterface;
12			use Coyote\Services\Parser\Helpers\City;
13			use Coyote\Tag;
14			use Illuminate\Validation\Rule;
15
16			class JobForm extends Form
17			{
18			/**
19			* @var string
20			*/
21			protected $theme = self::THEME_INLINE;
22
23			/**
24			* @var Job
25			*/
26			protected $data;
27
28			/**
29			* It's public so we can use use attr from twig
30			*
31			* @var array
32			*/
33			public $attr = [
34			'method' => self::POST,
35			];
36
37			/**
38			* @var GeocoderInterface
39			*/
40			private $geocoder;

adam-boduch / coyote

Branch — feature/job-plans (e266db)

JobForm::buildForm() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

9 paths for user data to reach this point

General Strategies to prevent injection

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like