Coyote\Http\Controllers\Forum\SubmitController

Complexity

Total Complexity

33

Size/Duplication

Total Lines	279
Duplicated Lines	0 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	edit()	0	6	1
A	savePoll()	0	11	4
B	index()	0	20	6
C	getDefaultText()	0	33	7
C	save()	0	75	10
B	subject()	0	67	4
A	getPollRepository()	0	3	1

<?php

namespace Coyote\Http\Controllers\Forum;

use Coyote\Http\Controllers\Controller;
use Coyote\Http\Forms\Forum\SubjectForm;
use Coyote\Repositories\Contracts\PollRepositoryInterface;
use Coyote\Services\UrlBuilder\UrlBuilder;
use Illuminate\Http\Request;
use Coyote\Services\Stream\Activities\Create as Stream_Create;
use Coyote\Services\Stream\Activities\Update as Stream_Update;
use Coyote\Services\Stream\Objects\Topic as Stream_Topic;
use Coyote\Services\Stream\Objects\Post as Stream_Post;
use Coyote\Services\Stream\Objects\Forum as Stream_Forum;
use Coyote\Services\Stream\Actor as Stream_Actor;
use Coyote\Services\Parser\Helpers\Login as LoginHelper;
use Coyote\Events\PostWasSaved;
use Coyote\Events\TopicWasSaved;
use Coyote\Services\Notification\Container;
use Coyote\Post\Log;

class SubmitController extends BaseController
{
    /**
     * Show new post/edit form
     *
     * @param Request $request
     * @param \Coyote\Forum $forum
     * @param \Coyote\Topic $topic
     * @param \Coyote\Post|null $post
     * @return \Illuminate\View\View
     */
    public function index(Request $request, $forum, $topic, $post = null)
    {
        if (!empty($topic->id)) {
            $this->breadcrumb->push([
                $topic->subject => route('forum.topic', [$forum->slug, $topic->id, $topic->slug]),
                $post === null ? 'Odpowiedz' : 'Edycja' => url($request->path())
            ]);
        } else {
            $this->breadcrumb->push('Nowy wątek', route('forum.topic.submit', [$forum->slug]));
        }

        if (!empty($post)) {
            // make sure user can edit this post
            $this->authorize('update', [$post]);
        }

        $form = $this->getForm($forum, $topic, $post);
        $form->text->setValue($form->text->getValue() ?: ($topic ? $this->getDefaultText($request, $topic) : ''));

The property text does not exist on Coyote\Http\Forms\Forum\PostForm. Since you implemented __get, consider adding a @property annotation.

The condition $topic can never be true.

The method getValue() does not exist on null.

        return Controller::view('forum.submit')->with(compact('forum', 'form', 'topic', 'post'));

The method Coyote\Http\Controllers\Controller::view() is not static, but was called statically.

    }

    /**
     * Show new post/edit form
     *
     * @param \Coyote\Forum $forum
     * @param \Coyote\Topic $topic
     * @param \Coyote\Post|null $post
     * @return mixed
     */
    public function save($forum, $topic, $post = null)
    {
        if (is_null($post)) {
            $post = $this->post->makeModel();
        } else {
            $this->authorize('update', [$post]);
        }

        $form = $this->getForm($forum, $topic, $post);
        $form->validate();

        return $this->transaction(function () use ($form, $forum, $topic, $post) {
            $request = $form->getRequest();

            $actor = new Stream_Actor($this->auth);
            if (auth()->guest()) {
                $actor->displayName = $request->get('user_name');
            }

            $poll = $this->savePoll($request, $topic->poll_id);

            $activity = $post->id ? new Stream_Update($actor) : new Stream_Create($actor);
            // saving post through repository... we need to pass few object to save relationships
            $this->post->save($form, $this->auth, $forum, $topic, $post, $poll);

            // url to the post
            $url = UrlBuilder::post($post);

            if ($post->wasRecentlyCreated) {
                $container = new Container();
                $notification = [
                    'sender_id' => $this->userId,
                    'sender_name' => $request->get('user_name', $this->userId ? $this->auth->name : ''),
                    'subject' => str_limit($topic->subject, 84),
                    'excerpt' => excerpt($post->html),
                    'url' => $url,
                    'text' => $post->html,
                    'topic_id' => $topic->id, // used to create unique notification object id
                    'post_id' => $post->id // used to create unique notification object id
                ];

                // $subscribersId can be int or array. we need to cast to array type
                $subscribersId = $forum->onlyUsersWithAccess($topic->subscribers()->pluck('user_id')->toArray());
                if ($subscribersId) {

The expression $subscribersId of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                    $container->attach(
                        app('notification.topic.subscriber')->with($notification)->setUsersId($subscribersId)
                    );
                }

                // get id of users that were mentioned in the text
                $subscribersId = $forum->onlyUsersWithAccess((new LoginHelper())->grab($post->html));

It seems like $post->html can also be of type Illuminate\Database\Eloquent\Builder&Illuminate\Database\Eloquent\Relations\Relation and Illuminate\Database\Eloquent\Relations\Relation; however, parameter $html of Coyote\Services\Parser\Helpers\Login::grab() does only seem to accept string, maybe add an additional type check?

                if ($subscribersId) {

The expression $subscribersId of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                    $container->attach(app('notification.post.login')->with($notification)->setUsersId($subscribersId));
                }

                $container->notify();
            }

            if ($topic->wasRecentlyCreated || $post->id === $topic->first_post_id) {
                $object = (new Stream_Topic)->map($topic, $post->html);

It seems like $post->html can also be of type Illuminate\Database\Eloquent\Builder&Illuminate\Database\Eloquent\Relations\Relation and Illuminate\Database\Eloquent\Relations\Relation; however, parameter $text of Coyote\Services\Stream\Objects\Topic::map() does only seem to accept null|string, maybe add an additional type check?

                $target = (new Stream_Forum)->map($forum);
            } else {
                $object = (new Stream_Post(['url' => $url]))->map($post);
                $target = (new Stream_Topic())->map($topic);
            }

            stream($activity, $object, $target);

            // fire the event. it can be used to index a content and/or add page path to "pages" table
            event(new TopicWasSaved($topic));
            // add post to elasticsearch
            event(new PostWasSaved($post));

            $request->attributes->set('url', $url);
            return $post;
        });
    }

    /**
     * @param Request $request
     * @param int $pollId
     * @return \Coyote\Poll|null
     */
    private function savePoll(Request $request, $pollId)
    {
        if ($request->input('poll.remove')) {
            $this->getPollRepository()->delete($pollId);
        } elseif ($request->has('poll.title')) {
            return $this->getPollRepository()->updateOrCreate($pollId, $request->input('poll'));
        } elseif ($pollId) {
            return $this->getPollRepository()->find($pollId);
        }

        return null;
    }

    /**
     * @return PollRepositoryInterface
     */
    private function getPollRepository()
    {
        return app(PollRepositoryInterface::class);
    }

    /**
     * Ajax request. Display edit form
     *
     * @param $forum
     * @param $topic
     * @param $post
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function edit($forum, $topic, $post)
    {
        $this->authorize('update', [$post]);
        $form = $this->getForm($forum, $topic, $post);

        return view('forum.partials.edit')->with('form', $form);
    }

    /**
     * @param \Coyote\Topic $topic
     * @param SubjectForm $form
     * @return \Symfony\Component\HttpFoundation\Response
     *
     * @todo moze jakas refaktoryzacja? przeniesienie do repozytorium? na pewno logowanie o tym, ze zostal zmieniony
     * tytul a nie tresc posta (jak to jest obecnie)
     */
    public function subject($topic, SubjectForm $form)
    {
        /** @var \Coyote\Forum $forum */
        $forum = $topic->forum()->first();
        $this->authorize('update', $forum);

        $request = $form->getRequest();

        $url = $this->transaction(function () use ($request, $forum, $topic) {
            $topic->fill(['subject' => $request->get('subject')]);

            /** @var \Coyote\Post $post */
            $post = $topic->firstPost()->first();
            $url = route('forum.topic', [$forum->slug, $topic->id, $topic->slug], false);

            if ($topic->isDirty()) {
                $original = $topic->getOriginal();

                $topic->save();
                $tags = $topic->getTagNames();

                // save it in log...
                (new Log)
                    ->fillWithPost($post)
                    ->fill(['user_id' => $this->userId, 'subject' => $topic->subject, 'tags' => $tags])
                    ->save();

                $post->fill([
                    'edit_count' => $post->edit_count + 1, 'editor_id' => $this->userId
                ])
                ->save();

                if ($post->user_id) {
                    app('notification.topic.subject')->with([
                        'users_id'    => $forum->onlyUsersWithAccess([$post->user_id]),
                        'sender_id'   => $this->userId,
                        'sender_name' => $this->auth->name,
                        'subject'     => str_limit($original['subject'], 84),
                        'excerpt'     => str_limit($topic->subject, 84),
                        'url'         => $url,
                        'topic_id'    => $topic->id
                    ])->notify();
                }

                // fire the event. it can be used to index a content and/or add page path to "pages" table
                event(new TopicWasSaved($topic));
                // add post to elasticsearch
                event(new PostWasSaved($post));
            }

            // get text from cache to put excerpt in stream activity
            $post->text = app('parser.post')->parse($post->text);

            // put action into activity stream
            stream(
                Stream_Update::class,
                (new Stream_Topic)->map($topic, $post->text),
                (new Stream_Forum)->map($forum)
            );

            return $url;
        });

        if ($request->ajax()) {
            return response(url($url));

It seems like url($url) can also be of type Illuminate\Contracts\Routing\UrlGenerator; however, parameter $content of response() does only seem to accept string, maybe add an additional type check?

The expression return response(url($url)) also could return the type Illuminate\Contracts\Routing\ResponseFactory which is incompatible with the documented return type Symfony\Component\HttpFoundation\Response.

        } else {
            return redirect()->to($url);
        }
    }

    /**
     * Format post text in case of quoting
     *
     * @param Request $request
     * @param \Coyote\Topic $topic
     * @return string
     */
    protected function getDefaultText(Request $request, $topic)
    {
        $text = '';

        // IDs of posts that user want to quote...
        $postsId = [];
        $cookie = isset($_COOKIE['mqid' . $topic->id]) ? $_COOKIE['mqid' . $topic->id] : null;

        if ($cookie) {
            $postsId = array_map('intval', explode(',', $cookie));
            // I used raw PHP function because I don't want to use laravel encryption in this case
            setcookie('mqid' . $topic->id, null, time() - 3600, '/');
        }

        if ($request->input('quote')) {
            $postsId[] = $request->input('quote');
        }

        if (!empty($postsId)) {
            $posts = $this->post->findPosts(array_unique($postsId), $topic->id);

            // builds text with quoted posts
            foreach ($posts as $post) {
                $text .= '> ##### [' .
                    ($post->name ?: $post->user_name) .
                    ' napisał(a)](' . route('forum.share', [$post->id]) . '):';

                $text .= "\n> " . str_replace("\n", "\n> ", $post->text);
                $text .= "\n\n";
            }
        }

        return $text;
    }
}