Issues in MediaController.php (master) - Issues in master - actualys/DrupalCommerceConnectorBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (76)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/Rest/MediaController.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Actualys\Bundle\DrupalCommerceConnectorBundle\Controller\Rest;

use Symfony\Component\HttpFoundation\Response;
use FOS\RestBundle\Controller\Annotations\NamePrefix;
use Pim\Bundle\CatalogBundle\Manager\MediaManager;
use Pim\Bundle\CatalogBundle\Manager\ProductManager;
use Pim\Bundle\CatalogBundle\Model\Product;
use Pim\Bundle\CatalogBundle\Entity\Attribute;
use Pim\Bundle\CatalogBundle\Entity\Repository\AttributeRepository;
use FOS\RestBundle\Controller\Annotations\Get;
use Pim\Bundle\UserBundle\Context\UserContext;
use Pim\Bundle\CatalogBundle\Model\ProductValue;
use Pim\Bundle\CatalogBundle\Model\ProductMedia;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;

/**
 * @NamePrefix("akeneo_api_")
 */
class MediaController extends Controller
{

    /**
     * Get a single product
     *
     * @Get("/{sku}/{attribute_id}")
     *
     * @param  string   $sku
     * @param  string   $attribute_id
     * @return Response
     */
    public function getAction($sku, $attribute_id)
    {
        /** @var UserContext $userContext */
        //$userContext = $this->get('pim_user.context.user');

        return $this->handleGetRequest($sku, $attribute_id);
    }

    /**
     * @param $identifier
     * @param $attribute_id
     * @return Response
     */
    protected function handleGetRequest($identifier, $attribute_id)
    {
        $productManager   = $this->container->get(
          'pim_catalog.manager.product'
        );
        $attributeManager = $this->container->get(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
          'pim_catalog.manager.attribute'
        );

        /** @var  Product $product */
        /** @var ProductManager $productManager */
        $product = $productManager->findByIdentifier($identifier);

        /** @var Attribute $attribute */
        $attributeRepository = $this->container->get(
          'pim_catalog.repository.attribute'
        );

        /** @var AttributeRepository $attributeRepository */
        $attribute = $attributeRepository->findOneBy(
          array('id' => $attribute_id)
        );

        /** @var ProductValue $productValue */
        $productValue = $product->getValue($attribute->getCode());
        $data         = $this->getSerializedData(
          $productValue,
          $attribute->getCode()
        );

        return new Response($data);
    }

    /**
     * @param  ProductValue $productValue
     * @param $attribute
     * @return string
     */
    public function getSerializedData(ProductValue $productValue, $attribute)

    {
        /** @var ProductMedia $media */
        $media = $productValue->getMedia();

        /** @var MediaManager $mediaManager */
        $mediaManager = $this->get('pim_catalog.manager.media');

        /** @var ProductValue $productValue */
        $info_media                   = new \stdClass();
        $info_media->content          = $mediaManager->getBase64($media);
        $info_media->created          = $productValue->getAttribute()
          ->getCreated()
          ->getTimestamp();
        $info_media->updated          = $productValue->getAttribute()
          ->getUpdated()
          ->getTimestamp();
        $info_media->filename         = $media->getFilename();
        $info_media->filepath         = $media->getFilePath();

        $info_media->originalFilename = $media->getOriginalFilename();
        $info_media->mimeType         = $media->getMimeType();
        $info_media->size             = filesize($media->getFilePath());

        $data                         = json_encode($info_media);

        return $data;
    }
}


1			<?php
2
3			namespace Actualys\Bundle\DrupalCommerceConnectorBundle\Controller\Rest;
4
5			use Symfony\Component\HttpFoundation\Response;
6			use FOS\RestBundle\Controller\Annotations\NamePrefix;
7			use Pim\Bundle\CatalogBundle\Manager\MediaManager;
8			use Pim\Bundle\CatalogBundle\Manager\ProductManager;
9			use Pim\Bundle\CatalogBundle\Model\Product;
10			use Pim\Bundle\CatalogBundle\Entity\Attribute;
11			use Pim\Bundle\CatalogBundle\Entity\Repository\AttributeRepository;
12			use FOS\RestBundle\Controller\Annotations\Get;
13			use Pim\Bundle\UserBundle\Context\UserContext;
14			use Pim\Bundle\CatalogBundle\Model\ProductValue;
15			use Pim\Bundle\CatalogBundle\Model\ProductMedia;
16			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
17
18			/**
19			* @NamePrefix("akeneo_api_")
20			*/
21			class MediaController extends Controller
22			{
23
24			/**
25			* Get a single product
26			*
27			* @Get("/{sku}/{attribute_id}")
28			*
29			* @param string $sku
30			* @param string $attribute_id
31			* @return Response
32			*/
33			public function getAction($sku, $attribute_id)
34			{
35			/** @var UserContext $userContext */
36			//$userContext = $this->get('pim_user.context.user');
37
38			return $this->handleGetRequest($sku, $attribute_id);
39			}
40
41			/**
42			* @param $identifier
43			* @param $attribute_id
44			* @return Response
45			*/
46			protected function handleGetRequest($identifier, $attribute_id)
47			{
48			$productManager = $this->container->get(
49			'pim_catalog.manager.product'
50			);
51			$attributeManager = $this->container->get(
			0 ignored issues – show Unused Code introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$attributeManager` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
52			'pim_catalog.manager.attribute'
53			);
54
55			/** @var Product $product */
56			/** @var ProductManager $productManager */
57			$product = $productManager->findByIdentifier($identifier);
58
59			/** @var Attribute $attribute */
60			$attributeRepository = $this->container->get(
61			'pim_catalog.repository.attribute'
62			);
63
64			/** @var AttributeRepository $attributeRepository */
65			$attribute = $attributeRepository->findOneBy(
66			array('id' => $attribute_id)
67			);
68
69			/** @var ProductValue $productValue */
70			$productValue = $product->getValue($attribute->getCode());
71			$data = $this->getSerializedData(
72			$productValue,
73			$attribute->getCode()
74			);
75
76			return new Response($data);
77			}
78
79			/**
80			* @param ProductValue $productValue
81			* @param $attribute
82			* @return string
83			*/
84			public function getSerializedData(ProductValue $productValue, $attribute)
			0 ignored issues – show Unused Code introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$attribute` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
85			{
86			/** @var ProductMedia $media */
87			$media = $productValue->getMedia();
88
89			/** @var MediaManager $mediaManager */
90			$mediaManager = $this->get('pim_catalog.manager.media');
91
92			/** @var ProductValue $productValue */
93			$info_media = new \stdClass();
94			$info_media->content = $mediaManager->getBase64($media);
95			$info_media->created = $productValue->getAttribute()
96			->getCreated()
97			->getTimestamp();
98			$info_media->updated = $productValue->getAttribute()
99			->getUpdated()
100			->getTimestamp();
101			$info_media->filename = $media->getFilename();
102			$info_media->filepath = $media->getFilePath();
			0 ignored issues – show Bug introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getFilePath()` does not exist on `Pim\Bundle\CatalogBundle\Model\ProductMedia`. Did you maybe mean `getFile()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
103			$info_media->originalFilename = $media->getOriginalFilename();
104			$info_media->mimeType = $media->getMimeType();
105			$info_media->size = filesize($media->getFilePath());
			0 ignored issues – show Bug introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getFilePath()` does not exist on `Pim\Bundle\CatalogBundle\Model\ProductMedia`. Did you maybe mean `getFile()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
106			$data = json_encode($info_media);
107
108			return $data;
109			}
110			}
111

actualys / DrupalCommerceConnectorBundle

Issues (76)

Security Analysis not enabled

Controller/Rest/MediaController.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like