ProductExportManager::updateProductExport() - Code Metrics - actualys/DrupalCommerceConnectorBundle - Measure and Improve Code Quality continuously with Scrutinizer

ProductExportManager::updateProductExport() B
last analyzed 2016-02-15 11:17 UTC

↳ Parent: ProductExportManager

Complexity

Conditions	5
Paths	9

Size

Total Lines	51
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	51
rs	8.6588
cc	5
eloc	26
nc	9
nop	2

How to fix Long Method

<?php

namespace Actualys\Bundle\DrupalCommerceConnectorBundle\Manager;

use PDO;
use Doctrine\Common\Persistence\ObjectManager;
use Doctrine\ORM\EntityManager;
use Pim\Bundle\CatalogBundle\Model\AbstractProduct;
use Akeneo\Bundle\BatchBundle\Entity\JobInstance;
use Pim\Bundle\CatalogBundle\Repository\ReferableEntityRepositoryInterface;
use PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct;


class ProductExportManager
{
    /**
     * @var boolean
     */
    protected $productValueDelta;

    /**
     * @var EntityManager
     */
    protected $entityManager;

    /**
     * @var string
     */
    protected $productExportClass;

    /**
     * @var EntityRepository
     */
    protected $productExportRepository;


    /**
     * @var EntityRepository
     */
    protected $productRepository;

    /**
     * Constructor
     *
     * @param EntityManager $entityManager      Entity manager for other entitites
     * @param string        $productExportClass ProductExport class
     * @param string        $productClass       Product class
     * @param boolean       $productValueDelta  Should we do a delta on product values
     */
    public function __construct(
      EntityManager $entityManager,
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
      $productExportClass,
      $productClass,
      $productValueDelta = false
    ) {
        $this->entityManager           = $entityManager;
        $this->productExportClass      = $productExportClass;
        $this->productExportRepository = $this->entityManager->getRepository($this->productExportClass);

        $this->productRepository       = $this->entityManager->getRepository($productClass);

        $this->productValueDelta       = $productValueDelta;
    }
    /**
     * Update product export dates for the given products
     * @param array       $products
     * @param JobInstance $jobInstance
     */
    public function updateProductExports($products, JobInstance $jobInstance)
    {
        foreach ($products as $product) {
            $this->updateProductExport($product->getIdentifier(), $jobInstance);
        }
    }

    /**
     * Update product export date for the given product
     * @param string      $identifier
     * @param JobInstance $jobInstance
     */
    public function updateProductExport($identifier, JobInstance $jobInstance)
    {
        $now = new \DateTime('now', new \DateTimeZone('UTC'));
        $product = $this->productRepository->findByReference((string) $identifier);
        if (class_exists('\PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct')) {
            if ($product instanceof \PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct ) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                /**@var \PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct  $product **/
                $productId = $product->getOriginalProduct()->getId();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $product = $product->getOriginalProduct();
            }
        }

        if (null != $product) {
            $productExport = $this->productExportRepository->findOneBy(array(
                'product'     => $product,
                'jobInstance' => $jobInstance
              ));

            $conn = $this->entityManager->getConnection();

            $jobInstance->getId();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
            $product->getId();


            if (null === $productExport) {
                $sql = '
                    INSERT INTO pim_delta_product_export
                    (product_id, job_instance_id, date)
                    VALUES (:product_id, :job_instance_id, :date)
                ';
            } else {
                $sql = '
                    UPDATE pim_delta_product_export
                    SET date = :date
                    WHERE product_id = :product_id AND job_instance_id = :job_instance_id
                ';
            }

            $q = $conn->prepare($sql);
            $date = $now->format('Y-m-d H:i:s');
            $productId = $product->getId();
            $jobInstanceId = $jobInstance->getId();



            $q->bindParam(':date', $date, PDO::PARAM_STR);
            $q->bindParam(':product_id', $productId, PDO::PARAM_INT);
            $q->bindParam(':job_instance_id', $jobInstanceId, PDO::PARAM_INT);
            $q->execute();
        }
    }

    /**
     * Filter products to export
     * @param array       $products
     * @param JobInstance $jobInstance
     *
     * @return AbstractProduct
     */
    public function filterProducts($products, JobInstance $jobInstance)
    {
        $productsToExport = array();

        foreach ($products as $product) {
            $product = $this->filterProduct($product, $jobInstance);

            if (null !== $product) {
                $productsToExport[] = $product;
            }
        }

        return $productsToExport;
    }

    /**
     * Filter a product (return null if the product got exported after his last edit)
     * @param AbstractProduct $product
     * @param JobInstance     $jobInstance
     *
     * @return AbstractProduct|null
     */
    public function filterProduct(AbstractProduct $product, JobInstance $jobInstance)
    {
        if ($product instanceof \PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct ) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            /**@var \PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct  $product **/
            $productExport = $this->productExportRepository->findProductExportAfterEdit(
              $product->getOriginalProduct(),
              $jobInstance,
              $product->getUpdated()
            );

            if (0 === count($productExport)) {
                if ($this->productValueDelta) {
                    $product = $this->filterProductValues($product);
                }
            } else {
                $product = null;
            }
        }

        return $product;
    }

    /**
     * Filter on product values
     *
     * @param AbstractProduct $product
     *
     * @return AbstractProduct
     */
    public function filterProductValues(AbstractProduct $product)
    {
        $this->entityManager->detach($product);
        $productValues  = $product->getValues();
        $identifierType = $product->getIdentifier()->getAttribute()->getAttributeType();

        foreach ($productValues as $productValue) {

            if ($identifierType != $productValue->getAttribute()->getAttributeType() && (
                null == $productValue->getUpdated() || (
                  null != $productValue->getUpdated() &&
                  $product->getUpdated()->getTimestamp() - $productValue->getUpdated()->getTimestamp() > 60
                )
              )
            ) {
                $product->removeValue($productValue);
            }
        }

        return $product;
    }
}


ProductExportManager::updateProductExport() B
last analyzed 2016-02-15 11:17 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1			<?php
2
3			namespace Actualys\Bundle\DrupalCommerceConnectorBundle\Manager;
4
5			use PDO;
6			use Doctrine\Common\Persistence\ObjectManager;
7			use Doctrine\ORM\EntityManager;
8			use Pim\Bundle\CatalogBundle\Model\AbstractProduct;
9			use Akeneo\Bundle\BatchBundle\Entity\JobInstance;
10			use Pim\Bundle\CatalogBundle\Repository\ReferableEntityRepositoryInterface;
11			use PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct;
12
13
14			class ProductExportManager
15			{
16			/**
17			* @var boolean
18			*/
19			protected $productValueDelta;
20
21			/**
22			* @var EntityManager
23			*/
24			protected $entityManager;
25
26			/**
27			* @var string
28			*/
29			protected $productExportClass;
30
31			/**
32			* @var EntityRepository
33			*/
34			protected $productExportRepository;
35
36
37			/**
38			* @var EntityRepository
39			*/
40			protected $productRepository;
41
42			/**
43			* Constructor
44			*
45			* @param EntityManager $entityManager Entity manager for other entitites
46			* @param string $productExportClass ProductExport class
47			* @param string $productClass Product class
48			* @param boolean $productValueDelta Should we do a delta on product values
49			*/
50			public function __construct(
51			EntityManager $entityManager,
			0 ignored issues – show Bug introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
52			$productExportClass,
53			$productClass,
54			$productValueDelta = false
55			) {
56			$this->entityManager = $entityManager;
57			$this->productExportClass = $productExportClass;
58			$this->productExportRepository = $this->entityManager->getRepository($this->productExportClass);
			0 ignored issues – show Documentation Bug introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report It seems like `$this->entityManager->ge...is->productExportClass)` of type `object<Doctrine\ORM\EntityRepository>` is incompatible with the declared type `object<Actualys\Bundle\D...nager\EntityRepository>` of property `$productExportRepository`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
59			$this->productRepository = $this->entityManager->getRepository($productClass);
			0 ignored issues – show Documentation Bug introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report It seems like `$this->entityManager->ge...pository($productClass)` of type `object<Doctrine\ORM\EntityRepository>` is incompatible with the declared type `object<Actualys\Bundle\D...nager\EntityRepository>` of property `$productRepository`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
60			$this->productValueDelta = $productValueDelta;
61			}
62			/**
63			* Update product export dates for the given products
64			* @param array $products
65			* @param JobInstance $jobInstance
66			*/
67			public function updateProductExports($products, JobInstance $jobInstance)
68			{
69			foreach ($products as $product) {
70			$this->updateProductExport($product->getIdentifier(), $jobInstance);
71			}
72			}
73
74			/**
75			* Update product export date for the given product
76			* @param string $identifier
77			* @param JobInstance $jobInstance
78			*/
79			public function updateProductExport($identifier, JobInstance $jobInstance)
80			{
81			$now = new \DateTime('now', new \DateTimeZone('UTC'));
82			$product = $this->productRepository->findByReference((string) $identifier);
83			if (class_exists('\PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct')) {
84			if ($product instanceof \PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct ) {
			0 ignored issues – show Bug introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report The class `PimEnterprise\Bundle\Wor...\Model\PublishedProduct` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
85			/@var \PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct $product /
86			$productId = $product->getOriginalProduct()->getId();
			0 ignored issues – show Unused Code introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report `$productId` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
87			$product = $product->getOriginalProduct();
88			}
89			}
90
91			if (null != $product) {
92			$productExport = $this->productExportRepository->findOneBy(array(
93			'product' => $product,
94			'jobInstance' => $jobInstance
95			));
96
97			$conn = $this->entityManager->getConnection();
98
99			$jobInstance->getId();
			0 ignored issues – show Unused Code introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report The call to the method `Akeneo\Bundle\BatchBundl...ty\JobInstance::getId()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
100			$product->getId();
101
102
103			if (null === $productExport) {
104			$sql = '
105			INSERT INTO pim_delta_product_export
106			(product_id, job_instance_id, date)
107			VALUES (:product_id, :job_instance_id, :date)
108			';
109			} else {
110			$sql = '
111			UPDATE pim_delta_product_export
112			SET date = :date
113			WHERE product_id = :product_id AND job_instance_id = :job_instance_id
114			';
115			}
116
117			$q = $conn->prepare($sql);
118			$date = $now->format('Y-m-d H:i:s');
119			$productId = $product->getId();
120			$jobInstanceId = $jobInstance->getId();
121
122
123
124			$q->bindParam(':date', $date, PDO::PARAM_STR);
125			$q->bindParam(':product_id', $productId, PDO::PARAM_INT);
126			$q->bindParam(':job_instance_id', $jobInstanceId, PDO::PARAM_INT);
127			$q->execute();
128			}
129			}
130
131			/**
132			* Filter products to export
133			* @param array $products
134			* @param JobInstance $jobInstance
135			*
136			* @return AbstractProduct
137			*/
138			public function filterProducts($products, JobInstance $jobInstance)
139			{
140			$productsToExport = array();
141
142			foreach ($products as $product) {
143			$product = $this->filterProduct($product, $jobInstance);
144
145			if (null !== $product) {
146			$productsToExport[] = $product;
147			}
148			}
149
150			return $productsToExport;
151			}
152
153			/**
154			* Filter a product (return null if the product got exported after his last edit)
155			* @param AbstractProduct $product
156			* @param JobInstance $jobInstance
157			*
158			* @return AbstractProduct\|null
159			*/
160			public function filterProduct(AbstractProduct $product, JobInstance $jobInstance)
161			{
162			if ($product instanceof \PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct ) {
			0 ignored issues – show Bug introduced 2016-02-15 11:17 UTC by Report Bug Copy Issue Report The class `PimEnterprise\Bundle\Wor...\Model\PublishedProduct` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
163			/@var \PimEnterprise\Bundle\WorkflowBundle\Model\PublishedProduct $product /
164			$productExport = $this->productExportRepository->findProductExportAfterEdit(
165			$product->getOriginalProduct(),
166			$jobInstance,
167			$product->getUpdated()
168			);
169
170			if (0 === count($productExport)) {
171			if ($this->productValueDelta) {
172			$product = $this->filterProductValues($product);
173			}
174			} else {
175			$product = null;
176			}
177			}
178
179			return $product;
180			}
181
182			/**
183			* Filter on product values
184			*
185			* @param AbstractProduct $product
186			*
187			* @return AbstractProduct
188			*/
189			public function filterProductValues(AbstractProduct $product)
190			{
191			$this->entityManager->detach($product);
192			$productValues = $product->getValues();
193			$identifierType = $product->getIdentifier()->getAttribute()->getAttributeType();
194
195			foreach ($productValues as $productValue) {
196
197			if ($identifierType != $productValue->getAttribute()->getAttributeType() && (
198			null == $productValue->getUpdated() \|\| (
199			null != $productValue->getUpdated() &&
200			$product->getUpdated()->getTimestamp() - $productValue->getUpdated()->getTimestamp() > 60
201			)
202			)
203			) {
204			$product->removeValue($productValue);
205			}
206			}
207
208			return $product;
209			}
210			}
211

actualys / DrupalCommerceConnectorBundle

ProductExportManager::updateProductExport() B last analyzed 2016-02-15 11:17 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like

ProductExportManager::updateProductExport() B
last analyzed 2016-02-15 11:17 UTC