Actualys\Bundle\DrupalCommerceConnectorBundle\Reader\ORM\CategoryReader

Complexity

Total Complexity

7

Size/Duplication

Total Lines	61
Duplicated Lines	19.67 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	read()	12	12	3
A	getQuery()	0	10	2
A	getRepository()	0	4	1

<?php

namespace Actualys\Bundle\DrupalCommerceConnectorBundle\Reader\ORM;

use Pim\Bundle\BaseConnectorBundle\Reader\ORM\EntityReader;
use Actualys\Bundle\DrupalCommerceConnectorBundle\Entity\Repository\CategoryRepository;
use Doctrine\ORM\EntityManager;

/**
 * Class CategoryReader
 * @package Actualys\Bundle\DrupalCommerceConnectorBundle\Reader\ORM
 */
class CategoryReader extends EntityReader
{
    /**
     * @var CategoryRepository
     */
    protected $repository;

    /**
     * @param EntityManager      $em
     * @param string             $className
     * @param CategoryRepository $repository
     */
    public function __construct(
      EntityManager $em,
      $className,
      CategoryRepository $repository
    ) {
        parent::__construct($em, $className);

        $this->repository = $repository;
    }

    /**
     * {@inheritdoc}
     */
    public function read()

This method seems to be duplicated in your project.

    {
        $entities = [];

        while ($entity = parent::read()) {
            $this->stepExecution->incrementReadCount();

            $entities[] = $entity;
        }

        return empty($entities) ? null : $entities;
    }

    /**
     * {@inheritdoc}
     */
    public function getQuery()
    {
        if (!$this->query) {
            $this->query = $this->getRepository()

It seems like $this->getRepository()->findRootCategories()->getQuery() of type object<Doctrine\ORM\Query> is incompatible with the declared type object<Pim\Bundle\BaseConnectorBundle\Reader\Doctrine\AbstractQuery> of property $query.

              ->findRootCategories()
              ->getQuery();
        }

        return $this->query;
    }

    /**
     * Get the custom category repository
     * @return CategoryRepository
     */
    protected function getRepository()
    {
        return $this->repository;
    }
}