Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | View Code Duplication | class AttributeProcessor extends DrupalItemStep implements ItemProcessorInterface |
|
|
|||
14 | { |
||
15 | /** |
||
16 | * @var AttributeNormalizer $attributeNormalizer |
||
17 | */ |
||
18 | protected $attributeNormalizer; |
||
19 | |||
20 | /** |
||
21 | * @var array |
||
22 | */ |
||
23 | protected $globalContext = array(); |
||
24 | |||
25 | /** |
||
26 | * @param AttributeNormalizer $attributeNormalizer The entity manager |
||
27 | */ |
||
28 | public function __construct(AttributeNormalizer $attributeNormalizer) |
||
32 | |||
33 | /** |
||
34 | * @param mixed $attribute |
||
35 | * @return array|mixed |
||
36 | * @throws InvalidItemException |
||
37 | */ |
||
38 | public function process($attribute) |
||
42 | |||
43 | /** |
||
44 | * @param Attribute $attribute |
||
45 | * @param array $context |
||
46 | * @return array |
||
47 | * @throws InvalidItemException |
||
48 | */ |
||
49 | protected function normalizeAttribute(Attribute $attribute, array $context) |
||
62 | |||
63 | public function getConfigurationFields() |
||
67 | |||
68 | /** |
||
69 | * @param StepExecution $stepExecution |
||
70 | */ |
||
71 | public function setStepExecution(StepExecution $stepExecution) |
||
75 | } |
||
76 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.