Completed
Pull Request — master (#44)
by Phil
03:17
created

AbstractSqlRepository   C

Complexity

Total Complexity 77

Size/Duplication

Total Lines 501
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 7

Test Coverage

Coverage 45.8%

Importance

Changes 0
Metric Value
wmc 77
lcom 1
cbo 7
dl 0
loc 501
ccs 120
cts 262
cp 0.458
rs 5.4715
c 0
b 0
f 0

13 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
A countFromRequest() 0 7 1
C getFromRequest() 0 34 7
C buildSortPart() 0 44 15
A acceptableField() 0 15 3
A countByField() 0 16 1
C buildQueryFromRules() 0 63 17
B getByField() 0 45 4
C attachRelationships() 0 80 14
B attachRelationshipsToCollection() 0 31 4
A getRelationshipBinds() 0 14 3
C getRelationshipMap() 0 39 7
getTable() 0 1 ?

How to fix   Complexity   

Complex Class

Complex classes like AbstractSqlRepository often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use AbstractSqlRepository, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
namespace Percy\Repository;
4
5
use Aura\Sql\ExtendedPdoInterface;
6
use InvalidArgumentException;
7
use Percy\Decorator\DecoratorTrait;
8
use Percy\Entity\Collection;
9
use Percy\Entity\CollectionBuilderTrait;
10
use Percy\Entity\EntityInterface;
11
use Percy\Http\QueryStringParserTrait;
12
use Percy\Store\StoreInterface;
13
use Psr\Http\Message\ServerRequestInterface;
14
use RuntimeException;
15
16
abstract class AbstractSqlRepository implements RepositoryInterface
17
{
18
    use CollectionBuilderTrait;
19
    use DecoratorTrait;
20
    use QueryStringParserTrait;
21
22
    /**
23
     * @var \Aura\Sql\ExtendedPdoInterface
24
     */
25
    protected $dbal;
26
27
    /**
28
     *
29
     * @var mixed
30
     */
31
    protected $relationships = [];
32
33
    /**
34
     * Construct.
35
     *
36
     * @param \Aura\Sql\ExtendedPdoInterface $dbal
37
     */
38 4
    public function __construct(ExtendedPdoInterface $dbal)
39
    {
40 4
        $this->dbal = $dbal;
41 4
    }
42
43
    /**
44
     * {@inheritdoc}
45
     */
46 1
    public function countFromRequest(ServerRequestInterface $request)
47
    {
48 1
        $rules = $this->parseQueryString($request->getUri()->getQuery());
49 1
        list($query, $params) = $this->buildQueryFromRules($rules, true);
50
51 1
        return (int) $this->dbal->fetchOne($query, $params)['total'];
52
    }
53
54
    /**
55
     * {@inheritdoc}
56
     */
57 2
    public function getFromRequest(ServerRequestInterface $request)
58
    {
59 2
        $rules = $this->parseQueryString($request->getUri()->getQuery());
60
61 2
        list($query, $params) = $this->buildQueryFromRules($rules);
62
63 2
        if (array_key_exists('sort', $rules) && ! array_key_exists('search', $rules)) {
64 2
            $entity    = $this->getEntityType();
65 2
            $entity    = new $entity;
66 2
            $mapping   = $entity->getMapping();
67 2
            $whitelist = array_keys($mapping);
68
69 2
            $query .= $this->buildSortPart($rules['sort'], $this->getTable(), $whitelist);
70 1
        }
71
72 1
        if (array_key_exists('search', $rules) && $this->acceptableField($rules['search']['fields'])) {
73 1
            $query .= sprintf(' ORDER BY MATCH (%s) AGAINST (:match_bind) > :score_bind', $rules['search']['fields']);
74 1
        }
75
76 1
        if (array_key_exists('limit', $rules)) {
77 1
            $query .= ' LIMIT ';
78 1
            $query .= (array_key_exists('offset', $rules)) ? sprintf('%d,', $rules['offset']) : '';
79 1
            $query .= sprintf('%d', $rules['limit']);
80 1
        }
81
82 1
        $query = trim(preg_replace('!\s+!', ' ', $query));
83
84 1
        $collection = $this->buildCollection($this->dbal->fetchAll($query, $params))
85 1
                           ->setTotal($this->countFromRequest($request));
86
87 1
        $this->decorate($collection, StoreInterface::ON_READ);
88
89 1
        return $collection;
90
    }
91
92
    /**
93
     * Build the sort part of the query.
94
     *
95
     * @param array|string $sorts
96
     * @param string       $table
97
     * @param array        $whitelist
98
     *
99
     * @return string
100
     */
101 2
    protected function buildSortPart($sorts, $table, array $whitelist)
102
    {
103 2
        if (is_string($sorts) && $sorts === 'RAND()') {
104 1
            return ' ORDER BY RAND()';
105
        }
106
107 2
        if (! is_array($sorts)) {
108
            return '';
109
        }
110
111 2
        $fields = [];
112
113 2
        foreach ($sorts as $sort) {
114 2
            $field = explode('.', $sort['field']);
115
116 2
            if (count($field) !== 2) {
117 1
                throw new InvalidArgumentException('Sort paramater is formatted incorrectly');
118
            }
119
120 2
            if ($field[0] !== $table && count($sorts) > 1) {
121 1
                continue;
122
            }
123
124 2
            if ($field[0] !== $table && count($sorts) < 2 && $field[0] === $this->getTable()) {
125
                continue;
126
            }
127
128 2
            if ($field[0] !== $table && count($sorts) < 2) {
129 1
                throw new InvalidArgumentException(
130 1
                    sprintf('(%s) is not a whitelisted field to sort by', $sort['field'])
131 1
                );
132
            }
133
134 2
            if (! in_array($field[1], $whitelist)) {
135 1
                throw new InvalidArgumentException(
136 1
                    sprintf('(%s) is not a whitelisted field to sort by', $sort['field'])
137 1
                );
138
            }
139
140 1
            $fields[] = sprintf('%s %s', $sort['field'], strtoupper($sort['direction']));
141 1
        }
142
143 1
        return (empty($fields)) ? '' : sprintf(' ORDER BY %s', implode(', ', $fields));
144
    }
145
146
    /**
147
     * Build a base query without sorting and limits from filter rules.
148
     *
149
     * @param array   $rules
150
     * @param boolean $count
151
     *
152
     * @return array
153
     */
154 2
    protected function buildQueryFromRules(array $rules, $count = false)
155
    {
156 2
        $start = ($count === false) ? 'SELECT * FROM ' : 'SELECT *, COUNT(*) as total FROM ';
157 2
        $query = $start . $this->getTable();
158
159 2
        $params = [];
160
161 2
        if (array_key_exists('filter', $rules)) {
162 2
            foreach ($rules['filter'] as $key => $where) {
163 2
                $this->acceptableField($where['field']);
164
165 1
                $isNull = ($where['value'] === 'null') ? true : false;
166
167 1
                $keyword   = ($key === 0) ? ' WHERE' : ' AND';
168 1
                $delimiter = strtoupper($where['delimiter']);
169 1
                $binding   = (in_array($delimiter, ['IN', 'NOT IN'])) ? '(' . $this->dbal->quote(explode(',', $where['value'])) . ')' : ':' . $where['binding'];
170
171 1
                if ($isNull === true) {
172 1
                    $delimiter = ($delimiter === '=') ? 'IS' : 'IS NOT';
173 1
                    $binding   = 'null';
174 1
                }
175
176 1
                $query .= sprintf('%s %s %s %s', $keyword, $where['field'], $delimiter, $binding);
177
178 1
                if (! in_array($delimiter, ['IN', 'NOT IN'])) {
179 1
                    $params[$where['binding']] = $where['value'];
180 1
                }
181 1
            }
182 1
        }
183
184 2
        if (array_key_exists('has', $rules)) {
185
            $keyword = (array_key_exists('filter', $rules)) ? ' AND' : ' WHERE';
186
187
            foreach ($rules['has'] as $has) {
188
                $relationship = $this->getRelationshipMap($has);
189
190
                $query .= sprintf(
191
                    '%s (SELECT COUNT(%s.%s) FROM %s WHERE %s.%s = %s.%s) > 0',
192
                    $keyword,
193
                    $relationship['defined_in']['table'],
194
                    $relationship['defined_in']['primary'],
195
                    $relationship['defined_in']['table'],
196
                    $relationship['defined_in']['table'],
197
                    $relationship['defined_in']['primary'],
198
                    $this->getTable(),
199
                    $relationship['defined_in']['entity']
200
                );
201
202
                $keyword = ' AND';
203
            }
204
        }
205
206 2
        if (array_key_exists('search', $rules) && $this->acceptableField($rules['search']['fields'])) {
207 1
            $keyword = (array_key_exists('filter', $rules)) ? ' AND' : ' WHERE';
208 1
            $query  .= sprintf('%s MATCH (%s) AGAINST (:match_bind IN BOOLEAN MODE)', $keyword, $rules['search']['fields']);
209 1
            $query  .= sprintf(' HAVING MATCH (%s) AGAINST (:match_bind) > :score_bind', $rules['search']['fields']);
210
211 1
            $params['match_bind'] = $rules['search']['term'];
212 1
            $params['score_bind'] = (array_key_exists('minscore', $rules)) ? $rules['minscore'] : 0;
213 1
        }
214
215 2
        return [$query, $params];
216
    }
217
218
    /**
219
     * Asserts that a field is acceptable to filter on.
220
     *
221
     * @param string $name
222
     *
223
     * @return boolean
224
     */
225 2
    protected function acceptableField($name)
226
    {
227 2
        $entity = $this->getEntityType();
228 2
        $entity = new $entity;
229
230 2
        foreach (explode(',', $name) as $field) {
231 2
            if (! array_key_exists($field, $entity->getMapping())) {
232 1
                throw new InvalidArgumentException(
233 1
                    sprintf('(%s) is not a whitelisted field to filter, search or sort by', $field)
234 1
                );
235
            }
236 1
        }
237
238 1
        return true;
239
    }
240
241
    /**
242
     * {@inheritdoc}
243
     */
244 1
    public function countByField($field, $value, ServerRequestInterface $request = null)
245
    {
246 1
        $query = sprintf(
247 1
            "SELECT COUNT(*) as total FROM %s WHERE %s.%s IN (:%s)",
248 1
            $this->getTable(),
249 1
            $this->getTable(),
250 1
            $field,
251
            $field
252 1
        );
253
254
        $params = [
255
            $field => $value
256 1
        ];
257
258 1
        return (int) $this->dbal->fetchOne($query, $params)['total'];
259
    }
260
261
    /**
262
     * {@inheritdoc}
263
     */
264 1
    public function getByField($field, $value, ServerRequestInterface $request = null)
265
    {
266 1
        $query = sprintf(
267 1
            'SELECT * FROM %s WHERE %s.%s IN (:%s)',
268 1
            $this->getTable(),
269 1
            $this->getTable(),
270 1
            $field,
271
            $field
272 1
        );
273
274 1
        $rules = [];
275
276 1
        if ($request instanceof ServerRequestInterface) {
277
            $rules = $this->parseQueryString($request->getUri()->getQuery());
278
        }
279
280 1
        if (is_array($value)) {
281
            if (! array_key_exists('sort', $rules)) {
282
                $query .= sprintf(
283
                    ' ORDER BY FIND_IN_SET(%s.%s, ' . $this->dbal->quote(implode(',', $value)) . ')',
284
                    $this->getTable(),
285
                    $field
286
                );
287
            } else {
288
                $entity    = $this->getEntityType();
289
                $entity    = new $entity;
290
                $mapping   = $entity->getMapping();
291
                $whitelist = array_keys($mapping);
292
                $query    .= $this->buildSortPart($rules['sort'], $this->getTable(), $whitelist);
293
            }
294
        }
295
296
        // @todo - allow extra filtering from request
297
298
        $params = [
299
            $field => $value
300 1
        ];
301
302 1
        $collection = $this->buildCollection($this->dbal->fetchAll($query, $params))
303 1
                           ->setTotal($this->countByField($field, $value));
304
305 1
        $this->decorate($collection, StoreInterface::ON_READ);
306
307 1
        return $collection;
308
    }
309
310
    /**
311
     * {@inheritdoc}
312
     */
313 1
    public function attachRelationships(
314
        Collection $collection,
315
        $include                        = null,
316
        ServerRequestInterface $request = null
317
    ) {
318 1
        if (count($collection) === 0 || is_null($include)) {
319 1
            return;
320
        }
321
322
        $bind = [];
323
324
        $rels = $collection->getIterator()->current()->getRelationshipMap();
325
326
        $rules = ($request instanceof ServerRequestInterface)
327
               ? $this->parseQueryString($request->getUri()->getQuery())
328
               : [];
329
330
        foreach ($this->getRelationshipMap() as $key => $map) {
331
            if (array_key_exists('include', $rules) && ! array_key_exists($key, $rules['include'])) {
332
                continue;
333
            }
334
335
            $binds = $this->getRelationshipBinds($collection, $key, $map['defined_in']['entity']);
336
337
            if (empty($binds)) {
338
                continue;
339
            }
340
341
            $query = sprintf(
342
                'SELECT * FROM %s LEFT JOIN %s ON %s.%s = %s.%s WHERE %s.%s IN (:relationships)',
343
                $map['defined_in']['table'],
344
                $map['target']['table'],
345
                $map['target']['table'],
346
                $map['target']['primary'],
347
                $map['defined_in']['table'],
348
                $map['target']['relationship'],
349
                $map['defined_in']['table'],
350
                $map['defined_in']['primary']
351
            );
352
353
            $options = $rules['include'][$key];
354
355
            if (! empty($options['filter'])) {
356
                foreach ($options['filter'] as $filter) {
357
                    $query .= sprintf(
358
                        ' AND %s.%s %s :%s',
359
                        $map['target']['table'],
360
                        $filter['field'],
361
                        $filter['delimiter'],
362
                        $filter['binding']
363
                    );
364
365
                    $bind[$filter['binding']] = $filter['value'];
366
                }
367
            }
368
369
            if (array_key_exists('sort', $rules)) {
370
                $whitelist = [];
371
372
                if (array_key_exists($key, $rels)) {
373
                    $entity    = $rels[$key];
374
                    $entity    = new $entity;
375
                    $mapping   = $entity->getMapping();
376
                    $whitelist = array_keys($mapping);
377
                }
378
379
                $query .= $this->buildSortPart($rules['sort'], $map['target']['table'], $whitelist);
380
            }
381
382
            if (array_key_exists('limit', $options) && ! is_null($options['limit'])) {
383
                $query .= ' LIMIT ' . (int) $options['limit'];
384
            }
385
386
            $bind['relationships'] = $binds;
387
388
            $result = $this->dbal->fetchAll($query, $bind);
389
390
            $this->attachRelationshipsToCollection($collection, $key, $result);
391
        }
392
    }
393
394
    /**
395
     * Iterate a result set and attach the relationship to it's correct entity
396
     * within a collection.
397
     *
398
     * @param \Percy\Entity\Collection $collection
399
     * @param string                   $relationship
400
     * @param array                    $data
401
     *
402
     * @return void
403
     */
404
    protected function attachRelationshipsToCollection(Collection $collection, $relationship, array $data)
405
    {
406
        $map           = $this->getRelationshipMap($relationship);
407
        $relationships = array_column($data, $map['defined_in']['primary']);
408
409
        $remove = [$map['defined_in']['primary'], $map['target']['relationship']];
410
411
        foreach ($data as &$resource) {
412
            $resource = array_filter($resource, function ($key) use ($remove) {
413
                return (! in_array($key, $remove));
414
            }, ARRAY_FILTER_USE_KEY);
415
        }
416
417
        foreach ($collection->getIterator() as $entity) {
418
            $entityRels = $entity->getRelationshipMap();
419
420
            if (! array_key_exists($relationship, $entityRels)) {
421
                continue;
422
            }
423
424
            $keys = array_keys(preg_grep("/{$entity[$map['defined_in']['entity']]}/", $relationships));
425
            $rels = array_filter($data, function ($key) use ($keys) {
426
                return in_array($key, $keys);
427
            }, ARRAY_FILTER_USE_KEY);
428
429
            $rels = $this->buildCollection($rels, $entityRels[$relationship])->setTotal(count($rels));
430
            $this->decorate($rels, StoreInterface::ON_READ);
431
432
            $entity->addRelationship($relationship, $rels);
433
        }
434
    }
435
436
    /**
437
     * Return relationship bind conditional.
438
     *
439
     * @param \Percy\Entity\Collection $collection
440
     * @param string                   $relationship
441
     * @param string                   $key
442
     *
443
     * @return string
444
     */
445
    protected function getRelationshipBinds(Collection $collection, $relationship, $key)
446
    {
447
        $primaries = [];
448
449
        foreach ($collection->getIterator() as $entity) {
450
            if (! array_key_exists($relationship, $entity->getRelationshipMap())) {
451
                continue;
452
            }
453
454
            $primaries[] = $entity[$key];
455
        }
456
457
        return $primaries;
458
    }
459
460
    /**
461
     * Get possible relationships and the properties attached to them.
462
     *
463
     * @param string $relationship
464
     *
465
     * @throws \InvalidArgumentException when requested relationship is not defined
466
     * @throws \RuntimeException when map structure is defined incorrectly
467
     *
468
     * @return array
469
     */
470
    public function getRelationshipMap($relationship = null)
471
    {
472
        if (is_null($relationship)) {
473
            return $this->relationships;
474
        }
475
476
        if (! array_key_exists($relationship, $this->relationships)) {
477
            throw new InvalidArgumentException(
478
                sprintf('(%s) is not defined in the relationship map on (%s)', $relationship, get_class($this))
479
            );
480
        }
481
482
        $map = $this->relationships[$relationship];
483
484
        foreach ([
485
            'defined_in' => ['table', 'primary', 'entity'],
486
            'target'     => ['table', 'primary', 'relationship']
487
        ] as $key => $value) {
488
            if (! array_key_exists($key, $map) || ! is_array($map[$key])) {
489
                throw new RuntimeException(
490
                    sprintf(
491
                        'Relationship (%s) should contain the (%s) key and should be of type array on (%s)',
492
                        $relationship, $key, get_class($this)
493
                    )
494
                );
495
            }
496
497
            if (! empty(array_diff($value, array_keys($map[$key])))) {
498
                throw new RuntimeException(
499
                    sprintf(
500
                        '(%s) for relationship (%s) should contain keys (%s) on (%s)',
501
                        $key, $relationship, implode(', ', $value), get_class($this)
502
                    )
503
                );
504
            }
505
        }
506
507
        return $map;
508
    }
509
510
    /**
511
     * Returns table that repository is reading from.
512
     *
513
     * @return string
514
     */
515
    abstract protected function getTable();
516
}
517