ManagesTransactions::getTransactionOptions() - Code Metrics - Inspection of "Merge pull request #15 from acquiropay/feature-tra..." - acquiropay/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 19c179...6b8e80 )

by Vladimir

created 2018-07-11 13:39 UTC

ManagesTransactions::getTransactionOptions() A

↳ Parent: ManagesTransactions

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

declare(strict_types=1);

namespace AcquiroPay\Paymarket\Actions;

use AcquiroPay\Paymarket\Resources\Transaction;

trait ManagesTransactions
{
    public function getTransactions(): array
    {
        return $this->transformCollection(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            array_get($this->get('transactions'), 'data'),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            Transaction::class
        );
    }

    public function getTransactionOptions(array $parameters): array
    {
        return $this->post('transactions/options', $parameters);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getTransaction(string $uuid): Transaction
    {
        return new Transaction(
            array_get($this->get('transactions/'.$uuid), 'data', [])
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        );
    }

    public function createTransaction(array $parameters): array
    {
        return $this->post('transactions', $parameters);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function confirmTransaction(string $uuid, array $parameters): array
    {
        return $this->post('transactions/'.$uuid.'/confirm', $parameters);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AcquiroPay\Paymarket\Actions;
6
7			use AcquiroPay\Paymarket\Resources\Transaction;
8
9			trait ManagesTransactions
10			{
11			public function getTransactions(): array
12			{
13			return $this->transformCollection(
			0 ignored issues – show Bug introduced 2018-03-21 10:39 UTC by Report Bug Copy Issue Report It seems like `transformCollection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14			array_get($this->get('transactions'), 'data'),
			0 ignored issues – show Bug introduced 2018-03-21 10:39 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
15			Transaction::class
16			);
17			}
18
19			public function getTransactionOptions(array $parameters): array
20			{
21			return $this->post('transactions/options', $parameters);
			0 ignored issues – show Bug introduced 2018-03-21 10:39 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			}
23
24			public function getTransaction(string $uuid): Transaction
25			{
26			return new Transaction(
27			array_get($this->get('transactions/'.$uuid), 'data', [])
			0 ignored issues – show Bug introduced 2018-03-21 10:39 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28			);
29			}
30
31			public function createTransaction(array $parameters): array
32			{
33			return $this->post('transactions', $parameters);
			0 ignored issues – show Bug introduced 2018-07-11 13:39 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			}
35
36			public function confirmTransaction(string $uuid, array $parameters): array
37			{
38			return $this->post('transactions/'.$uuid.'/confirm', $parameters);
			0 ignored issues – show Bug introduced 2018-03-21 10:39 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
39			}
40			}
41

acquiropay / php-sdk

Push — master ( 19c179...6b8e80 )

ManagesTransactions::getTransactionOptions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like