ManagesServices::getServices() - Code Metrics - Inspection of "Merge pull request #3 from acquiropay/feature-paym..." - acquiropay/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 38a4e8...c04e1d )

by Vladimir

created 2018-03-21 10:43 UTC

ManagesServices::getServices() A

↳ Parent: ManagesServices

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	0

<?php

declare(strict_types=1);

namespace AcquiroPay\Paymarket\Actions;

use AcquiroPay\Paymarket\Resources\Service;

trait ManagesServices
{
    public function getServices(): array
    {
        return $this->transformCollection(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            array_get($this->get('services'), 'data', []),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            Service::class
        );
    }

    public function getService(int $id): Service
    {
        return new Service(
            array_get($this->get('services/'.$id), 'data', [])
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AcquiroPay\Paymarket\Actions;
6
7			use AcquiroPay\Paymarket\Resources\Service;
8
9			trait ManagesServices
10			{
11			public function getServices(): array
12			{
13			return $this->transformCollection(
			0 ignored issues – show Bug introduced 2018-03-21 10:39 UTC by Report Bug Copy Issue Report It seems like `transformCollection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14			array_get($this->get('services'), 'data', []),
			0 ignored issues – show Bug introduced 2018-03-21 10:39 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
15			Service::class
16			);
17			}
18
19			public function getService(int $id): Service
20			{
21			return new Service(
22			array_get($this->get('services/'.$id), 'data', [])
			0 ignored issues – show Bug introduced 2018-03-21 10:39 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			);
24			}
25			}
26

acquiropay / php-sdk

Push — master ( 38a4e8...c04e1d )

ManagesServices::getServices() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like