Completed
Pull Request — master (#19)
by Yuan
02:00
created

ManagerBase   A

Complexity

Total Complexity 8

Size/Duplication

Total Lines 64
Duplicated Lines 12.5 %

Coupling/Cohesion

Components 2
Dependencies 2

Test Coverage

Coverage 94.74%

Importance

Changes 0
Metric Value
wmc 8
lcom 2
cbo 2
dl 8
loc 64
ccs 18
cts 19
cp 0.9474
rs 10
c 0
b 0
f 0

3 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
A getResponseJson() 0 7 1
B getQueryString() 8 17 6

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Acquia\LiftClient\Manager;
4
5
use GuzzleHttp\ClientInterface;
6
use Psr\Http\Message\RequestInterface;
7
8
abstract class ManagerBase
9
{
10
    /**
11
     * @var array A list of query parameters that the URL could possibly have
12
     */
13
    protected $queryParameters = [];
14
15
    /**
16
     * @var \GuzzleHttp\ClientInterface The request client
17
     */
18
    protected $client;
19
20
    /**
21
     * @param \GuzzleHttp\ClientInterface $client The request client
22
     */
23 96
    public function __construct(ClientInterface $client)
24
    {
25 96
        $this->client = $client;
26 96
    }
27
28
    /**
29
     * Make the given Request and return as JSON Decoded PHP object.
30
     *
31
     * @param \Psr\Http\Message\RequestInterface $request
32
     *
33
     * @return mixed the value encoded in <i>json</i> in appropriate
34
     *               PHP type. Values true, false and
35
     *               null (case-insensitive) are returned as <b>TRUE</b>, <b>FALSE</b>
36
     *               and <b>NULL</b> respectively. <b>NULL</b> is returned if the
37
     *               <i>json</i> cannot be decoded or if the encoded
38
     *               data is deeper than the recursion limit
39
     */
40 78
    protected function getResponseJson(RequestInterface $request)
41
    {
42 78
        $response = $this->client->send($request);
43 42
        $body = (string) $response->getBody();
44
45 42
        return json_decode($body, true);
46
    }
47
48
    /**
49
     * Get query string of using the options.
50
     *
51
     * @param $options The options
52
     * @return string  The query string
53
     */
54 18
    protected function getQueryString($options) {
55 18
      $queries = [];
56 18
      foreach ($this->queryParameters as $queryName => $queryDefaultValue) {
57
        // Use user value if possible.
58 18 View Code Duplication
        if (isset($options[$queryName])) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
59 9
          $queries[] = $queryName . '=' . $options[$queryName];
60 9
          continue;
61
        }
62
        // Use default value if possible.
63 9 View Code Duplication
        if (!isset($options[$queryName]) && is_string($queryDefaultValue)) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
64
          $queries[] = $queryName . '=' . $queryDefaultValue;
65 3
          continue;
66
        }
67 12
      }
68 18
      $queryString = implode('&', $queries);
69 18
      return empty($queryString) ? '' : '?' . $queryString;
70
    }
71
}
72