SlotManager::add() - Code Metrics - Inspection of "Adding goals support to the PHP SDK" - acquia/lift-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Nick

created 2016-10-26 10:18 UTC

SlotManager::add() A

↳ Parent: SlotManager

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	10
Ratio	100 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes

Metric	Value
dl	10
loc	10
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	1
crap	1

<?php

namespace Acquia\LiftClient\Manager;

use Acquia\LiftClient\Entity\Slot;
use GuzzleHttp\Psr7\Request;

class SlotManager extends ManagerBase
{

    /**
     * Get a list of slots.
     *
     * Example of how to structure the $options parameter:
     * <code>
     * $options = [
     *     'visible_on_page'  => 'http://localhost/blog/*',
     *     'status' => 'enabled',
     * ];
     * </code>
     *
     * @see http://docs.decision-api.acquia.com/#slots_get
     *
     * @param array $options
     *
     * @return \Acquia\LiftClient\Entity\Slot[]
     *
     * @throws \GuzzleHttp\Exception\RequestException
     */
    public function query($options = [])
    {
        $variables = $options + [
            'limit' => 1000,
            'start' => 0,
          ];

        $url = "/slots";
        $url .= isset($variables['visible_on_page']) ? "&visible_on_page={$variables['visible_on_page']}" : '';
        $url .= isset($variables['status']) ? "&status={$variables['status']}" : '';

        // Now make the request.
        $request = new Request('GET', $url);
        $data = $this->client->getResponseJson($request);

        // Get them as Slot objects
        $slots = [];
        foreach ($data as $dataItem) {
            $slots[] = new Slot($dataItem);
        }

        return $slots;
    }


    /**
     * Get a specific slot
     *
     * Example of how to structure the $options parameter:
     *
     * @see http://docs.decision-api.acquia.com/#slots__slotId__get
     *
     * @param array $options
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return \Acquia\LiftClient\Entity\Slot
     *
     * @throws \GuzzleHttp\Exception\RequestException
     */
    public function get(

      $slotId
    ) {
        $url = "/slots/{$slotId}";

        // Now make the request.
        $request = new Request('GET', $url);
        $data = $this->client->getResponseJson($request);

        return new Slot($data);
    }

    /**
     * Add a slot
     *
     * @param \Acquia\LiftClient\Entity\Slot $slot
     *
     * @return \Acquia\LiftClient\Entity\Slot
     *
     * @throws \GuzzleHttp\Exception\RequestException
     */
    public function add(

      Slot $slot
    ) {
        $body = $slot->json();
        $url = "/slots";
        $request = new Request('POST', $url, [], $body);
        $data = $this->client->getResponseJson($request);

        return new Slot($data);
    }

    /**
     * Deletes a slot by ID.
     *
     * @param string $id
     *
     * @return bool
     *   returns TRUE if successful.
     *
     * @throws \GuzzleHttp\Exception\RequestException
     */
    public function delete(
      $id
    ) {
        $url = "/slots/{$id}";
        $this->client->delete($url);

        return true;
    }
}


1			<?php
2
3			namespace Acquia\LiftClient\Manager;
4
5			use Acquia\LiftClient\Entity\Slot;
6			use GuzzleHttp\Psr7\Request;
7
8			class SlotManager extends ManagerBase
9			{
10
11			/**
12			* Get a list of slots.
13			*
14			* Example of how to structure the $options parameter:
15			* <code>
16			* $options = [
17			* 'visible_on_page' => 'http://localhost/blog/*',
18			* 'status' => 'enabled',
19			* ];
20			* </code>
21			*
22			* @see http://docs.decision-api.acquia.com/#slots_get
23			*
24			* @param array $options
25			*
26			* @return \Acquia\LiftClient\Entity\Slot[]
27			*
28			* @throws \GuzzleHttp\Exception\RequestException
29			*/
30	6		public function query($options = [])
31			{
32			$variables = $options + [
33	6		'limit' => 1000,
34	4		'start' => 0,
35	4		];
36
37	6		$url = "/slots";
38	6		$url .= isset($variables['visible_on_page']) ? "&visible_on_page={$variables['visible_on_page']}" : '';
39	6		$url .= isset($variables['status']) ? "&status={$variables['status']}" : '';
40
41			// Now make the request.
42	6		$request = new Request('GET', $url);
43	6		$data = $this->client->getResponseJson($request);
44
45			// Get them as Slot objects
46	3		$slots = [];
47	3		foreach ($data as $dataItem) {
48	3		$slots[] = new Slot($dataItem);
49	2		}
50
51	3		return $slots;
52			}
53
54
55			/**
56			* Get a specific slot
57			*
58			* Example of how to structure the $options parameter:
59			*
60			* @see http://docs.decision-api.acquia.com/#slots__slotId__get
61			*
62			* @param array $options
			0 ignored issues – show Bug introduced 2016-08-22 13:20 UTC by Report Bug Copy Issue Report There is no parameter named `$options`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
63			*
64			* @return \Acquia\LiftClient\Entity\Slot
65			*
66			* @throws \GuzzleHttp\Exception\RequestException
67			*/
68	6	View Code Duplication	public function get(
			1 ignored issue – show Duplication introduced 2016-08-22 13:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69			$slotId
70			) {
71	6		$url = "/slots/{$slotId}";
72
73			// Now make the request.
74	6		$request = new Request('GET', $url);
75	6		$data = $this->client->getResponseJson($request);
76
77	3		return new Slot($data);
78			}
79
80			/**
81			* Add a slot
82			*
83			* @param \Acquia\LiftClient\Entity\Slot $slot
84			*
85			* @return \Acquia\LiftClient\Entity\Slot
86			*
87			* @throws \GuzzleHttp\Exception\RequestException
88			*/
89	6	View Code Duplication	public function add(
			1 ignored issue – show Duplication introduced 2016-08-22 13:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
90			Slot $slot
91			) {
92	6		$body = $slot->json();
93	6		$url = "/slots";
94	6		$request = new Request('POST', $url, [], $body);
95	6		$data = $this->client->getResponseJson($request);
96
97	3		return new Slot($data);
98			}
99
100			/**
101			* Deletes a slot by ID.
102			*
103			* @param string $id
104			*
105			* @return bool
106			* returns TRUE if successful.
107			*
108			* @throws \GuzzleHttp\Exception\RequestException
109			*/
110	6		public function delete(
111			$id
112			) {
113	6		$url = "/slots/{$id}";
114	6		$this->client->delete($url);
115
116	3		return true;
117			}
118			}
119

acquia / lift-sdk-php

Pull Request — master (#4)

SlotManager::add() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like