DFSWEMNewsNodesTranslations::__construct() - Code Metrics - Inspection of "Prepare for 7.x-1.24." - acquia/df - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 7.x-1.x ( 94dab8...029788 )

by Devin

created 2016-06-24 18:43 UTC

DFSWEMNewsNodesTranslations::__construct() B

↳ Parent: DFSWEMNewsNodesTranslations

Complexity

Conditions	1
Paths	1

Size

Total Lines	31
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	20
nc	1
nop	1
dl	0
loc	31
rs	8.8571
c	0
b	0
f	0

<?php

/**
 * @file
 *  Migrations for WEM News Nodes Translations.
 */

class DFSWEMNewsNodesTranslations extends DemoFrameworkBaseNodesTranslations {

  public function __construct($arguments) {
    parent::__construct($arguments);
    $this->description = t('Import node translations.');
    $import_path = drupal_get_path('module', 'dfs_wem') . '/import/';
    // Create a MigrateSource object.
    $this->source = new MigrateSourceCSV($import_path . 'dfs_wem.nodes.wem_news.translations.csv', $this->csvcolumns(), array('header_rows' => 1));
    $this->destination = new MigrateDestinationNode('wem_news');
    // Image
    $this->addFieldMapping('field_wem_image', 'image');
    $this->addFieldMapping('field_wem_image:file_replace')->defaultValue(FILE_EXISTS_REPLACE);
    $this->addFieldMapping('field_wem_image:source_dir')->defaultValue($import_path . 'images');
    $this->addFieldMapping('field_wem_image:destination_file', 'filename');
    // Video
    $this->addFieldMapping('field_wem_video', 'video')->sourceMigration('DFSWEMNewsVideo');
    $this->addFieldMapping('field_wem_video:file_class')->defaultValue('MigrateFileFid');
    // Taxonomy
    $this->addFieldMapping('field_wem_interests', 'interests');
    // Workbench
    $this->addFieldMapping('workbench_moderation_state_new', 'workbench_moderation_state_new')->defaultValue('published');
    // Translations
    $this->addFieldMapping('title', 'translated_title');
    $this->addFieldMapping('tnid', 'title')->sourceMigration('DFSWEMNewsNodes');
    // UUID
    $this->addFieldMapping('uuid', 'uuid');
    // Created
    $this->addFieldMapping('created', 'created')->defaultValue(strtotime("now"));
    // Persona
    $this->addFieldMapping('field_persona', 'persona');
    // Site Section
    $this->addFieldMapping('field_site_section', 'site_section')->defaultValue("Content");
  }

  function csvcolumns() {

    $columns[0] = array('title', 'Source Title');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    $columns[1] = array('language', 'Language');
    $columns[2] = array('translated_title', 'Title');
    $columns[3] = array('body', 'Body');
    $columns[4] = array('image', 'Image');
    $columns[5] = array('video', 'Video');
    $columns[6] = array('interests', 'Interests');
    $columns[7] = array('uuid', 'UUID');
    $columns[8] = array('created', 'Created');
    $columns[9] = array('persona', 'Persona');
    return $columns;
  }

  function prepareRow($row) {

    $row->interests = explode(", ", $row->interests);
    return TRUE;
  }

  function prepare(&$node, $row) {

    if (isset($node->tnid) && ($source = node_load($node->tnid))) {
      $node->translation_source = $source;
    }
  }
}


1			<?php
2
3			/**
4			* @file
5			* Migrations for WEM News Nodes Translations.
6			*/
7
8			class DFSWEMNewsNodesTranslations extends DemoFrameworkBaseNodesTranslations {
9
10			public function __construct($arguments) {
11			parent::__construct($arguments);
12			$this->description = t('Import node translations.');
13			$import_path = drupal_get_path('module', 'dfs_wem') . '/import/';
14			// Create a MigrateSource object.
15			$this->source = new MigrateSourceCSV($import_path . 'dfs_wem.nodes.wem_news.translations.csv', $this->csvcolumns(), array('header_rows' => 1));
16			$this->destination = new MigrateDestinationNode('wem_news');
17			// Image
18			$this->addFieldMapping('field_wem_image', 'image');
19			$this->addFieldMapping('field_wem_image:file_replace')->defaultValue(FILE_EXISTS_REPLACE);
20			$this->addFieldMapping('field_wem_image:source_dir')->defaultValue($import_path . 'images');
21			$this->addFieldMapping('field_wem_image:destination_file', 'filename');
22			// Video
23			$this->addFieldMapping('field_wem_video', 'video')->sourceMigration('DFSWEMNewsVideo');
24			$this->addFieldMapping('field_wem_video:file_class')->defaultValue('MigrateFileFid');
25			// Taxonomy
26			$this->addFieldMapping('field_wem_interests', 'interests');
27			// Workbench
28			$this->addFieldMapping('workbench_moderation_state_new', 'workbench_moderation_state_new')->defaultValue('published');
29			// Translations
30			$this->addFieldMapping('title', 'translated_title');
31			$this->addFieldMapping('tnid', 'title')->sourceMigration('DFSWEMNewsNodes');
32			// UUID
33			$this->addFieldMapping('uuid', 'uuid');
34			// Created
35			$this->addFieldMapping('created', 'created')->defaultValue(strtotime("now"));
36			// Persona
37			$this->addFieldMapping('field_persona', 'persona');
38			// Site Section
39			$this->addFieldMapping('field_site_section', 'site_section')->defaultValue("Content");
40			}
41
42			function csvcolumns() {
			0 ignored issues – show Best Practice introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
43			$columns[0] = array('title', 'Source Title');
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report `$columns` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$columns = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
44			$columns[1] = array('language', 'Language');
45			$columns[2] = array('translated_title', 'Title');
46			$columns[3] = array('body', 'Body');
47			$columns[4] = array('image', 'Image');
48			$columns[5] = array('video', 'Video');
49			$columns[6] = array('interests', 'Interests');
50			$columns[7] = array('uuid', 'UUID');
51			$columns[8] = array('created', 'Created');
52			$columns[9] = array('persona', 'Persona');
53			return $columns;
54			}
55
56			function prepareRow($row) {
			0 ignored issues – show Best Practice introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
57			$row->interests = explode(", ", $row->interests);
58			return TRUE;
59			}
60
61			function prepare(&$node, $row) {
			0 ignored issues – show Best Practice introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
62			if (isset($node->tnid) && ($source = node_load($node->tnid))) {
63			$node->translation_source = $source;
64			}
65			}
66			}
67

acquia / df

GitHub Access Token became invalid

Push — 7.x-1.x ( 94dab8...029788 )

DFSWEMNewsNodesTranslations::__construct() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like