DFSMEDSlideshowNodes::__construct() - Code Metrics - Inspection of "Prepare for 7.x-1.24." - acquia/df - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 7.x-1.x ( 94dab8...029788 )

by Devin

created 2016-06-24 18:43 UTC

DFSMEDSlideshowNodes::__construct() A

↳ Parent: DFSMEDSlideshowNodes

Complexity

Conditions	1
Paths	1

Size

Total Lines	22
Code Lines	15

Duplication

Lines	22
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	15
c	1
b	0
f	1
nc	1
nop	1
dl	22
loc	22
rs	9.2

<?php

/**
 * @file
 *  Migrations for Slideshow Nodes.
 */

class DFSMEDSlideshowNodes extends DemoFrameworkBaseNodesUUID {
  public function __construct($arguments) {

    parent::__construct($arguments);
    $this->description = t('Import nodes.');
    $import_path = drupal_get_path('module', 'dfs_med') . '/import/';
    // Create a MigrateSource object.
    $this->source = new MigrateSourceCSV($import_path . 'dfs_med.nodes.slideshow.csv', $this->csvcolumns(), array('header_rows' => 1));
    $this->destination = new MigrateDestinationNode('slideshow_slide');
    // Created
    $this->addFieldMapping('created', 'created')->defaultValue(strtotime("now"));
    // Main Image
    $this->addFieldMapping('field_main_image', 'image');
    $this->addFieldMapping('field_main_image:file_replace')->defaultValue(FILE_EXISTS_REPLACE);
    $this->addFieldMapping('field_main_image:source_dir')->defaultValue($import_path . 'images');
    $this->addFieldMapping('field_main_image:destination_file', 'filename');
    // Link
    $this->addfieldmapping('field_link', 'link');
    $this->addfieldmapping('field_link:title', 'link_title');
    // Persona
    $this->addFieldMapping('field_persona', 'persona');
    // Site Section
    $this->addFieldMapping('field_site_section', 'site_section')->defaultValue("Content");
  }

  function csvcolumns() {

    $columns[0] = array('uuid', 'UUID');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    $columns[1] = array('title', 'Title');
    $columns[2] = array('body', 'Body');
    $columns[3] = array('image', 'Image');
    $columns[4] = array('link', 'Link');
    $columns[5] = array('link_title', 'Link Title');
    $columns[6] = array('persona', 'Persona');
    return $columns;
  }

}



1		<?php
2
3		/**
4		* @file
5		* Migrations for Slideshow Nodes.
6		*/
7
8		class DFSMEDSlideshowNodes extends DemoFrameworkBaseNodesUUID {
9	View Code Duplication	public function __construct($arguments) {
		0 ignored issues – show Duplication introduced 2016-04-04 18:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		parent::__construct($arguments);
11		$this->description = t('Import nodes.');
12		$import_path = drupal_get_path('module', 'dfs_med') . '/import/';
13		// Create a MigrateSource object.
14		$this->source = new MigrateSourceCSV($import_path . 'dfs_med.nodes.slideshow.csv', $this->csvcolumns(), array('header_rows' => 1));
15		$this->destination = new MigrateDestinationNode('slideshow_slide');
16		// Created
17		$this->addFieldMapping('created', 'created')->defaultValue(strtotime("now"));
18		// Main Image
19		$this->addFieldMapping('field_main_image', 'image');
20		$this->addFieldMapping('field_main_image:file_replace')->defaultValue(FILE_EXISTS_REPLACE);
21		$this->addFieldMapping('field_main_image:source_dir')->defaultValue($import_path . 'images');
22		$this->addFieldMapping('field_main_image:destination_file', 'filename');
23		// Link
24		$this->addfieldmapping('field_link', 'link');
25		$this->addfieldmapping('field_link:title', 'link_title');
26		// Persona
27		$this->addFieldMapping('field_persona', 'persona');
28		// Site Section
29		$this->addFieldMapping('field_site_section', 'site_section')->defaultValue("Content");
30		}
31
32	View Code Duplication	function csvcolumns() {
		0 ignored issues – show Duplication introduced 2016-04-04 18:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Best Practice introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
33		$columns[0] = array('uuid', 'UUID');
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report `$columns` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$columns = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
34		$columns[1] = array('title', 'Title');
35		$columns[2] = array('body', 'Body');
36		$columns[3] = array('image', 'Image');
37		$columns[4] = array('link', 'Link');
38		$columns[5] = array('link_title', 'Link Title');
39		$columns[6] = array('persona', 'Persona');
40		return $columns;
41		}
42
43		}
44
45

acquia / df

GitHub Access Token became invalid

Push — 7.x-1.x ( 94dab8...029788 )

DFSMEDSlideshowNodes::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like