DFSWEMPersonaTerms - Code Metrics - Inspection of "Prepare for 7.x-1.24." - acquia/df - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 7.x-1.x ( 94dab8...029788 )

by Devin

created 2016-06-24 18:43 UTC

DFSWEMPersonaTerms A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	15
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	15
loc	15
rs	10
c	0
b	0
f	0
wmc	2
lcom	0
cbo	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	1
A	csvcolumns()	4	4	1

How to fix Duplicated Code

<?php

/**
 * @file
 *  Migration for Persona Taxonomy Terms in DFS WEM.
 */

class DFSWEMPersonaTerms extends ImportBaseTerms {


  public function __construct($arguments) {
    parent::__construct($arguments);
    $import_path = drupal_get_path('module', 'dfs_wem') . '/import/';
    $this->source = new MigrateSourceCSV($import_path . 'dfs_wem.terms.persona.csv', $this->csvcolumns(), array('header_rows' => 1));
    $this->destination = new MigrateDestinationTerm('persona');
    $this->addFieldMapping('name', 'name');
  }

  function csvcolumns() {

    $columns[0] = array('name', 'Name');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    return $columns;
  }
}


1		<?php
2
3		/**
4		* @file
5		* Migration for Persona Taxonomy Terms in DFS WEM.
6		*/
7
8	View Code Duplication	class DFSWEMPersonaTerms extends ImportBaseTerms {
		0 ignored issues – show Duplication introduced 2016-04-04 18:33 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9
10		public function __construct($arguments) {
11		parent::__construct($arguments);
12		$import_path = drupal_get_path('module', 'dfs_wem') . '/import/';
13		$this->source = new MigrateSourceCSV($import_path . 'dfs_wem.terms.persona.csv', $this->csvcolumns(), array('header_rows' => 1));
14		$this->destination = new MigrateDestinationTerm('persona');
15		$this->addFieldMapping('name', 'name');
16		}
17
18		function csvcolumns() {
		0 ignored issues – show Best Practice introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
19		$columns[0] = array('name', 'Name');
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report `$columns` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$columns = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
20		return $columns;
21		}
22		}
23

acquia / df

GitHub Access Token became invalid

Push — 7.x-1.x ( 94dab8...029788 )

DFSWEMPersonaTerms A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like