MenuRouterRebuildSubscriber - Code Metrics - Inspection of "Merge pull request #7 from typhonius/drushrc-worka..." - acquia/df - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 8.x-1.x ( 869a51...b7bfed )

by Brant

created 2016-04-19 16:34 UTC

MenuRouterRebuildSubscriber A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
wmc	8
c	2
b	0
f	2
lcom	0
cbo	0
dl	0
loc	31
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
B	onKernelRequestMenuRouterRebuild()	0	12	7
A	getSubscribedEvents()	0	5	1

<?php

/**
 * @file
 * Contains \Drupal\df_admin\EventSubscriber\MenuRouterRebuildSubscriber.
 */

namespace Drupal\df_admin\EventSubscriber;

use Symfony\Component\HttpKernel\KernelEvents;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * Rebuilds the menu router to ensure image derivatives are created.
 */
class MenuRouterRebuildSubscriber implements EventSubscriberInterface {

  /**
   * Rebuilds the menu router if the rebuild.dat file is found.
   *
   * @param \Symfony\Component\HttpKernel\Event\GetResponseEvent $event
   *   The Event to process.
   */
  public function onKernelRequestMenuRouterRebuild(GetResponseEvent $event) {

    if (file_exists("public://rebuild.dat")) {
      $site_path = preg_replace('/^sites\//', '', \Drupal::service('site.path'));
      if (!file_exists('public://.drushrc') && file_exists('public://') && is_writable('public://') && file_put_contents('public:///.drushrc', "<?php\n\$options['l'] = 'http://${site_path}';")) {
        drupal_chmod('public:///.drushrc', 0444);
      }

      if (\Drupal::service('router.builder')->rebuild()) {
        file_unmanaged_delete("public://rebuild.dat");
      }
    }
  }

  /**
   * {@inheritdoc}
   */
  static function getSubscribedEvents() {
    $events[KernelEvents::REQUEST][] = ['onKernelRequestMenuRouterRebuild', 255];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

    return $events;
  }

}



1			<?php
2
3			/**
4			* @file
5			* Contains \Drupal\df_admin\EventSubscriber\MenuRouterRebuildSubscriber.
6			*/
7
8			namespace Drupal\df_admin\EventSubscriber;
9
10			use Symfony\Component\HttpKernel\KernelEvents;
11			use Symfony\Component\HttpKernel\Event\GetResponseEvent;
12			use Symfony\Component\EventDispatcher\EventSubscriberInterface;
13
14			/**
15			* Rebuilds the menu router to ensure image derivatives are created.
16			*/
17			class MenuRouterRebuildSubscriber implements EventSubscriberInterface {
18
19			/**
20			* Rebuilds the menu router if the rebuild.dat file is found.
21			*
22			* @param \Symfony\Component\HttpKernel\Event\GetResponseEvent $event
23			* The Event to process.
24			*/
25			public function onKernelRequestMenuRouterRebuild(GetResponseEvent $event) {
			0 ignored issues – show Unused Code introduced 2016-04-09 12:33 UTC by Report Bug Copy Issue Report The parameter `$event` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
26			if (file_exists("public://rebuild.dat")) {
27			$site_path = preg_replace('/^sites\//', '', \Drupal::service('site.path'));
28			if (!file_exists('public://.drushrc') && file_exists('public://') && is_writable('public://') && file_put_contents('public:///.drushrc', "<?php\n\$options['l'] = 'http://${site_path}';")) {
29			drupal_chmod('public:///.drushrc', 0444);
30			}
31
32			if (\Drupal::service('router.builder')->rebuild()) {
33			file_unmanaged_delete("public://rebuild.dat");
34			}
35			}
36			}
37
38			/**
39			* {@inheritdoc}
40			*/
41			static function getSubscribedEvents() {
42			$events[KernelEvents::REQUEST][] = ['onKernelRequestMenuRouterRebuild', 255];
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-09 12:33 UTC by Report Bug Copy Issue Report `$events` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$events = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
43
44			return $events;
45			}
46
47			}
48
49

acquia / df

GitHub Access Token became invalid

Push — 8.x-1.x ( 869a51...b7bfed )

MenuRouterRebuildSubscriber A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like