ModerationSidebarContext - Code Metrics - Inspection of "Added a moderation sidebar context and updated mod..." - acquia/df - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 8.x-2.x ( 60568e...519fd1 )

by Devin

created 2017-11-01 11:53 UTC

ModerationSidebarContext A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	93
Duplicated Lines	62.37 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	58
loc	93
rs	10
wmc	6
lcom	1
cbo	4

4 Methods

Rating	Name	Duplication	Size	Complexity
A	openModerationSidebar()	16	16	2
A	closeModerationSidebar()	16	16	2
A	selectModerationSidebarButton()	13	13	1
A	selectModerationSidebarLink()	13	13	1

How to fix Duplicated Code

<?php

namespace Acquia\DFExtension\Context;

use Acquia\LightningExtension\AwaitTrait;
use Acquia\LightningExtension\Context\PanelsInPlaceContext;
use Acquia\LightningExtension\Context\UtilityContext;
use Drupal\DrupalExtension\Context\DrupalSubContextBase;

/**
 * A context with miscellaneous helpers.
 */
class ModerationSidebarContext extends DrupalSubContextBase {

  use AwaitTrait;

  /**
   * Opens the moderation sidebar.
   *
   * @When I open the moderation sidebar
   */
  public function openModerationSidebar() {

    $assert = $this->assertSession();

    // Assert that the tab exists...
    $link = $assert->elementExists(
      'named',
      ['link', 'Tasks'],
      $assert->elementExists('css', '.moderation-sidebar-toolbar-tab')
    );

    // ...but only open it if not already active.
    if ($link->hasClass('sidebar-open') == FALSE) {

      $link->click();
      $this->awaitAjax();
    }
  }

  /**
   * Closes the moderation sidebar.
   *
   * @When I close the moderation sidebar
   */
  public function closeModerationSidebar() {

    $assert = $this->assertSession();

    // Assert that the tab exists...
    $link = $assert->elementExists(
      'named',
      ['link', 'Tasks'],
      $assert->elementExists('css', '.moderation-sidebar-toolbar-tab')
    );

    // ...but only open it if already active.
    if ($link->hasClass('sidebar-open') == TRUE) {

      $link->click();
      $this->awaitAjax();
    }
  }

  /**
   * Selects a moderation sidebar item.
   *
   * @param string $item
   *   The moderation sidebar item to select.
   *
   * @Given I select the :item moderation sidebar button
   */
  public function selectModerationSidebarButton($item) {

    $assert = $this->assertSession();

    // Assert that the tab exists...
    $link = $assert->elementExists(
      'named',
      ['button', $item],
      $assert->elementExists('css', '.moderation-sidebar-actions')
    );

    $link->click();
    $this->awaitAjax();
  }

  /**
   * Selects a moderation sidebar item.
   *
   * @param string $item
   *   The moderation sidebar item to select.
   *
   * @Given I select the :item moderation sidebar link
   */
  public function selectModerationSidebarLink($item) {

    $assert = $this->assertSession();

    // Assert that the tab exists...
    $link = $assert->elementExists(
      'named',
      ['link', $item],
      $assert->elementExists('css', '.moderation-sidebar-actions')
    );

    $link->click();
    $this->awaitAjax();
  }

}



1		<?php
2
3		namespace Acquia\DFExtension\Context;
4
5		use Acquia\LightningExtension\AwaitTrait;
6		use Acquia\LightningExtension\Context\PanelsInPlaceContext;
7		use Acquia\LightningExtension\Context\UtilityContext;
8		use Drupal\DrupalExtension\Context\DrupalSubContextBase;
9
10		/**
11		* A context with miscellaneous helpers.
12		*/
13		class ModerationSidebarContext extends DrupalSubContextBase {
14
15		use AwaitTrait;
16
17		/**
18		* Opens the moderation sidebar.
19		*
20		* @When I open the moderation sidebar
21		*/
22	View Code Duplication	public function openModerationSidebar() {
		0 ignored issues – show Duplication introduced 2017-11-01 11:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		$assert = $this->assertSession();
24
25		// Assert that the tab exists...
26		$link = $assert->elementExists(
27		'named',
28		['link', 'Tasks'],
29		$assert->elementExists('css', '.moderation-sidebar-toolbar-tab')
30		);
31
32		// ...but only open it if not already active.
33		if ($link->hasClass('sidebar-open') == FALSE) {
		0 ignored issues – show Coding Style Best Practice introduced 2017-04-27 15:49 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
34		$link->click();
35		$this->awaitAjax();
36		}
37		}
38
39		/**
40		* Closes the moderation sidebar.
41		*
42		* @When I close the moderation sidebar
43		*/
44	View Code Duplication	public function closeModerationSidebar() {
		0 ignored issues – show Duplication introduced 2017-11-01 11:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		$assert = $this->assertSession();
46
47		// Assert that the tab exists...
48		$link = $assert->elementExists(
49		'named',
50		['link', 'Tasks'],
51		$assert->elementExists('css', '.moderation-sidebar-toolbar-tab')
52		);
53
54		// ...but only open it if already active.
55		if ($link->hasClass('sidebar-open') == TRUE) {
		0 ignored issues – show Coding Style Best Practice introduced 2017-11-01 11:58 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
56		$link->click();
57		$this->awaitAjax();
58		}
59		}
60
61		/**
62		* Selects a moderation sidebar item.
63		*
64		* @param string $item
65		* The moderation sidebar item to select.
66		*
67		* @Given I select the :item moderation sidebar button
68		*/
69	View Code Duplication	public function selectModerationSidebarButton($item) {
		0 ignored issues – show Duplication introduced 2017-11-01 11:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		$assert = $this->assertSession();
71
72		// Assert that the tab exists...
73		$link = $assert->elementExists(
74		'named',
75		['button', $item],
76		$assert->elementExists('css', '.moderation-sidebar-actions')
77		);
78
79		$link->click();
80		$this->awaitAjax();
81		}
82
83		/**
84		* Selects a moderation sidebar item.
85		*
86		* @param string $item
87		* The moderation sidebar item to select.
88		*
89		* @Given I select the :item moderation sidebar link
90		*/
91	View Code Duplication	public function selectModerationSidebarLink($item) {
		0 ignored issues – show Duplication introduced 2017-11-01 11:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92		$assert = $this->assertSession();
93
94		// Assert that the tab exists...
95		$link = $assert->elementExists(
96		'named',
97		['link', $item],
98		$assert->elementExists('css', '.moderation-sidebar-actions')
99		);
100
101		$link->click();
102		$this->awaitAjax();
103		}
104
105		}
106
107

acquia / df

GitHub Access Token became invalid

Push — 8.x-2.x ( 60568e...519fd1 )

ModerationSidebarContext A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like