DFSWEMProductReviewNodes::csvcolumns() - Code Metrics - Inspection of "Updated the Entity Translation module to 7.x-1.0-b..." - acquia/df - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 7.x-1.x ( 9e29a0...ca9ee1 )

by Devin

created 2016-05-20 16:15 UTC

DFSWEMProductReviewNodes::csvcolumns() A

↳ Parent: DFSWEMProductReviewNodes

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	9

Duplication

Lines	10
Ratio	100 %

Metric	Value
cc	1
eloc	9
nc	1
nop	0
dl	10
loc	10
rs	9.4285

<?php

/**
 * @file
 *  Migrations for WEM Commerce Product Nodes.
 */

class DFSWEMProductReviewNodes extends DemoFrameworkBaseNodesUUID {

  public function __construct($arguments) {
    parent::__construct($arguments);
    $this->description = t('Import product reviews for WEM Commerce nodes.');

    $this->dependencies = array('DFSWEMCommerceNodes');

    $import_path = drupal_get_path('module', 'dfs_wem') . '/import/';

    // Create a MigrateSource object.
    $this->source = new MigrateSourceCSV($import_path . 'dfs_wem.nodes.wem_product_review.csv', $this->csvcolumns(), array('header_rows' => 1));

    $this->destination = new MigrateDestinationNode('wem_product_review');

    // Author
    $this->addFieldMapping('uid', 'author')->sourceMigration('DFSWEMUsers');

    // Entity Reference
    $this->addFieldMapping('field_wem_commerce_ref', 'commerce')->sourceMigration('DFSWEMCommerceNodes');
     
    // Image
    $this->addFieldMapping('field_product_review_image', 'image');
    $this->addFieldMapping('field_product_review_image:file_replace')->defaultValue(FILE_EXISTS_REPLACE);
    $this->addFieldMapping('field_product_review_image:source_dir')->defaultValue($import_path . 'images');
    $this->addFieldMapping('field_product_review_image:destination_file', 'filename');

    // Created
    $this->addFieldMapping('created', 'created')->defaultValue(strtotime("now"));
  }

  function csvcolumns() {

    $columns[0] = array('title', 'Title');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    $columns[1] = array('body', 'Body');
    $columns[2] = array('commerce', 'Commerce');
    $columns[3] = array('image', 'Image');
    $columns[4] = array('author', 'Author');
    $columns[5] = array('uuid', 'UUID');
    $columns[6] = array('created', 'Created');
    return $columns;
  }

}



1		<?php
2
3		/**
4		* @file
5		* Migrations for WEM Commerce Product Nodes.
6		*/
7
8		class DFSWEMProductReviewNodes extends DemoFrameworkBaseNodesUUID {
9
10		public function __construct($arguments) {
11		parent::__construct($arguments);
12		$this->description = t('Import product reviews for WEM Commerce nodes.');
13
14		$this->dependencies = array('DFSWEMCommerceNodes');
15
16		$import_path = drupal_get_path('module', 'dfs_wem') . '/import/';
17
18		// Create a MigrateSource object.
19		$this->source = new MigrateSourceCSV($import_path . 'dfs_wem.nodes.wem_product_review.csv', $this->csvcolumns(), array('header_rows' => 1));
20
21		$this->destination = new MigrateDestinationNode('wem_product_review');
22
23		// Author
24		$this->addFieldMapping('uid', 'author')->sourceMigration('DFSWEMUsers');
25
26		// Entity Reference
27		$this->addFieldMapping('field_wem_commerce_ref', 'commerce')->sourceMigration('DFSWEMCommerceNodes');
28
29		// Image
30		$this->addFieldMapping('field_product_review_image', 'image');
31		$this->addFieldMapping('field_product_review_image:file_replace')->defaultValue(FILE_EXISTS_REPLACE);
32		$this->addFieldMapping('field_product_review_image:source_dir')->defaultValue($import_path . 'images');
33		$this->addFieldMapping('field_product_review_image:destination_file', 'filename');
34
35		// Created
36		$this->addFieldMapping('created', 'created')->defaultValue(strtotime("now"));
37		}
38
39	View Code Duplication	function csvcolumns() {
		0 ignored issues – show Duplication introduced 2016-04-04 18:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Best Practice introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
40		$columns[0] = array('title', 'Title');
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report `$columns` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$columns = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
41		$columns[1] = array('body', 'Body');
42		$columns[2] = array('commerce', 'Commerce');
43		$columns[3] = array('image', 'Image');
44		$columns[4] = array('author', 'Author');
45		$columns[5] = array('uuid', 'UUID');
46		$columns[6] = array('created', 'Created');
47		return $columns;
48		}
49
50		}
51
52

acquia / df

GitHub Access Token became invalid

Push — 7.x-1.x ( 9e29a0...ca9ee1 )

DFSWEMProductReviewNodes::csvcolumns() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like