DFSMEDProducts::__construct() - Code Metrics - Inspection of "Updated Drupal Core to 7.44." - acquia/df - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 7.x-1.x ( 34e25a...94dab8 )

by Devin

created 2016-06-16 18:29 UTC

DFSMEDProducts::__construct() A

↳ Parent: DFSMEDProducts

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	13
c	1
b	0
f	1
nc	1
nop	1
dl	0
loc	20
rs	9.4285

<?php

/**
 * @file
 *  Migrations for Commerce Product Nodes.
 */

class DFSMEDCommerceNodes extends DemoFrameworkBaseCommerceNodes {
  public function __construct($arguments) {
    parent::__construct($arguments);
    $this->description = t('Import Commerce Product nodes.');
    $this->map = new MigrateSQLMap($this->machineName,
      array(
        'sku' => array(
          'type' => 'varchar',
          'length' => 32,
          'not null' => TRUE,
        ),
      ),
      MigrateDestinationNode::getKeySchema()
    );
    $this->dependencies = array('DFSMEDProducts');
    $import_path = drupal_get_path('module', 'dfs_med') . '/import/';
    $this->source = new MigrateSourceCSV($import_path . 'dfs_med.nodes.commerce.csv', $this->csvcolumns(), array('header_rows' => 1));
    $this->destination = new MigrateDestinationNode('commerce');
    // Created
    $this->addFieldMapping('created', 'created')->defaultValue(strtotime("now"));
    // Brand
    $this->addFieldMapping('field_brand', 'brand')->sourceMigration('DFSMEDBrandNodes');
    // Commerce
    $this->addFieldMapping('field_product', 'skus');
    // Feature Image
    $this->addFieldMapping('field_product_image', 'image');
    $this->addFieldMapping('field_product_image:file_replace')->defaultValue(FILE_EXISTS_REPLACE);
    $this->addFieldMapping('field_product_image:source_dir')->defaultValue($import_path . 'images');
    $this->addFieldMapping('field_product_image:destination_file', 'filename');
    // Booleans
    $this->addfieldmapping('field_featured', 'featured');
    $this->addfieldmapping('field_bestseller', 'bestseller');
    // Persona
    $this->addFieldMapping('field_persona', 'persona');
    // Site Section
    $this->addFieldMapping('field_site_section', 'site_section')->defaultValue("Commerce");
  }

  function csvcolumns() {

    $columns[0] = array('title', 'Title');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    $columns[1] = array('brand', 'Brand');
    $columns[2] = array('sku', 'SKU');
    $columns[3] = array('image', 'Image');
    $columns[4] = array('featured', 'Featured');
    $columns[5] = array('bestseller', 'Bestseller');
    $columns[7] = array('persona', 'Persona');
    return $columns;
  }

  function prepareRow($row) {

    $products = array();
    foreach (explode(', ', $row->sku) as $sku) {
      $product = commerce_product_load_by_sku($sku);
      $products[] = $product->product_id;
    }
    $row->skus = $products;
  }

}

class DFSMEDProducts extends DemoFrameworkBaseProducts {
  public function __construct($arguments) {
    parent::__construct($arguments);
    $this->description = t('Import Commerce products.');
    // Create a map object for tracking the relationships between source rows
    $this->map = new MigrateSQLMap($this->machineName,
      array(
        'sku' => array(
          'type' => 'varchar',
          'length' => 32,
          'not null' => TRUE,
        ),
      ),
      MigrateDestinationEntityAPI::getKeySchema('commerce_product', 'product')
    );
    $this->destination = new MigrateDestinationEntityAPI('commerce_product', 'product');
    // Define a default import path.
    $import_path = drupal_get_path('module', 'dfs_med') . '/import/';
    // Create a MigrateSource object.
    $this->source = new MigrateSourceCSV($import_path . 'dfs_med.nodes.commerce.csv', $this->csvcolumns(), array('header_rows' => 1));
  }

  function csvcolumns() {

    $columns[0] = array('title', 'Title');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    $columns[2] = array('sku', 'SKU');
    $columns[6] = array('commerce_price', 'Price');
    return $columns;
  }

}


1		<?php
2
3		/**
4		* @file
5		* Migrations for Commerce Product Nodes.
6		*/
7
8		class DFSMEDCommerceNodes extends DemoFrameworkBaseCommerceNodes {
9		public function __construct($arguments) {
10		parent::__construct($arguments);
11		$this->description = t('Import Commerce Product nodes.');
12		$this->map = new MigrateSQLMap($this->machineName,
13		array(
14		'sku' => array(
15		'type' => 'varchar',
16		'length' => 32,
17		'not null' => TRUE,
18		),
19		),
20		MigrateDestinationNode::getKeySchema()
21		);
22		$this->dependencies = array('DFSMEDProducts');
23		$import_path = drupal_get_path('module', 'dfs_med') . '/import/';
24		$this->source = new MigrateSourceCSV($import_path . 'dfs_med.nodes.commerce.csv', $this->csvcolumns(), array('header_rows' => 1));
25		$this->destination = new MigrateDestinationNode('commerce');
26		// Created
27		$this->addFieldMapping('created', 'created')->defaultValue(strtotime("now"));
28		// Brand
29		$this->addFieldMapping('field_brand', 'brand')->sourceMigration('DFSMEDBrandNodes');
30		// Commerce
31		$this->addFieldMapping('field_product', 'skus');
32		// Feature Image
33		$this->addFieldMapping('field_product_image', 'image');
34		$this->addFieldMapping('field_product_image:file_replace')->defaultValue(FILE_EXISTS_REPLACE);
35		$this->addFieldMapping('field_product_image:source_dir')->defaultValue($import_path . 'images');
36		$this->addFieldMapping('field_product_image:destination_file', 'filename');
37		// Booleans
38		$this->addfieldmapping('field_featured', 'featured');
39		$this->addfieldmapping('field_bestseller', 'bestseller');
40		// Persona
41		$this->addFieldMapping('field_persona', 'persona');
42		// Site Section
43		$this->addFieldMapping('field_site_section', 'site_section')->defaultValue("Commerce");
44		}
45
46		function csvcolumns() {
		0 ignored issues – show Best Practice introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
47		$columns[0] = array('title', 'Title');
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report `$columns` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$columns = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
48		$columns[1] = array('brand', 'Brand');
49		$columns[2] = array('sku', 'SKU');
50		$columns[3] = array('image', 'Image');
51		$columns[4] = array('featured', 'Featured');
52		$columns[5] = array('bestseller', 'Bestseller');
53		$columns[7] = array('persona', 'Persona');
54		return $columns;
55		}
56
57	View Code Duplication	function prepareRow($row) {
		0 ignored issues – show Duplication introduced 2016-04-04 18:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Best Practice introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
58		$products = array();
59		foreach (explode(', ', $row->sku) as $sku) {
60		$product = commerce_product_load_by_sku($sku);
61		$products[] = $product->product_id;
62		}
63		$row->skus = $products;
64		}
65
66		}
67
68		class DFSMEDProducts extends DemoFrameworkBaseProducts {
69		public function __construct($arguments) {
70		parent::__construct($arguments);
71		$this->description = t('Import Commerce products.');
72		// Create a map object for tracking the relationships between source rows
73		$this->map = new MigrateSQLMap($this->machineName,
74		array(
75		'sku' => array(
76		'type' => 'varchar',
77		'length' => 32,
78		'not null' => TRUE,
79		),
80		),
81		MigrateDestinationEntityAPI::getKeySchema('commerce_product', 'product')
82		);
83		$this->destination = new MigrateDestinationEntityAPI('commerce_product', 'product');
84		// Define a default import path.
85		$import_path = drupal_get_path('module', 'dfs_med') . '/import/';
86		// Create a MigrateSource object.
87		$this->source = new MigrateSourceCSV($import_path . 'dfs_med.nodes.commerce.csv', $this->csvcolumns(), array('header_rows' => 1));
88		}
89
90	View Code Duplication	function csvcolumns() {
		0 ignored issues – show Duplication introduced 2016-04-04 18:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Best Practice introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
91		$columns[0] = array('title', 'Title');
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-20 16:22 UTC by Report Bug Copy Issue Report `$columns` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$columns = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
92		$columns[2] = array('sku', 'SKU');
93		$columns[6] = array('commerce_price', 'Price');
94		return $columns;
95		}
96
97		}
98

acquia / df

GitHub Access Token became invalid

Push — 7.x-1.x ( 34e25a...94dab8 )

DFSMEDProducts::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like