DemoFrameworkBaseCommerceNodes

Complexity

Total Complexity

4

Size/Duplication

Total Lines	47
Duplicated Lines	29.79 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	27	1
A	csvcolumns()	6	6	1
A	prepareRow()	8	8	2

<?php

/**
 * @file
 *  Migrations for Commerce Nodes with Product References.
 */

class DemoFrameworkBaseCommerceNodes extends LightningModerationNodes {

  public function __construct($arguments) {
    parent::__construct($arguments);
    $this->description = t('Import commerce product nodes.');

    // Create a map object for tracking the relationships between source rows
    $this->map = new MigrateSQLMap($this->machineName,
      array(
        'title' => array(
          'type' => 'varchar',
          'length' => 255,
          'not null' => TRUE,
        ),
      ),
      MigrateDestinationNode::getKeySchema()
    );

    $import_path = drupal_get_path('module', 'df_commerce') . '/import/';
    $this->source = new MigrateSourceCSV($import_path . 'df_commerce.base.nodes.commerce.csv', $this->csvcolumns(), array('header_rows' => 1));

    $this->destination = new MigrateDestinationNode('commerce');

    $this->addFieldMapping('uid', 'uid')->defaultValue(1);

    $this->addFieldMapping('title', 'title');
    $this->addFieldMapping('body', 'description');
    $this->addFieldMapping('field_product', 'skus');
  }

  function csvcolumns() {

This method seems to be duplicated in your project.

It is generally recommended to explicitly declare the visibility for methods.

    $columns[0] = array('title', 'Title');

$columns was never initialized. Although not strictly required by PHP, it is generally a good practice to add $columns = array(); before regardless.

    $columns[1] = array('description', 'Description');
    $columns[2] = array('sku', 'SKU');
    return $columns;
  }

  function prepareRow($row) {

This method seems to be duplicated in your project.

It is generally recommended to explicitly declare the visibility for methods.

    $products = array();
    foreach (explode(', ', $row->sku) as $sku) {
      $product = commerce_product_load_by_sku($sku);
      $products[] = $product->product_id;
    }
    $row->skus = $products;
  }

}