DFSMEDEditorialComments

Complexity

Total Complexity

2

Size/Duplication

Total Lines	34
Duplicated Lines	61.76 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	2
Bugs	0	Features	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	21	21	1
A	csvcolumns()	0	8	1

<?php

/**
 * @file
 *  Migrations for Editorial Nodes.
 */

class DFSMEDEditorialNodes extends DemoFrameworkBaseNodesUUID {
  public function __construct($arguments) {
    parent::__construct($arguments);
    $this->description = t('Import nodes.');
    $this->map = new MigrateSQLMap($this->machineName,
      array(
        'uuid' => array(
          'type' => 'char',
          'length' => 36,
          'not null' => FALSE,
        ),
      ),
      MigrateDestinationNode::getKeySchema()
    );
    $import_path = drupal_get_path('module', 'dfs_med') . '/import/';
    // Create a MigrateSource object.
    $this->source = new MigrateSourceCSV($import_path . 'dfs_med.nodes.article.csv', $this->csvcolumns(), array('header_rows' => 1));
    $this->destination = new MigrateDestinationNode('article');
    // Override body:format
    $this->addFieldMapping('body:format')->defaultValue('full_html');
    // Created
    $this->addFieldMapping('created', 'created')->defaultValue(strtotime("now"));
    // Image
    $this->addFieldMapping('field_image', 'image');
    $this->addFieldMapping('field_image:file_replace')->defaultValue(FILE_EXISTS_REPLACE);
    $this->addFieldMapping('field_image:source_dir')->defaultValue($import_path . 'images');
    $this->addFieldMapping('field_image:destination_file', 'filename');
    // Headlines
    $this->addfieldmapping('field_headline', 'headlines');
    // Persona
    $this->addFieldMapping('field_persona', 'persona');
    // Site Section
    $this->addFieldMapping('field_site_section', 'site_section')->defaultValue("Content");
}

  function csvcolumns() {

It is generally recommended to explicitly declare the visibility for methods.

    $columns[0] = array('uuid', 'UUID');

$columns was never initialized. Although not strictly required by PHP, it is generally a good practice to add $columns = array(); before regardless.

    $columns[1] = array('title', 'Title');
    $columns[2] = array('image', 'Image');
    $columns[3] = array('body', 'Body');
    $columns[4] = array('headlines', 'Headlines');
    $columns[5] = array('persona', 'Persona');
    return $columns;
  }

  public function prepareRow($row) {
    $row->headlines = explode(", ", $row->headlines);
    return TRUE;
  }

}

class DFSMEDEditorialComments extends ImportBaseComments {

  public function __construct($arguments) {

This method seems to be duplicated in your project.

    parent::__construct($arguments);
    $this->description = t('Import comments.');
    // Create a map object for tracking the relationships between source rows
    $this->map = new MigrateSQLMap($this->machineName,
      array(
        'subject' => array(
          'type' => 'varchar',
          'length' => 255,
          'not null' => TRUE,
        ),
      ),
      MigrateDestinationComment::getKeySchema()
    );
    $import_path = drupal_get_path('module', 'dfs_med') . '/import/';
    $this->source = new MigrateSourceCSV($import_path . 'dfs_med.comments.article.csv', $this->csvcolumns(), array('header_rows' => 1));
    $this->destination = new MigrateDestinationComment('comment_node_article');
    $this->addFieldMapping('nid', 'node')->sourceMigration('DFSMEDEditorialNodes');
    $this->addFieldMapping('uid', 'author')->sourceMigration('DFSMEDUsers');
    $this->addFieldMapping('created', 'created');
  }

  function csvcolumns() {

It is generally recommended to explicitly declare the visibility for methods.

    $columns[0] = array('subject', 'Subject');

$columns was never initialized. Although not strictly required by PHP, it is generally a good practice to add $columns = array(); before regardless.

    $columns[1] = array('node', 'Node');
    $columns[2] = array('author', 'Author');
    $columns[3] = array('body', 'Body');
    $columns[4] = array('created', 'Created');
    return $columns;
  }

}