acquia / df

modules/df/df_tools/df_tools_moderation/src/EventSubscriber/LatestCheckSubscriber.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\EventDispatcher\Event;
-use Symfony\Component\HttpKernel\Event\KernelEvent;
 use Symfony\Component\HttpKernel\KernelEvents;
 use Symfony\Component\HttpKernel\Event\GetResponseEvent;
 use Drupal\Core\Cache\CacheTagsInvalidator;

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
     if ($node = $event->getRequest()->get('node')) {
       if (\Drupal::currentUser()->hasPermission('view latest version')) {
         $theme = $this->themeManager->getActiveTheme()->getName();
-        $tag = 'config:block.block.' . $theme . '_local_actions';
+        $tag = 'config:block.block.'.$theme.'_local_actions';
         $this->cacheTagsInvalidator->invalidateTags([$tag]);
       }
     }

modules/df/df_tools/df_tools_moderation/src/Routing/RouteSubscriber.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
    * {@inheritdoc}
    */
   public static function getSubscribedEvents() {
-    $events[RoutingEvents::ALTER] = ['onAlterRoutes',-9999];  // negative Values means "late"
+    $events[RoutingEvents::ALTER] = ['onAlterRoutes', -9999]; // negative Values means "late"
     return $events;
   }
 

modules/df/df_tools/df_tools_map/df_tools_map.views.inc

Spacing +3 added lines, -3 removed lines

@@ -10,13 +10,13 @@
   foreach ($geofield_map as $entity_type_id => $fields) {
     foreach ($fields as $field_name => $info) {
       $args = array('@field_name' => $field_name);
-      $data_key = $entity_type_id . '__' . $field_name;
+      $data_key = $entity_type_id.'__'.$field_name;
 
       $field_coordinates_table_data = $data[$data_key][$field_name];
-      $data[$data_key][$data_key . '_simple_proximity'] = [
+      $data[$data_key][$data_key.'_simple_proximity'] = [
         'group' => 'Content',
         'title' => t('Simple Proximity (@field_name)', $args),
-        'title short' => $field_coordinates_table_data['title short'] . t(' Simple Proximity'),
+        'title short' => $field_coordinates_table_data['title short'].t(' Simple Proximity'),
         'help' => $field_coordinates_table_data['help'],
         'real field' => $field_name,
         'filter' => [

modules/df/df_tools/df_tools_map/src/Plugin/views/filter/SimpleProximity.php

Spacing +11 added lines, -11 removed lines

@@ -56,9 +56,9 @@ 
     // Don't show this element in the context of an admin menu.
     if (!isset($form['admin_label'])) {
       $form['value']['#suffix'] =
-        '<a class="simple-proximity-location-button button" title="' . $this->t('Use your current location') . '">' .
-        '  <i class="fa fa-map-marker" aria-hidden="true"></i>' .
-        '</a>' . $form['value']['#suffix'];
+        '<a class="simple-proximity-location-button button" title="'.$this->t('Use your current location').'">'.
+        '  <i class="fa fa-map-marker" aria-hidden="true"></i>'.
+        '</a>'.$form['value']['#suffix'];
       $form['value']['#attached'] = ['library' => ['df_tools_map/main']];
     }
   }
@@ -109,15 +109,15 @@ 
 
     // Geocode the location if it's present.
     if (!empty($location)) {
-      if ($collection = \Drupal::service('geocoder')->geocode($location,['googlemaps'])) {
+      if ($collection = \Drupal::service('geocoder')->geocode($location, ['googlemaps'])) {
         $coordinates = $collection->first()->getCoordinates();
 
         // Generate a distance formula programatically.
         $haversine_options = [
           'origin_latitude' => $coordinates->getLatitude(),
           'origin_longitude' => $coordinates->getLongitude(),
-          'destination_latitude' => $this->table . '.' . $this->realField . '_lat',
-          'destination_longitude' => $this->table . '.' . $this->realField . '_lon',
+          'destination_latitude' => $this->table.'.'.$this->realField.'_lat',
+          'destination_longitude' => $this->table.'.'.$this->realField.'_lon',
           'earth_radius' => GEOFIELD_KILOMETERS,
         ];
 
@@ -125,13 +125,13 @@ 
 
         /** @var \Drupal\views\Plugin\views\query\Sql $query */
         $query = $this->query;
-        $query->addOrderBy(NULL, $formula, 'ASC', $this->table . '_simple_proximity');
+        $query->addOrderBy(NULL, $formula, 'ASC', $this->table.'_simple_proximity');
 
         // Add a where expression if a distance is used.
         if ($this->options['expose']['distance']) {
           $distance = $this->options['expose']['distance'];
-          $placeholder = $query->placeholder($this->table . '_simple_proximity');
-          $query->addWhereExpression(0, '(' . $formula . ' <= ' . $placeholder . ')', [$placeholder => $distance]);
+          $placeholder = $query->placeholder($this->table.'_simple_proximity');
+          $query->addWhereExpression(0, '('.$formula.' <= '.$placeholder.')', [$placeholder => $distance]);
         }
       }
     }
@@ -149,10 +149,10 @@ 
 
     foreach ($options as $key => $option) {
       if (is_numeric($option)) {
-        $formula = str_replace(':' . $key, $option, $formula);
+        $formula = str_replace(':'.$key, $option, $formula);
       }
       else {
-        $formula = str_replace(':' . $key, db_escape_field($option), $formula);
+        $formula = str_replace(':'.$key, db_escape_field($option), $formula);
       }
     }
 

Braces +2 added lines, -4 removed lines

@@ -102,8 +102,7 @@ 
     $this->ensureMyTable();
     if (is_array($this->value)) {
       $location = $this->value[0];
-    }
-    else {
+    } else {
       $location = $this->value;
     }
 
@@ -150,8 +149,7 @@ 
     foreach ($options as $key => $option) {
       if (is_numeric($option)) {
         $formula = str_replace(':' . $key, $option, $formula);
-      }
-      else {
+      } else {
         $formula = str_replace(':' . $key, db_escape_field($option), $formula);
       }
     }

Doc Comments +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
    *
    * @param $options
    *
-   * @return mixed|string
+   * @return string
    */
   protected function haversine($options) {
     $formula = '( :earth_radius * ACOS( COS( RADIANS(:origin_latitude) ) * COS( RADIANS(:destination_latitude) ) * COS( RADIANS(:destination_longitude) - RADIANS(:origin_longitude) ) + SIN( RADIANS(:origin_latitude) ) * SIN( RADIANS(:destination_latitude) ) ) )';

modules/df/df_tools/df_tools_map/src/Plugin/migrate/source/MapBlock.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
   public function prepareRow(Row $row) {
     // Prefix the state per the normal Address schema.
     if ($state = $row->getSourceProperty('Address State')) {
-      $row->setSourceProperty('Address State', 'US-' . $state);
+      $row->setSourceProperty('Address State', 'US-'.$state);
     }
 
     // Use a cached geolocation if possible.
@@ -34,7 +34,7 @@ 
       $zip = $row->getSourceProperty('Address Zip');
 
       if ($address && $city && $zip && $state) {
-        $address2 = $address2 ? $address2 . "\n" : '';
+        $address2 = $address2 ? $address2."\n" : '';
         $address_string = "$address\n$address2$city, $state $zip\nUS";
         if ($collection = \Drupal::service('geocoder')->geocode($address_string, ['googlemaps'])) {
           // Set our value in a similar way to Geofield's LatLon Widget.

Braces +1 added lines, -2 removed lines

@@ -25,8 +25,7 @@
       list($lat, $lon) = explode(',', $geolocation);
       $point = [$lon, $lat];
       $row->setSourceProperty('Geofield', \Drupal::service('geofield.wkt_generator')->WktBuildPoint($point));
-    }
-    else {
+    } else {
       // Manually geocode from source information.
       $address = $row->getSourceProperty('Address Line 1');
       $address2 = $row->getSourceProperty('Address Line 2');

modules/df/df_tools/df_tools_frontend/df_tools_frontend.module

Spacing +1 added lines, -1 removed lines

@@ -6,6 +6,6 @@
 function df_tools_frontend_library_info_alter(&$libraries, $extension) {
   if ($extension == 'image') {
     $path = drupal_get_path('module', 'df_tools_frontend');
-    $libraries['quickedit.inPlaceEditor.image']['js']['/' . $path . '/js/quickedit_image_browser.js'] = [];
+    $libraries['quickedit.inPlaceEditor.image']['js']['/'.$path.'/js/quickedit_image_browser.js'] = [];
   }
 }

modules/df/df_tools/df_tools_frontend/src/Controller/QuickEditImageBrowserController.php

Braces +2 added lines, -4 removed lines

@@ -90,8 +90,7 @@ 
       $entity_view_mode_ids = array_keys($this->entityManager()->getViewModes($entity->getEntityTypeId()));
       if (in_array($view_mode_id, $entity_view_mode_ids)) {
         $output = $entity->$field_name->view($view_mode_id);
-      }
-      else {
+      } else {
         // Each part of a custom (non-Entity Display) view mode ID is separated
         // by a dash; the first part must be the module name.
         $mode_id_parts = explode('-', $view_mode_id, 2);
@@ -108,8 +107,7 @@ 
         'html' => $this->renderer->renderRoot($output),
       ];
       return new JsonResponse($data);
-    }
-    else {
+    } else {
       return new JsonResponse(['main_error' => $this->t('File does not exist.')]);
     }
   }

modules/df/df_tools/df_tools_migration/df_tools_migration.drush.inc

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
   if ($migration != null) {
     $definition = $migration->getPluginDefinition();
     $dump = Yaml::dump($definition);
-    $file_url = $destination . $migration->id() . '.yml';
+    $file_url = $destination.$migration->id().'.yml';
     $message = t('Export migration @name?', ['@name' => $name]);
     if (drush_confirm($message) && $data = file_save_data($dump, $file_url)) {
       drush_print(t('File saved: @file', ['@file' => $data->getFileUri()]));

modules/df/df_tools/df_tools_image/df_tools_image.module

Braces +1 added lines, -2 removed lines

@@ -75,8 +75,7 @@
   $dir = rtrim($dir, '/');
   if ($dir == 'public') {
     $file_pattern = "[^\/]*"; // Finds anything that does not contain "/", should be fine.
-  }
-  else {
+  } else {
     $file_pattern = $dir ? $dir . ".+" : ".+";
   }
 

Spacing +6 added lines, -6 removed lines

@@ -55,14 +55,14 @@ 
     $file_pattern = "[^\/]*"; // Finds anything that does not contain "/", should be fine.
   }
   else {
-    $file_pattern = $dir ? $dir . ".+" : ".+";
+    $file_pattern = $dir ? $dir.".+" : ".+";
   }
 
-  $regex = "^public:\/\/(" . $file_pattern . ")\.(" . implode($extensions, '|') . ")$";
+  $regex = "^public:\/\/(".$file_pattern.")\.(".implode($extensions, '|').")$";
 
   // Query the database for files that match this pattern.
   $query = db_select('file_managed', 'f')
-      ->condition('filemime', $mimetypes , 'IN')
+      ->condition('filemime', $mimetypes, 'IN')
       ->condition('uri', $regex, 'REGEXP');
   $total_count = $query->countQuery()->execute()->fetchField();
 
@@ -81,12 +81,12 @@ 
 
   foreach (\Drupal\image\Entity\ImageStyle::loadMultiple() as $name => $style) {
     if (!empty($excludes) && in_array($style->getName(), $excludes)) {
-      $operations[] = array('drush_log', array('Excluding ' . $name, 'success'));
+      $operations[] = array('drush_log', array('Excluding '.$name, 'success'));
       continue;
     }
 
     if (empty($includes[0]) || in_array($style->getName(), $includes)) {
-      $operations[] = array('drush_log', array('Processing ' . $name, 'success'));
+      $operations[] = array('drush_log', array('Processing '.$name, 'success'));
       $count = 1;
       $last_progress = 0;
       foreach ($files as $file) {
@@ -99,7 +99,7 @@ 
         if (($progress % 25 === 0 || $progress % 7 === 0) && $progress != $last_progress) {
           // If we're in the command line, print the percentage, otherwise hide it
           if (PHP_SAPI === 'cli') {
-            $operations[] = array('drush_print', array('...' . $progress . '%', 0, NULL, ($progress == 100)));
+            $operations[] = array('drush_print', array('...'.$progress.'%', 0, NULL, ($progress == 100)));
           }
         $last_progress = $progress;
         }