Drupal\df_tools_migration\Plugin\migrate\source\AuthorMigrationTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	setUidProperty()	0	14	3

<?php

namespace Drupal\df_tools_migration\Plugin\migrate\source;

use Drupal\migrate\Row;

/**
 * Provides shared methods for processing image migrations in Source Plugins.
 */
trait AuthorMigrationTrait {

  /**
   * Configuration information passed into the plugin.
   *
   * @var array
   */
  protected $configuration;

  /**
   * The entity migration object.
   *
   * @var \Drupal\migrate\Entity\MigrationInterface

The type Drupal\migrate\Entity\MigrationInterface was not found. Maybe you did not declare it correctly or list all dependencies?

   */
  protected $migration;

  /**
   * Sets the UID property for the migration target, optionally
   * accepting a null UID and role-based lookup with
   * random author assignment.
   *
   * @param \Drupal\migrate\Row $row
   * @param null $uid

Are you sure the doc-type for parameter $uid is correct as it would always require null to be passed?

   * @param string $roles
   */
  protected function setUidProperty(Row $row, $uid = NULL, $roles = 'administrator') {
    if ($uid == NULL) {

The condition $uid == NULL is always true.

      $request_users = \Drupal::entityTypeManager()
        ->getStorage('user')
        ->loadByProperties([
          'roles' => $roles,
        ]);

      if ($request_users) {

The expression $request_users of type Drupal\Core\Entity\EntityInterface[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        $uid = array_rand($request_users);
      }
    }

    $row->setSourceProperty('UID', $uid);
  }

}