Completed
Push — 7.x-3.x ( adb615...edd9a9 )
by Devin
11:15 queued 07:56
created
themes/commons/commons_origins/template.php 1 patch
Braces   +18 added lines, -36 removed lines patch added patch discarded remove patch
@@ -38,8 +38,7 @@  discard block
 block discarded – undo
38 38
       foreach($words as &$word) {
39 39
         if(is_numeric($word)) {
40 40
           $word = '<span class="notification-count">' . $word . '</span>';
41
-        }
42
-        else {
41
+        } else {
43 42
           $word = '<span class="notification-label element-invisible">' . $word . '</span>';
44 43
         }
45 44
       }
@@ -321,8 +320,7 @@  discard block
 block discarded – undo
321 320
           if ($name != 'comment_forbidden' && $name != 'answer-add' && !is_string($link['attributes']['class'])) {
322 321
             $link['attributes']['class'][] = 'action-item-small';
323 322
             $link['attributes']['class'][] = 'action-item-inline';
324
-          }
325
-          elseif ($name != 'comment_forbidden' && $name != 'answer-add') {
323
+          } elseif ($name != 'comment_forbidden' && $name != 'answer-add') {
326 324
             $link['attributes']['class'] .= ' action-item-small action-item-inline';
327 325
           }
328 326
         }
@@ -343,8 +341,7 @@  discard block
 block discarded – undo
343 341
     foreach ($chunks as &$chunk) {
344 342
       if ($chunk == $variables['comment_count']) {
345 343
         $chunk = '<span class="action-item-small-append">' . $variables['comment_count'] . '</span>';
346
-      }
347
-      else {
344
+      } else {
348 345
         $chunk = '<span class="element-invisible">' . $chunk . '</span>';
349 346
       }
350 347
     }
@@ -473,8 +470,7 @@  discard block
 block discarded – undo
473 470
     // Style the flag links like buttons.
474 471
     if ($variables['last_action'] == 'flagged') {
475 472
       $variables['flag_classes_array'][] = 'action-item-small-active';
476
-    }
477
-    else {
473
+    } else {
478 474
       $variables['flag_classes_array'][] = 'action-item-small';
479 475
     }
480 476
     $variables['flag_classes'] = implode(' ', $variables['flag_classes_array']);
@@ -612,8 +608,7 @@  discard block
 block discarded – undo
612 608
   foreach ($view->result as $id => $result) {
613 609
     if (isset($result->node_type)) {
614 610
       $variables['classes_array'][$id] .= ' ' . drupal_html_class('row-type-' . $result->node_type);
615
-    }
616
-    else if (($view->name == 'commons_events_upcoming' && $view->override_path != 'events') || $view->name == 'commons_events_user_upcoming_events') {
611
+    } else if (($view->name == 'commons_events_upcoming' && $view->override_path != 'events') || $view->name == 'commons_events_user_upcoming_events') {
617 612
       $variables['classes_array'][$id] .= ' ' . drupal_html_class('row-type-event');
618 613
     }
619 614
   }
@@ -651,8 +646,7 @@  discard block
 block discarded – undo
651 646
   // Roll the classes into the attributes.
652 647
   if (empty($variables['attributes_array']['class'])) {
653 648
     $variables['attributes_array']['class'] = $variables['classes_array'];
654
-  }
655
-  else {
649
+  } else {
656 650
     $variables['attributes_array']['class'] = array_merge($variables['attributes_array']['class'], $variables['classes_array']);
657 651
   }
658 652
 
@@ -834,8 +828,7 @@  discard block
 block discarded – undo
834 828
     return '<span class="' . $classes . '" id="rate-button-' . $id . '">' .
835 829
       '<span class="element-invisible">' . check_plain($text) . '</span>' .
836 830
       '</span>';
837
-  }
838
-  else {
831
+  } else {
839 832
     return '<a class="' . $classes . '" id="rate-button-' . $id . '" rel="nofollow" href="' . htmlentities($href) . '" title="' . check_plain($text) . '">' .
840 833
       '<span class="element-invisible">' . check_plain($text) . '</span>' .
841 834
       '</a>';
@@ -851,8 +844,7 @@  discard block
 block discarded – undo
851 844
   if (is_array($form['#theme'])) {
852 845
     $hooks = array('form_content');
853 846
     $form['#theme'] = array_merge($form['#theme'], $hooks);
854
-  }
855
-  else {
847
+  } else {
856 848
     $form['#theme'] = array(
857 849
       $form['#theme'],
858 850
       'form_content',
@@ -1000,8 +992,7 @@  discard block
 block discarded – undo
1000 992
         if (isset($link['href'])) {
1001 993
           // Pass in $link as $options, they share the same keys.
1002 994
           $output .= l($link['title'], $link['href'], $link);
1003
-        }
1004
-        elseif (!empty($link['title'])) {
995
+        } elseif (!empty($link['title'])) {
1005 996
           // Some links are actually not links, but we wrap these in <span> for adding title and class attributes.
1006 997
           if (empty($link['html'])) {
1007 998
             $link['title'] = check_plain($link['title']);
@@ -1098,8 +1089,7 @@  discard block
 block discarded – undo
1098 1089
         }
1099 1090
         if (isset($item['#href']) && strpos($item['#href'], 'messages')) {
1100 1091
           $item['#options']['attributes']['class'][] = 'message-contact';
1101
-        }
1102
-        elseif (isset($item['#href'])) {
1092
+        } elseif (isset($item['#href'])) {
1103 1093
           $item['#options']['attributes']['class'][] = 'trusted-status-request';
1104 1094
         }
1105 1095
       }
@@ -1118,8 +1108,7 @@  discard block
 block discarded – undo
1118 1108
 
1119 1109
   if (!isset($element['#value'])) {
1120 1110
     return '<' . $element['#tag'] . $attributes . " />\n";
1121
-  }
1122
-  else {
1111
+  } else {
1123 1112
     $output = '<' . $element['#tag'] . $attributes . '>';
1124 1113
     if (isset($element['#value_prefix'])) {
1125 1114
       $output .= $element['#value_prefix'];
@@ -1152,8 +1141,7 @@  discard block
 block discarded – undo
1152 1141
     if (isset($item['#type']) && $item['#type'] == 'link') {
1153 1142
       if (strpos($item['#href'], '/subscribe')) {
1154 1143
         $item['#options']['attributes']['class'][] = 'action-item-primary';
1155
-      }
1156
-      else {
1144
+      } else {
1157 1145
         $item['#options']['attributes']['class'][] = 'action-item';
1158 1146
       }
1159 1147
     }
@@ -1181,8 +1169,7 @@  discard block
 block discarded – undo
1181 1169
     // validating that the administrative area has been populated.
1182 1170
     if (!empty($address['#address']['administrative_area'])) {
1183 1171
       _commons_origins_format_address($address);
1184
-    }
1185
-    else {
1172
+    } else {
1186 1173
       // Deny access to incomplete addresses.
1187 1174
       $address['#access'] = FALSE;
1188 1175
     }
@@ -1220,8 +1207,7 @@  discard block
 block discarded – undo
1220 1207
         // If an address is incomplete, remove it and tell the system a
1221 1208
         // rebuild is needed.
1222 1209
         unset($variables['row']->field_field_address[$key]);
1223
-      }
1224
-      else {
1210
+      } else {
1225 1211
         _commons_origins_format_address($address['rendered']);
1226 1212
       }
1227 1213
     }
@@ -1294,8 +1280,7 @@  discard block
 block discarded – undo
1294 1280
   if (module_exists('timeago') && variable_get('timeago_node', 1)) {
1295 1281
     $variables['date'] = timeago_format_date($node->created, $variables['date']);
1296 1282
     $use_timeago_date_format = TRUE;
1297
-  }
1298
-  else {
1283
+  } else {
1299 1284
     $use_timeago_date_format = FALSE;
1300 1285
   }
1301 1286
 
@@ -1318,16 +1303,13 @@  discard block
 block discarded – undo
1318 1303
       $placeholders['!group'] = l($wrapper->{OG_AUDIENCE_FIELD}->get(0)->label(), 'node/' . $wrapper->{OG_AUDIENCE_FIELD}->get(0)->getIdentifier());
1319 1304
       if ($use_timeago_date_format == TRUE) {
1320 1305
         $variables['submitted'] = t('!type created !date in the !group group by !user', $placeholders);
1321
-      }
1322
-      else {
1306
+      } else {
1323 1307
         $variables['submitted'] = t('!type created @interval ago in the !group group by !user', $placeholders);
1324 1308
       }
1325
-    }
1326
-    else {
1309
+    } else {
1327 1310
       if ($use_timeago_date_format == TRUE) {
1328 1311
         $variables['submitted'] = t('!type created !date by !user', $placeholders);
1329
-      }
1330
-      else {
1312
+      } else {
1331 1313
         $variables['submitted'] = t('!type created @interval ago by !user', $placeholders);
1332 1314
       }
1333 1315
     }
Please login to merge, or discard this patch.
commons_bw/includes/views/handlers/commons_bw_handler_node_partial_form.inc 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,8 +33,7 @@
 block discarded – undo
33 33
     $permission = "create $bundle content";
34 34
     if ($group_id && !og_user_access('node', $group_id, $permission)) {
35 35
       return;
36
-    }
37
-    elseif (!user_access($permission)) {
36
+    } elseif (!user_access($permission)) {
38 37
       return;
39 38
     }
40 39
 
Please login to merge, or discard this patch.
modules/commons/commons_bw/commons_bw.module 1 patch
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -118,11 +118,9 @@  discard block
 block discarded – undo
118 118
 
119 119
   if(!empty($form_state['field'][$field_name][LANGUAGE_NONE]['instance']['display_in_partial_form'])) {
120 120
     $display_default = $form_state['field'][$field_name][LANGUAGE_NONE]['instance']['display_in_partial_form'];
121
-  }
122
-  else if (isset($form_state['build_info']['args'][0]['display_in_partial_form'])) {
121
+  } else if (isset($form_state['build_info']['args'][0]['display_in_partial_form'])) {
123 122
     $display_default = $form_state['build_info']['args'][0]['display_in_partial_form'];
124
-  }
125
-  else {
123
+  } else {
126 124
     $display_default = FALSE;
127 125
   }
128 126
 
@@ -174,13 +172,11 @@  discard block
 block discarded – undo
174 172
   if (module_exists('locale')) {
175 173
     if (locale_multilingual_node_type($node->type)) {
176 174
       $node->language = $language->language;
177
-    }
178
-    else {
175
+    } else {
179 176
       $default = language_default();
180 177
       $node->language = $default->language;
181 178
     }
182
-  }
183
-  else {
179
+  } else {
184 180
     $node->language = LANGUAGE_NONE;
185 181
   }
186 182
 
Please login to merge, or discard this patch.
modules/commons/commons_search/commons_search.module 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -44,8 +44,7 @@  discard block
 block discarded – undo
44 44
       // We're using faceted core search, so change Site search key to reflect
45 45
       // the change of search engines.
46 46
       $site_key = 'o-search_facetapi';
47
-    }
48
-    else {
47
+    } else {
49 48
       if (module_exists('apachesolr_search')) {
50 49
         // Are we using Apache Solr? If so change the Site search key to reflect
51 50
         // the change of search engines.
@@ -106,14 +105,12 @@  discard block
 block discarded – undo
106 105
       // specified group.
107 106
       $qm = (strpos($form_state['redirect'], '?') !== FALSE ? '' : '?');
108 107
       $form_state['redirect'] .= $qm . '&f[1]=sm_og_group_ref:node:' . $form_state['search_group_id'];
109
-    }
110
-    else {
108
+    } else {
111 109
       // Using core search to search within a group doesn't work, so we simply
112 110
       // use a view with exposed search terms to do the searching.
113 111
       drupal_goto('search/group/' . $form_state['search_group_id'], array('query' => array('keys' => $keys)));
114 112
     }
115
-  }
116
-  else {
113
+  } else {
117 114
     if ($form_state['values']['custom_search_types'] == 'c-user') {
118 115
       // Force update the redirect on User search since Custom Search is weird.
119 116
       $keys = check_plain($form_state['values']['search_block_form']);
Please login to merge, or discard this patch.
modules/commons/commons_groups/commons_groups.module 1 patch
Braces   +9 added lines, -18 removed lines patch added patch discarded remove patch
@@ -71,8 +71,7 @@  discard block
 block discarded – undo
71 71
       set, an administrator can dismiss the update notice.") . '</p>';
72 72
     if ($path == 'admin/content/groups/update') {
73 73
       return $message;
74
-    }
75
-    elseif ($arg[0] == 'node' && $arg[2] == 'edit') {
74
+    } elseif ($arg[0] == 'node' && $arg[2] == 'edit') {
76 75
       $node = menu_get_object();
77 76
       if($node->type == 'group' && empty($node->field_og_subscribe_settings)) {
78 77
         return $message;
@@ -178,11 +177,9 @@  discard block
 block discarded – undo
178 177
 
179 178
   if (!empty($permissions['subscribe without approval'])) {
180 179
     $subscribe_type = 'anyone';
181
-  }
182
-  elseif (!empty($permissions['subscribe'])) {
180
+  } elseif (!empty($permissions['subscribe'])) {
183 181
     $subscribe_type = 'approval';
184
-  }
185
-  else {
182
+  } else {
186 183
     $subscribe_type = 'invitation';
187 184
   }
188 185
 
@@ -313,8 +310,7 @@  discard block
 block discarded – undo
313 310
       $topics_text .= '!topic-' . $topic->tid;
314 311
       if ($topic == end($topics)) {
315 312
         $topics_text .= '.';
316
-      }
317
-      else {
313
+      } else {
318 314
         $topics_text .= ', ';
319 315
       }
320 316
       $t_args['!topic-' . $topic->tid] = l(t($topic->name), 'taxonomy/term/' . $topic->tid);
@@ -971,8 +967,7 @@  discard block
 block discarded – undo
971 967
       if (!empty($account->picture->uri)) {
972 968
         $filepath = $account->picture->uri;
973 969
       }
974
-    }
975
-    elseif (variable_get('user_picture_default', '')) {
970
+    } elseif (variable_get('user_picture_default', '')) {
976 971
       $filepath = variable_get('user_picture_default', '');
977 972
     }
978 973
 
@@ -1099,8 +1094,7 @@  discard block
 block discarded – undo
1099 1094
         $links['href'] = "group/$entity_type/$id/unsubscribe";
1100 1095
       }
1101 1096
     }
1102
-  }
1103
-  else {
1097
+  } else {
1104 1098
     // Check if user can subscribe to the field.
1105 1099
     if (empty($settings['field_name']) && $audience_field_name = og_get_best_group_audience_field('user', $account, $entity_type, $bundle)) {
1106 1100
       $settings['field_name'] = $audience_field_name;
@@ -1147,13 +1141,11 @@  discard block
 block discarded – undo
1147 1141
           $links['title'] = t('Join group');
1148 1142
           if ($account->uid) {
1149 1143
             $links['href'] = $url;
1150
-          }
1151
-          else {
1144
+          } else {
1152 1145
             $links['href'] = 'user/login';
1153 1146
             $links['options'] = array('query' => array('destination' => $url));
1154 1147
           }
1155
-        }
1156
-        else {
1148
+        } else {
1157 1149
           $element[0] = array('#markup' => '<div class="subscription-type">' . t('Invite-only group') . '</div>');
1158 1150
           return $element;
1159 1151
         }
@@ -1228,8 +1220,7 @@  discard block
 block discarded – undo
1228 1220
       foreach ($roles as $rid => $rolename) {
1229 1221
         if (in_array($rolename, $details['roles'])) {
1230 1222
           $grant[$rid][] = $perm;
1231
-        }
1232
-        else {
1223
+        } else {
1233 1224
           $revoke[$rid][] = $perm;
1234 1225
         }
1235 1226
       }
Please login to merge, or discard this patch.
modules/commons/commons_media/commons_media.private_files.inc 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,8 +79,7 @@
 block discarded – undo
79 79
   foreach (commons_media_filter_parse_from_fields($entity_type, $entity) as $file_reference) {
80 80
     if (empty($entity_files[$file_reference['fid']])) {
81 81
       $entity_files[$file_reference['fid']] = 1;
82
-    }
83
-    else {
82
+    } else {
84 83
       $entity_files[$file_reference['fid']]++;
85 84
     }
86 85
   }
Please login to merge, or discard this patch.
modules/commons/commons_trusted_contacts/commons_trusted_contacts.module 1 patch
Braces   +7 added lines, -14 removed lines patch added patch discarded remove patch
@@ -360,8 +360,7 @@  discard block
 block discarded – undo
360 360
         // If user is blocked, they should not be able to apply for
361 361
         // membership.
362 362
         return;
363
-      }
364
-      elseif (og_is_member($entity_type, $id, 'user', $account, array(OG_STATE_PENDING))) {
363
+      } elseif (og_is_member($entity_type, $id, 'user', $account, array(OG_STATE_PENDING))) {
365 364
         // If user is pending, they should not be able to apply for
366 365
         // membership.
367 366
         $link = array(
@@ -373,8 +372,7 @@  discard block
 block discarded – undo
373 372
           ),
374 373
         );
375 374
         $element[0][] = $link;
376
-      }
377
-      elseif (!og_is_member($entity_type, $id, 'user', $account, array(OG_STATE_ACTIVE))) {
375
+      } elseif (!og_is_member($entity_type, $id, 'user', $account, array(OG_STATE_ACTIVE))) {
378 376
         // Check if user can subscribe to the field.
379 377
         if (empty($settings['field_name']) && $audience_field_name = og_get_best_group_audience_field('user', $account, $entity_type, $bundle)) {
380 378
           $settings['field_name'] = $audience_field_name;
@@ -423,8 +421,7 @@  discard block
 block discarded – undo
423 421
               array('system', 'jquery.form'),
424 422
             ),
425 423
           );
426
-        }
427
-        else {
424
+        } else {
428 425
           $link = array('#type' => 'link');
429 426
           $link['#href'] = 'user/login';
430 427
           $link['#options'] = array('query' => array('destination' => $url));
@@ -680,8 +677,7 @@  discard block
 block discarded – undo
680 677
     $commands[] = ajax_command_replace('#user-' . $account->uid, trim(theme('html_tag__request_pending', $element)));
681 678
     $page = array('#type' => 'ajax', '#commands' => $commands);
682 679
     ajax_deliver($page);
683
-  }
684
-  else {
680
+  } else {
685 681
     drupal_goto('user/' . $og_membership->gid);
686 682
   }
687 683
 }
@@ -710,8 +706,7 @@  discard block
 block discarded – undo
710 706
     $commands[] = ajax_command_replace(".field-name-group-group a", $new);
711 707
     $page = array('#type' => 'ajax', '#commands' => $commands);
712 708
     ajax_deliver($page);
713
-  }
714
-  else {
709
+  } else {
715 710
     drupal_goto('user/' . $account->uid);
716 711
   }
717 712
 }
@@ -843,8 +838,7 @@  discard block
 block discarded – undo
843 838
         $commands[] = ajax_command_append('#messages', theme('status_messages'));
844 839
         $page = array('#type' => 'ajax', '#commands' => $commands);
845 840
         ajax_deliver($page);
846
-      }
847
-      else {
841
+      } else {
848 842
         drupal_goto();
849 843
       }
850 844
       return FALSE;
@@ -1289,8 +1283,7 @@  discard block
 block discarded – undo
1289 1283
 function commons_trusted_contacts_batch_finished($success, $results, $operations) {
1290 1284
   if ($success) {
1291 1285
     $message = format_plural($results['processed'], t('One user processed.'), t('@count users processed.'));
1292
-  }
1293
-  else {
1286
+  } else {
1294 1287
     $message = t('Error encountered while upgrading users.');
1295 1288
   }
1296 1289
 
Please login to merge, or discard this patch.
commons_events/modules/commons_events_solr/commons_events_solr.module 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -263,8 +263,7 @@
 block discarded – undo
263 263
 
264 264
   if (node_access('create', 'event')) {
265 265
     return t('There are no events. Be the first to <a href="!url">create one</a>!', array('!url' => url('node/add/event')));
266
-  }
267
-  else {
266
+  } else {
268 267
     return t('There are no events. Be the first to create one!');
269 268
   }
270 269
 }
Please login to merge, or discard this patch.
modules/commons/commons_events/includes/commons_events.theme.inc 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,8 +32,7 @@
 block discarded – undo
32 32
     && registration_access('create', $registration, $user, $registration->type)
33 33
     && registration_status('node', $event->nid, TRUE)) {
34 34
     return drupal_get_form('commons_events_attend_event_form_' . $event->nid, $event, $registration, $attendee_count);
35
-  }
36
-  elseif (registration_is_registered($registration, NULL, $user->uid) &&
35
+  } elseif (registration_is_registered($registration, NULL, $user->uid) &&
37 36
     registration_access('delete', $registration, $user, $registration->type)) {
38 37
     $query = new EntityFieldQuery();
39 38
     $query->entityCondition('entity_type', 'registration')
Please login to merge, or discard this patch.