TaskQueue::dequeuedCount() - Code Metrics - Inspection of "Improve architecture" - ackintosh/snidel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 94cacb...6d69f5 )

by Akihito

created 2016-04-24 11:11 UTC

TaskQueue::dequeuedCount() A

↳ Parent: TaskQueue

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php
namespace Ackintosh\Snidel;

use Ackintosh\Snidel\IpcKey;
use Opis\Closure\SerializableClosure;

class TaskQueue
{
    const TASK_MAX_SIZE = 1024;

    private $queuedCount = 0;
    private $dequeuedCount = 0;

    public function __construct($ownerPid)
    {
        $this->ownerPid = $ownerPid;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->ipcKey = new IpcKey($ownerPid, 'snidel_task_' . uniqid((string) mt_rand(1, 100), true));
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->id = msg_get_queue($this->ipcKey->generate());
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param   callable            $callable
     * @param   array               $args
     * @param   string              $tag
     * @return  void
     * @throws  RuntimeException
     */
    public function enqueue($callable, $args = array(), $tag = null)
    {
        $this->queuedCount++;
        if ($this->isClosure($callable)) {
            $serializedCallable = new SerializableClosure($callable);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } else {
            $serializedCallable = serialize($callable);
        }

        $data = array(
            'callable'  => $serializedCallable,
            'args'      => $args,
            'tag'       => $tag,
        );

        if (!msg_send($this->id, 1, serialize($data))) {
            throw new RuntimeException('failed to enqueue task.');
        }
    }

    public function dequeue()
    {
        $this->dequeuedCount++;
        $msgtype = $message = null;
        $success = msg_receive($this->id, 1, $msgtype, self::TASK_MAX_SIZE, $message);

        if (!$success) {
            throw new \RuntimeException('failed to dequeue task');
        }

        $data = unserialize($message);
        if ($this->isClosure($data['callable'])) {
            $data['callable'] = $data['callable']->getClosure();
        } else {
            $data['callable'] = unserialize($data['callable']);
        }
        return $data;
    }

    public function queuedCount()
    {
        return $this->queuedCount;
    }

    public function dequeuedCount()
    {
        return $this->dequeuedCount;
    }

    private function isClosure($callable)
    {
        return is_object($callable) && is_callable($callable);
    }

    public function __destruct()
    {
        if ($this->ipcKey->isOwner(getmypid())) {
            $this->ipcKey->delete();
            return msg_remove_queue($this->id);
        }
    }// @codeCoverageIgnore
}


1			<?php
2			namespace Ackintosh\Snidel;
3
4			use Ackintosh\Snidel\IpcKey;
5			use Opis\Closure\SerializableClosure;
6
7			class TaskQueue
8			{
9			const TASK_MAX_SIZE = 1024;
10
11			private $queuedCount = 0;
12			private $dequeuedCount = 0;
13
14			public function __construct($ownerPid)
15			{
16			$this->ownerPid = $ownerPid;
			0 ignored issues – show Bug introduced 2016-04-24 11:14 UTC by Report Bug Copy Issue Report The property `ownerPid` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17			$this->ipcKey = new IpcKey($ownerPid, 'snidel_task_' . uniqid((string) mt_rand(1, 100), true));
			0 ignored issues – show Bug introduced 2016-04-24 11:14 UTC by Report Bug Copy Issue Report The property `ipcKey` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18			$this->id = msg_get_queue($this->ipcKey->generate());
			0 ignored issues – show Bug introduced 2016-04-24 11:14 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			}
20
21			/**
22			* @param callable $callable
23			* @param array $args
24			* @param string $tag
25			* @return void
26			* @throws RuntimeException
27			*/
28			public function enqueue($callable, $args = array(), $tag = null)
29			{
30			$this->queuedCount++;
31			if ($this->isClosure($callable)) {
32			$serializedCallable = new SerializableClosure($callable);
			0 ignored issues – show Documentation introduced 2016-04-24 11:14 UTC by Report Bug Copy Issue Report `$callable` is of type `callable`, but the function expects a `object<Closure>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			} else {
34			$serializedCallable = serialize($callable);
35			}
36
37			$data = array(
38			'callable' => $serializedCallable,
39			'args' => $args,
40			'tag' => $tag,
41			);
42
43			if (!msg_send($this->id, 1, serialize($data))) {
44			throw new RuntimeException('failed to enqueue task.');
45			}
46			}
47
48			public function dequeue()
49			{
50			$this->dequeuedCount++;
51			$msgtype = $message = null;
52			$success = msg_receive($this->id, 1, $msgtype, self::TASK_MAX_SIZE, $message);
53
54			if (!$success) {
55			throw new \RuntimeException('failed to dequeue task');
56			}
57
58			$data = unserialize($message);
59			if ($this->isClosure($data['callable'])) {
60			$data['callable'] = $data['callable']->getClosure();
61			} else {
62			$data['callable'] = unserialize($data['callable']);
63			}
64			return $data;
65			}
66
67			public function queuedCount()
68			{
69			return $this->queuedCount;
70			}
71
72			public function dequeuedCount()
73			{
74			return $this->dequeuedCount;
75			}
76
77			private function isClosure($callable)
78			{
79			return is_object($callable) && is_callable($callable);
80			}
81
82			public function __destruct()
83			{
84			if ($this->ipcKey->isOwner(getmypid())) {
85			$this->ipcKey->delete();
86			return msg_remove_queue($this->id);
87			}
88			}// @codeCoverageIgnore
89			}
90

ackintosh / snidel

Push — master ( 94cacb...6d69f5 )

TaskQueue::dequeuedCount() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like