Ackintosh\Snidel\Task

Complexity

Total Complexity

11

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	serialize()	0	5	2
A	unserialize()	0	5	2
A	getCallable()	0	4	1
A	getArgs()	0	4	2
A	getTag()	0	4	1
A	isClosure()	0	4	2

<?php
namespace Ackintosh\Snidel;
use Opis\Closure\SerializableClosure;

class Task
{
    /** @var callable */
    private $callable;

    /** @var array */
    private $args;

    /** @var string */
    private $tag;

    /**
     * @param   callable    $callable
     * @param   array       $args
     * @param   string      $string

There is no parameter named $string. Was it maybe removed?

     */
    public function __construct($callable, $args, $tag)
    {
        $this->callable     = $callable;
        $this->args         = $args;
        $this->tag          = $tag;
    }

    /**
     * @return  string
     */
    public function serialize()
    {
        $serializedCallable = $this->isClosure($this->callable) ? new SerializableClosure($this->callable) : serialize($this->callable);

The call to Task::isClosure() has too many arguments starting with $this->callable.

$this->callable is of type callable, but the function expects a object<Closure>.

        return serialize(new self($serializedCallable, $this->args, $this->tag));
    }

    /**
     * @return  \Ackintosh\Snidel\Task
     */
    public function unserialize()
    {
        $unserializedCallable = $this->isClosure($this->callable) ? $this->callable->getClosure() : unserialize($this->callable);

The call to Task::isClosure() has too many arguments starting with $this->callable.

The method getClosure cannot be called on $this->callable (of type callable).

        return new self($unserializedCallable, $this->args, $this->tag);
    }

    /**
     * @return  callable
     */
    public function getCallable()
    {
        return $this->callable;
    }

    /**
     * @return  array
     */
    public function getArgs()
    {
        return is_array($this->args) ? $this->args : array($this->args);
    }

    /**
     * @return  string|null
     */
    public function getTag()
    {
        return $this->tag;
    }

    private function isClosure()
    {
        return is_object($this->callable) && is_callable($this->callable);
    }
}