Acelaya\Website\Feed\Service\BlogFeedConsumer

Complexity

Total Complexity

7

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
B	refreshFeed()	0	24	3
A	processFeed()	0	20	3

<?php
declare(strict_types=1);

namespace Acelaya\Website\Feed\Service;

use Acelaya\Website\Feed\BlogOptions;
use Doctrine\Common\Cache;
use Zend\Feed\Reader\Feed\FeedInterface;
use Zend\Feed\Reader\Http\ClientInterface;
use Zend\Feed\Reader\Reader;

class BlogFeedConsumer implements BlogFeedConsumerInterface
{
    /**
     * @var BlogOptions
     */
    private $blogOptions;
    /**
     * @var Cache\Cache
     */
    private $feedCache;
    /**
     * @var Cache\ClearableCache
     */
    private $viewsCache;

    public function __construct(
        ClientInterface $httpClient,
        Cache\Cache $feedCache,
        Cache\ClearableCache $viewsCache,
        BlogOptions $blogOptions
    ) {
        Reader::setHttpClient($httpClient);
        $this->blogOptions = $blogOptions;
        $this->feedCache = $feedCache;
        $this->viewsCache = $viewsCache;
    }

    public function refreshFeed(): array
    {
        $cacheId = $this->blogOptions->getCacheKey();
        $feed = Reader::import($this->blogOptions->getFeed());
        $feed = $this->processFeed($feed);

It seems like $feed defined by $this->processFeed($feed) on line 43 can also be of type object<Zend\Feed\Reader\Entry\Atom>; however, Acelaya\Website\Feed\Service\BlogFeedConsumer::processFeed() does only seem to accept object<Zend\Feed\Reader\Feed\FeedInterface>, maybe add an additional type check?

        // If no feed has been cached yet, cache current one and return
        if (! $this->feedCache->contains($cacheId)) {
            $this->viewsCache->deleteAll();
            $this->feedCache->save($cacheId, $feed);
            return $feed;
        }

        // Check if the last feed has changed, otherwise, return
        $cachedFeed = $this->feedCache->fetch($cacheId);
        if ($cachedFeed[0]['link'] === $feed[0]['link']) {
            return $feed;
        }

        // If the feed has changed, clear all cached elements so that views are refreshed, and cache feed too
        $this->viewsCache->deleteAll();
        $this->feedCache->save($cacheId, $feed);
        return $feed;
    }

    /**
     * @param FeedInterface $feed
     * @return array
     */
    protected function processFeed(FeedInterface $feed): array
    {
        $data = [];
        $count = 0;

        /** @var FeedInterface $entry */
        foreach ($feed as $entry) {
            if ($count >= $this->blogOptions->getElementsToDisplay()) {
                break;
            }

            $data[] = [
                'title' => $entry->getTitle(),
                'link' => $entry->getLink(),
            ];
            $count += 1;
        }

        return $data;
    }
}