SlimRouterTest::injectRoutes() - Code Metrics - Inspection of "Updated router implementations so that parsing is..." - acelaya/expressive-slim-router - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1595c9...264e47 )

by Alejandro

created 2018-03-19 21:14 UTC

SlimRouterTest::injectRoutes() A

↳ Parent: SlimRouterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	7
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php
namespace AcelayaTest\Expressive\Router;

use Acelaya\Expressive\Router\SlimRouter;
use PHPUnit\Framework\TestCase;
use Prophecy\Prophecy\ObjectProphecy;
use Psr\Http\Server\MiddlewareInterface;
use Slim\Router;
use Zend\Diactoros\ServerRequest;
use Zend\Diactoros\ServerRequestFactory;
use Zend\Expressive\Router\Route;

class SlimRouterTest extends TestCase
{
    /**
     * @var SlimRouter
     */
    protected $router;
    /**
     * @var Router
     */
    protected $slimRouter;
    /**
     * @var ObjectProphecy
     */
    protected $middleware;

    public function setUp()
    {
        new SlimRouter();
        $this->slimRouter = new Router();
        $this->router = new SlimRouter($this->slimRouter);
        $this->middleware = $this->prophesize(MiddlewareInterface::class);
    }

    public function testAddRoute()
    {
        $middleware = $this->middleware->reveal();
        $this->router->addRoute(new Route('/foo(/:bar)', $middleware, ['GET', 'POST'], 'home'));
        $this->injectRoutes();

        $this->assertCount(1, $this->slimRouter->getNamedRoutes());

        /** @var \Slim\Route $route */
        $route = $this->slimRouter->getMatchedRoutes('GET', '/foo/baz')[0];
        $this->assertEquals('/foo(/:bar)', $route->getPattern());
        $this->assertEquals('home', $route->getName());
        $this->assertEquals($middleware, $route->getParams()['middleware']);
    }

    public function testAddRouteWithOptions()
    {
        $middleware = $this->middleware->reveal();
        $route = new Route('/foo/:bar', $middleware, ['GET', 'POST'], 'home');
        $route->setOptions([
            'conditions' => [
                'bar' => 'es|en'
            ],
            'defaults' => [
                'bar' => 'en'
            ]
        ]);
        $this->router->addRoute($route);
        $this->injectRoutes();

        $this->assertCount(1, $this->slimRouter->getMatchedRoutes('GET', '/foo/es'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertCount(0, $this->slimRouter->getMatchedRoutes('GET', '/foo/baz', true));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testAddRouteWithAnyMethod()
    {
        $middleware = $this->middleware->reveal();
        $route = new Route('/foo/bar', $middleware, Route::HTTP_METHOD_ANY, 'home');
        $this->router->addRoute($route);
        $this->injectRoutes();

        $this->assertCount(1, $this->slimRouter->getMatchedRoutes('GET', '/foo/bar'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertCount(1, $this->slimRouter->getMatchedRoutes('POST', '/foo/bar'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertCount(1, $this->slimRouter->getMatchedRoutes('PUT', '/foo/bar'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertCount(1, $this->slimRouter->getMatchedRoutes('DELETE', '/foo/bar'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertCount(1, $this->slimRouter->getMatchedRoutes('PATCH', '/foo/bar'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertCount(1, $this->slimRouter->getMatchedRoutes('OPTIONS', '/foo/bar'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertCount(1, $this->slimRouter->getMatchedRoutes('HEAD', '/foo/bar'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testDummyCallable()
    {
        $this->assertNull($this->router->dummyCallable());
    }

    public function testGenerateUrl()
    {
        $middleware = $this->middleware->reveal();
        $route = new Route('/foo(/:bar)', $middleware, ['GET', 'POST'], 'home');
        $this->router->addRoute($route);

        $this->assertEquals('/foo', $this->router->generateUri('home'));
        $this->assertEquals('/foo/baz', $this->router->generateUri('home', ['bar' => 'baz']));
    }

    /**
     * @expectedException \Zend\Expressive\Router\Exception\RuntimeException
     */
    public function testGenerateUrlWithInvalidName()
    {
        $middleware = $this->middleware->reveal();
        $route = new Route('/foo(/:bar)', $middleware, ['GET', 'POST'], 'home');
        $this->router->addRoute($route);
        $this->router->generateUri('invalidName');
    }

    public function testMatchInvalidRequest()
    {
        $result = $this->router->match(ServerRequestFactory::fromGlobals());
        $this->assertTrue($result->isFailure());
    }

    public function testMatchValidRequest()
    {
        $middleware = $this->middleware->reveal();
        $this->router->addRoute(new Route('/foo(/:bar)', $middleware, ['GET', 'POST'], 'home'));
        $this->injectRoutes();

        $this->assertCount(1, $this->slimRouter->getNamedRoutes());
        $result = $this->router->match(new ServerRequest([], [], '/foo/bar', 'POST'));
        $this->assertTrue($result->isSuccess());
    }

    private function injectRoutes()
    {
        $ref = new \ReflectionObject($this->router);
        $method = $ref->getMethod('injectRoutes');
        $method->setAccessible(true);
        $method->invoke($this->router);
    }
}


1			<?php
2			namespace AcelayaTest\Expressive\Router;
3
4			use Acelaya\Expressive\Router\SlimRouter;
5			use PHPUnit\Framework\TestCase;
6			use Prophecy\Prophecy\ObjectProphecy;
7			use Psr\Http\Server\MiddlewareInterface;
8			use Slim\Router;
9			use Zend\Diactoros\ServerRequest;
10			use Zend\Diactoros\ServerRequestFactory;
11			use Zend\Expressive\Router\Route;
12
13			class SlimRouterTest extends TestCase
14			{
15			/**
16			* @var SlimRouter
17			*/
18			protected $router;
19			/**
20			* @var Router
21			*/
22			protected $slimRouter;
23			/**
24			* @var ObjectProphecy
25			*/
26			protected $middleware;
27
28			public function setUp()
29			{
30			new SlimRouter();
31			$this->slimRouter = new Router();
32			$this->router = new SlimRouter($this->slimRouter);
33			$this->middleware = $this->prophesize(MiddlewareInterface::class);
34			}
35
36			public function testAddRoute()
37			{
38			$middleware = $this->middleware->reveal();
39			$this->router->addRoute(new Route('/foo(/:bar)', $middleware, ['GET', 'POST'], 'home'));
40			$this->injectRoutes();
41
42			$this->assertCount(1, $this->slimRouter->getNamedRoutes());
43
44			/** @var \Slim\Route $route */
45			$route = $this->slimRouter->getMatchedRoutes('GET', '/foo/baz')[0];
46			$this->assertEquals('/foo(/:bar)', $route->getPattern());
47			$this->assertEquals('home', $route->getName());
48			$this->assertEquals($middleware, $route->getParams()['middleware']);
49			}
50
51			public function testAddRouteWithOptions()
52			{
53			$middleware = $this->middleware->reveal();
54			$route = new Route('/foo/:bar', $middleware, ['GET', 'POST'], 'home');
55			$route->setOptions([
56			'conditions' => [
57			'bar' => 'es\|en'
58			],
59			'defaults' => [
60			'bar' => 'en'
61			]
62			]);
63			$this->router->addRoute($route);
64			$this->injectRoutes();
65
66			$this->assertCount(1, $this->slimRouter->getMatchedRoutes('GET', '/foo/es'));
			0 ignored issues – show Documentation introduced 2018-03-18 18:44 UTC by Report Bug Copy Issue Report `$this->slimRouter->getMa...outes('GET', '/foo/es')` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
67			$this->assertCount(0, $this->slimRouter->getMatchedRoutes('GET', '/foo/baz', true));
			0 ignored issues – show Documentation introduced 2018-03-18 18:44 UTC by Report Bug Copy Issue Report `$this->slimRouter->getMa...GET', '/foo/baz', true)` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
68			}
69
70			public function testAddRouteWithAnyMethod()
71			{
72			$middleware = $this->middleware->reveal();
73			$route = new Route('/foo/bar', $middleware, Route::HTTP_METHOD_ANY, 'home');
74			$this->router->addRoute($route);
75			$this->injectRoutes();
76
77			$this->assertCount(1, $this->slimRouter->getMatchedRoutes('GET', '/foo/bar'));
			0 ignored issues – show Documentation introduced 2018-03-18 18:44 UTC by Report Bug Copy Issue Report `$this->slimRouter->getMa...utes('GET', '/foo/bar')` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
78			$this->assertCount(1, $this->slimRouter->getMatchedRoutes('POST', '/foo/bar'));
			0 ignored issues – show Documentation introduced 2018-03-18 18:44 UTC by Report Bug Copy Issue Report `$this->slimRouter->getMa...tes('POST', '/foo/bar')` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
79			$this->assertCount(1, $this->slimRouter->getMatchedRoutes('PUT', '/foo/bar'));
			0 ignored issues – show Documentation introduced 2018-03-18 18:44 UTC by Report Bug Copy Issue Report `$this->slimRouter->getMa...utes('PUT', '/foo/bar')` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
80			$this->assertCount(1, $this->slimRouter->getMatchedRoutes('DELETE', '/foo/bar'));
			0 ignored issues – show Documentation introduced 2018-03-18 18:44 UTC by Report Bug Copy Issue Report `$this->slimRouter->getMa...s('DELETE', '/foo/bar')` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
81			$this->assertCount(1, $this->slimRouter->getMatchedRoutes('PATCH', '/foo/bar'));
			0 ignored issues – show Documentation introduced 2018-03-18 18:44 UTC by Report Bug Copy Issue Report `$this->slimRouter->getMa...es('PATCH', '/foo/bar')` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
82			$this->assertCount(1, $this->slimRouter->getMatchedRoutes('OPTIONS', '/foo/bar'));
			0 ignored issues – show Documentation introduced 2018-03-18 18:44 UTC by Report Bug Copy Issue Report `$this->slimRouter->getMa...('OPTIONS', '/foo/bar')` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
83			$this->assertCount(1, $this->slimRouter->getMatchedRoutes('HEAD', '/foo/bar'));
			0 ignored issues – show Documentation introduced 2018-03-18 18:44 UTC by Report Bug Copy Issue Report `$this->slimRouter->getMa...tes('HEAD', '/foo/bar')` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
84			}
85
86			public function testDummyCallable()
87			{
88			$this->assertNull($this->router->dummyCallable());
89			}
90
91			public function testGenerateUrl()
92			{
93			$middleware = $this->middleware->reveal();
94			$route = new Route('/foo(/:bar)', $middleware, ['GET', 'POST'], 'home');
95			$this->router->addRoute($route);
96
97			$this->assertEquals('/foo', $this->router->generateUri('home'));
98			$this->assertEquals('/foo/baz', $this->router->generateUri('home', ['bar' => 'baz']));
99			}
100
101			/**
102			* @expectedException \Zend\Expressive\Router\Exception\RuntimeException
103			*/
104			public function testGenerateUrlWithInvalidName()
105			{
106			$middleware = $this->middleware->reveal();
107			$route = new Route('/foo(/:bar)', $middleware, ['GET', 'POST'], 'home');
108			$this->router->addRoute($route);
109			$this->router->generateUri('invalidName');
110			}
111
112			public function testMatchInvalidRequest()
113			{
114			$result = $this->router->match(ServerRequestFactory::fromGlobals());
115			$this->assertTrue($result->isFailure());
116			}
117
118			public function testMatchValidRequest()
119			{
120			$middleware = $this->middleware->reveal();
121			$this->router->addRoute(new Route('/foo(/:bar)', $middleware, ['GET', 'POST'], 'home'));
122			$this->injectRoutes();
123
124			$this->assertCount(1, $this->slimRouter->getNamedRoutes());
125			$result = $this->router->match(new ServerRequest([], [], '/foo/bar', 'POST'));
126			$this->assertTrue($result->isSuccess());
127			}
128
129			private function injectRoutes()
130			{
131			$ref = new \ReflectionObject($this->router);
132			$method = $ref->getMethod('injectRoutes');
133			$method->setAccessible(true);
134			$method->invoke($this->router);
135			}
136			}
137

acelaya / expressive-slim-router

Push — master ( 1595c9...264e47 )

SlimRouterTest::injectRoutes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like