Acelaya\Doctrine\Type\PhpEnumType

Complexity

Total Complexity

6

Size/Duplication

Total Lines	42
Duplicated Lines	33.33 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	registerEnumType()	7	20	3
A	registerEnumTypes()	7	7	3

<?php
namespace Acelaya\Doctrine\Type;

use Acelaya\Doctrine\Exception\InvalidArgumentException;
use Doctrine\DBAL\DBALException;
use MyCLabs\Enum\Enum;

class PhpEnumType extends AbstractPhpEnumType
{
    /**
     * @param $typeNameOrEnumClass
     * @param null $enumClass
     * @throws InvalidArgumentException
     * @throws DBALException
     */
    public static function registerEnumType($typeNameOrEnumClass, $enumClass = null)
    {
        $typeName = $typeNameOrEnumClass;
        $enumClass = $enumClass ?: $typeNameOrEnumClass;

        if (! is_subclass_of($enumClass, Enum::class)) {

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \MyCLabs\Enum\Enum::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

This code seems to be duplicated across your project.

            throw new InvalidArgumentException(sprintf(
                'Provided enum class "%s" is not valid. Enums must extend "%s"',
                $enumClass,
                Enum::class
            ));
        }

        // Register and customize the type
        self::addType($typeName, static::class);
        /** @var PhpEnumType $type */
        $type = self::getType($typeName);
        $type->name = $typeName;
        $type->enumClass = $enumClass;
    }

    /**
     * @param array $types
     * @throws InvalidArgumentException
     * @throws DBALException
     */
    public static function registerEnumTypes(array $types)

This method seems to be duplicated in your project.

    {
        foreach ($types as $typeName => $enumClass) {
            $typeName = is_string($typeName) ? $typeName : $enumClass;
            static::registerEnumType($typeName, $enumClass);
        }
    }
}