AcMailer\Service\MailServiceAwareTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setMailService()	0	6	1
A	getMailService()	0	12	4

<?php
namespace AcMailer\Service;

use Zend\ServiceManager\ServiceLocatorAwareInterface;

/**
 * Class MailServiceAwareTrait
 * @author Alejandro Celaya Alastrué
 * @link http://www.alejandrocelaya.com
 */
trait MailServiceAwareTrait
{
    /**
     * @var MailServiceInterface
     */
    protected $mailService;

    /**
     * @param MailServiceInterface $mailService
     * @return $this
     */
    public function setMailService(MailServiceInterface $mailService)
    {
        $this->mailService = $mailService;

        return $this;
    }

    /**
     * @return MailServiceInterface
     */
    public function getMailService()
    {
        if (
            $this instanceof ServiceLocatorAwareInterface
            && ! isset($this->mailService)

Accessing mailService on the interface Zend\ServiceManager\ServiceLocatorAwareInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            && $this->getServiceLocator()->has('AcMailer\Service\MailService')
        ) {
            $this->mailService = $this->getServiceLocator()->get('AcMailer\Service\MailService');

Accessing mailService on the interface Zend\ServiceManager\ServiceLocatorAwareInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        return $this->mailService;
    }
}